Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 17, 2024
    • Oisin Coveney's avatar
      Unverified
      e2828c79
    • Jesse Devaney's avatar
      Move series data label formatters from `option` to the `model` (#42616) · c747c170
      Jesse Devaney authored
      
      * move series data label formatters to the model
      
      - TODO: move stacked data label formatters to the model
      
      * combo stacked chart
      
      * spec
      
      * remove irrelevant spec
      
      * combo stacking
      
      * fix selecting y-axis on stacked charts
      
      * snapshot
      
      * linter, specs, types
      
      * propagate combo stacking to area and bar charts
      
      * enable combo stacking for bar/area charts, fix data transform
      
      * fix types, specs
      
      * fix y-axis extents calculations
      
      * remove spec that tested the removed control, update specs, update test data
      
      * propagate combo stacking to area and bar charts (#42600)
      
      * propagate combo stacking to area and bar charts
      
      * enable combo stacking for bar/area charts, fix data transform
      
      * fix types, specs
      
      * fix y-axis extents calculations
      
      * remove spec that tested the removed control, update specs, update test data
      
      * review
      
      * remove unused formatting options parameter
      
      * move stacked labels formatter to model
      
      * fix stacked combo chart label display for non-stacked lines
      
      * combo stacked chart
      
      * spec
      
      * remove irrelevant spec
      
      * combo stacking
      
      * fix selecting y-axis on stacked charts
      
      * snapshot
      
      * linter, specs, types
      
      * propagate combo stacking to area and bar charts (#42600)
      
      * propagate combo stacking to area and bar charts
      
      * enable combo stacking for bar/area charts, fix data transform
      
      * fix types, specs
      
      * fix y-axis extents calculations
      
      * remove spec that tested the removed control, update specs, update test data
      
      * review
      
      * fix waterfall chart labels
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Unverified
      c747c170
    • Raphael Krut-Landau's avatar
      rebase (#42788) · c0596902
      Raphael Krut-Landau authored
      Unverified
      c0596902
  2. May 16, 2024
  3. May 15, 2024
    • Luis Paolini's avatar
    • Nick Fitzpatrick's avatar
      42701 search type ahead cp (#42716) · 62754d5b
      Nick Fitzpatrick authored
      * respect search-typeahead-enabled
      
      * updating unit test
      
      * adding e2e test
      Unverified
      62754d5b
    • Raphael Krut-Landau's avatar
      Move createMockModelResult to browse folder (#42690) · 95d5a829
      Raphael Krut-Landau authored
      * Move createMockModelResult to browse folder
      
      * fix
      Unverified
      95d5a829
    • Jeff Bruemmer's avatar
      docs - update appearance settings (#42388) · 95db5801
      Jeff Bruemmer authored
      Unverified
      95db5801
    • Jeff Bruemmer's avatar
      docs - offset (#42484) · 7bdfafc8
      Jeff Bruemmer authored
      Unverified
      7bdfafc8
    • Nick Fitzpatrick's avatar
      replace search bar with command palette toggle (#42603) · f37c417b
      Nick Fitzpatrick authored
      * replace search bar with command palette toggle
      
      * e2e test part one
      
      * onboarding suite
      
      * green e2e
      
      * unit tests
      
      * delete shame
      Unverified
      f37c417b
    • Alex Yarosh's avatar
      [docs] Jessica's onboarding feedback (#42670) · e8d6f86c
      Alex Yarosh authored
      
      * update collections
      
      * feedback
      
      * links
      
      * Update docs/questions/native-editor/sql-parameters.md
      
      Co-authored-by: default avatarJeff Bruemmer <jeff.bruemmer@gmail.com>
      
      ---------
      
      Co-authored-by: default avatarJeff Bruemmer <jeff.bruemmer@gmail.com>
      Unverified
      e8d6f86c
    • John Swanson's avatar
      remove TODOs from metabase.models.setting (#40020) · 9aa572cb
      John Swanson authored
      3 TODOs were removed here:
      
      - "a way to SET Database-local values." More like TODONE :haaa:
      
      - "we should probably also bind this [that is, *database-local-values*]
      in sync contexts e.g. functions in [[metabase.sync]]" I think we don't
      need to do this. The full set of maybe-database-local settings right now
      is `aggregated-query-row-limit`, `unaggregated-query-row-limit`,
      `database-enable-actions`, and `persist-models-enabled`. None of these
      need to be set when `sync`ing. If at some point we do add a db-local
      setting that should affect the way syncing works, we will need to do
      this - but I don't think this TODO will help figure that out.
      
      - "settings sent via an env var aren't returned for security purposes.
      It is an open question whether we should obfuscate them and still show
      the last two characters like we do for sensitive values that are set via
      the UI." I think if it's been this way for 5 years, it no longer
      qualifies as an "open question." We can reopen if down the road if this
      is something we want.
      Unverified
      9aa572cb
    • adam-james's avatar
      Pivot table exports (#41668) · a52450c3
      adam-james authored
      
      * PoC Pivot table exporting.
      
      Works so far!
      
      This just hacks a couple things in. I added the :query via format_rows, which should instead have its own proper
      middleware
      
      Pivot export should probably not just be in the middleware namespace but in qp.pivot.
      
      Should not break the streaming results writer for non-pivots... obviously this breaks ordinary results, so that needs
      to be handled properly.
      
      Better documentation about how the logic actually works. Pivot tables are hard to remember/easy to forget, so some
      very clear diagrams/examples would probably be good.
      
      * adjust csv export to export a pivot table when pivot options exist
      
      * post processing of pivot table rows for card/dashcard downloads
      
      * WIP on getting pivot exports to work with unsaved questions
      
      * WIP getting pivot exports working on unsaved questions
      
      The dataset POST /pivot endpoint is used to get the pivot data to the frontend, but also to get the pivot query.
      
      The query that is returned by the POST comes from the json_query, which is populated by the userland-query stuff with
      the last run query. The pivot qp runs mulitple queries and each query runs through the regular userland query qp, so
      we'll 1. see lots of executions recorded and 2. end up with the wrong query in the POST return. It'll look mostly
      correct, but due to how the pivot qp works won't necessarily have all of the fields.
      
      That incorrect pivot query is passed to the /:export-format endpoint and we don't end up seeing correct results.
      
      Since that json_query gets fed back to the backend when doing an export, we do need it to be correct, like the query
      that was sent to /pivot in the first place.
      
      Since this is a WIP, I've just passed the query as a string to :original-query in :info, and if that exists, use that
      to fill the :json_query key.
      
      Then, also add a :was-pivot flag so that the dataset download endpoint can look at it and use the pivot qp instead of
      the regular qp. Even if we have the correct 'top level' query, we need to run it through the pivot qp to get the full,
      correct pivoted results.
      
      * Pivot Export Test
      
      Here I've added a pivot export test that has various assertions trying to capture the correct output from the pivot
      csv export.
      
      I've done my best to explain the tests with comments, but have also left a (comment ) form with a function
      `explore-pivot` to help *show* rather than tell what the expected pivot output should be.
      
      I've created this new namespace to first capture this pivot export test with the intent to add tests that can improve
      our confidence that ALL exports/downloads in ALL places behave as we expect in the future. It just seemed nice to
      start fresh here with the pivot export test first.
      
      * Don't need to make this public.
      
      * Add lots of comments to hopefully make this a bit easier to follow
      
      * Added an explore-raw-pivot fn in comment form
      
      * Update test/metabase/api/downloads_exports_test.clj
      
      Co-authored-by: default avatarCam Saul <1455846+camsaul@users.noreply.github.com>
      
      * begin addressing feedback
      
      - finish an unfinished docstring
      - merge info instead of assoc
      - use a native query to build the pivot data instead of using a custom dataset, to keep test speed ok
      
      * Create a new ns for the pivot post processing utils
      
      Separate the post processing fns into their own namespace. This means I can easily add a test namespace for the post
      processing specifically as well.
      
      * Add pivot postprocessing test ns, not complete, but decent start
      
      * fix mistake in endpoint. Only add original query to first pivot q
      
      * Figured out how to keep the original query without storing as a string
      
      * Perhaps this'll fix things properly?
      
      ---------
      
      Co-authored-by: default avatarCam Saul <1455846+camsaul@users.noreply.github.com>
      Unverified
      a52450c3
    • Romeo Van Snick's avatar
      Design update for extract examples (#42399) · 3506941e
      Romeo Van Snick authored
      * Move the extract examples inline
      
      * Use ui Button for ClickAction and render examples inline
      Unverified
      3506941e
    • Phoomparin Mano's avatar
      Support basic theming in interactive data tables for embedding SDK (#42411) · c16ff2be
      Phoomparin Mano authored
      * support theming in table
      
      * theme injection with hoc
      
      * reasonable default theme options
      
      * customizable text color
      
      * theming table header
      
      * table theming
      
      * change theme configuration order
      
      * apply sorted cell color directly
      
      * gutter background
      
      * remove header theming for now
      
      * fix: id column styling
      
      * id column borders
      
      * border color
      
      * add cell hover color
      
      * conditional hover color
      
      * use brand color to accent
      
      * add default theme values to unit test
      
      * cell background should default to white
      
      * update unit test
      
      * remove unused properties
      
      * remove duplicated color declaration as inner cell data styles it
      
      * remove duplicate fallback
      
      * remove unused use-embedding-theme hook
      
      * use theme color from Mantine for css variables
      
      * update defaults
      
      * inject default component theme
      
      * add notes on cell data theme
      
      * update unit tests
      
      * update unit tests
      
      * remove no-op text-brand hover color
      
      * remove no-op is sorted cell color
      Unverified
      c16ff2be
    • Raphael Krut-Landau's avatar
Loading