This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 17, 2024
-
-
Oisin Coveney authored
-
Jesse Devaney authored
* move series data label formatters to the model - TODO: move stacked data label formatters to the model * combo stacked chart * spec * remove irrelevant spec * combo stacking * fix selecting y-axis on stacked charts * snapshot * linter, specs, types * propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data * propagate combo stacking to area and bar charts (#42600) * propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data * review * remove unused formatting options parameter * move stacked labels formatter to model * fix stacked combo chart label display for non-stacked lines * combo stacked chart * spec * remove irrelevant spec * combo stacking * fix selecting y-axis on stacked charts * snapshot * linter, specs, types * propagate combo stacking to area and bar charts (#42600) * propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data * review * fix waterfall chart labels --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
Raphael Krut-Landau authored
-
- May 16, 2024
-
-
Cal Herries authored
-
Raphael Krut-Landau authored
-
Cam Saul authored
* Fix sorting by `Offset()` custom expression aggregation * Unskip test * Revert breaking change to `mt/id` and related
-
Cal Herries authored
-
Alexander Polyankin authored
-
bryan authored
* handle recent view for non-existant entity * test that recent views works with missing entities - just doesn't return them. * dont count on there being entities in the app-db * Query for the entity data upfront for recent-views - Still need to check for the model_object due to popular-items calls * cleanup, fix ellide logic memoize get-parent-coll * more cleanup * rewire half of the queries * rewrite the other queries, and improve docs * align some queries * lookup all entities ahead of time - always return effective parent collections * seperate n+1 tests * use = instead of a set * no need for a vector * fixup simple table test * go from effective-location-path to id instead of hydrating
-
Filipe Silva authored
* feat: cloud migration endpoints * fix: don't leave open conn behind when checking migrations `unrun-migrations` would open a new connection but not close it. Since `with-liquibase` is happy enough using a data-source the fix is straightforward. You can verify this by running the following code: ``` (comment (require '[metabase.cmd.dump-to-h2 :as dump-to-h2] '[metabase.analytics.prometheus :as prometheus]) (defn dump [] (-> (str "cloud_migration_dump_" (random-uuid) ".mv.db") io/file .getAbsolutePath dump-to-h2/dump-to-h2!)) (defn busy-conns [] (-> (prometheus/connection-pool-info) first second :numBusyConnections)) ;; each dump leaves behind 1 busy conn (busy-conns) ;; => 0 (dump) (busy-conns) ;; => 1 (dump) (busy-conns) ;; => 2 (dump) (busy-conns) ;; => 3 ) ``` * fix: flush h2 before returning from dump * rfct: move code to models.cloud-migration * test: add login while on read-only test * fix: assorted cloud_migration fixes from review * test: allow overriding uploaded dump * fix: add UserParameterValue to read-only exceptions Also make the list a little bit nicer. * fix: only block dumped tables on read-only * fix: recover on startup if read-only was left on * feat: block migration when hosted already * test: test settings for migration * feat: cloud migration supports retries and multipart * test: sane dev defaults for migration * fix: upload 100% shouldn't be migration 100% * chore: make up a new migration id after merge * Cloud Migration FE (#42542) * it's a start * ui wip * wip * dynamic polling intervals, and custom modal for migrate confirmation modal * cleans out most of the remainig UI TODOs * adding progress component * impls team feedback * makes component more testable, starts some a unit test for the CloudPanel * finish unit testing * reverts api changes * update progress styling * fix type issues * fix e2e failure, fix feature unit tests by holding last migration state in fetchMock if more requests than expected happen at the end of a test, remove white spacing change in clj file * second pass at fixing tests * fix copy from ready-only to read-only * copy fix * Update frontend/src/metabase/admin/settings/components/CloudPanel/MigrationError.tsx Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> * Update frontend/src/metabase/admin/settings/components/CloudPanel/MigrationInProgress.tsx Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> * adding e2e test * pr feedback --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com> Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> --------- Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com> Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
Alexander Polyankin authored
-
Ryan Laurie authored
* Basic Upsell System Setup * Hosting Upsell * add upsell to updates page * update utms * update copy, utms and text
-
Raphael Krut-Landau authored
Accept license tokens with an `airgap_` prefix, besides the already accepted 64-character long tokens. This weakens the validation in the FE. Rigorous validation of tokens beginning with `airgap_` occurs in the BE. See this [Slack message](https://metaboat.slack.com/archives/C064EB1UE5P/p1715813885703249?thread_ts=1715813614.437989&cid=C064EB1UE5P).
-
Raphael Krut-Landau authored
Rename "Browse data" to "Browse databases" Closes #42781
-
Aleksandr Lesnenko authored
* combo stacked chart * spec * remove irrelevant spec * combo stacking * fix selecting y-axis on stacked charts * snapshot * linter, specs, types * propagate combo stacking to area and bar charts (#42600) * propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data * review * show show data values setting on normalized charts that have a line series * fixes
-
adam-james authored
* Area Bar Combo Stacked Viz Settings Migration Per: https://www.notion.so/metabase/Migration-spec-e2732e79215a4a5fa44debb272413db9 This addresses the necessary migrations for area/bar/combo stacked viz settings. * Custom migration test works * Check that non area/bar/combo charts also remove stack_display
-
Braden Shepherdson authored
* [MBQL lib] Add `canPreview` and use it from the notebook * Fix previewQuery * Apply can-preview across stages; add unit tests --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Jeff Bruemmer authored
-
adam-james authored
* Correct Data Shape for Multi-Series Static Viz Fixes: #41787 During the echarts migration, some backend tests needed fixing. In this process, the shape of data (eg. list of cards and their data results from execution) were altered. This was done to fix failing tests and renders for single series cards (all Questions and many dashcards), but didn't correctly handle a multi-series card. This conditionally adds back the expected shape. Perhaps in a follow on PR it's worth inspecting the implementation of the :javascript_visualization render method to clean it up. Probably worth putting some Malli schemas around it too to make it clearer what shape we need. * Make sure card/data maps going into static-viz are distinct * Add a test util to render dashcards, add multiseries card test We haven't made a 'unit' (perhaps more like a small integration test at this point) test for multi series dashcards yet. In most other cases, making sure a card (Question) renders properly is sufficient, but the multi series dashcards are a special case. It's probably useufl to have a test or two, and the dashcards test util should hopefully help future test writing a bit now too.
-
Kamil Mielnik authored
-
Aleksandr Lesnenko authored
-
Nemanja Glumac authored
-
Oisin Coveney authored
-
Alexander Polyankin authored
-
Mahatthana (Kelvin) Nomsawadi authored
* WIP some workflows * Add reminder todo comment * Complete the workflow * Fix YAML syntax error * Trigger the workflow * Fix resuable workflow * Fix uberjar workflow * Add missing steps before testing * Pass recrets to resuable workflow, so it could run * Fix sdk artifact location * Remove unneeded output * fetch tags, so it doesn't fail on push * Only running EE uberjar in SDK workflow Because OSS is never needed * Fix incorrect syntax * Shuffle workflow so it failed fast * Fix syntax error * Attempt to bulid only EE jar * Fix the error handling step * Fix failing to upload to s3 * Fix create a PR step * Fix the last temporary command, so the build looks green * Remove hack to trigger the workflow * Remove completed todo comment * Clean up S3 step * Add todo comment * Upload correct docker image name * Bump the package version before building SDK * Fix uploading the correct Metabase dev container name * Fix one too many double quote * Push the correct docker image * Fix PR creation step * Dry run publishing SDK * Use a separate uberjar workflow for SDK * Remove a bunch of unused steps * Update variable names, step names * Improve tag error message * Correct m2-cache-key to be unique * Fix the push tag failure step to only run when failed to push tag * Fix changed artifact name * Improve env name for clarity * Fix extra trailing empty line * Remove conditions from running certian steps * Removing npm publish dry-run
-
Tim Macdonald authored
* Add a simple replace-names test * Support find-and-replace in cards with variables and field filters [Fixes #42580] [Fixes #42581] * Add models.card/replace-fields-and-tables! * Docstring fix * Little cleanup
-
Mahatthana (Kelvin) Nomsawadi authored
-
Cal Herries authored
-
- May 15, 2024
-
-
Luis Paolini authored
same compatibility of the previous one but this is compatible with JDK 21 https://learn.microsoft.com/en-us/sql/connect/jdbc/release-notes-for-the-jdbc-driver?view=sql-server-ver16 Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Nick Fitzpatrick authored
* respect search-typeahead-enabled * updating unit test * adding e2e test
-
Raphael Krut-Landau authored
* Move createMockModelResult to browse folder * fix
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Nick Fitzpatrick authored
* replace search bar with command palette toggle * e2e test part one * onboarding suite * green e2e * unit tests * delete shame
-
Alex Yarosh authored
* update collections * feedback * links * Update docs/questions/native-editor/sql-parameters.md Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
John Swanson authored
3 TODOs were removed here: - "a way to SET Database-local values." More like TODONE :haaa: - "we should probably also bind this [that is, *database-local-values*] in sync contexts e.g. functions in [[metabase.sync]]" I think we don't need to do this. The full set of maybe-database-local settings right now is `aggregated-query-row-limit`, `unaggregated-query-row-limit`, `database-enable-actions`, and `persist-models-enabled`. None of these need to be set when `sync`ing. If at some point we do add a db-local setting that should affect the way syncing works, we will need to do this - but I don't think this TODO will help figure that out. - "settings sent via an env var aren't returned for security purposes. It is an open question whether we should obfuscate them and still show the last two characters like we do for sensitive values that are set via the UI." I think if it's been this way for 5 years, it no longer qualifies as an "open question." We can reopen if down the road if this is something we want.
-
adam-james authored
* PoC Pivot table exporting. Works so far! This just hacks a couple things in. I added the :query via format_rows, which should instead have its own proper middleware Pivot export should probably not just be in the middleware namespace but in qp.pivot. Should not break the streaming results writer for non-pivots... obviously this breaks ordinary results, so that needs to be handled properly. Better documentation about how the logic actually works. Pivot tables are hard to remember/easy to forget, so some very clear diagrams/examples would probably be good. * adjust csv export to export a pivot table when pivot options exist * post processing of pivot table rows for card/dashcard downloads * WIP on getting pivot exports to work with unsaved questions * WIP getting pivot exports working on unsaved questions The dataset POST /pivot endpoint is used to get the pivot data to the frontend, but also to get the pivot query. The query that is returned by the POST comes from the json_query, which is populated by the userland-query stuff with the last run query. The pivot qp runs mulitple queries and each query runs through the regular userland query qp, so we'll 1. see lots of executions recorded and 2. end up with the wrong query in the POST return. It'll look mostly correct, but due to how the pivot qp works won't necessarily have all of the fields. That incorrect pivot query is passed to the /:export-format endpoint and we don't end up seeing correct results. Since that json_query gets fed back to the backend when doing an export, we do need it to be correct, like the query that was sent to /pivot in the first place. Since this is a WIP, I've just passed the query as a string to :original-query in :info, and if that exists, use that to fill the :json_query key. Then, also add a :was-pivot flag so that the dataset download endpoint can look at it and use the pivot qp instead of the regular qp. Even if we have the correct 'top level' query, we need to run it through the pivot qp to get the full, correct pivoted results. * Pivot Export Test Here I've added a pivot export test that has various assertions trying to capture the correct output from the pivot csv export. I've done my best to explain the tests with comments, but have also left a (comment ) form with a function `explore-pivot` to help *show* rather than tell what the expected pivot output should be. I've created this new namespace to first capture this pivot export test with the intent to add tests that can improve our confidence that ALL exports/downloads in ALL places behave as we expect in the future. It just seemed nice to start fresh here with the pivot export test first. * Don't need to make this public. * Add lots of comments to hopefully make this a bit easier to follow * Added an explore-raw-pivot fn in comment form * Update test/metabase/api/downloads_exports_test.clj Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> * begin addressing feedback - finish an unfinished docstring - merge info instead of assoc - use a native query to build the pivot data instead of using a custom dataset, to keep test speed ok * Create a new ns for the pivot post processing utils Separate the post processing fns into their own namespace. This means I can easily add a test namespace for the post processing specifically as well. * Add pivot postprocessing test ns, not complete, but decent start * fix mistake in endpoint. Only add original query to first pivot q * Figured out how to keep the original query without storing as a string * Perhaps this'll fix things properly? --------- Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Romeo Van Snick authored
* Move the extract examples inline * Use ui Button for ClickAction and render examples inline
-
Phoomparin Mano authored
* support theming in table * theme injection with hoc * reasonable default theme options * customizable text color * theming table header * table theming * change theme configuration order * apply sorted cell color directly * gutter background * remove header theming for now * fix: id column styling * id column borders * border color * add cell hover color * conditional hover color * use brand color to accent * add default theme values to unit test * cell background should default to white * update unit test * remove unused properties * remove duplicated color declaration as inner cell data styles it * remove duplicate fallback * remove unused use-embedding-theme hook * use theme color from Mantine for css variables * update defaults * inject default component theme * add notes on cell data theme * update unit tests * update unit tests * remove no-op text-brand hover color * remove no-op is sorted cell color
-
Raphael Krut-Landau authored
-