This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 13, 2022
-
-
Gustavo Saiani authored
-
Gustavo Saiani authored
-
Gustavo Saiani authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Sep 12, 2022
-
-
Ryan Laurie authored
* enforce import order * reorder all imports * more import updates
-
Case Nelson authored
When creating a new question, you can choose an existing saved question as your starting point. However, we want to exclude is_write cards from that list.
-
Ryan Laurie authored
* derive parameter types from form settings on save * update template tag types with parameter types * improve tests * pass action visualization settings to actionParametersInputForm
-
Alexander Polyankin authored
-
Dalton authored
* Update FieldSchema to store virtual card table fields using both table_id and field id * Update the metadata selector to look use field's uniqueId property * Add tableId arg to Metadata.prototype.field method * Normalize fields in sample_database_fixture * Fix incorrect e2e test * Make the second arg of field optional * Pull out small fn * Refactoring + clean up + mocks & tests * Update metadata.field(...) usage in a few places * Revert FieldDimension change * Move complex FieldDimension `field` logic to the instantiation of "virtual" fields by the associated query's `table` method (#25109) * Add merge method to Field * add new virtual table utils + tests * Use new utils in implementation of Structured/NativeQuery table methods + remove unneeded Dimension logic * let all Questions return dependentMetadata * Fix types related to query.table() potentially returning null * Fix updateQuestion tests * Remove unused Dimension imports * Fix issue resolving rootTable on queries based on virtual tables * Fallback to the nested card table stored in the Metadata instance * Make the nested card Table the main driver in returning fields for nested cards + other misc fixes * more tweaks related to cloned Tables, source queries * Don't clobber metadata if something is already there (like a method named 'metadata') * Fix for nested native query * Don't use real table for source query * Update table code to use the actual nested card table fields instead of doing merge logic * Skip an e2e test * Workaround for getting Dimensions from joins * Update arg name * Try removing the Table fetch from Question's dependentMetadata method * Don't rerun query when converting question to model * Fix for source query not showing 'previous results' * Fix unit tests * Update models e2e tests not to wait on query * Unskip repro for #23449 * make sure a join's joinedQuery is not a dataset/model * use createQuestion in e2e test * don't use Question redux dispatch method for updating * split test cases * Add comment
-
Anton Kulyk authored
-
Anton Kulyk authored
* Move `DataAppNavbar` to its own directory * Move `MainNavbarContainer` to its own directory * Move `BookmarksList` to `MainNavbarContainer` * Extract `getSelectedItems` * Extract `DataAppActionPanel`
-
Nick Fitzpatrick authored
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
Ryan Laurie authored
* derive parameter types from form settings on save * update template tag types with parameter types * improve tests
-
Cam Saul authored
* Support starting Metabase without initializing the Quartz scheduler * Fix
-
Mahatthana (Kelvin) Nomsawadi authored
* Render text in Slack subscription when there is no result * Change is correct, just fixing nitpicks Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
Alexander Polyankin authored
-
Cal Herries authored
* Show a basic banner if token status is "unpaid" or "past_due" * Add warning emoji to banner message * Swap unpaid and past-due meanings * Make links consistent between messages * Replace useLicense with token-status setting * Add token-status to SettingName * Extract AppBanner logic to selector and reuse Banner component * Create TokenStatus type and createMockTokenStatus * Remove hard-coded status * Make token-status have internal visibility * Revert "Make token-status have internal visibility" This reverts commit 8983617a0f7f1e1a9e36206d93d871df5c290965. * Write test for token-status setting * Bring back AppBanner to render message correctly * Test banner isn't present for normal users * Address Alex's comments
-
Cal Herries authored
Don't show an error page when loading cardtagEditor if the user doesn't have permission to view the referenced card (#25334)
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Move `ClickBehavior` types to its own file * Add click_behavior to `ActionButtonDashboardCard` * Fix `createMockDashboardActionButton` helper * Rename `isActionButtonWithMappedAction` * Add unit tests for `isMappedExplicitActionButton`
-
Mahatthana (Kelvin) Nomsawadi authored
* Make data point circle more visible * Test combo-chart with data point values shown
-
- Sep 09, 2022
-
-
Natalie authored
-
Noah Moss authored
* use .p12 file extension for pkcs-12 keys * test * fix messed up indentation * default to empty string ssl password * address feedback * fix tests
-
Cal Herries authored
* Add an autocomplete completer that gets all the columns for referenced questions * Tidy up * Add docstring for WIP * Add TODOs * Add endpoint for referenced-cards * Undo changing comment * Revert back to returning null * Update src/metabase/api/card.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Add template tag that isn't a card reference to the test * Make ids follow conventions and tidy * Remove unused require * Create e2e test * Add wait to be sure autocompleter finishes * Remove referenced-cards endpoint and fetch questions as the user types * Remove unrelated change * Filter columns for substring matches only * Prioritise question columns in autocomplete results * Fix issue with autocomplete if user doesn't have access to referenced question * Add useCachedForbiddenError option for withCachedData * Actually add useCachedForbiddenError Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Anton Kulyk authored
* Allow rendering `DataSelector` outside of popover * Add scaffold endpoint * Add scaffold action * Implement scaffolded "New App" flow
-
Natalie authored
-
adam-james authored
* Respect custom series names in static viz * Remove change that isn't actually necessary * Revert "Remove change that isn't actually necessary" This reverts commit 617ff4a9719bd5386bf69651cad696948a1fea7b. * Remove uneeded change * Add helper fn * Add back a change I actually did need... brain fart, oops * Add a test to make sure the correct :name key is used for series * Remove unused function
-
Gustavo Saiani authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Render ordinal x-axis label 90deg instead of 45deg * Fix chart grid and x-axis size not equal when having left padding * Fix X-axis line covered by grid lines * Update static chart text size to match new designs * Handle 90deg rotated x-axis tick labels * Fix timeseries overlapping x-axis tick labels * Fix typo * Show data point circle to make reading line charts less confusing * Render data point circle only on visible data point values + fix types * Address review
-
- Sep 08, 2022
-
-
Bryan Maass authored
* users may only send non-ddl native sql to h2 * tests for diasllowing h2 ddl * improve error message on throw * fix linter + cleanup the-exploit example. * refix linter * handle garbage input by failing to classify it. If it h2 can't parse it, then that input cannot trigger a vulnerability. Our parser simply chews through erroneous sql, and classifies statements that it is able to parse. * When h2 is running in client-side mode, do not parse sql - SessionRemote indicates that we are currently client side * refactor so that building parser is easier * remove unused import SessionRemote * Revert "refactor so that building parser is easier" This reverts commit a41800131696de00d98e4eb7124d4d4b1b1cb33c. * check client-side conns => import SessionRemote * replace truncate function via inlining * fix drop arg order
-
adam-james authored
* Add goal line settings to the viz-settings map passed to combo chart * Add a test to check that goal lines are added to line/area/bar/combo
-
Jeff Bruemmer authored
-
Gustavo Saiani authored
-
Case Nelson authored
* [Apps] Prototype backend app scaffolding WIP Given a set of table-ids, we try to build out an app. Ideally the produced scaffold is done on the frontend and passed in to 1. avoid code duplication 2. allow the front end to maintain ownership of visualization_settings 3. avoid regressions on frontend code changes However, this currently builds the scaffold on the backend due to FE dev bandwidth. In theory, it is done in such a way that it both matches the FE as closely as possible as well as becomes easy to change this code to accept a scaffold rather than generating one itself. It uses `scaffold-target` to map cards and dashboards in the scaffold with the inserted ids. Things that are still being worked out elsewhere: 1. The shape of nav-items 2. The shape of implicit action buttons * Sort namespace * Update and fix scaffold based on demo * Address review comments Deduplicate table-ids and make sure they are valid. i18n page suffixes. Check that tables have exactly one primary key column. Check that card scaffold has a `scaffold-target` Remove redudant check in scaffold-target replacement that the map lookup took care of.
-
Jeff Bruemmer authored
-
Case Nelson authored
-
Nick Fitzpatrick authored
-