Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 13, 2022
  2. Sep 12, 2022
  3. Sep 09, 2022
  4. Sep 08, 2022
    • Bryan Maass's avatar
      users may only send non-ddl native sql to h2 (#25220) · 52beccdb
      Bryan Maass authored
      * users may only send non-ddl native sql to h2
      
      * tests for diasllowing h2 ddl
      
      * improve error message on throw
      
      * fix linter + cleanup the-exploit example.
      
      * refix linter
      
      * handle garbage input by failing to classify it.
      
      If it h2 can't parse it, then that input cannot trigger a vulnerability.
      
      Our parser simply chews through erroneous sql, and classifies statements
      that it is able to parse.
      
      * When h2 is running in client-side mode, do not parse sql
      
      - SessionRemote indicates that we are currently client side
      
      * refactor so that building parser is easier
      
      * remove unused import SessionRemote
      
      * Revert "refactor so that building parser is easier"
      
      This reverts commit a41800131696de00d98e4eb7124d4d4b1b1cb33c.
      
      * check client-side conns => import SessionRemote
      
      * replace truncate function via inlining
      
      * fix drop arg order
      Unverified
      52beccdb
    • adam-james's avatar
      Add goal line settings to the viz-settings map passed to combo chart (#25269) · 83d72daf
      adam-james authored
      * Add goal line settings to the viz-settings map passed to combo chart
      
      * Add a test to check that goal lines are added to line/area/bar/combo
      Unverified
      83d72daf
    • Jeff Bruemmer's avatar
      add frontmatter to API doc page (#25316) · f8a2ada1
      Jeff Bruemmer authored
      Unverified
      f8a2ada1
    • Gustavo Saiani's avatar
      Add white bg (#25268) · 53a295f7
      Gustavo Saiani authored
      Unverified
      53a295f7
    • Case Nelson's avatar
      [Apps] Prototype backend app scaffolding (#25314) · 1740b105
      Case Nelson authored
      * [Apps] Prototype backend app scaffolding
      
      WIP
      
      Given a set of table-ids, we try to build out an app. Ideally the
      produced scaffold is done on the frontend and passed in to
      
      1. avoid code duplication
      2. allow the front end to maintain ownership of visualization_settings
      3. avoid regressions on frontend code changes
      
      However, this currently builds the scaffold on the backend due to FE dev
      bandwidth. In theory, it is done in such a way that it both matches the
      FE as closely as possible as well as becomes easy to change this code to
      accept a scaffold rather than generating one itself.
      
      It uses `scaffold-target` to map cards and dashboards in the scaffold
      with the inserted ids.
      
      Things that are still being worked out elsewhere:
      1. The shape of nav-items
      2. The shape of implicit action buttons
      
      * Sort namespace
      
      * Update and fix scaffold based on demo
      
      * Address review comments
      
      Deduplicate table-ids and make sure they are valid.
      
      i18n page suffixes.
      
      Check that tables have exactly one primary key column.
      
      Check that card scaffold has a `scaffold-target`
      
      Remove redudant check in scaffold-target replacement that the map lookup took care of.
      Unverified
      1740b105
    • Jeff Bruemmer's avatar
      matching titles (#25313) · 8879900d
      Jeff Bruemmer authored
      Unverified
      8879900d
    • Case Nelson's avatar
    • Nick Fitzpatrick's avatar
Loading