This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 31, 2024
-
-
Kamil Mielnik authored
* Fix #49036 * Add explanatory comments * Improve comment * Improve comment * Update comment * Add repro for #49036 * Exclude custom Shift + Tab handling
-
Nicolò Pretto authored
-
Romeo Van Snick authored
-
Romeo Van Snick authored
-
Romeo Van Snick authored
-
Romeo Van Snick authored
* Manually remove bad matches when preparing results for ACE * Do two-phase autocompletion * Allow single-character completions * Add test for flickering autocomplete results * Fix autocomplete tests * Simplify autocomplete helpers * Handle empty results in autocomplete * Fix e2e test
-
- Oct 30, 2024
-
-
Noah Moss authored
-
Case Nelson authored
* perf: Implement faster sync methods for postgres Fixes #48575 Pulls work from redshift into the common postgres driver. * Fix tests and formatting * Move nested-field-column sync to sync functions so describe-fields will also get them * Fix test * Fix test * Remove fixed safety test * Add test specific database-supports feature for pk metadata * Fix test * Adrress PR feedback * Fix test * Don't use subselect for field-comment * Fix quoting weird identifiers * Make format string inline
-
Oleksandr Yakushev authored
-
Oleksandr Yakushev authored
-
Noah Moss authored
-
Jeff Bruemmer authored
-
Denis Berezin authored
* fix(sdk): Editable dashboard should not overlap content below it * Add sizing note
-
Nemanja Glumac authored
* Remove unused component * Remove extra space * Remove cross-component dependency on the `Banner` * Use named export * Convert the Banner to TS * Make `ReadOnlyBanner` use `Banner` under the hood * Add test id to the banner * Simplify render method and tests * Add the missing test for ReadOnly banner * Avoid using special ASCII characters for the common apostrophe * Remove E2E spec * Use `Banner` for `DatabaseInfoField` * Use colors defined in the theme * Remove the dependency on the `Banner` component again! * Add a comment * Use pattern matching
-
Oisin Coveney authored
-
Oleksandr Yakushev authored
-
Nicolò Pretto authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Update static embed card copy to avoid confusion * Fix E2E tests * Fix unit tests * Update the copy inside static embed modal
-
- Oct 29, 2024
-
-
lbrdnk authored
* Select only compatible fields from idFields * Use isComparableWith to filter target fields * Remove filter-comparable-fields * Add test
-
adam-james authored
* Mongo objects should download as JSON, not EDN Fixes #48198 Prior to this change, object columns (base or effective type of :type/Dictionary) were just formatted with `(str value)` which results in a csv or json download containing EDN formatted objects. This is a bug because we present object column values as json in the app, so the expected formatting of the download should match this. The formatter function now takes this type into account. As well, since this is a type of formatting that should be always applied (even when format_rows is false), the function is modified to unconditionally apply the json/encode formatting to dictionary types when encountered. * add a test * add proper condition to test * card-download should be public * uncomment json encoding formatter * set-cell! should keep encoded json string for Objects I think this is the correct change; I don't really understand the reason for wrapping, encoding, decoding, and then string-ing that value. Maybe I'm missing something. * Adjusted xlsx Object set-cell! implementation * forgot the not... inverted
-
Romeo Van Snick authored
* Update cursor position when selection changes * Add reproduction for #33640 * Revert "Add reproduction for #33640" This reverts commit 573f6320. We cannot reproduce the bug with tests, so having a test is useless.
-
Jeff Bruemmer authored
-
Nick Fitzpatrick authored
* fix broken css rule, remove description from field table * adding back description
-
Alex Yarosh authored
* docs: clarify downloading results in embedding * docs: static params table description * format * Apply suggestions from code review Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
bryan authored
-
Raphael Krut-Landau authored
-
Jeff Bruemmer authored
-
Noah Moss authored
-
Nicolò Pretto authored
have them in the real codebase + to remove warnings from test output
-
Oisin Coveney authored
-
Romeo Van Snick authored
* Add reproduction for #12586 * Do not show the dirty overlay when an error occurred * Fix tests that rely on dirty overlay * Add issue tag to test case Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Romeo Van Snick authored
* Add max-height to the click actions popover to prevent overflow and infinite scroll * Add reproduction for #48851 * Update reproduction to speed it up * Use existing helper for table header click * Add max height to string filter picker * Revert "Add max-height to the click actions popover to prevent overflow and infinite scroll" This reverts commit 166478d8.
-
Oisin Coveney authored
-
- Oct 28, 2024
-
-
Aleksandr Lesnenko authored
* add grey accent color * fix pie chart color assignment * specs * update grey accent * update colors * grey -> gray
-
bryan authored
- AG instances cannot connect to open ai
-
John Swanson authored
The audit collection is a bit weird. Users have permissions on the collection but even superusers don't actually have write permissions on the elements within it. For now, I'm just excluding anything in the audit collection from the "stale" endpoint, so we won't suggest cleaning these up, but I wonder if maybe there's a cleaner way here. It feels weird to fake permissions like this. Fixes https://github.com/metabase/metabase/issues/49164
-
Nemanja Glumac authored
* Add new route * Add the navigation link * Guard the route * Add first pass of the page structure * Add the bottom section * Add placeholder dummy YT videos * Add images * Track checklist being opened * Track checklist item expanded * Track checklist item CTA clicked * PoC: Stop the video on accordion change * Use actual onboarding videos * Fix missing unique `key` prop * Final content tweaks * Override the accordion styles defined in the `theme` * Use predefined t-shirt sizes where possible * Update copy * Conditionally display the example dashboard CTA * Add very basic unit test coverage * Show onboarding link to new instances only * Remember the last position in the onboarding * Fix the mock settings types * Scroll last opened item into view * Properly display docs links * Another accordion style override * Add tests for the Onboarding page contents * Add E2E Snowplow tests * Conditionally display xray item contents based on settings * Split tests * Make sure items scroll into view when expanded * Do not show example question CTA if example dashboard doesn't exist * Allow YT videos to play in fullscreen * Add comments about the example question * Update rules for when we show the onboarding nav link * Test the conditional documentation links display * Reduce E2E test flakiness
-
Phoomparin Mano authored
* document loader and error states * document loader and error states in the docs * revert changes to README.md Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Jeff Bruemmer authored
-
Mahatthana (Kelvin) Nomsawadi authored
-