Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Dec 06, 2022
  2. Dec 05, 2022
  3. Dec 02, 2022
  4. Dec 01, 2022
    • Braden Shepherdson's avatar
      Serdes v2: Rebuild the directory structure to be more human-friendly (#26793) · f0655fc2
      Braden Shepherdson authored
      There are now three top-level trees:
      
      - regular `collections/path/to/collection/...`
      - `:namespace :snippet` collections in `snippets/path/to/collection/...`
      - `databases/mydb/schemas/PUBLIC/tables/customers/fields/name.yaml`
      
      The path for any given entity is determined by the
      `serdes.base/storage-path` multimethod.
      
      On the ingestion side, things are a bit tricky because the paths don't
      map directly to `:serdes/meta` hierarchies anymore. Instead each model
      registers a function to turn a file path into either a `:serdes/meta`
      hierarcy or nil for a bad match.
      
      Ingestion will fetch all these functions once and then try them all in
      arbitrary order until one matches.
      Unverified
      f0655fc2
  5. Nov 30, 2022
    • Anton Kulyk's avatar
      Migrate new collection form to formik (#26820) · 06afa5f1
      Anton Kulyk authored
      * Add basic `CreateCollectionForm`
      
      * Add `CreateCollectionModal`
      
      * Use new form in "New" menu
      
      * Remove no longer needed `onChangeLocation`
      
      * Use new form in collections ellipsis menu
      
      * Add unit tests
      
      * Don't use legacy form lib in collection plugin
      
      * Add `canManageCollectionAuthorityLevel` utility
      
      * Update `FormCollectionAuthorityLevel`
      
      * Add authority level field to new collection form
      
      * Remove old collection form
      
      * Tweak how authority level form field is exposed
      Unverified
      06afa5f1
    • Anton Kulyk's avatar
      Convert metabase-enterprise/collections plugin to TypeScript (#26801) · 681f3bc2
      Anton Kulyk authored
      * Convert authority level plugin to TypeScript
      
      * Don't use `any` too much
      Unverified
      681f3bc2
    • Anton Kulyk's avatar
      Clean up setting selectors usage (#26637) · f1daa097
      Anton Kulyk authored
      * Clean up setting selector wrappers
      
      * Sort `LicenseAndBillingSettings` imports
      
      * Use `getSettings` in `LicenseAndBillingSettings`
      
      * Fix selectors usage in metabase enterprise
      
      * Fix selectors usage in Slack forms
      
      * Fix selectors usage in `GoogleAuthForm`
      
      * Fix selectors usage in `AppBanner`
      
      * Fix selectors usage in `CloudMigrationHelp`
      
      * Unsubscribe query builder from app settings
      
      They don't seem to be used at all
      
      * Fix selectors usage in auth selectors
      
      * Fix selectors usage across the app
      
      * Fix something happened to an import
      Unverified
      f1daa097
  6. Nov 29, 2022
  7. Nov 22, 2022
  8. Nov 18, 2022
  9. Nov 17, 2022
  10. Nov 16, 2022
  11. Nov 15, 2022
  12. Nov 14, 2022
  13. Nov 09, 2022
    • Ngoc Khuat's avatar
      Remove legacy MBQL syntax in tests (#26309) · cb1da495
      Ngoc Khuat authored
      * [:field-id id] => [:field id nil] or $name. Except places where tests
      are meant to check normalization
      
      * [:datetime-field [:field id] unit] -> [:field id {:temporal-unit unit}]
      or !unit.name
      
      * [:fk-> [:field 1] [:field 2]] => [:field 2 {:source-field 1}]
      Unverified
      cb1da495
  14. Nov 07, 2022
    • Bryan Maass's avatar
      Use all text scorers in the final result to increase scoring signal (#26026) · 1c6e8109
      Bryan Maass authored
      * Uses all text scorers in the final result
      
      - instead of just the maximum one
      - add tests
      
      * add prefix scorer test + fix text-score-with
      
      * linter fixes
      
      * pass in number of results to find
      
      * refactor test function
      
      * fix linter by removing unused namespace: metabase.util
      
      * limit arity of serialize to 3
      
      * make oss-score and ee-score different things
      
      - They were defined to be exactly the same, but should be different!
      - Update some tests that broke when a test function was fixed
      
      * remove extra let
      
      * move rseq back out of sorted-take
      
      * improve test feedback
      
      * force weight of text based scorers always weigh 10
      
      * handle 0 score/weights when normalizing scores
      
      * add nil check
      
      * fix more subtle test differences
      
      * more test fiddling
      
      - still test that :offset and :limit respect limits
      
      * reuse bit->boolean from api collection
      
      * clean up some tests
      
      - filter -> remove
      - replace some magic numbers
      - revert to testing entire maps instead of names of sorted items
      
      * add test, docstring, and weight
      
      * sort ns requires
      
      * responding to most of the review comments
      
      * start our zero-score sum check with 0
      
      * do not tokenize / normalize nil raw-search-string
      
      * force equality in basic search test
      
      * modify test to work in dev and test environments
      
      * use display_name in results when appropriate
      
      - This was looking for the _first_ column that had a non-zero score, but
      actually we need to consider all relevant columns.
      - Uses them to figure out if there is a display name, and if there is,
      to use it.
      - Coppied over the logic about showing :context from the prior approach
      Unverified
      1c6e8109
    • Braden Shepherdson's avatar
      Serdes v2: Search for dependencies both on the filesystem and the appdb (#26217) · 1e4fb63b
      Braden Shepherdson authored
      This allows smaller selective exports that (for example) don't need to
      include the data model if you know the other side has it.
      Unverified
      1e4fb63b
  15. Nov 01, 2022
  16. Oct 31, 2022
  17. Oct 26, 2022
  18. Oct 25, 2022
  19. Oct 24, 2022
  20. Oct 21, 2022
    • Cam Saul's avatar
      Add `created_at` to Collection (#25871) · 7af4f706
      Cam Saul authored
      * Add created_at to Collection
      
      * Simplified migrations [ci skip]
      
      * Add SQL for H2 and MySQL; add tests
      
      * Sort namespaces
      
      * Test fixes :wrench:
      
      * Test fixes
      
      * Test fixes :wrench:
      
      * Make sure MySQL/MariaDB Liquibase generator sets the current timestamp function for ADD COLUMN
      Unverified
      7af4f706
    • Braden Shepherdson's avatar
      Serdes v2: Refactor entire serdes flow to use real Toucan, not low level (#25981) · a9f44010
      Braden Shepherdson authored
      Previously, some automatic behavior was causing problems in serdes.
      (The worst example is generating an `entity_id` on insert while
      deserializing an entity we don't own - if deserialized again it would be
      duplicated.)
      
      A whole cascade of design choices fell out of this problem:
      - `insert!` would generate `entity_id`s, so use `simple-insert!`
      - But `simple-insert!` doesn't convert eg. MBQL `:definition` maps back
        into JSON strings
      - We got the maps as Clojure data and not JSON strings because `select`
        and `simple-select` both run `post-select` and parse the JSON.
      - So we ended up with a raw query on the select side and `simple-insert!`
        on the storage side.
      
      This change unwinds that whole stack, and instead uses a dynamic
      var to suppress the few pieces of `pre-insert` and `pre-update` logic
      that causes problems.
      
      The end result is much cleaner, and much more consistent with the rest
      of Metabase's backend logic.
      Unverified
      a9f44010
  21. Oct 19, 2022
    • Case Nelson's avatar
      [Apps] Remove emitters (#25999) · f5a9ea85
      Case Nelson authored
      * [Apps] Remove emitters
      
      Emitters were created when we thought that we would be adding actions to
      multiple places in metabase. Instead we've coalesced to actions being a
      core feature of data-apps and are executed from within them. Attaching
      actions to models, as a form of re-use rather than a form of execution,
      means that actions can still be executed directly from a model, if we
      want to allow that in the future.
      
      * Fix lint errors
      
      * Move perform-action! tests out of the api.
      
      Since we want to keep the implicit bulk functionality but remove those
      endpoints move the tests to the actions namespace.
      
      * Fix linter
      
      * Change driver test to use function instead of endpoint
      Unverified
      f5a9ea85
Loading