This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 14, 2022
-
-
Luis Paolini authored
-
metamben authored
* Use (str ...) forms to translate multi-line messages * Make H2 error messages refer to the correct field
-
Ryan Laurie authored
* only call commit once
-
Ariya Hidayat authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Make `Card` types generic * Add basic question mock objects * Less typescript shenanigans
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Nick Fitzpatrick authored
updating icons and spacing
-
Luis Paolini authored
-
- Jun 13, 2022
-
-
Ryan Laurie authored
* make slider change less
-
Ryan Laurie authored
-
Dalton authored
* Remove popover logic from ParameterFieldWidget * Support formatting array values * Fix isValid logic * Readd close popover logic * Fix various bugs/broken tests Fix formatting/remapping Fix text Fix unit test Fix text Fix placeholder Fix placeholder Fix ellipses Fix bug caused by the any type Fix date parameter value formatting Readd dashboard prop Fix e2e test selector
-
adam-james authored
* Migration to allow 'null' first and last names for users This is part of improving how we handle user names, related to SSO, but we also have an opportunity to make login via email simpler as well -> just loosen the requirement for names. * When only last name is given, :common_name should not have a space * WIP making optional first/last names safe in the backend. Trying to fix up some assumptions about first/last name keys in backend implementations. * Only add `:common_name` key when non-nil * Adjust setup tests to pass if use first/last name are nil * Fix up setup tests to work with null first/last names. * User API endpoints altered to handle nil names * Remove name validation test since they can be nil now * Alter JWT/SAML tests for nil user names * Remove "unknown" default in SAML * Add tests to make sure users are updating appropriately * use good naming convention in local function Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> * Simplify truthy check in test Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> * Simplify truthy check in test Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> * Indentation fix * Fix up syntax issue from github merge. * Fix missed function name changes in test * Clean up how sets are built up in the PUT user/:id endpoint * Better implementation for update-user-name * Avoid relying on 'vals' since order of keys is not guaranteed * Fixing little things, clarification in a comment * I'm tired... missed an obvious thing here. oops * indentation and clarify some testing * Change post-select implementation slightly * expected status is now an optional arg no dynamic var binding needed * 'f' is not optional, so we take it with first, then args are rest * simplify destructuring Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Aleksandr Lesnenko authored
* validate current password * return ignored for admins old_password field for future steps
-
Gustavo Saiani authored
-
Gustavo Saiani authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Braden Shepherdson authored
Define identity-hash for fairly robust de-duplication when deserializing This is a fallback for fully robust de-duplication based on `entity_id` fields. All serialized models should support identity-hash, and there is a test to enforce that.
-
Ngoc Khuat authored
* add API to fetch and search card parameters * remove code to support linked filters * remove unecessary data in tests * fix from Noah's comments * some chain-filter -> param-values
-
Alexander Polyankin authored
-
Nick Fitzpatrick authored
-
- Jun 11, 2022
-
-
Ngoc Khuat authored
-
- Jun 10, 2022
-
-
Kyle Doherty authored
* add link to debugging sql syntax article * extract styling * use External link, tweak style
-
Alexander Lesnenko authored
-
Ariya Hidayat authored
-
Alexander Lesnenko authored
-
Maz Ameli authored
-
Mahatthana (Kelvin) Nomsawadi authored
* WIP puzzle driven development * Refactor action name to use verb * Remove element that's never shown * Handle null user names * Fix Cypress test failure after using user full name * continue handling null user name * Clean up changes * Fix code according to review - Correct translation - Fix wrong story name case - Use user data for testing * Fix failed CI build
-
Alexander Lesnenko authored
-
Alexander Lesnenko authored
-
Noah Moss authored
* allow str form as the first argument to deferred-tru * add tests and update doc strings * migrate more setting descriptions * Handle multiline translation sources ```clojure enumerate=> x (deferred-tru (str "Whether an introductory modal should be shown after the next database connection is added. " "Defaults to false if any non-default database has already finished syncing for this instance.")) enumerate=> (form->string-for-translation x) "Whether an introductory modal should be shown after the next database connection is added. Defaults to false if any non-default database has already finished syncing for this instance." ``` We get the form from `(g/grasp <file> ::translate)` which returns the `x`. And then simply pick through it for either a string literal or a call to `(str <literal>+)` Co-authored-by:
dan sutton <dan@dpsutton.com>
-
Howon Lee authored
Previously we defaulted to integer and float type in all cases for json unfolding type determination, even with bigints and bigdecimals. Now if we encounter a bignum in json unfolding we call it a bignum.
-
Gustavo Saiani authored
-
- Jun 09, 2022
-
-
Alexander Lesnenko authored
-
dpsutton authored
* Correctly handle fall-through case. Condp is exhaustive and throws if nothing matches ``` mysql=> (condp = 2 1 :nope 3 :nope) Execution error (IllegalArgumentException) at metabase.driver.mysql/eval169387 (REPL:870). No matching clause: 2 mysql=> ``` and can take a single default clause at the end with no predicate ```clojure mysql=> (condp = 2 1 :nope :default-catch-all) :default-catch-all ``` This was attempted with a regex `#".*"` but this regex does not match everything! ```clojure mysql=> (driver/humanize-connection-error-message :mysql "hello\nthere") Execution error (IllegalArgumentException) at metabase.driver.mysql/eval167431$fn (mysql.clj:124). No matching clause: hello there mysql=> (re-matches #".*" "hi\nthere") nil ``` So just use use the message as the default to be returned which was the original intention. * Fix other databases as well
-
Ariya Hidayat authored
-