Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 02, 2024
    • Chris Truter's avatar
    • Phoomparin Mano's avatar
      feat(sdk): improve license, mock server and post-install for embedding cli (#47229) · d29aa557
      Phoomparin Mano authored
      
      * ask for tenancy isolation columns
      
      * deny all permissions for all users group
      
      * create new collections
      
      * add jwt group mappings
      
      * add the permissions step
      
      * add multi-tenancy message in helper text format
      
      * add permission graph
      
      * wire together permissions
      
      * use schema permissions
      
      * use fields from table metadata from query_metadata
      
      * add tenancy field reference
      
      * remove log messages
      
      * deny access to unsandboxed tables
      
      * make permission graph more explicit
      
      * deny access to sample database for customer groups
      
      * add unit test for permission graph
      
      * split permission groups and sandboxes
      
      * jwt settings and hard-coded user attributes
      
      * handle errors when updating sso mappings
      
      * add express api and user switcher
      
      * only fallback to api keys when license is invalid
      
      * add util to sample tenancy column values
      
      * conditional BASE_SSO_API imports
      
      * improve embedding error message
      
      * setup jwt configuration after license step
      
      * setup permissions at the last step
      
      * add missing import
      
      * update steps that requires license
      
      * fix incorrect imports
      
      * add missing useContext
      
      * handle permission update error
      
      * remove tenancyIsolationEnabled field
      
      * add tenancy column sampling
      
      * differentiate tenancy column query error
      
      * rename tenancyColumnValues to tenantIds
      
      * assign sampled tenant ids to user attributes
      
      * add tenant ids
      
      * define collection permissions
      
      * reference sandboxing group by name
      
      * update snippet to be same as the README
      
      * extract ask for tenancy columns to a separate step
      
      * use the customer_id attribute
      
      * query the table query metadata at origin
      
      * append tables correctly
      
      * improve error handling in table scanning
      
      * add retry logic to metadata fetching
      
      * only query metadata for selected fields
      
      * fix race condition with retry
      
      * update loading state and retries
      
      * update comments on jwt license
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * filter the target table by id
      
      * highlight last selected tenant column
      
      * use breakout to get list of ids
      
      * temporary workaround to reload the whole page
      
      * update row value types
      
      * update row value types
      
      * ask if they want to setup a pro license
      
      * post-installation improvements for cli
      
      * block non-selected tables
      
      * remove the source-field from sandboxing
      
      * use the fk_target_field_id as instead of target.id
      
      * update unit test
      
      * add learn more message
      
      * install mock server dependencies
      
      * fix post-setup step formatting
      
      * fix text wrapping
      
      * skip tenancy columns and permissions if token is not provided
      
      * only show the server dir step when license is enabled
      
      * skip permission setup if there is no tenancy column
      
      * remove source-field as we only reference our own column
      
      * add runIf flag to skip steps
      
      * remove the gitignore mention as this is automatic
      
      * configure permission if there are some tenancy columns
      
      * make native permission types more strict
      
      * add notice about setting up local mb instance
      
      * support multiple tenancy columns
      
      * map the tenancy column name as the user attribute
      
      * add component import guide
      
      * fix deprecated punycode in node-fetch
      
      * warn on unsampled tables
      
      * show helper text on tenancy columns
      
      * allow sampling repeated tenant
      
      * add instruction to change directory into mock server
      
      * align the learn more message
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
    • Chris Truter's avatar
    • Alexander Solovyov's avatar
    • Tim Macdonald's avatar
      Upgrade Macaw to 0.2.10 (#47498) · 3286bdce
      Tim Macdonald authored
      Includes https://github.com/metabase/macaw/pull/97, which will prevent
      some false positives
    • Alexander Solovyov's avatar
      [serdes] a bit more valuable ns docstring (#47445) · 9d20e3c2
      Alexander Solovyov authored
      fixes #46039
  2. Aug 31, 2024
  3. Aug 30, 2024
  4. Aug 29, 2024
    • Aleksandr Lesnenko's avatar
    • bryan's avatar
      Realign migration ids (#47367) · 05c2fb22
      bryan authored
      * move migration in release to match master
      
      * add column if not exists
    • bryan's avatar
      Static embed dashboard and question endpoints (#47270) · b0dbb38e
      bryan authored
      
      * entity id translation + tests
      
      * add api level test
      
      * simplify definition of eid-table->model + add test
      
      * update tests to take keywords
      
      * improve comment
      
      * generate the eid-table->model map
      
      * delete now-obsolete test
      
      * make it work in oss
      
      * put the resulting response into a key, so we can add more information later
      
      * formatting
      
      * use model names without the model/ prefix as keys
      
      * Creates list of `api/model->db-model`
      
      - update keys for util/entity_id request
      - update shape of util/entity_id response
      - add test for not-found eids
      
      * formatting
      
      * Respond to code review feedback
      
      * entity-ids work on /embed/{card,dashboard}* routes
      
      * make entity id translation work for all tokens
      
      * Merge branch 'static-embed-dashboard-and-question-endpoints' of github.com:metabase/metabase into static-embed-dashboard-and-question-endpoints
      
      * massage schema. add tons of tests
      
      * decode more eids
      
      * test alignment
      
      * don't require ns inside of itself :think:
      
      * make the test functions to create tokens better
      
      * bring back `dashboard-url`
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
    • github-automation-metabase's avatar
    • Nick Fitzpatrick's avatar
      Query validator FE (#47098) · b7349ec5
      Nick Fitzpatrick authored
      * Query Validator FE
      
      * collection path, unit tests
      
      * wrapping feature with token flag
      
      * updating util function, adding row type
      
      * updating session_test.clj
      
      * type adjustment
      
      * fixing other table sorting
      
      * Empty state, clean up utils
      
      * unit test adjustment
      
      * e2e adjustment
    • Ryan Laurie's avatar
      Milestone Check Perms Fix (for real this time) :sweat_smile: (#47401) · 2b25fcab
      Ryan Laurie authored
      * another attempt at perms fix
      
      * try again
      
      * try manual graphql auth
      
      * try with global env
      
      * Try setting defaults in graphql
      
      * try some more things
      
      * use my own graphql instance
      
      * one more test
      
      * remove test code
      
      * remove rogue curly brace
    • Dennis Schridde's avatar
      Hide attached DWH database details (#47247) · 592360c9
      Dennis Schridde authored
      == Goal ==
      
      Hide attached DWH database details from anyone incl. admins:
      * Do not show them in the UI
      * Do not permit to change them
      * Do not serialize them
      
      The aim is that customers cannot gain access to (parts of) credentials,
      and they cannot break a feature they are paying for by changing
      connection details.
      
      == Implementation ==
      
      The Metabase backend already contains provisions in the implementation
      of `metabase.models.interface/to-json` for `:model/Database` to hide the
      `details` of the database in HTTP responses, if the user lacks write
      permission on the database.  We utilize this by adding an
      `is_attached_dwh` column to the `database` table and rejecting
      `metabase.models.interface/can-write?` when this flag is enabled.  In
      the "admin" UI, we show a replacement text instead of the edit form when
      the flag is set.  (It might be correct to show this whenever `details`
      is absent.  See below for possible follow-up work.)
      
      However, several sections of the frontend code expected the `details`
      field to always be present.  In order to make `details` optional, as the
      backend seems to handle it, we fix the respective code to treat this
      case in the way that appears appropriate in the context.
      
      Database details are already generally excluded from H2 dump snapshots
      (see `metabase.cmd.copy/*copy-h2-database-details*`), thus nothing
      changes there.
      
      == How to test ==
      
      === New behaviour ===
      
      Setting the `is_attached_dwh` field hides the database details:
      
      1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases.
         - In addition to the fields you would normally set, also set
           `is_attached_dwh: true`.
         - This also works when adding this flag to a database that previously
           did not have this flag set.
      2. Start your Metabase instance.
      3. Verify the database shows up in the "admin" section
         (`/admin/databases`).
      4. Verify that clicking the database to see its details only reveals
         "This database cannot be modified."
      5. Verify that responses from the backend do not include a `details`
         field for this database.
      
      === Original behaviour ===
      
      Behaviour without setting the `is_attached_dwh` field is unchanged:
      
      1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases.
         - Only set the fields you would normally set.  Do not set
           `is_attached_dwh` (or set it to `false`).
      2. Start your Metabase instance.
      3. Verify the database shows up in the "admin" section
         (`/admin/databases`).
      4. Verify that clicking the database to see its details only reveal the
         regular edit form, showing connection fields like `host`, `user`,
         etc. with the values you configured.
      
      == How this will be rolled out ==
      
      1. Upgrade existing Metabase Cloud instances with data warehouse to a
         Metabase version that supports `is_attached_dwh`.
      2. Set `is_attached_dwh` in the database section of the config file for
         Metabase Cloud instances with a data warehouse.
      
      == Possible follow-up work ==
      
      In https://github.com/metabase/metabase/issues/25715, absent
      `database.details` was identified as a bug.  Since then, `details` was
      made `NOT NULL` in the application database, so this bug can no longer
      occur.  However, today backend responses can be missing the `details`
      field, if the current user lacks write permission to the database
      setting (see above).  Fully re-evaluating the fix to #25715 in this
      context is outside the scope of this PR.
      
      Closes: https://github.com/metabase/harbormaster/issues/5051
    • Cam Saul's avatar
      Update Kondo to `2024.08.01` and add `deps.edn` aliases to run from the JVM (#47370) · 7fb88340
      Cam Saul authored
      * Add `clojure -M:kondo` and `clojure -M:kondo:kondo/all` and bump version
      
      * Fix Kondo errors
      
      * Fix Kondo+LSP issues with `defendpoint`, `defenterprise`, etc.
      
      * Use replace-deps instead of deps for speed
      
      * Ok apparently maybe we do need to copy configs when we run Kondo on CI
      
      * Oops `./bin/kondo.sh` should not try to use `clj-kondo`
      
      * Remove references to GA driver folders
    • Noah Moss's avatar
Loading