Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 08, 2024
  2. May 07, 2024
  3. May 06, 2024
  4. May 05, 2024
  5. May 03, 2024
    • John Swanson's avatar
      Add `can_write` to /collection/:id/items (#42184) · 60657636
      John Swanson authored
      For dashboards and cards/models only.
      Unverified
      60657636
    • Nicolò Pretto's avatar
      Embed homepage, MS4 (#41990) · 55500108
      Nicolò Pretto authored
      
      * use css modules instead of inline styles for cursor: default (#41644)
      
      * add toast notification after the feedback (#41575)
      
      * fix modal submit sending data while button says skip (#41784)
      
      * fix: it should not send the feedback if button says skip
      
      * add comment explaining why we check that getLastFeedbackCall() is undefined
      
      * embedding homepage analytics (#41725)
      
      * rename defaultTab -> initialTab
      
      * add events schema for embedding-homepage
      
      * fix stories
      
      * add analytics, e2e tests and fix typo in dismiss reason
      
      * copy embed_flow schema for better diff in the next commit
      
      * adds isExampleDashboard to trackStaticEmbedPublished
      
      * utm tags
      
      * fix bug of is_example_dashboard
      
      * better test names
      
      * refactor embed homepage status type
      
      * "() => {}" => "_.noop"
      
      * add "Setup embedding" to the admin setup checklist (#41638)
      
      * add setup embedding to the admin setup checklist
      
      * restore whitespace as it was before
      
      * i miss prettier (whitespace again)
      
      * Clean up check list for embedding
      
      Largely making a new entry for the embedding info just to fight long
      lines. `:embedding-homepage-dismissed-as-done` just made the maps really
      long. If we have a `:done?` under an `:embedding` keyword it reads much
      more naturally.
      
      Also, The previous diff was calling `boolean` on a var rather than
      invoking the var:
      
      ```clojure
      :embedding-app-origin (boolean embed.settings/embedding-app-origin)
      ;;                             ^^^^^^^^^^^^^^ needs to be (invoked)
      ```
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      
      * Change utm tags for embedding homepage links (#42042)
      
      * update utm tags
      
      * utm_media -> utm_content
      
      * add description to the checklist setup step (#42200)
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      55500108
    • Braden Shepherdson's avatar
      Add a few tests for time granularity parameters (#42119) · bf5eb3a0
      Braden Shepherdson authored
      The API/model schemas for dashboard parameters are general enough
      that they just work for this new type, which doesn't look very different
      from a value parameter right now.
      
      Part of #42118.
      Unverified
      bf5eb3a0
    • Cam Saul's avatar
      MLv2: Simplify MetadataProvider protocols (16 methods/3 protocols => 7... · 3829b2ce
      Cam Saul authored
      MLv2: Simplify MetadataProvider protocols (16 methods/3 protocols => 7 methods/2 protocols) (#42070)
      
      * Simplified MetadataProvider protocol
      
      * Test fix
      
      * Ok make CachedMetadataProvider a separate schema again after all.
      
      * Consolidate the Metadata schemas
      
      * Clean Kondo warnings
      
      * Malli-ify the stuff in metabase.lib.metadata.protocols
      
      * Fix Kondo warnings
      
      * Test fix :wrench:
      
      * PR feedback
      Unverified
      3829b2ce
  6. May 02, 2024
  7. May 01, 2024
  8. Apr 30, 2024
    • Cam Saul's avatar
      Fix Snowflake/Redshift filtering on date for timestamp with time zone columns (#41864) · 856b4496
      Cam Saul authored
      * Fix Snowflake filtering on date for `timestamp with time zone` columns
      
      * Snowflake should just generate raw SQL for literals
      
      * Go ahead and fix other Snowflake stuff and reenable a bunch of disabled tests
      
      * Snowflake test fixes :wrench:
      
      * Minor test improvements
      
      * Fix Redshift and Vertica as well.
      
      * Address PR feedback
      Unverified
      856b4496
    • adam-james's avatar
      Store Parameter Values Set by User on a per-user basis (#40415) · 2d29f05f
      adam-james authored
      * Store Parameter Values Set by User on a per-user basis
      
      This is a WIP for #28181 and the notion doc:
      
      https://www.notion.so/metabase/Tech-Maintain-user-level-state-in-dashboards-for-filters-fc16909a3216482f896934dd94b54f9a
      
      Still to do:
      
      - [ ] validate the table/model design
      - [ ] hook up the endpoints mentioned in the doc (2 in api/dashboard)
      - [ ] return the user specific parameter values on /api/dashboard/:dashboardID endpoints
      - [ ] write a few tests to capture the intent of this feature
      
      * Accidentally deleted a digit in the change ID timestamp
      
      * first pass at writing user param values to the db.
      
      It's in a doseq here which is probably not the correct way to go yet, but it's a step in the right direction.
      
      * Hydrate dashboard response with `:last_used_param_values` key
      
      If the user has previously set a parameter's value, it will show up in the map under that parameter id.
      
      If the user has no parameter value set, that entry will be 'null'.
      
      * Use proper fn name
      
      * Only save or retreive user params if there's a current user id
      
      * Add model to necessary lists
      
      * Only run query when there are parameter ids to run it with
      
      * Add a test to confirm that last_used_param_values works
      
      * Add models test namespace for CRUD test
      
      * The hydration is checked in the dashboard api test already
      Unverified
      2d29f05f
    • Cal Herries's avatar
  9. Apr 29, 2024
  10. Apr 26, 2024
Loading