Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 24, 2023
  2. Aug 23, 2023
  3. Aug 22, 2023
  4. Aug 21, 2023
  5. Aug 20, 2023
  6. Aug 18, 2023
  7. Aug 17, 2023
  8. Aug 16, 2023
  9. Aug 15, 2023
  10. Aug 14, 2023
  11. Aug 11, 2023
  12. Aug 10, 2023
    • Cam Saul's avatar
      Test metadata helper function consolidation (#33031) · 88451885
      Cam Saul authored
      * Test metadata helper function consolidation
      
      * More code consolidation
      Unverified
      88451885
    • lbrdnk's avatar
      Unify semicolon and comment handling in nested native queries (#30677) · 9fef23dc
      lbrdnk authored
      
      * Unify semicolon and comment handling in nested native queries
      
      * Use different comment and semicolon removal approach
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Update base and effective type verification for oracle
      
      * Avoid running test with snowflake and bigquery
      
      * Update `breakout-results` and test
      
      1. In `breakout-results` case driver statement was redundant.
      Original code had field name and types hardcoded. During further
      examination, I've realized name and types are available thanks
      to the use of `qp.test/col`, so are just "unhardcoded" :)
      
      2. `card-id-native-source-queries-test` is altered, so instead of
      hardcoding native sub-queries, roughly equivalent* mbql query is
      compiled and its native form is used. This way I can hopefully avoid
      problems with extraction of cloud databases' table names for testing
      purposes.
      
      * By roughly equivalent I mean instead of using * for selecting
      fields, mbql is compiled selecting fields explicitly. Also limit is added
      in some cases, but local testing showed no problems with that.
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Unverified
      9fef23dc
    • lbrdnk's avatar
      Modify `:contains`, `:starts-with` and `:ends-with` so field or expression can... · a98bfa1f
      lbrdnk authored
      Modify `:contains`, `:starts-with` and `:ends-with` so field or expression can be used as the second argument (#32446)
      
      * Update `LIKE` to handle fields and expressions
      
      Previously only string could be used with like clause, ie. as second
      argument of `:starts-with`, `:ends-with` or `:contains`. This commit modifies
      translation of those functions, so fields or expressions can be
      used in place of second argument.
      
      * Make only expression or field args use `concat`
      
      Using concat with values unnecessarily complects generated sql.
      
      * Update tests
      
      * Extend mongo string matching capabilities
      
      Make mongo filter compilation use `$regexMatch` for `:contains`,
      `:starts-with` and `:ends-with` so expressions and fields
      can be matched against.
      
      * Adjust mongo specific tests
      
      * Update druid
      
      Druid's filters work with `:contains`, `:starts-with` and `:ends-with`,
      but only if second argument is literal pattern. This commit updates
      existing code, so expection is thrown if `pattern` has different form
      than `[:value ...]`.
      
      * Address review comments - sql
      
      * Address review comments - mongo
      
      * Use mbql `:concat` instead of `hx/call :concat`
      
      Vertica, orcacle and sqlite handle concat differently than other
      drivers. To overcome this limitation, `pre`, `post` and `arg` are
      wrapped into mbql's concat expression which is then translated
      with regards to the specifics of particular driver.
      
      * Update according to the review feedback
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Unverified
      a98bfa1f
  13. Aug 09, 2023
Loading