This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 05, 2024
-
-
dependabot[bot] authored
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.15.4...v1.15.6 ) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
Chris Truter <chris@metabase.com>
-
- Apr 04, 2024
-
-
Braden Shepherdson authored
Goal is to properly document the interface between MLv2 and the FE. In particular I want to call out the health and fate of each function. Some of them only exist to support legacy compatibility, for example, and that should be documented to discourage new usage and make clear the conditions for removing the functions.
-
Romeo Van Snick authored
* Hide info icons when no description exists * Move defaults for InfoIcon to separate file * Add open delay to popover * Remove inverted background from type label * Fix margin on semantic type label * Make semantic type not be bold * Fix unit tests for hidden info icons * Rename file to constants * Remove unused showIfEmpty prop altogether * Fix the height of the expression suggestions that don't have an info icon * Fix padding on filter modal * Fix the height on dataref
-
Aleksandr Lesnenko authored
-
Jeff Bruemmer authored
-
Denis Berezin authored
* Add manual imports fixup * Fixes * Fixes * Review fixes * Review fixes
-
lbrdnk authored
* Enable not emptyable arguments for is-empty and not-empty clauses * Add review remarks * Shorten dataset name so it is usable with some drivers * Disable test for Athena * Handle possibly missing base type * Update comment * Missing base type field is treated as not emptyable * Update desugar middleware Now middleware adds base type to fields with integer id that are missing that first. This ensures correct function of is-empty expansion. * Update desugar middleware Cleanup base types necessary for desugaring is-empty * Update desugar middleware cleanup * Update test * Adjust tests * Remove now redundant e2e test * Update comment
-
Nicolò Pretto authored
This reverts commit 88a36a6a.
-
Kamil Mielnik authored
* Repro #23103 - Wrong number of distinct values in a native model * Fix flake
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
The first time you zoom in on a bin in a binned query, it works fine. For example, Orders COUNT by SUBTOTAL auto-binned has a bin for 40-60. If you zoom in on that, it correctly shows the range 40 to 60 broken down into smaller bins which are 2.5 units wide. If you then try to zoom in on one of these smaller bins, say 50-52.5, there are two problems: 1. The filters from the first zoom (`>= 40` and `< 60`) are still there, and so are the new ones (`>= 50` and `< 52.5`). 2. The new filter is actually wrong; it uses the big width (20) from the original bins, not the width of the nested bins (2.5), so the new filters are `>= 50` and `< 70`. This PR fixes both issues, so nested bins (1) remove the old filters, and (2) use the correct width for the nested bins.
-
Alexander Solovyov authored
-
Chris Truter authored
-
Chris Truter authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix flaky test caused by unmounted HoverCard * Remove unused test util
-
Nicolò Pretto authored
-
Oisin Coveney authored
-
Alexander Polyankin authored
-
- Apr 03, 2024
-
-
Braden Shepherdson authored
This logic was trying to match `[name join-alias]` pairs previously, but that won't work since the later stage field doesn't have a `:join-alias` on it. This falls back to matching on only the ID or name, but only if it's unambiguous. Fixes #40252.
-
Alex Yarosh authored
* fix indent in referencing models * remove syntax highlighting for now
-
John Swanson authored
This middleware shouldn't throw exceptions when `limit` or `offset` query parametesr aren't integers.
-
Lena authored
* Make Noah the codeowner for permissions et al et al = `integrations` (OSS google auth, LDAP and Slack integrations) + `enterprise` (audit, advanced SSO, advanced config stuff). `enterprise` also has LLM which doesn't really have a codeowner now, but it also doesn't need one. * Correct the paths and the scopes
-
Raphael Krut-Landau authored
Adds: * Performance tab * Data caching settings tab * Two-panel strategy editor * "Don't cache" strategy * "TTL" strategy * "Duration" strategy * "Use default" option for databases * OSS page * Unit tests [Loom](https://www.loom.com/share/b1b173a52be9401588ffb63f718e052a?sid=bed4bdf5-f967-4d93-af55-9b96b6b52730)
-
Nemanja Glumac authored
* Bump the question schema and update it with the new events * Enable snowplow tracking on the frontend * Add E2E test for tracking snowplow events related to native preview sidebar * Fix question id type in the schema
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix overflow static dashboard * Fix `frame` event's height for interactive dashboards * Fix E2E tests * Fix test names to match the correct GitHub issue numbers * Use `data-element-id` for consistency * Make the test selector more consistent
-
Ngoc Khuat authored
-
Ngoc Khuat authored
-
Lena authored
* Clarify that backport/no-backport is an internal thing A few times per month, external contributors ask about the notion doc they can't access and about the labels they are not expected to set. This is not the experience we should give to people who not only take their time to contribute to metabase, but also actually read the PR template. (slightly duplicated condition in the beginning and the end of the paragraph — "For those employed [...] If you're not employed [...]" — is on purpose) * Add linebreaks in PR template Co-authored-by:
Tim Macdonald <tim@metabase.com> --------- Co-authored-by:
Tim Macdonald <tim@metabase.com>
-
Nick Fitzpatrick authored
* Command Palette UI adjustments * move search to end of results list * ellipsis long command palette items, min icon size and showing debounced text * setting fixed width. adjusting admin result icons and text * fixing e2e test
-
Alexander Polyankin authored
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
* Map row id on object detail id * Add a fallback * Add e2e test * Add a limit * Provide a fix for #34070 * Simplify test
-
Nemanja Glumac authored
* Use MLv2 to determine whether a query can be previewed * Add E2E repro for #40608 * Expand E2E repro * Fix test * Make sure the step is active and visible before offering to preview its query * Expand E2E test * Address review comment - use `getNotebookStep` helper
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
* Do not put js code into page title * Typecheck * Add e2e test * Update e2e/test/scenarios/question/document-title.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove old config + fix typo * Add new analytics for 4 new illustration settings
-
Cal Herries authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .DashEditing * Migrate .CardTitle * Migrate .PinMap * Migrate .PinMapUpdateButtonDisabled * Migrate .BrandColorResizeHandle * Migrate .VisualizationSlowSpinner * Migrate .AddSeriesModal * Migrate 2 more classes
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix default export * Remove unused classes * Remove unused components
-
Mahatthana (Kelvin) Nomsawadi authored
* Add login page illustration (#39299) * Move Metabot setting to a new place * Add setting for login page illustration * fix UI styling * Fix not able to upload the same file twice * Update the admin > appearance > conceal metabase copy * Prepare the component for tests * Add some unit tests * Prevent settings not saved sometimes After setting the value to/from `custom` one of the setting could be failed to save, I suspect this happens because the race condition from trying to save the setting values relatively at the same time. * Make unit tests easier to read * Add all unit test test cases * Add basic E2E test * Show fallback icon for broken images * Make use of the proper component * Update the comment to affect the reality * Add an error message when file size is over 2MB * Show an error message when the file size > 2MB * Add the error message tests * Preserve the preview image aspect-ratio * Detect corrupted images * Fix failing unit tests * Address feedback: Type * Feedback: Create meaningful variables * Feedback: Make selector API more sensible * Prevent race condition Makes sure we save the settings completely before making other actions that also change settings otherwise, there could be race conditions. * Feedback: tighten up a type * Feedback: Fix inconsistency callback calls * 2. Add the rest 3 illustration settings (#40487) * Add the rest 3 illustration settings * Don't make the X icon feel lonely * Fix illustration widget saving * Fix type error * 3. Update the select UX to match new design (#40491) * Update the select UX to match new design * Move info dot next to file upload button * Simplify IllustrationWidget API * Update setting title copy * Clean up test comments * Feedback: Clarify `any` type * Feedback: Use shorthand object creation Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Feedback: Use global CSS glass instead of inlining values Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Feedback: Remove unnecessary curly brackets in JSX Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * 4. Connect illustrations to new setting values (#40139) * Wire landing page illustration to the setting value * Wire the unsubscribe page to the setting value * Prepare no rows error to be wired to the setting value * Wire no question results illustration to the setting value * Wire no search results illustration to setting value * Fix error from fixing conflict * Fix required unnecsseary prop on Image * Use Image component * Link dashboard card no results image to the setting value * Move the no data results to more a generic directory * Link collection picker no results image to the setting value * Make illustrations more accessible * Fix failed tests * Test unscribe page illustration + test no illustration * Add landing page tests * Simplify Cypress selectors * Refactor: Rename settings to match the new requirements No question data -> No Data No search results -> No object These changes are made so, these 2 settings are generic enough to include other illustrations later on. * Add no data illustration test * Add no object illustration tests * Fix unsubscribe page background style * Fix not able to build static viz * 5. Follow-up on milestone 1 (#40710) * Update custom background illustration scale behavior * Remove the need to put an SVG file in static folder * Fix test from rebasing off master with @testing-library/user-event upgrade --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-