Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 21, 2024
  2. Jun 20, 2024
  3. Jun 19, 2024
    • Raphael Krut-Landau's avatar
      fix: Use an indicator-agnostic testid (#44265) · e5c14e16
      Raphael Krut-Landau authored
      * Use an indicator-agnostic testid
      
      * Run sed
      
      * Use correct testid
      e5c14e16
    • Case Nelson's avatar
      fix: populate param-fields for named fields on public dashboards (#44440) · 523ea248
      Case Nelson authored
      
      * Update e2e test
      
      * Update e2e test
      
      * fix: populate param-fields for named fields on public dashboards
      
      * Add name to public hydration
      
      * Add tests
      
      * Add tests
      
      * Fix tests
      
      ---------
      
      Co-authored-by: default avatarAlexander Polyankin <alexander.polyankin@metabase.com>
      523ea248
    • Raphael Krut-Landau's avatar
      fix(cache): Fix two bugs in Admin / Performance (#44255) · 08613cb3
      Raphael Krut-Landau authored
      Ensures that minimum query durations are correctly displayed in the form post-save (#44249) and that all times can be used in the Schedule component  (#44257)
      08613cb3
    • Raphael Krut-Landau's avatar
    • Cal Herries's avatar
      Exclude native query matches in search scoring when the search should exclude... · 3f788bba
      Cal Herries authored
      Exclude native query matches in search scoring when the search should exclude native queries (#43982)
      
      Co-authored-by: default avatarChris Truter <crisptrutski@users.noreply.github.com>
      3f788bba
    • adam-james's avatar
      User parameter value json fix (#44420) · bbde99dd
      adam-james authored
      
      * UserParameterValue transforms wrapped to properly escape string vals
      
      The `json-in` and `json-out` functions used for toucan model transforms do not perform any string escaping logic. This
      makes sense as we don't want to make assumptions about the shape of data flowing in/out of the db. But, this did mean
      that for the User paramter values table, string values were causing an error to be logged. This doesn't break
      anything, as the function will still correctly return the string, but it can clutter up logs.
      
      So, this PR wraps all incoming values in a map and unwraps it for outgoing values.
      
      * Add migration to wrap existing user param values with ::wrapper key
      
      Since the in/out transform for UserParameterValues is updated, we need to migrate any existing values to have this wrapping.
      
      * Simplify the solution to the problem.
      
      Since we're already getting what we need from the json-in/json-out *except* that it's logging a parse error, we can
      create a json-out that works the same way (tries to parse and returns the string as-is if it fails) without logging an
      error at all.
      
      * take away the arg and keywordize inside the json-out fn
      
      * remove irrelevant comment
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      
      * Add a little more test coverage for different value types
      
      * faster test thanks to Dan!
      
      * Add a comment about the data being tested
      
      ---------
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      bbde99dd
    • Alexander Polyankin's avatar
    • adam-james's avatar
      XLSX Pivot Table Downloads have 'Native' Pivot Table (#43791) · 89bdaa2f
      adam-james authored
      * XLSX Pivot Table Downloads have 'Native' Pivot Table
      
      Addresses: #2473
      
      The xlsx downloads work fine for regular tables. However, on Pivot Table downloads, the resulting file isn't pivoted
      and is formatted somewhat strangely (it contains additional rows related to totals, has an extra 'pivot-grouping'
      column).
      
      Now, the downloaded xlsx file contains 2 sheets:
      - the data sheet containing the question's rows unpivoted. If you were constructing a pivot table yourself, you would
      probably start with this shape of data.
      - the pivot sheet containing a 'native' Pivot table whose reference points to the data on the data sheet, and whose
      columns, rows, and values align with the cols, rows, and measures set up in Metabase
      
      * Silly typo!
      
      * Exported Pivot uses correct aggregation (sum, count, stddev, avg, min, max)
      
      * data for pivot exports now also uses the formatting
      
      * Add a test asserting that a pivot table exists in the xlsx file
      
      * add-row! is a method dispatching on sheet class
      
      * remove unnecessary hint
      
      * address review feedback:
      
       - consolidate the aggregation function key fns into one function in the .xlsx namespace
         this was moved out of postprocessing so that the xlsx specific fns don't litter the post processing namespace at
         this time
      
       - clean up an unnecessary destructiring inside the native-pivot function
       - don't shadow 'name' inside the body of a fn
      
      * Add tests that confirm zero-col and zero-row situations work
      
      * Consolidate the atoms used to store pivot rows/options
      89bdaa2f
    • Alex Yarosh's avatar
      docs: Serialization API uses POST (#44439) · 301ab32c
      Alex Yarosh authored
      * call attention to POST
      
      * wording
      301ab32c
    • Nemanja Glumac's avatar
      MS2: Expose "Include this {period}" in time-series chrome (#44247) · 737c24af
      Nemanja Glumac authored
      * Expose "Include this {period}" in timeseries chrome
      
      * Fix type errors
      
      * Simplify type guards
      
      * Add unit tests
      
      * Remove Flex wrapper around Switch
      
      * Extract `IncludeCurrentSwitch` component
      
      * Add E2E smoke tests
      
      * Cover the toggle behavior with E2E tests
      
      * Simplify test with a simple helper
      737c24af
    • Chris Truter's avatar
      870dcd6c
Loading