Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 12, 2021
    • Nemanja Glumac's avatar
    • Howon Lee's avatar
      Popover movement #15502 (#15524) · 9baaff76
      Howon Lee authored
      Popover movement is with reference to #15502 but also with reference to #15277 and #15534 and #15502 but not #15445, except for the mutation movement portion of #15445 which is not a whole fix.
      
      Confusingly, the overlap portion of #15502 is almost a completely separate bug but a fix is in here anyways.
    • Alexander Lesnenko's avatar
      Support both 0 and null values in a dimension for X axis (#15554) · bfbc3c45
      Alexander Lesnenko authored
      * support both 0 and null values in a dimension for X-axis
    • Nemanja Glumac's avatar
    • Dalton's avatar
      Dashboard parameter field filter operators feature flag (#15519) · a362e2f3
      Dalton authored
      
      * Backend feature flag for new field filters
      
      * Feature flag new parameter options
      
      When the "field-filter-operators-enabled?" flag is disabled we do the following:
      1. Replace new operator options with old category and location/city, etc., options
         in the PARAMETER_OPTIONS list found in metabase/meta/Parameter.js
      2. Hide numbers section in the PARAMETER_SECTIONS list found in
         metabase/meta/Dashboard.js
      3. Return args as-is in the mapUIParameterToQueryParameter function
         found in metabase/meta/Parameter.js
      
      React/UI code handles both old options and new options so doesn't need
      to change. Old parameter types like "category" and "location/city" are
      treated like "string/=" in the UI but retain their own parameter type
      when used to send a new query.
      
      * Fix FE issues caused by meta/Parameter refactor
      
      * mock the field operator param flag to make tests pass
      
      * add/fix cypress tests
      
      * fix import in ParametersPopover
      
      * update widget tag type
      
      * Enable field filter operators for cypress tests
      
      * Question marks are questionable
      
      * Conditionally use category or string/= if field filters are enabled
      
      * rmv mocks where we don't need them
      
      * rmv mock from chained-filters test
      
      * env vars as string in project.clj, alignment
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
    • Cam Saul's avatar
    • Jeff Evans's avatar
      Various improvements to version update checks (#15517) · 9392ddd7
      Jeff Evans authored
      * Various improvements to version update checks
      
      ***************************
      * Release project changes *
      ***************************
      
      Updating version_info.clj code to build version-info-ee.json file for Enterprise Edition build
      
      Adding test for both oss and ee version info file generation logic
      
      Decoupling GitHub milestone from version and setting it to be the OSS value for :ee release build
      
      Adding nREPL alias for release deps.edn project and usage note
      
      ************************
      * Core product changes *
      ************************
      
      Adding new :ee version of :mb-version-info-url (:mb-version-info-ee-url) with default value to match the file name generated by the release code
      
      Making enterprise-edition? public from core.clj, since it's now needed from the upgrade check code to switch between the URLs
      
      Adding new setting to store when updates were last checked (since it's on a 12-hour interval)
      
      Changing update check code to both set this new timestamp setting (always) to the current time, and set version-info itself to nil if the update check fails (so that users won't see "latest and greatest" if the update check succeeded at some point in the past, but then started failing
      
      Frontend changes:
      
      Showing the "last checked" timestamp (in user's browser timezone) when we show the "Sorry" text because of being unable to check for updates, so they know when the last check was made
      
      Removing custom implementation of MetabaseSettings.versionInfo from EE frontend code since it's no longer needed (and never worked), because the EE backend will now be hitting a different URL with the version info specifically for EE releases
      
      Linking to https://www.metabase.com/docs/<newVersion>/operations-guide/upgrading-metabase.html URL instead of simply /start
    • Dalton's avatar
    • Nemanja Glumac's avatar
  2. Apr 10, 2021
  3. Apr 09, 2021
  4. Apr 08, 2021
    • Nemanja Glumac's avatar
      Fix flakiness in `scatter` visualization tests (#15520) · 22d17fa2
      Nemanja Glumac authored
      - Fixes a flake in scatter.cy.spec.js that started appearing after throttle was introduced to the ExplicitSize component in #15235
      - Also fixes a flake with brush filter that apparently wasn't fully fixed in the previous attempt
      
      ## Additional Info:
      - Stress testing this fix in isolation with GitHub actions shows 20/20 runs passing 
      - Stress testing "brush date filter" revealed that it still fails approximately 4-5x out of 20!
      
      - The reason seems to be that `mouseup` event doesn't always happen at the same time so the resulting filter doesn't have the same ending month every time (for example I've seen: "Created At between May, 2016 September, 2016", "Created At between May, 2016 July, 2016" and even "Created At between May, 2016 May, 2016")
      - It is more than enough that we assert that this filter exists in the first place so I changed the assertion to: `cy.contains(/^Created At between May, 2016/);` since the beginning of this string is the only thing we care about
  5. Apr 07, 2021
  6. Apr 06, 2021
  7. Apr 05, 2021
  8. Apr 04, 2021
Loading