This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 12, 2024
-
-
metabase-bot[bot] authored
* Compare datetimes w/o timezone fields with literals as strings Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
metabase-bot[bot] authored
* source-field populated in aggregates with foreign refs When aggregates are populated that reference other tables, either a `:source-field` must be provided in the field metadata or a `:join-alias` needs to be provided. The former is preferred. Prior to this PR, the first situation in the below simplified case could happen: ```clojure ;;Simplified case ;; busted (qp/process-query {:database 1, ;; 59 is "PRODUCTS" -> "PRICE" which is not in the "REVIEWS" table :query {:aggregation [["sum" ["field" 59 {:base-type "type/Float"}]]] ;; "REVIEWS" :source-table 8}, :type "query"}) ; Works (qp/process-query {:database 1, ;; The `:source-field` metadata fixes the above query :query {:aggregation [["sum" ["field" 59 {:base-type "type/Float" ;; "REVIEWS" -> "PRODUCT_ID" :source-field 71}]]] :source-table 8}, :type "query"}) ``` This PR updates `metabase.automagic-dashboards.interestin/ground-metric` to use the `->reference` function for fields when building the `decoder` for transforming field names to references, which properly adds sources for external fields. Fixes #38618 * Updating `grounded-metrics-test` to reflect updated field referencing. Co-authored-by:
Mark Bastian <markbastian@gmail.com>
-
metabase-bot[bot] authored
* Track * Browse models: Add banner (#38261) * Fix banner width * Browse models: Sort official collections to the top (#38578) * Browse models: only show 'Learn about our data' on the databases tab * Browse models: Add banner (#38261) * Fix banner width * Browse models: Sort official collections to the top (#38578) * Browse models: only show 'Learn about our data' on the databases tab * Use BrowseRedirect to set default tab properly, and test * Use setup function in BrowseRedirect tests * Clarify BrowseRedirect tests * Fix e2e test * Fix unit tests * Try to fix e2e test * Remove TODO * Rename tests * Follow Ryan's good advice * Use localStorage rather than a setting * Be more explicit * Update tests of BrowseRedirect to use localStorage * Remove unit tests of bromo default tab (these were failing in CI and the functionality is covered in e2e tests ) * Revert "Remove unit tests of bromo default tab (these were failing in CI and the functionality is covered in e2e tests )" This reverts commit 5f4c3c1e2c1e9f67c2c43c5423ab87d66d0c78ca. * No need to mock local storage in this way; it's done automatically * Fix import * Remove uberjar tracker * Restore uberjar tracking * remove build * clean up header * fix database browsing * fix + simplify tab persistence * encapsulate banner logic * simplify authority level sort * fix rebase --------- Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
Cal Herries authored
-
metabase-bot[bot] authored
* Fix linking to public or embed resource on dashboards not working * Update embedding test name to use a snazzier term * Add tests Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Chris Truter authored
-
- Feb 11, 2024
-
-
Nick Fitzpatrick authored
* don't lower dashboard title when there is no last edit info * same with questions
-
Nick Fitzpatrick authored
* adding links with hardcoded IDs * add audit-info endpoint * fix perms * Fetching Dashboard IDs from the API * e2e tests * add BE tests * kinda busted * InstanceAnalyticsButton * removing unused file * Update enterprise/backend/src/metabase_enterprise/audit_app/api/user.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> --------- Co-authored-by:
Jerry Huang <jhuang37050@gmail.com> Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Feb 10, 2024
-
-
Ryan Laurie authored
* Connection Impersonation for Redshift * redshift test based on the existing postgres one * fix test * fix test * change impersonation UI for redshift * copy/style updates * update tests for new copy * update copy * lets tweak it even more --------- Co-authored-by:
Noah Moss <noahbmoss@gmail.com>
-
- Feb 09, 2024
-
-
Jerry Huang authored
* add BE for billing status * add BE for billing status * fix whitespace * fix english * address comments * fix whitespace * fix comments * update design * update design * add test * consume json error * address comments * update url
-
Jeff Bruemmer authored
-
John Swanson authored
Sometimes analytics bits get removed by other tests (e.g. deleting all cards, dashboards, users, etc.). When we run `ensure-audit-db-installed!`, though, the checksum hasn't changed (since the underlying analytics files didn't change), so we skip reloading the data. This sets `last-analytics-checksum` to `-1` (meaning: skip the checksum and just load the analytics data) when running `ensure-audit-db-installed!` in the tests that we've seen flake.
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
Zoom-in drills are not available for such bins, and this is now tested. Also updates a few comments: - Pivot drills work for **one** aggregation and 0 breakouts, not for 0. - Legend clicks and pivot cell clicks look the same, so some tests cover both cases and this is now noted by comments.
-
bryan authored
* load analytics only when changed using a checksum - over audit deserialization files * update docstrings * fix testing wording * fix nil analytics-resource-dir * in tests, when you delete the audit db, set the checksum back to 0 * add a comment * WIP hashing ia content from inside a jar * Do the unzip sooner, still hashes the file system Co-authored-by:
John Swanson <john.swanson@metabase.com> * cleanup java-time -> java-time.api --------- Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
Braden Shepherdson authored
These were not adding an extra stage in order to filter queryies with aggregations. Progress towards #36253.
-
Ryan Laurie authored
* allow appends from collection list * little type fixes * fix existing unit tests * possible one-character-catastrophe * don't allow invalid form submission * add appends test *
enums * design feedback * update tests to match new design -
Noah Moss authored
* Connection Impersonation for Redshift * redshift test based on the existing postgres one * fix test * fix test
-
Oisin Coveney authored
* Add snowplow events for embedding setup flow * Fix dashboard model tests * Fix dashboard tests * Fix card tests * Fix dashboard API tests * Fix type error * Implement analytics 2/7 1. public_link_copied 2. public_link_removed * Fix snowplow schema enum Removing null as we don't seem to put `null` in `enum` * Complete the embed_flow snowplow schema * Modify `initial_published_at` to not be overridden * Implement analytics 4/7 1. public_link_copied 2. public_link_removed 3. public_embed_code_copied 4. static_embed_published 5. static_embed_unpublished * Prevent accidental ESLint log in Cypress * Differentiate `EmbeddingParametersSettings` from `EmbeddingParametersValues` We were mixing the type before, as the former one are the type of the setting values, not the actual values for the parameters. * Fix dashboard and card types * Fix `params` count for `static_embed_published` event * fixup! Prevent accidental ESLint log in Cypress * Fix ESlint from the result of upgrading ESLint package * Fix Snowplow schema enum to include null * Fully implement `static_embed_code_copied` * Finish embed_flow snowplow
* Fix unit tests because markup change * Fix E2E tests * Fix E2E CI failure Apparently using `.realClick()` on copy button could fail locally, but pass on CI and vice-versa. I couldn't replicate this all the time. I'm not sure why it would fail locally. * Fix copy to clipboard not working on CI * Improve test readability * Remove extra test-id * Fix refactor `*CodeOptionId` * Restrict Snowplow schema * Revert unnecessary change * Apply Cal's suggestions for BE improvements Co-authored-by:Cal Herries <39073188+calherries@users.noreply.github.com> * Update src/metabase/util/embed.clj Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> * Fix backend linter error, hopefully. --------- Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Noah Moss authored
* Default enable-public-sharing to false for existing instances, and true for new ones * add rollback * fix typo * try to fix e2e test * invert conditionals * use derivedSettings instead
-
Chris Truter authored
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Luis Paolini authored
-
Jesse Devaney authored
* Migration adding 'width' to Dashboards 3 migrations: - 1st adding the width column with default value of 'fixed' - 2nd updating all existing dashboards to have width 'full', which corresponds to what the current behaviour is (will be the 'old' behaviour after the fixed-width project lands). - The rolloback here is necessary but we don't care what happens as the column will be dropped immediately in the next rollback anyway - 3rd sets the notNullableConstraint. DefaultNull is 'full' here, just in case there's an existing dashboard whose width value is not yet set from the 1st migration. Don't know how that could happen, but its here in case * Dashboard PUT api endpoint accepts width changes and updates appdb update-dashboard function now is aware of the :width key so those changes can end up in the transaction. Also added a width test that asserts that the value's default is "fixed", it can be changed, eg. to "full", but cannot be changed to other values. * Add width to revision tests * Fix dashboard revision tests. :width key is now needed in some revision tests. As well we need a string communicating that the :width setting has changed from 'full' to 'fixed' or vice-versa. * Fix comments/remarks in migration to be accurate * Attempt to fix default not working mysql/mariadb * Set default in dashboard model Signed-off-by:
Adam James <adam.vermeer2@gmail.com> * Revert default :width 'fixed' value. * Explicitly add default value 'fixed' for MySQL/MariaDB * dashboard fixed width FE implementation * adjust popover shadow styling as the popover was blending in with the header * adjust extra button popover offset * add E2E to validate behavior * add fixed width container to public dashboards * fix public embedding not respecting dashboard width setting * add test for public dashboards * Fix embed test failures * add fixed width to x-ray dashboards * reduce code duplication * move FixedWidthContainer into DashboardGridConnected - We get the fixed-width w/o code duplication across AutomaticDashboardApp, PublicDashboard, and Dashboard * update E2E tests to reflect actual intended behavior * fix type errors * tweak default width of cards to accomodate fixed width * adjust tooltip button after merging changes from master * fix bar chart test failure * fix dashboard filters date test failure - new ellipsis button in dashboard edit mode broke the test * adjust test for new fixed width dashboards * adjust test for new fixed width dashboards * adjust test for new fixed width dashboards * bump funnel default width * adjust test for new fixed width dashboards * Fix double overlay for LineAreaBarChart dash-cards - No longer has an overlay that persists from editing mode to viewing mode - Adjust click-behavior tests to account for new grid-width. Old test relied on a dashcard being taller than they will now default to being. i.e. Move the chosen point/row to down an index. * Merge FixedWidthContainer with dashboard grid div * supress brush events while editing timeseries line charts on dashboard * fix failing test - test failed because I did not update this assertion based on previous changes * fix broken link input in editing mode * initial commit * fix pointer events issue on text cards in edit mode * update tests for new dash-card default sizes * update tabs card moving test because of new default card sizes * Include apply filters button in fixed width behavior * tweak - do not need centering if full width * fix apply filters button * add fixed width behavior to dashboard filters in edit mode * remove double border in edit mode * evenly space parameters/filters in edit mode * update test to account for moving location of edit mode filters * Milestone 3B: Fix dashboard tabs and filters order on a public dashboard page (#38574) * Add `className` prop to `DashboardTabs` * Fix tab panel position in public dashboards * adjust filters container padding * Address feedback --------- Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> --------- Signed-off-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Noah Moss authored
* new audit views and migrations * fix tests * rename external users group to anonymous, handle api key users, and add query definition to query_execution table * fix mysql user email field * update yamls for 49 --------- Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com>
-
John Swanson authored
`with-model-cleanup` is called like so: ``` (with-model-cleanup [:model/User] ...) ``` This ends up calling: ``` (with-model-cleanup-additional-conditions model) ``` to get the additional conditions necessary when "cleaning up" the model. This multimethod dispatched on `mi/model`. But `(mi/model :model/User)` is `nil`. Instead, we *already have* the model, not an instance of it, so we want to dispatch on that to properly clean up after ourselves.
-
Cam Saul authored
* Redshift: drop session schema when test suite finishes [ci skip] * Update Hawk version * PR feedback * Bump Hawk version * Skip after-run for drivers that don't have test extensions --------- Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
Oleg Gromov authored
-
Thomas Schmidt authored
-
Cal Herries authored
-
Cal Herries authored
-
Romeo Van Snick authored
* Use greater than to assert timeout has elapsed * Use fake timers to test delay group
-
Chris Truter authored
Co-authored-by:
Callum Herries <calherries@gmail.com>
-
Chris Truter authored
-
Cal Herries authored
-
- Feb 08, 2024
-
-
Braden Shepherdson authored
There are cases where the ref as provided is not the same as what a fresh `(lib.ref/ref column)` would give. This seems mostly to affect models, where the metadata leaks some of the underlying details like joins. Fixes #38034.
-
Kyle Doherty authored
-
Kyle Doherty authored
* Migration adding 'width' to Dashboards 3 migrations: - 1st adding the width column with default value of 'fixed' - 2nd updating all existing dashboards to have width 'full', which corresponds to what the current behaviour is (will be the 'old' behaviour after the fixed-width project lands). - The rolloback here is necessary but we don't care what happens as the column will be dropped immediately in the next rollback anyway - 3rd sets the notNullableConstraint. DefaultNull is 'full' here, just in case there's an existing dashboard whose width value is not yet set from the 1st migration. Don't know how that could happen, but its here in case * Dashboard PUT api endpoint accepts width changes and updates appdb update-dashboard function now is aware of the :width key so those changes can end up in the transaction. Also added a width test that asserts that the value's default is "fixed", it can be changed, eg. to "full", but cannot be changed to other values. * Add width to revision tests * Fix dashboard revision tests. :width key is now needed in some revision tests. As well we need a string communicating that the :width setting has changed from 'full' to 'fixed' or vice-versa. * Fix comments/remarks in migration to be accurate * Attempt to fix default not working mysql/mariadb * Set default in dashboard model Signed-off-by:
Adam James <adam.vermeer2@gmail.com> * Revert default :width 'fixed' value. * Explicitly add default value 'fixed' for MySQL/MariaDB * dashboard fixed width FE implementation * adjust popover shadow styling as the popover was blending in with the header * adjust extra button popover offset * add E2E to validate behavior * add fixed width container to public dashboards * fix public embedding not respecting dashboard width setting * add test for public dashboards * Fix embed test failures * add fixed width to x-ray dashboards * reduce code duplication * move FixedWidthContainer into DashboardGridConnected - We get the fixed-width w/o code duplication across AutomaticDashboardApp, PublicDashboard, and Dashboard * update E2E tests to reflect actual intended behavior * fix type errors * tweak default width of cards to accomodate fixed width * adjust tooltip button after merging changes from master * fix bar chart test failure * fix dashboard filters date test failure - new ellipsis button in dashboard edit mode broke the test * adjust test for new fixed width dashboards * adjust test for new fixed width dashboards * adjust test for new fixed width dashboards * bump funnel default width * adjust test for new fixed width dashboards * Fix double overlay for LineAreaBarChart dash-cards - No longer has an overlay that persists from editing mode to viewing mode - Adjust click-behavior tests to account for new grid-width. Old test relied on a dashcard being taller than they will now default to being. i.e. Move the chosen point/row to down an index. * Merge FixedWidthContainer with dashboard grid div * supress brush events while editing timeseries line charts on dashboard * fix failing test - test failed because I did not update this assertion based on previous changes * fix broken link input in editing mode * fix pointer events issue on text cards in edit mode * update tests for new dash-card default sizes * update tabs card moving test because of new default card sizes --------- Signed-off-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-