This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 05, 2024
-
-
Kamil Mielnik authored
* Introduce describeWithSnowplowEE and use it in e2e/test/scenarios/onboarding/home/browse.cy.spec.js * Use separate block for EE tests
-
metabase-bot[bot] authored
Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
- Mar 04, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
metabase-bot[bot] authored
* wip * SLO works with auth slo handler route * move slo handling endpoint to /auth/sso/handle_slo * fix slo redirect url * SLO works, and the sso-handle-slo for saml is where it belongs - a ton of cleanup * fix api/session namespace + add docstrings * cleaning up logout action * add slo logout test along with slo response xml * whitespace + linter * add docstring * update exclusions in deps.edn * un-require metabase-enterprise ns from oss ns * add docs for how to setup SLO to metabase docs * docs: clarify that setting up SLO is optional * move slo logout endpoint into ee code - removes sso-info defenterprise since it is no longer needed * use current version of saml20-clj --------- Co-authored-by:
bryan <bryan.maass@gmail.com> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
* Add new email function and send email to creator * remove debug stuff * add tests, address comments * actually add tests * Update src/metabase/email/messages.clj * address comments --------- Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
metabase-bot[bot] authored
In the legacy QP the `:fields` of the outer query has the ID, `[:field 100 {}]` so the JSON unfolding is written out again. With this change, the `source-alias` is used for columns coming from previous stages. Fixes #34930. Fixes #35636. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
metabase-bot[bot] authored
When determining column aliases in `add-alias-info`, reuse an existing desired column alias if one is present. Fixes #39059. Might fix #25931. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
metabase-bot[bot] authored
`(joinable-columns query stage a-join)` previously returned `:lib/source :source/table-defaults` and set `:metabase.lib.join/join-alias` but not `:source-alias`. This corrects both issues so that `joinable-columns` on a join returns columns with the same shape as from `visible-columns`. Also refactors a series of `mapv` transforms into a transducer pipeline. Fixes #39514. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
metabase-bot[bot] authored
This just expands the documentation in the primary x-ray namespace (`metabase.automagic-dashboards.core`). At this point, someone new to the namespace should be able to get into the x-ray code without difficulty. Co-authored-by:
Mark Bastian <markbastian@gmail.com>
-
metabase-bot[bot] authored
* Clear undo stack when first opening native editor (#39003) * Add regression test for #35344 * Clear undo's when first opening editor * Make sure normal undo's still work * Fix test not to use focusNativeEditor --------- Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
* Fix mongo password handling * Update test, add credential check * Address the review remarks Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
metabase-bot[bot] authored
Repro #23851 - Drill-through on a timestamp column binned as XofY fails unless sematic type is defined (#39510) (#39521) * Add repro for #23851 * Use arrow function * Improve assertions * Improve assertion Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
metabase-bot[bot] authored
Repro #30312 - Cannot filter directly from table column header when Question is Summarized (#39500) (#39515) * Add repro for #30312 * Use arrow function * Improve assertions Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
metabase-bot[bot] authored
* Use `null` instead of `false` for `setEditingDashboard` * Replace `isEditing` with `editingDashboard` * Extract `EditableActionButtonAttrs` Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
metabase-bot[bot] authored
* Add repro for #34690 * Add a repro for #34688 * Rename file * Format code * Update test name Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
metabase-bot[bot] authored
* Fix snowflake ssh tunnel * Put test where it will run in CI * Override incorporate-ssh-tunnel * Revert snowflake in util.ssh-test * Move tunnel connection tests to sql_jdbc * Add mock-server fixture * Exclude drivers from tunnel test * Fix up reconnection tests * Exclude more drivers * Address PR feedback Co-authored-by:
Case Nelson <case@metabase.com>
-
- Mar 01, 2024
-
-
metabase-bot[bot] authored
* Dashboard Header FC, using entity, select, and dispatch hooks (#39267) * Dashboard Header FC, using entity, select, and dispatch hooks * resolving types * updating other use of getDashboardActions * PR feedback * shimming in bookmark list hook --------- Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
metabase-bot[bot] authored
* Generate unique user name in table-privileges-test Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
metabase-bot[bot] authored
* fix click behavior for routing to a new tab on the same dashboard * update changes * add test to validate behavior Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
-
metabase-bot[bot] authored
* Fix dashboard tabs drop animation * Remove animation delay from an e2e test Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Kamil Mielnik authored
* Revert "Fix missing result metadata (#39201) (#39243)" This reverts commit ca5d0e28. * Bring back e2e test
-
metabase-bot[bot] authored
Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
- Feb 29, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
metabase-bot[bot] authored
* Hack test case to unblock Oracle tests In metabase.query-processor-test.implicit-joins-test/implicit-joins-with-expressions-test we calculate an interval by going back from today a number of years to arrive at 2019. On February 29, this calculation fails with Oracle because there was no February 29 in 2019. This hack changes 2019 to 2020 and makes Oracle happy. breakout-on-temporally-bucketed-implicitly-joined-column-inside-source-query-test had to be adjusted too. Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
metabase-bot[bot] authored
* Don't delete "off" persisted_info records If they are off, they are "eligible" models for persistence that we do not want to persist. And to remember that use choice to not persist them we need to keep the record around. This was handled previously, but https://github.com/metabase/metabase/pull/39219 was a bit too blunt. We had a bunch of records in a "creating" state that we weren't removing, so i deleted them regardless of state. But we want to make sure that the "off" ones are not deleted. On stats, a bunch of ones that were set to off are now slated to be persisted after the prune job deleted the persisted_info records. * unused local. whoops Co-authored-by:
dpsutton <dan@dpsutton.com>
-
metabase-bot[bot] authored
* translate object action select strings * import order fix Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
metabase-bot[bot] authored
* improve error messages * update error message Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
-
metabase-bot[bot] authored
We prune persisted info records if they meet any of the following criteria: ```clojure (or (contains? (persisted-info/prunable-states) current-state) (:archived card-info) (not (:dataset card-info))) ``` But we only deleted the record when: ```clojure (when (= "deletable" current-state) (t2/delete! PersistedInfo :id (:id persisted-info))) ``` So any records that were in a "creating" state (persist a model, but before it first gets persisted, make it not a model, or archive the underlying model), we constantly pruned them but never removed the persisted info record. Leading to task results like: ```javascript {"success": 21, "error": 0, "skipped": 0} ``` Because 21 things were queued up for pruning, were attempted to be pruned, but the persisted info record never removed. Co-authored-by:
dpsutton <dan@dpsutton.com>
-