Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 26, 2021
  2. Nov 25, 2021
  3. Nov 24, 2021
  4. Nov 23, 2021
  5. Nov 22, 2021
  6. Nov 19, 2021
  7. Nov 18, 2021
    • Anton Kulyk's avatar
    • Dalton's avatar
      Reimplement tooltips using tippy.js (#18880) · 80d81a10
      Dalton authored
      * add tippy and react-is
      
      * add tippy styles to vendor.css
      
      we'll probably override most things but it handles
      apply the triangle to tooltips
      
      * reimplement Tooltip using tippy
      
      * reimplement ChartTooltip using Tooltip
      
      * add tooltip theme styling
      
      * fix StoreLink styling
      
      * remove TooltipPopover
      
      * add util for easy mapping to innerRef
      
      * use innerRef util with StoreLink target
      
      * react-is type defs
      
      * convert Tooltip into tsx
      
      * convert styled-components util into typescript
      
      * fix Tooltip fallback return
      
      * use Tooltip in Icon over Tooltipify
      
      * remove Tooltipify
      
      * pass ref all the way through Icon
      
      * fix DimensionListItem styling caused by missing ref
      
      * fix ChartTooltip event target bug
      
      * fix unit test by making Icon.tsx grosser
      
      * replace popover() util with tooltip() in cy tests
      
      * fix random broken e2e test
      
      * improve types in Tooltip
      
      * move everything to a separate folder + add tests
      
      * add more examples
      
      * rmv accidental deps
      
      * fix run button styling
      
      * add Link tooltip prop to avoid tooltip on icon
      
      * wrap MetabotLogo in forwardRef
      
      * support reduced motion
      
      * remove flow type from dom.js so we can use in ts files
      
      * pass isEnabled prop to tippy's disabled prop
      
      once you've activated "control mode" in tippy you can't turn it off so
      using "visible" as a toggle doesn't work. instead, use disabled.
      
      * fix uncentered tooltip the right way
      
      tippy includes padding/margin in its centering calculations, unlike
      tether, so we will need to be careful about adding one-sides
      padding/margins to a tooltip target, otherwise the tooltip will appear
      offcenter
      
      * workaround for absolutely positioned element
      
      the tooltip appeared on the far end of the target because of a child div
      that is absolutely positioned. quick fix is to instead target the icon
      
      * fix positioning of HintIcon tooltip
      
      * lint fix
      
      * add placement prop
      
      * fix styled component tooltip target styling
      
      * place QuestionNotebookButton tooltip below
      
      * Make the NativeQueryButton an actual button
      
      * set tooltip placement to bottom
      
      * lint fix warning
      Unverified
      80d81a10
    • Dalton's avatar
      Use filesystem caching in webpack (#19022) · c7c4975b
      Dalton authored
      * enable webpack caching
      
      * only enable in devMode
      
      * invalidate cache when build deps change
      Unverified
      c7c4975b
    • Anton Kulyk's avatar
    • Anton Kulyk's avatar
      Display datasets in recent searches and on activity page (#18987) · 9e026ac0
      Anton Kulyk authored
      * Display dataset model name in recent searches
      
      * Fix dataset URLs in activity
      
      * Fix icons in activity recent views
      
      * Distinguish datesets from questions in activity
      
      * Fix message
      Unverified
      9e026ac0
  8. Nov 17, 2021
    • dpsutton's avatar
      Add fixture warning to rebuild static viz on failures (#18995) · 0a83bd3c
      dpsutton authored
      Had wanted to make a heuristic that would look at timestamp of the
      bundle and timestamps of the sources and compare. But this could fail
      when switching branches. Simpler and easier to just throw a warning on
      all failures
      
      ```clojure
      js-svg-test=> (binding [*test-out* *out*] (run-tests))
      
      Testing metabase.pulse.render.js-svg-test
      
      FAIL in (foo) (js_svg_test.clj:28)
      [PRO TIP] If this test fails, you may need to rebuild the bundle with `yarn build-static-viz`
      
      expected: 1
        actual: 2
          diff: - 1
                + 2
      
      Ran 8 tests containing 29 assertions.
      1 failures, 0 errors.
      {:test 8, :pass 28, :fail 1, :error 0, :type :summary}
      ```
      
      For posterity, attempt using timestamps was
      
      ```clojure
      (deftest bundle-up-to-date-test
        (let [js-bundle (io/file (io/resource js-svg/bundle-path))
              to-date   (fn [epoch] (java.time.Instant/ofEpochMilli epoch))]
          (is (.exists js-bundle) bundle-recreate-warning)
          (when (.exists js-bundle)
            (let [source-files       (file-seq (io/file "frontend/src/metabase/static-viz"))
                  most-recent-source (apply max-key #(.lastModified %) source-files)]
              (is (.isAfter (to-date (.lastModified js-bundle))
                            (to-date (.lastModified most-recent-source)))
                  bundle-recreate-warning)))))
      ```
      Unverified
      0a83bd3c
    • dpsutton's avatar
      Fix flaky email tests (#19023) · b51d1788
      dpsutton authored
      Docstring for `regex-email-bodies` states:
      
      > "Return messages in the fake inbox whose body matches the
      regex(es). The body will be replaced by a map with the stringified regex
      as it's key and a boolean indicated that the regex returned results."
      
      But it does ont return messages in the fake inbox whose body matches any
      of the regex. It returns them all regardless, with information if they
      match or not. Simply correct this behavior to match the docstring
      
      ```clojure
      {"rasta@metabase.com"
       ({:from "notifications@metabase.com",
         :to #{"rasta@metabase.com"},
         :subject "We've Noticed a New Metabase Login, Rasta",
         :body {"https://metabase.com/testmb" false, "has any results" false, "My question" false}}
        {:from "notifications@metabase.com",
         :to #{"rasta@metabase.com"},
         :subject "We've Noticed a New Metabase Login, Rasta",
         :body {"https://metabase.com/testmb" false, "has any results" false, "My question" false}}
        {:from "notifications@metabase.com",
         :to #{"rasta@metabase.com"},
         :subject "You set up an alert",
         :body {"https://metabase.com/testmb" true, "has any results" true, "My question" true}})}
      ```
      Unverified
      b51d1788
    • Jeff Evans's avatar
      Secrets :closed_lock_with_key: PR 6 - Update Oracle properties (#18320) · 0480c2cc
      Jeff Evans authored
      
      * Add SSL keystore and truststore secret properties to Oracle driver YAML files
      
      
      Update Oracle driver to set keystore and truststore connection options from secret values
      
      Adding new `select-keys-sequentially` helper function for dealing with assertions on transformed conn props
      
      Add new function to the secret namespace to return a lighter weight "secret map", and remove that functionality from the `handle-db-details-secret-prop!`, so that it can be reused from connection testing
      
      Modifying CircleCI to set the corresponding truststore secret conn prop vars instead of JVM-level truststore settings, as the test had been doing previously
      
      Expand Oracle test connection details to incorporate all SSL related properties, and also make it a function instead of delayed def (so changes can be picked up later)
      
      Misc. fixes in Oracle driver YAML files
      
      Update `exception-classes-not-to-retry` to include SSLHandshakeException
      
      Fix misc issues in secret and database model code
      
      Update CircleCI config to use correct secret based env var keys and values
      
      Add *database-name-override* dynamic var in `metabase.test.data.interface` to allow for DB name overriding
      
      Fix up ssl connectivity test so all parts pass successfully
      
      Get rid of crazy with-redefs to swap in the existing test-data's schema, and instead, just dropping the DB if it was created under a different schema (similar to what H2 does)
      
      Co-authored-by: default avatarGustavo Saiani <gustavo@poe.ma>
      Unverified
      0480c2cc
    • frannietrempe's avatar
      Docs – jar install page and getCallerClass error (#19018) · fa7b5ffc
      frannietrempe authored
      
      * added links and edited headings
      
      * documented getCallerClass error
      
      * Added create directory section
      
      * Wording and spacing edits per Jeff feedback
      
      * Fixing error in ToC from last commit
      
      * punctuation and spacing
      
      Co-authored-by: default avatarft-metabase <ft-metabase@ft-metabases-MacBook-Pro.local>
      Co-authored-by: default avatarJeff Bruemmer <jeff@metabase.com>
      Unverified
      fa7b5ffc
    • Alexander Polyankin's avatar
      Unverified
      afb9a039
  9. Nov 16, 2021
Loading