Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 29, 2023
  2. May 27, 2023
  3. May 26, 2023
    • Mark Bastian's avatar
      Change MySQL DDL creation timeout back to 10 minutes (from 30 seconds) (#31104) · 125b5e60
      Mark Bastian authored
      We use async to monitor ddl execution for MySQL since it does not have the concept of a (non-select) statement timeout.
      
      @snoe had originally set this to 10 minutes, but (we believe) this was causing tests to run exceptionally long and 30 seconds felt more reasonable. After receiving customer feedback that we actually do need longer timeouts, we are restoring the timeout to 10 minutes.
      
      Links containing context:
      - https://github.com/metabase/metabase/pull/23443
      - https://github.com/metabase/metabase/pull/27858
      - https://metaboat.slack.com/archives/CKZEMT1MJ/p1685128597747419
      
      Fixes #31102
      125b5e60
    • Denis Berezin's avatar
      [Epic PR] Make drill-through chiller (#26836) (#30273) · 45dcf573
      Denis Berezin authored
      * Update underlying records drill - bring to top, label changes (#29984)
      
      * Zoom in Drill (#30208)
      
      * Add updated zoom drill title
      
      * Fix e2e tests
      
      * Add title unit tests
      
      * Fix for Records drill UI when it is the only one displayed
      
      * Review fixes
      
      * Add pivot drill common popover (#30275)
      
      * Add grouping for Pivot drill options
      
      * Reuse filterField type
      
      * Fix date formatting after rebase
      
      * Move Automatic insight action to a common popover (#30370)
      
      * Refactor ChartClickActionsView, reuse it component in drills (#30706)
      
      * 26836 separate views for quick cell click filters (#30532)
      
      * Added separate views for QuickFilterDrill
      
      * Add tests, fix styles issues
      
      * 26836 contains/does not contain quick filter for tables (#30778)
      
      * Add contains/does not contain quick filter for tables
      
      * Self review fixes
      
      * Fix for column header filter search options cropped
      
      * Fix for icon margin difference for contains / does not contain filters
      
      * Fix contains filter actions icon styles
      
      * Add quick filters support for aggregated queries
      
      * Not show contains filter for joined fields
      
      * Fix typecheck
      
      * Adjust string field quick filter section title to have column name (#30888)
      
      * 26836 Add View details action for quick filters (#30967)
      
      * Add View details action to quick filters
      
      * Self review fixes
      
      * Fix e2e tests
      
      * Fix review issues
      45dcf573
    • Aleksandr Lesnenko's avatar
      fix the question description icon placement in the collection view (#31051) · bfd25306
      Aleksandr Lesnenko authored
      * fix the question description icon placement in the collection view
      
      * fix specs
      bfd25306
    • metamben's avatar
    • Aleksandr Lesnenko's avatar
      fix dashcards crash (#31044) · d550a27e
      Aleksandr Lesnenko authored
      d550a27e
    • Cam Saul's avatar
      Fix `:convert-timezone` and `:get-week` schemas (#31054) · ffacb252
      Cam Saul authored
      * Fix `:convert-timezone` and `:get-week` schemas
      
      * Make sure moment-timezone stuff gets loaded in Cljs
      ffacb252
    • Cam Saul's avatar
      MLv2: TS wrappers for `fields` and `withFields`; minor tweaks (#31052) · 1f196cbf
      Cam Saul authored
      * MLv2: TS wrappers for `fields` and `withFields`; minor tweaks
      
      * Fix type declaration
      1f196cbf
    • lbrdnk's avatar
      Fix mongo nested queries handling (#30877) · 08a6a5c4
      lbrdnk authored
      * Fix native source query handling for mongo
      
      * Add test for mongo nested native query
      
      * Fix mongo `aggregation-at-index` usage
      
      * Add test for source query with aggregation and sort
      
      * Adjust test for presto and oracle
      
      * Add PR suggestions
      08a6a5c4
    • Natalie's avatar
      docs - update public links (#31045) · 1432ac8b
      Natalie authored
      1432ac8b
    • Braden Shepherdson's avatar
      For a breakout on a custom column, hide the binning/bucketing options (#31037) · 94d3d37d
      Braden Shepherdson authored
      This has never worked (see #11371) and produces bad results which group
      by every individual value of the column, rather than binning/bucketing
      correctly.
      
      This can theoretically be supported, but needs BE work to construct
      correct queries. To be addressed after MLv2.
      94d3d37d
    • Nemanja Glumac's avatar
      [E2E] Cypress Replay.io Integration (#29787) · 5e359e20
      Nemanja Glumac authored
      
      * Install `replay.io` library
      
      * Register `replay.io` in the Cypress config
      
      * Run E2E tests using Replay chromium browser but only in CI
      
      * Upload Replay.io recordings to the dashboard
      
      * Manually install Replay.io browser
      
      * Always upload recordings
      
      * Pass in a custom test run id
      
      * Disable asserts and send replays to a separate team
      
      * Upload OSS recordings as well
      
      * Use specific Ubuntu version
      
      * Record and run Replay.io on `master` only
      
      * Do not toggle CI browsers in the config
      
      * Test run: pass `replay-chromium` browser as CLI flag in a run
      
      * Fix multi-line command
      
      * Use replay plugin conditionally
      
      * Set the flag correctly
      
      * Require node process
      
      * Remove sourcemap vars
      
      * Record using replay.io on schedule
      
      * Explicitly name replay runs
      
      ---------
      
      Co-authored-by: default avatarJaril <jarilvalenciano@gmail.com>
      5e359e20
    • Ngoc Khuat's avatar
      Move logic to infer revision.description to BE (#30502) · edc969ce
      Ngoc Khuat authored
      
      * Dashboard Tab entity (#29802)
      
      * add dashboard tab entity
      
      * Dashboard tabs CRUD (#29861)
      
      * Dashboard tabs frontend (#30189)
      
      * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx`
      
      commit-id:7cdfd86a
      
      * add tabs to dash
      
      commit-id:d3c2fa74
      
      * improve code structure and other fixes
      
      * rename `dashboardtab_id` to `dashboard_tab_id`
      
      * remove explicit `position` logic
      
      * improve code quality
      
      * add renaming functionality
      
      * add two new tabs when creating first tab
      
      * hide tabs if there is only one
      
      * add unit test for `DashboardTabs` component
      
      * refactor
      
      * fix type errors
      
      * add `tabId` to text cards
      
      * add `tabId` to link cards
      
      * add `tabId` to action button
      
      * use disabled state when only one tab remains
      
      * refetch cards with filter value when changing tabs
      
      * add e2e test
      
      * fix broken e2e tests
      
      * add horizontal scrolling
      
      * fix unit test
      
      * fix create tab button being on right
      
      * fix performance issue when switching tabs
      
      * add `ttag` to `tabs.ts`
      
      * use `aria-label` in e2e test helper
      
      * fix type error after rebasing
      
      * making ordered_tabs optional for tests purposes
      
      * fix failing unit tests
      
      * fix failing e2e tests
      
      * fix flaky revision history e2e test
      
      * fix type error after merging feature branch with master and rebasing
      
      * fix revisions unit test
      
      * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * migrating revision logic to BE
      
      * handle description for multiple cards add/remove
      
      * test fixes
      
      * adds tests
      
      * make sures events are started so tests work
      
      * remove additional `:maybe` that was added while rebasing
      
      * add title and has_multile_changes to revision
      
      * fixes potential test flake
      
      * more tests
      
      * remove debug code
      
      * handles collection change description in card and dashboard
      
      * fixes fail to build
      
      * use backend for revision history (#30772)
      
      * use BE response for revision history
      
      * update `service.unit.spec.js`
      
      * sort revision and moderation events for question timeline
      
      * test fixes
      
      * create revision directly instead of via API to avoid flake
      
      * reverted to an earlier revision => reverted to an earlier version
      
      * translate the model name too
      
      * Rename functions:
      - diff-strs -> diff-strings
      - diff-strings -> diff-strings*
      - diff-strings* -> diff-string
      
      * move the diff to diff-strings*
      
      * use case instead of map for model-str->i18n-str
      
      * remove title from API response
      
      * do not translate test model
      
      * rename var `title_text` to `titleText`
      
      * address comments
      
      * stringify the display name
      
      * fix revert button not working
      
      * add loading wrapper to fix unit test
      
      * fix tests
      
      * fix type error
      
      * fix QuestionActivityTimeline test
      
      * add a dot for edited this
      
      ---------
      
      Co-authored-by: default avatarEmmad Usmani <emmadusmani@berkeley.edu>
      edc969ce
    • Alexander Polyankin's avatar
    • Kamil Mielnik's avatar
      Fix missing confirmation when running an action without parameters in dashboards (#31058) · 28b1789c
      Kamil Mielnik authored
      * Add a test case for #28981
      
      * Always open ActionParametersInputModal when clicking an action
      - update unit tests to reflect this behavior
      28b1789c
    • Cal Herries's avatar
      Fix not able to Enable/Disable Actions when Choose when syncs and scans happen is Enabled (#30976) · a1405914
      Cal Herries authored
      * Fix not being able to Enable/Disable Actions when Choose when syncs and scans happen is Enabled
      
      * Fix test
      a1405914
    • Kamil Mielnik's avatar
    • Mahatthana (Kelvin) Nomsawadi's avatar
      fcaf6554
    • Uladzimir Havenchyk's avatar
      15a30d3b
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Merge Track disabling auto-apply filters in Snowplow to master #30796 (#31020) · 9f575cd1
      Mahatthana (Kelvin) Nomsawadi authored
      * Consolidate auto-apply filters toggle action (#30978)
      
      So that when we start tracking the event on Snowplow, we can only do that in a single place.
      
      * Track disabling auto-apply filters in Snowplow (#30987)
      
      * Fix dashboard ID type
      9f575cd1
    • Nemanja Glumac's avatar
      [CI] Fix stress-test workflow (#31028) · 3090dfaf
      Nemanja Glumac authored
      3090dfaf
  4. May 25, 2023
    • metamben's avatar
      e87e627f
    • Cam Saul's avatar
      5c5a81f0
    • Nick Fitzpatrick's avatar
      89fd0a09
    • bryan's avatar
      Ensure smooth audit-db syncs for h2, postgres, and mysql (#30885) · 7aa00451
      bryan authored
      * fix h2 audit db syncs
      
      - typo: s/default-admin-db-id/default-audit-db-id/g
      - print db id without locale settings in `name-for-logging`
        - we probably never had a database with and id > 1000, but it would
          print like "1,000" in logs.
      - remove 2 more `defendpoint-schema` forms
      
      * adds making sure creating spec for *application-db* doesn't fail
      
      * Fixes test to only run when ee-avaliable, and only check for no throwing
      
      - Also handle case where manuall deleting the database doesn't delete
        the matching permissions (the path aka object is the same)
      
      * linter fix
      
      * fix linter error over deprecated hx namespace
      
      * add some test logging
      
      * update requires
      
      * remove logging, continue testing:
      
      - db->pooled-connection-spec
      - connection-details->spec
      
      * make sure we call the right ensure-audit-db-installed!
      
      * use mbc/ensure-audit-db-installed! directly
      
      * clean up test ns + fix clj-kondo linting
      
      * tie audit-db creation to running ee edition
      7aa00451
    • Maz Ameli's avatar
      New upload icon (#30956) · 2db279b8
      Maz Ameli authored
      
      * new upload to cloud icon
      
      * add upload icon to dropzone overlay
      
      * update icon size prop type
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      2db279b8
    • Nick Fitzpatrick's avatar
      9c17dea8
    • Luis Paolini's avatar
    • Nick Fitzpatrick's avatar
      Custom homepage (#30545) · 111c47ee
      Nick Fitzpatrick authored
      
      * Adding admin settings
      
      * updating homepage
      
      * permissions
      
      * Include custom homepage on current user
      
      Response from `/api/user/current/` now always includes a key
      `custom_homepage`. It is nil unless `custom-homepage` setting is true
      and `custom-homepage-dashboard` is set to an id that is a valid
      dashboard that the user can read. (note this includes archived
      dashboards). In this circumstance, the response will be
      
      ```
        ...
        "custom_homepage": {
          "dashboard_id": 87
        },
        ...
      ```
      
      * adding unit tests
      
      * Homepage CTA
      
      * cleanup and types
      
      * e2e tests, small adustments
      
      * lint
      
      * type fix
      
      * Editing Dashboard Reminder
      
      * fixing unit test
      
      * ensure custom homepage dashboard exists and is not archived
      
      * handling dashboard archived scenario, use-dashboard-query
      
      * polish
      
      * Copy updates, removing personal collections from picker
      
      * PR Feedback
      
      * CI checks
      
      * PR Feedback
      
      * Adding default filter function
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      111c47ee
Loading