This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 24, 2021
-
-
Noah Moss authored
* respect `remember` field on backend if session tokens are not enforced via env variable * modify docs to describe new behavior * fix indentation * use get-in to access remember field of request * add a session api test * expose session-cookies as a public setting * hide remember me checkbox if session-cookies is set
-
Alexander Lesnenko authored
* Fix #15980: Refresh on hover * unskip repro for #15980 Co-authored-by:
Roman Abdulmanov <roman.abdulmanov@gmail.com>
-
- May 21, 2021
-
-
Ariya Hidayat authored
Co-authored-by:
Yoshiki Iida <lhclrt176@gmail.com>
-
Nemanja Glumac authored
#16170 Repro: Line Chart on MongoDB drops all values when using "Replace Missing Values with nothing or zero" (#16183) * Add repro for #16170 * Skip describe block in mongo `native.cy.spec.js` * Skip describe block in postgres `native.cy.spec.js`
-
- May 20, 2021
-
-
Ariya Hidayat authored
-
Nemanja Glumac authored
* Remove helper type functions from the global scope We are using `_typeUsingPlaceholder` and `_typeUsingGet` only in `frontend/test/metabase/scenarios/question/custom_column.cy.spec.js`. There is no point in exporting them and keeping them available in the global scope. * Create `enterCustomColumnDetails()` helper function * Use new helper function in repro for 13241 * Refactor existing test with the new helper function This test is interesting and a good litmus for this new helper function. It clearly shows that issues with `contentEditable` field were truly fixed in #16157. Formula `[Quantity] * [Product.Price]` resolves in the UI as `[Quantity] * [Product → Price]` and the test doesn't break, which means race conditions were solved. * Use new helper function in repro for 12762 * Refactor repro for 13289 * Refactor repro for 12649 * Refactor repro for 15741 * Use helper function in ExpressionEditorTextfield describe block Confirms #16157 is working as expected. * Erase `_typeUsingPlaceholder` and `_typeUsingGet` functions * Refactor repro for 13122 * Refactor repro for 13217 * Refactor repro for 15922
-
Gustavo Saiani authored
* Update ExpressionWidget state criteria * Remove isRequired from onClose propType
-
- May 19, 2021
-
-
Ariya Hidayat authored
Guard against undefined `options` passed from FieldValuesWidget to the TokenField component, which happens in some cases.
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Abstract and reuse `mockProperty` function * Add repro for #15558
-
Nemanja Glumac authored
* Add repro for #15882 * Assert on the number of lines
-
Nemanja Glumac authored
-
- May 18, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- May 17, 2021
-
-
Cam Saul authored
* Fix Druid queries with multiple filters if some but not all are temporal * Fix Druid queries with temporal Fields that don't have a :temporal-unit * Test fix
* Fix syntax errors * Query result metadata should return the :unit from the source query when applicable * Test fix * Clarify comment in test * More test fixes * Test fix -
Ariya Hidayat authored
* Use ExternalLink to automatically use noopener/noreferrer * Address code review feedback
-
Noah Moss authored
-
Noah Moss authored
-
- May 14, 2021
-
-
Noah Moss authored
-
- May 13, 2021
-
-
Nemanja Glumac authored
* Delete obsolete Safari favicon * Set the default favicon path to the existing icon * Delete fallback png favicons * Fix placeholder in related Cypress test
-
Cam Saul authored
-
dpsutton authored
log4j includes different class files for different jvm versions. This means our uberjar includes these versions so we are a multi-release jar. Need to set this in our manifest. Fixes the reflection warning seen on startup on jdk 11's ~/p/w/metabase ❯❯❯ java -jar target/uberjar/metabase.jar WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.
-
Cam Saul authored
* Fix Druid queries with multiple filters if some but not all are temporal * Fix syntax errors
-
Nemanja Glumac authored
#15959 Repro: Adding cards to dashboard via search can cause the card to show spinner until browser refresh (#16040)
-
Nemanja Glumac authored
* Install `cypress-real-events` library * Register `cypress-real-events` globally
-
- May 12, 2021
-
-
Cam Saul authored
* Dashboard param value (chain filter) endpoints should return cached FieldValues * Test fix
* Test fixes * PR feedback/appease linters * Hydrate :table to avoid lots of DB calls * Use hash of current user perms set for sandboxed field values cache key * Fix missing :require * Test fix -
Raimon Grau authored
Co-authored-by:
Raimon Grau <raimonster@gmail.com> Co-authored-by:
Walter Leibbrandt <23798+walterl@users.noreply.github.com>
-
Nemanja Glumac authored
-
- May 11, 2021
-
-
Nemanja Glumac authored
- Cherry picks 274be949 from `master`, which extracted unit and timezone tests from CircleCi and made them run using GitHub actions - Synchronizes the "state" between the `master` and `release-x.39.x` branches Co-authored-by:
Ariya Hidayat <ariya@metabase.com>
-
Nemanja Glumac authored
#15998 Repro: Tooltip only shows first Y-axis value when X-axis is numeric and style is Ordinal/Histogram (#16003)
-
- May 10, 2021
-
-
Noah Moss authored
Clarifies which part of the Google link is relevant to Metabase, and modifies some language to better mirror the terms used by Google/OAuth
-
Nemanja Glumac authored
Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Nemanja Glumac authored
Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Jeff Evans authored
Update tests in accordance with changed geocode API results ("Begles" -> "Talence") See output of: https://get.geojs.io/v1/ip/geo.json?ip=185.233.100.23
-
dpsutton authored
* Emit events outside of db/transaction When emitting events (particularly revision events), the event handler loads the item from the db to ensure that all post-processing is done. If done from inside a transaction, there's a race between the event handler looking up the object from the db and the transaction completing to put the item in the db. When the event handler wins, the following code fails: ```clojure (push-revision! :entity Dashboard, :id id, :object (Dashboard id), ;; this is nil :user-id user-id, :is-creation? (= :dashboard-create topic) :message revision-message) ``` and then the schema check for `push-revision!` fails `(map? object)` and there is no event recorded for creation. On edit, it might get the pre-edit version and record an incorrect message or not create the revision for the latest change, preventing going back in the future. I'm only doing this in dashboard but these changes should be audited and applied everywhere * Remove `:dashboard-card-update` and `:dashboard-card-create` events These events were introduced 5 years ago and never have had an event handler. No worries about race conditions when emitting them from a transaction if nothing ever cared in the first place.
-
Nemanja Glumac authored
* Add repro for #15947 * Expand the assertion with the joined table Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
- May 07, 2021
-
-
Ariya Hidayat authored
-
Nemanja Glumac authored
-
- May 06, 2021
-
-
dpsutton authored
I don't exactly follow what's going on in #15901. But it seems that the field information can be kept in the db > ""field_ref"":[""field"",""count(*)"",{""base-type"":""type/BigInteger""}] And so we need to handle this base type here. Note that in the function that calls `update-filter-for-field-type` it checks that the field has a base_type. I'm also a bit confused by the base_type vs base-type in the above snippet. But again the calling code has ```clojure (and (= param-type :dimension) (get-in value [:field :base_type])) (update-filter-for-field-type value) ``` So it seems the field has a base_type rather than a base-type.
-