Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 24, 2021
  2. May 21, 2021
  3. May 20, 2021
    • Ariya Hidayat's avatar
    • Nemanja Glumac's avatar
      Fix #16131: Refactor "hacky" helper functions (#16164) · bab15e94
      Nemanja Glumac authored
      * Remove helper type functions from the global scope
      
      We are using `_typeUsingPlaceholder` and `_typeUsingGet` only in `frontend/test/metabase/scenarios/question/custom_column.cy.spec.js`.
      There is no point in exporting them and keeping them available in the global scope.
      
      * Create `enterCustomColumnDetails()` helper function
      
      * Use new helper function in repro for 13241
      
      * Refactor existing test with the new helper function
      
      This test is interesting and a good litmus for this new helper function.
      It clearly shows that issues with `contentEditable` field were truly fixed in #16157.
      
      Formula `[Quantity] * [Product.Price]` resolves in the UI as `[Quantity] * [Product → Price]` and the test doesn't break, which means race conditions were solved.
      
      * Use new helper function in repro for 12762
      
      * Refactor repro for 13289
      
      * Refactor repro for 12649
      
      * Refactor repro for 15741
      
      * Use helper function in ExpressionEditorTextfield describe block
      
      Confirms #16157 is working as expected.
      
      * Erase `_typeUsingPlaceholder` and `_typeUsingGet` functions
      
      * Refactor repro for 13122
      
      * Refactor repro for 13217
      
      * Refactor repro for 15922
      Unverified
      bab15e94
    • Gustavo Saiani's avatar
      Fix UX bugs in ExpressionWidget (#16157) · 03bdd075
      Gustavo Saiani authored
      * Update ExpressionWidget state criteria
      
      * Remove isRequired from onClose propType
      Unverified
      03bdd075
  4. May 19, 2021
  5. May 18, 2021
  6. May 17, 2021
  7. May 14, 2021
  8. May 13, 2021
  9. May 12, 2021
  10. May 11, 2021
  11. May 10, 2021
  12. May 07, 2021
  13. May 06, 2021
    • dpsutton's avatar
      Fall back to base_type when calling parse-value-for-field-type (#15905) · 45c4d2fe
      dpsutton authored
      I don't exactly follow what's going on in #15901. But it seems that
      the field information can be kept in the db
      
      > ""field_ref"":[""field"",""count(*)"",{""base-type"":""type/BigInteger""}]
      
      And so we need to handle this base type here. Note that in the
      function that calls `update-filter-for-field-type` it checks that the
      field has a base_type.
      
      I'm also a bit confused by the base_type vs base-type in the above
      snippet. But again the calling code has
      
      ```clojure
      (and (= param-type :dimension)
           (get-in value [:field :base_type]))
      (update-filter-for-field-type value)
      ```
      
      So it seems the field has a base_type rather than a base-type.
      Unverified
      45c4d2fe
Loading