This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 26, 2022
-
-
dpsutton authored
* Substitute persisted queries in parameter card references ```sql select o.total, o.quantity, model_p.category, model_p.title from orders o left join {{#14-pg-products}} model_p -- reference to products model on o.product_id = model_p.id limit 4 ``` Testing: I'm unhappy with how verbose the test is. At some point we're going to need a better, standardized way to test persistence. But the test makes a persisted table of the test-data.categories table (test/metabase/test/data/dataset_definitions/test-data.edn). It runs some sql to update the values in the table to turn `"Winery"` -> `"Winery from cached table"`, joins the two tables together to have both at once. There's a lot of moving pieces and the setup is a bit verbose. There's also no obvious place where these types of tests should go. We'll need to consolidate them in the future (and extend them). * persisted macro * docstring for `persisted-info-native-query` * alignments and small nits * Reuse persistence macro * clj-kondo cleanups * remove clj-kondo change before rebase
-
Alexander Polyankin authored
-
Jeff Bruemmer authored
-
Natalie authored
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
- Sep 23, 2022
-
-
Dalton authored
-
Natalie authored
-
Natalie authored
-
Dalton authored
* Remove redundant query runs * Don't show dirty mode screen and add exceptional code to handle editing dataset question * Fix unit test * jk no need to do that * Fix e2e tests * Refactor/fix getIsResultDirty selector * Add updateQuestion unit test * update fn name
-
Natalie authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix rotated x-axis tick labels margin * Adjust spacing * Remove unused imports.
-
Alexander Polyankin authored
-
metamben authored
* Introduce /execution/ permission
-
Cal Herries authored
* Extract updateTemplateTagNames from initializeQB * Move updateTemplateTagNames back to intializeQB * Rename variable
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Cal Herries authored
* Tidy propagateDashboardParameters * Add comment for propagateDashboardParameters * Update comment * Add comments to shouldPropagateDashboardParameters * Expand boolean expression * Remove redundant comments
-
Ngoc Khuat authored
* the fix * adding some tests * alternative solution in which we don't merge metadata for aggregation fields at all * wording for the docstring * use partial= and remove smart quotes. Thanks Cam
-
Nemanja Glumac authored
* Rename setup spec * Generate sample database metadata * Configure datamodel settings * [TEMP] Trigger workflow run in the current branch * Authenticate as admin * Tweak popover getter * Do not use popover at all * Use scrollable container * Add initial questions * Expand smoke test checks * Dismiss the `qnewb` modal * Wait for the card query to load * Revert "[TEMP] Trigger workflow run in the current branch" This reverts commit 8f8601e5fbcbe5520efe056b806f09a89af83624.
-
- Sep 22, 2022
-
-
Bryan Maass authored
* Handle bigint and boolean casts properly - Add JSON -> SerializedJSON to `database-type->base-type` * adds tests json bigint and boolean types for mysql * Fix most of the tests - still need to figure out :type/BigInteger vs :type/Integer * fiddling with tests * handle json booleans via default mechanism * fix tests * remove not(not(...)) from test * bonk the test - also fixes ddl.execute-with-timeout-test thrown? regex * remove inline def * try to get logs off ci * don't test json on mariadb -- that never worked * cleanup tests * revert change to driver/database-supports? :mysql :nested-field-columns * respond to code review comments
-
Cam Saul authored
* 347 errors, 34 warnings * 89 errors, 66 warnings * 63 errors, 39 warnings * 52 errors, 33 warnings * 23 errors, 22 warnings * 13 errors, 4 warnings * Fix the last few errors. * Sort Kondo config
-
Noah Moss authored
* allow disabling custom geojson via env var * add env var to docs and tweak setting description
-
Noah Moss authored
-
Noah Moss authored
* wip changes * new endpoint * fix test * more test fixes * add test for EE settings permissions * try to fix another BE test * address ngoc's comment * fix cypress test * fix another cypress test to hit new settings endpoint
-
Ryan Laurie authored
* update query instead of datasetQuery in action editor * fix type
-
Anton Kulyk authored
* Remove collection actions not suitable for apps * Allow archiving apps
-
Nemanja Glumac authored
* Unskip repro for #13059 * Consolidate tests related to moving the dashboard
-
Alexander Polyankin authored
-
Dalton authored
* Remove _update from Question * Update TimeseriesGroupingWidget * Update ExtendedOptions * Update SummarizeSidebar * Update AddAggregationButton and AggreationItem * Remove update method from MBQLClause * Update ChartTypeSidebar * Update GuiQueryEditor * Update NativeQueryEditor * Update BulkFilterModal * Update Notebook * Update NotebookSteps * Update NotebookStep * Update AggregateStep * Update BreakoutStep * Update DataStep * Update ExpressionStep * Update FilterStep * Update JoinStep * Update LimitStep * Update SortStep * Update NativeQueryButton * Update QuestionDataSelector * Update QuestionFilters * Update QuestionRowCount * Update View * Update random doc * Ensure we have a 'datasetQuery' in the setDatasetQuery function * Ensure we have a 'datasetQuery' in the setDatasetQuery action
-
Anton Kulyk authored
-
Anton Kulyk authored
-
- Sep 21, 2022
-
-
Bryan Maass authored
* allow turning off mysql json unwrapping - somehow this value was set to always be true, but it should be toggle-able.
-
Natalie authored
-
Jeff Bruemmer authored
-
Anton Kulyk authored
* Fetch foreign keys for main model table * Add `foreignTables` method to `Table` * Show related tables in the info panel * Fix duplicates
-
Bryan Maass authored
- also for ignoring INIT=... on the conn string
-
Anton Kulyk authored
* Export `SidebarLinkProps` * Expose `SidebarLink's` left & right containers That'd allow styling left and right elements from external components * Extract `DraggableSidebarLink` component Based on sortable bookmarks code * Use `DraggableSidebarLink` in `BookmarkList` * Fix dragged item styles
-
Case Nelson authored
`display: action-button` => `display: action`
-
Nick Fitzpatrick authored
* Adding tests for re-ordering bar chart series * PR feedback * more PR feedback
-