Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jan 23, 2023
  2. Dec 28, 2022
  3. Dec 13, 2022
  4. Sep 23, 2022
  5. Aug 02, 2022
  6. Jul 06, 2022
  7. Jun 08, 2022
    • metamben's avatar
      Support SSL with client auth for Mongo (#22977) · cef4c19b
      metamben authored
      We have already had support for server authentication based on custom
      certificates. This change adds support for authenticating the client
      based on custom client key and certificate.
      cef4c19b
  8. Jun 02, 2022
    • adam-james's avatar
      Adjust JWT and SAML fetch-and-update user to save new attributes (#23005) · 174afe58
      adam-james authored
      * Adjust JWT and SAML fetch-and-update user to save new attributes
      
      Before this change, JWT/SAML logins would attempt to update attributes, but never considered the first-name or
      last-name attributes.
      
      * Attempts to fix tests to prevent pulluting test users with "Unknown"
      
      * No deleting users.
      
      * Unit tests checking that first/last names are updated for SSO users
      
      When an SSO user is first logged in, they might not have first_name and/or last_name keys. This is allowed, but the
      names will be "Unknown" in the app-db. Subsequently, a User may log in again with SSO but have fisrt/last name
      attributes, which should update the Metabase user data in the app-db.
      
      These unit tests set up such a scenario to check that the :first_name and :last_name keys are indeed updated.
      
      * Adjust Enterprise LDAP to also use SSO-UTILS
      
      Trying to unify the LDAP implementation with JWT/SAML a bit here.
      
      * Lint error
      
      * Reverting LDAP ns changes to get the PR unstuck
      
      This is to keep the ball rolling on SSO fixes. I'll add LDAP as an item in the Epic to address this separately.
      174afe58
  9. May 09, 2022
  10. Apr 07, 2022
    • Ngoc Khuat's avatar
      Fix SSO failed to sync admin group (#20991) · 0708ce0a
      Ngoc Khuat authored
      * fix failed to sync admin group
      
      * address noah's comments and add migration script
      
      * document for run-with-data-migration-index
      
      * update comments
      
      * fix name space
      
      * adding data_migrations tests
      
      * add docg
      
      * make sure we don't remove admin group if sso and ldap are not configured
      
      * fix tests for be-ee
      
      * fix tests for oss
      
      * misc docs updates
      
      * remove data-migration-index
      
      * return some newlines
      
      * is it failling here?
      
      * update data_migration docs
      
      * update data_migration docs
      
      * fix all styling comments
      
      * make migration to run both in oss and enterprise and make sure the tests are accounted for that
      
      * fix failed namespace checks
      
      * Add a comment to the test
      
      * fix per comments
      
      * Update permissions.clj
      
      * tweaking with the :warning: icon
      
      * refactor with-temporary-raw-setting-values
      
      * update comments
      
      * Add extension for cert file
      
      * address Noah's comments
      0708ce0a
  11. Jan 06, 2022
  12. Dec 03, 2021
    • Jeff Evans's avatar
      Secrets :closed_lock_with_key: PR 7 - Enable Postgres driver to use secrets for configuring SSL parameters (#18968) · f8d712d6
      Jeff Evans authored
      * Enable Postgres driver to use secrets for configuring SSL parameters
      
      Adding secret related properties for SSL options to Postgres driver
      
      Move `conn-props->secret-props-by-name` to secret.clj since it's needed directly there, too
      
      Add `us-east-2-bundle.pem` to `test-resources/certificates` for testing Postgres with SSL connectivity to our RDS instance (and a README.md explaining how it differs from the existing `ssl` directory)
      
      Updating `value->file!` to have better logic for building the error message when the existing file is not found (for better UX from the Database admin page)
      
      Updating frontend to support the `visible-if` value being an array, in which case any value may match the current details value, in order for that field to be visible
      
      Adding secret related properties for SSL options to Postgres driver
      
      Updating CircleCI config.yml to refer to the RDS instance when running Postgres SSL test
      
      Implement server side expansion of transitive visible-if dependency chain
      
      Update shouldShowEngineProvidedField on client to consider multiple key/value pairs in the visible-if map, and only show the field if ALL are true
      
      Adding new test to confirm transitive visible-if resolution, and cycle detection
      
      Add Cypress test for SSL field visibility
      f8d712d6
  13. Oct 27, 2021
    • Pawit Pornkitprasan's avatar
      Fix SSH tunnel with ED25519 keys (#18697) · 24975664
      Pawit Pornkitprasan authored
      `org.apache.sshd` requires `net.i2p.crypto/eddsa` dependency
      to work with ED25519 keys.
      
      This worked in 0.40 because `eddsa` was included as a transitive
      dependency of another unrelated dependency (`buddy`) but stopped
      working in 0.41 because the new version of `buddy` no longer depends
      on `eddsa`. Thus, we must explicitly include the dependency.
      
      To prevent this from breaking again, switched one of the test
      keys to an ED25519 key.
      24975664
  14. Jul 30, 2021
  15. Jul 29, 2021
    • Cam Saul's avatar
      Run Eastwood linter against test namespaces. Remove reflection-warning script (#17193) · 89382bae
      Cam Saul authored
      * Fix some Eastwood failures
      
      * Fix a lot of Eastwood errors now that it runs against test namespaces [ci skip]
      
      * Run Eastwood against test namespaces [WIP]
      
      * Bump Eastwood version to fix some errors in Eastwood itself
      
      * Fix another lint warning
      
      * Fix test failure
      
      * More test fixes :wrench:
      
      * Fix all the warnings!
      
      * Test fix :wrench:
      
      * Bump Eastwood GH action timeout to 20 minutes (!)
      89382bae
  16. Jun 10, 2021
  17. Jun 09, 2021
  18. Jun 08, 2021
  19. May 17, 2021
  20. Feb 25, 2021
    • Jeff Evans's avatar
      Implement ssh tunnel reconnection (#14563) · b4d8e35a
      Jeff Evans authored
      * Implement ssh tunnel reconnection
      
      From the connection-with-timezone method of execute, check whether an ssh tunnel that should be open actually is not, and if so, mark the entire pool as invalid (thereby forcing the connection code to rebuild the source and open a new tunnel)
      
      Fixing the create-pool! function so that the relevant ssh tunnel entries are kept (in addition to the :datasource)
      
      Adding test in ssh-test namespace, which will test that the tunnel is reestablished (for now, running with Postgres driver)
      
      * Responding to PR feedback from Dan
      
      * Fixing test by adding AcceptAllForwardingFilter forwardingFilter to the mock password server instance
      
      * Change with-driver to test-driver
      
      * Add ssh tunnel reconnect test that can run against H2
      
      * Implement ssh tunnel reconnection
      
      From the connection-with-timezone method of execute, check whether an ssh tunnel that should be open actually is not, and if so, mark the entire pool as invalid (thereby forcing the connection code to rebuild the source and open a new tunnel)
      
      Fixing the create-pool! function so that the relevant ssh tunnel entries are kept (in addition to the :datasource)
      
      Adding test in ssh-test namespace, which will test that the tunnel is reestablished (for now, running with Postgres driver)
      
      * Responding to PR feedback from Dan
      
      * Fixing test by adding AcceptAllForwardingFilter forwardingFilter to the mock password server instance
      
      * Rebase again to fix merge conflict
      
      * Change test-driver to with-driver in hopes of making CodeCov finally happy
      
      * Adding new multimethod to ssh namespace, called incorporate-ssh-tunnel-details, for accounting for the
      
      Implementing incorporate-ssh-tunnel-details for h2 so update the URI string (:db key) to point to the tunnel entry point
      
      Pulled logic for :sql-jdbc implementation of connection-with-timezone out to a new fn, so it can be called elsewhere
      
      Updating H2 reconnection test imn light of the changes above
      
      Added "!" suffix to name of include-ssh-tunnel to reflect the fact that it does modify global state
      
      * Fixing NPE in incorporate-ssh-tunnel-details implementation for :h2
      
      Moving multimethod declaration for incorporate-ssh-tunnel-details to driver namespace
      
      * Fix :h2 implementation again
      
      * Remove another errant extra line :(
      
      * Rebase onto master
      
      * Inline the private helper fn back into connection-with-timezone
      
      * Remove dead code
      b4d8e35a
  21. Feb 08, 2021
  22. Oct 23, 2020
  23. Oct 07, 2020
  24. Oct 06, 2020
    • Cam Saul's avatar
      Fix Google driver build [ci bigquery] (#13386) · 22a09e37
      Cam Saul authored
      * Fix Google driver build [ci bigquery]
      
      * Tweak chain filter tests
      
      * Fix i18n tag
      
      * Fix database sync test (maybe)
      
      * Add u/decolorize for latest JUnit output tweak
      
      * Fix :wrench:
      
      * Test fix :wrench:
      22a09e37
  25. Oct 02, 2020
    • Robert Roland's avatar
      Upgrade to log4j 2.13.3 (#13310) · 1b75a42b
      Robert Roland authored
      * Upgrade to log4j 2.13.3
      
      Upgrades us to newer Log4j
      
      Resolves #12719
      
      * fixing reflection warnings
      
      * reflection warning on test
      
      * make tests work
      
      took a while to figure out how to configure log4j properly
      programatically - it's not as easy as log4j 1
      
      add logging adapters for commons-logging, slf4j, liquibase, etc so that
      all logging routes through log4j2 now
      
      * appease the linters
      
      * okay cljr-clean-ns makes this line too long, I get it
      
      * add log4j2.xml config for Cypress tests
      
      * update log4j configuration file documentation
      
      update which flag is used by the backend tests
      
      [ci all]
      
      * update cheshire because clj-http updated
      
      * Wire up the metabase-appender to Log4j2
      
      This was brutal to figure out - log4j usually silently fails, so it took
      finding the right combination of configuration settings and system
      properties to get it to log enough to find out why the appender was
      never invoked.
      1b75a42b
  26. Jul 16, 2020
  27. May 26, 2020
  28. May 21, 2020
  29. Dec 03, 2019
  30. Jun 05, 2019
  31. May 13, 2019
  32. Dec 12, 2018
  33. Nov 17, 2018
  34. Oct 29, 2018
  35. Oct 10, 2018
  36. Sep 10, 2018
    • Ryan Senior's avatar
      Add UserLocalizedString and SystemLocalizedString for i18n · 96b77169
      Ryan Senior authored
      Currently i18n'd strings that are defined at compile time only return
      english text. This occurs with both system and user locale
      strings. For system locale, the locale can be changed via setting, so
      we can't rely on the JVM locale on startup to be correct as it may
      have changed. For the user locale, it could be different for every
      request.
      
      This commit adds two new `tru` and `trs` macros that have the same
      name as the `puppetlabs.i18n.core` macros (and thus will be extracted
      similarly) but will return a defrecord with a `toString` method. This
      delays the conversion of the english text to the translated text until
      `str` is invoked. All of the code hasn't been flipped to use the new
      i18n macros yet, but this gets it in place and tested for the rest of
      the application to be migrated to.
      
      Fixes #8245
      96b77169
  37. Nov 14, 2017
  38. Aug 07, 2017
Loading