This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 08, 2022
-
-
Dalton authored
-
Dalton authored
-
Anton Kulyk authored
-
Anton Kulyk authored
-
Anton Kulyk authored
-
Anton Kulyk authored
-
Anton Kulyk authored
-
Anton Kulyk authored
-
Anton Kulyk authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Aug 07, 2022
-
-
Gustavo Saiani authored
-
Gustavo Saiani authored
-
- Aug 05, 2022
-
-
Nick Fitzpatrick authored
-
Aleksandr Lesnenko authored
-
Jeff Bruemmer authored
-
Gustavo Saiani authored
-
- Aug 04, 2022
-
-
Nick Fitzpatrick authored
-
Ryan Laurie authored
* Dashboard Card String Filters are now case-insensitive This PR is a draft because while it solves the problem of string filters being case sensitive, it doesn't necessarily do it in the best way. This isn't necessarily a bug, but it seems that there is no way for the frontend to set the :case-sensitive true/false option anyway. For the purposes of this initial attempt at a solution, I have modified the endpoint ` POST "/:dashboard-id/dashcard/:dashcard-id/card/:card-id/query"` to automatically include an option map containing :case-sensitive false. The machinery to take this option into consideration already exists with the default :sql ->honeysql function in the ` metabase.driver.sql.query-processor` namespace. See the `like-clause` private function in particular. Since the query processor is a bit opaque to me at present, I was unable to figure out if there is a proper way that the frontend could send an options map (or key-value pair) all the way through the qp middleware to the query building stage. I discovered that if you conj a map `{:case-sensitive false}` to the output of the `to-clause` function in `metabase.driver.common.parameters.operators`, you will get the desired case-insensitive behavior. So, I modified the to-clause function in this PR to appropriately conj an options map if one exists. What I'd like to know: - is there a super-simple way to pass an option in already that I just missed? (eg. I thought perhaps in the `[:field 13 nil]` that 'nil' could be an options map, but I couldn't get that to work for me) - is there a middleware approach that I should consider? - any other options to appropriately hanlde this? * Revert the endpoint. If the frontend sends an options map on an options key inside the parameter, this endpoint will pass that on, so no change is needed. * include parameter options in datasetQuery Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
Alexander Polyankin authored
-
Aleksandr Lesnenko authored
-
Alexander Polyankin authored
-
Dalton authored
-
Dalton authored
-
Dalton authored
* Update hasPermissionsToMap to check for existence of dataset_query * Add check to mapping-options fn, too * Add repro for #24536 * Uncomment and enable the repro Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Alexander Polyankin authored
-
- Aug 03, 2022
-
-
Anton Kulyk authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Aug 02, 2022
-
-
Ryan Laurie authored
-
Gustavo Saiani authored
-
Ryan Laurie authored
* make search visible * update Modal title
-
Nick Fitzpatrick authored
* Fixing null error when value is null and isCustom is true * PR Feedback
-
Ryan Laurie authored
-
Jeff Bruemmer authored
* exception for none and block * add howon's test
-
Aleksandr Lesnenko authored
* open urls with the site-url origin in the same tab * revoew
-
Nick Fitzpatrick authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
Alexander Polyankin authored
-
Aleksandr Lesnenko authored
-