Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 01, 2023
  2. Nov 29, 2022
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Match static combo chart colors and legends with app viz colors (#26211) · c6e41b75
      Mahatthana (Kelvin) Nomsawadi authored
      * Match static combo chart colors with app viz colors
      
      * Match colors when individual series color is set
      
      * Remove tests that test colors
      
      Since colors is now determined in FE
      
      * Fix static viz Series type
      
      * Match static progress bar colors with app viz colors
      
      * Simplify Clojure code, makes it more idiomatic
      
      * Fix certain combo charts don't respect whitelabel colors
      
      * Make Clojure code more idiomatic
      
      * Fix Series type
      
      * Add colors back to static internal page
      
      * Simplify type predicate
      
      * fix colors matching for multiple series with mulitple metrics or dimensions
      
      * Handle legends not formatted in static viz in some cases
      
      * Fix failed BE tests after BE API changed
      
      * Fix failed BE tests after BE API changed
      
      * Add multiple series dashcard test to `getSeriesWithColors` test
      
      * Add `getSeriesWithLegends` tests
      
      * Fix URL `/_internal/static-viz` not loading due to API change
      
      * Correctly render legend when having dashcard title set
      
      * Simplify combo-chart API
      
      don't really need `settings-seqs` yet
      
      * Make static combo chart component type easier to understand
      
      * Address review: refactor `render-multiple-lab-chart`
      
      * Make variable names easier to understand
      
      * Simplify color API
      
      * Address review on `body.clj`
      
      * Address review, make parameter name more consistent
      
      * Fix multiple scalars not rendering
      
      * Remove unused imports
      Unverified
      c6e41b75
  3. Nov 15, 2022
    • Aleksandr Lesnenko's avatar
      Row chart polish (#26183) · 750ed365
      Aleksandr Lesnenko authored
      * fix showing placeholder series
      
      * row chart polish
      
      * wip
      
      * don't use nice x ticks for stacked expand chart
      
      * make grouped row not clickable
      
      * update specs
      
      * update specs
      Unverified
      750ed365
  4. Oct 24, 2022
  5. Oct 11, 2022
    • Aleksandr Lesnenko's avatar
      Static row chart (#25829) · 23837a6f
      Aleksandr Lesnenko authored
      * support static row chart on the backend
      
      * update and add types
      
      * update types
      
      * add chart columns helper, dataset grouping
      
      * add viz settings helpers
      
      * fix text measuring
      
      * add generic row chart component for static and dynamic rendering
      
      * update deps
      
      * fix jest config for d3
      
      * allow importing cljs in static viz
      
      * add a hook for getting chart columns and series
      
      * add a static row chart
      
      * build cljs before static viz
      
      * specs
      
      * add stories, moved isomorphic row chart component to the shared folder
      
      * update import
      
      * fix backend merge
      
      * remove an extra line
      
      * one more extra line
      
      * exclude unused props from the row chart
      
      * cleanup
      
      * review
      
      * fix types
      
      * fix log scale
      
      * add visual spec, fix goal label truncate
      
      * review
      
      * fix mock path
      
      * fix specs
      Unverified
      23837a6f
  6. Oct 07, 2022
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Static gauge chart (#25651) · d4cb1e5a
      Mahatthana (Kelvin) Nomsawadi authored
      * Basic static gauge chart
      
      * Add gauge segment min max labels
      
      * Add gauge segment label
      
      * Cleanup code
      
      * Fix React list key error
      
      * Remove hard-coded colors
      
      * Make the everything calculates at the gauge center
      
      * Make gauge segment data easier to understand
      
      * Example scaling chart to avoid label overflow
      
      * Avoid long labels overflow by scaling the gauge chart down
      
      * Match gauge needle color with the design
      
      * Fix hard coded gauge segment label anchor calculation
      
      * Fix static gauge chart not rotate gauge needle correctly
      
      * Add E2E for static gauge chart
      
      * Fix `transform-origin: center` not working with BE static chart
      
      * Truncate long segment label so charts can never be too small
      
      * Fix gauge segment not connected to each other
      
      * Static chart refactor part 1
      
      * Final static gauge chart refactoring
      
      * Simplify clojure chart render function
      
      * Fix relative imports
      
      * Make overlapping gauge labels more legible
      
      * Make GaugeLabelData property orders consistent
      
      * Make a function easier to read
      
      * Make the calculation more correct
      
      though the behavior would still be the same
      
      * Separate presentational component out of the Gauge component
      
      * Remove unused tap>
      
      * Fix gauge chart not working on chart tester in internal static viz page
      
      * Fix gauge chart not rendered with Lato font
      
      * Improve internal page static chart tester option clarity
      
      * Support column settings in gauge charts
      
      * Add unit tests for static gauge chart utils
      
      * Address review
      
      * Fix unittest failure
      Unverified
      d4cb1e5a
  7. Sep 27, 2022
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Waterfall data point values (#25560) · fa7338e6
      Mahatthana (Kelvin) Nomsawadi authored
      
      * Refactor static waterfall chart to use a single entrypoint
      
      * Consolidate static watetrfall chart
      
      * Update waterfall chart text size to match combo-chart
      
      * Move `<Values />` from XYChart/ to be under components/
      
      Since it'll be used by waterfall chart
      
      * Fix `<Values />` key error (forgot to add key attribute)
      
      * Show data point values on waterfall chart
      
      * Fix failed BE tests
      
      * Fix test -> wrong `waterfall-type` used. And test both types
      
      The waterfall component was changed to take a type argument, instead of having 2 functions for nearly identical
      output. The failing test just passed the wrong string to the key argument.
      
      * Change waterfall keys from strings to Clojure keys
      
      * Remove redundant test. Categorical also handled in `waterfall-test`
      
      * Fix clj-kondo lint error
      
      * Cleanup conditional statements
      
      * Miscellaneous code cleanup
      
      * Update waterfall test to render data point values
      
      * Fix waterfall chart data point values not center in the bar
      
      * Make some API for static waterfall chart with total saner
      
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Unverified
      fa7338e6
  8. Sep 16, 2022
  9. Aug 18, 2022
    • Aleksandr Lesnenko's avatar
      fix static viz waterfall colors (#24852) · 8c225418
      Aleksandr Lesnenko authored
      
      * fix static viz waterfall colors
      
      * tests
      
      * Pass colors into StaticChart as third argument
      
      This might not be the best design, so changes are welcome, but I added this to properly consider the case where the
      application-colors are different, but the chart has no viz-settings: application-colors were being ignored (as they
      were passed into options, but not pulled out of options into the colors arg).
      
      * review
      
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Unverified
      8c225418
  10. Mar 14, 2022
    • Benoit Vinay's avatar
      Clean up static chart components accessors (#20968) · f6085da3
      Benoit Vinay authored
      * accessors constants created
      
      * accessors dependencies removed from all charts
      
      * Removed accessors dependencies from BE JS for static viz
      
      * Removed accessors references in chart editor
      
      * accessors added to defaultProps
      
      * Remove accessors in tests
      
      * defaultProps removed form static viz components
      Unverified
      f6085da3
  11. Dec 13, 2021
  12. Dec 08, 2021
    • Howon Lee's avatar
      Combo / Multi chart static viz BE (#19151) · e3388f14
      Howon Lee authored
      Combo type and multiple cards for static viz BE. These go into one FE endpoint but are two really separate things in BE. This one conforms to the FE type but the price is that the previous more-dynamic BE types needed to be changed to conform: this will require a refactoring to whack the js-viz types that already exist, when the FE is refactored also.
      Unverified
      e3388f14
  13. Dec 02, 2021
  14. Nov 28, 2021
  15. Nov 15, 2021
  16. Oct 06, 2021
  17. Sep 08, 2021
    • dpsutton's avatar
      Static viz send viz settings (#17736) · 6aba6f1e
      dpsutton authored
      * Pass along date formatting
      
      * extract and rename some things
      
      * Number formatting
      
      * Update tests
      
      * Improve test validation of svg labels
      
      * Clean up tests
      
      * Move static-viz interface file to custom file
      Unverified
      6aba6f1e
  18. Apr 26, 2021
  19. Aug 29, 2019
    • Walter Leibbrandt's avatar
      Handle unsupported formatting operators gracefully [WIP] (#10737) · 0a7f36be
      Walter Leibbrandt authored
      * Avoid using `undefined` array when column formatters not specified
      
      This led to `TypeError: Cannot read property "forEach" from undefined`
      errors when no formatters were specified.
      
      * Improve logging of unexpected errors during format compilation
      
      * Log unsupported formatting operators and return a dummy operator fn
      
      * Linting fixes
      
      * Manually ES5-ify code that is to be executed by the Nashorn engine
      
      Nashorn in JDK 8 only supports ES5.1.
      
      * Update Rebuilt shared JS from `yarn build-shared`
      
      * Move formatting foctory fns into an operator-indexed object
      
      * Linter appeasement
      
      * Test that all defined operators are supported in table formatting
      
      * Flow annotations
      
      * Return `null` in stead of `undefined`
      
      Formatting/style changes snuck in.
      
      * `yarn build-shared`
      
      * Use operators from table formatting and not column filters
      Unverified
      0a7f36be
  20. Jul 23, 2018
  21. Jul 17, 2018
  22. Jul 12, 2018
  23. Jul 11, 2018
    • Ryan Senior's avatar
      Driver pulse table cell color from visualiation settings · e1f9f9ca
      Ryan Senior authored
      This creates a new shared javascript file in
      `resources/frontend_shared` that will be used by the frontend and the
      backend to drive the background color of cells using conditional
      formatting features the frontend has.
      
      This uses the JDK 8 included Nashorn javascript engine to eval and
      invoke the functions in that shared file.
      e1f9f9ca
Loading