Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 16, 2022
    • Cal Herries's avatar
      Use slugs for card template tags in the native query editor + autocomplete (#25319) · 2c7178ea
      Cal Herries authored
      * Allow slugs in question template tags, like `{{#123-a-question}}`
      
      * Update CardTagEditor to add slug names to the query text, instead of IDs
      
      * Fix dispatchApiErrorEvent prop for entity object loader
      
      * Ignore errors loading names of referenced questions
      
      * Fix e2e tests
      
      * Implement autocomplete for model slugs
      
      * Prioritize models above questions
      
      * Make the ace_autocomplete popup slightly wider to account for longer question names
      
      * Reorder requires
      
      * Remove unnecessary ? from endpoint string
      
      * Add e2e test for card tag autocomplete
      
      * Fix NativeQueryEditor not swapping back to standard completers
      
      * Refactor replaceCardSlug
      
      * Add e2e test for updating tags when card name is changed
      
      * Refactor updateReferencedQuestionNames
      
      * Add slug method to Question class
      
      * Use map for autocomplete API results
      
      * Rename endpoint path
      
      * Rename for consistency
      
      * Add docstrings
      
      * Update slug() to guard against undefined names
      
      * Fix read permissions for the endpoint
      
      * Add backend test
      
      * Fix unit tests
      
      * Fix permissions error
      
      * Make regex simpler
      
      * Undo change of value on QuestionPicker
      
      * Fix tests
      
      * Fix models e2e test
      
      * Simplify updateReferencedQuestionNames
      
      * Fix bugs in updateReferencedQuestionNames
      
      * Rename variable
      
      * Move NativeQuery methods to new native-query utils module
      
      * Fix typescript errors
      
      * Fix e2e tests
      
      * Fix e2e test
      
      * Fix BE tests
      
      * Actually fix BE test
      
      * Refactor updateQuestionTagNames
      
      * Align comments
      
      * Reorder autocomplete results
      
      * Refactor: move all query text tag utils in one place
      
      * Add tests for regex
      
      * Add unit tests for cardIdFromTagName
      
      * Add schema to autocomplete_suggestions endpoints
      
      * Add perms checks to autocomplete tests
      
      * Add unit test for updateCardTagNames
      
      * Rename updateQuestionTagNames -> updateCardTagNames
      
      * Tidy card-autocomplete-suggestions-test
      
      * Rename questionReference-> cardTag for consistency
      
      * Rename card-reference -> card-tag for consistency
      
      * Use ternary operator for comprehension
      
      * Fix broken swapCompleters
      
      * Use prefix match on name for 123-foo case
      2c7178ea
    • Ryan Laurie's avatar
      Action Creator 8: Required Fields and Default Values (#25445) · 56791a6c
      Ryan Laurie authored
      * add support for required fields and default values in action forms
      
      * handle missing settings better
      
      * save default numbers as numbers
      56791a6c
    • Natalie's avatar
      docs - update full-app embedding (#25426) · 822ae735
      Natalie authored
      822ae735
    • Jeff Bruemmer's avatar
      remove tables of contents (#25466) · 63d72010
      Jeff Bruemmer authored
      63d72010
    • Natalie's avatar
      docs - update "manage database" permission · 450c308a
      Natalie authored
      450c308a
    • Maz Ameli's avatar
      change dataset to model (#25448) · 0ae41438
      Maz Ameli authored
      0ae41438
    • Dalton's avatar
      Preserve Model metadata when changing the Model's query (#25442) · a11e9d77
      Dalton authored
      * Preserve model column metadata in the QUERY_COMPLETED action
      
      * Update metadata everywhere in redux
      
      * Unskip repro
      
      * Tweak isSameField default to get rid of some dup code
      a11e9d77
    • Dalton's avatar
      Fix Visualization component handling of mode prop (#25438) · 500d407c
      Dalton authored
      * Fix Visualization component handling of mode prop
      
      * Pass mode prop in and give it a gross name
      500d407c
    • Alexander Polyankin's avatar
    • Alexander Polyankin's avatar
    • Aleksandr Lesnenko's avatar
      remove unused static chart types (#25440) · bac8ab35
      Aleksandr Lesnenko authored
      * remove unused static chart types
      
      * add visual tests for single series charts
      bac8ab35
  2. Sep 15, 2022
    • Gustavo Saiani's avatar
    • Nick Fitzpatrick's avatar
      52735311
    • Ryan Laurie's avatar
      Action Creator 7: Customize Placeholder text (#25407) · c1cb7f38
      Ryan Laurie authored
      * support field placeholder customization
      
      * update tests
      c1cb7f38
    • metamben's avatar
      Add helper function sending debug-qp events to portal (#25423) · 5fc9133f
      metamben authored
      * Add helper function sending debug-qp events to portal
      * Include the intended value in the transformed-result event
      5fc9133f
    • Jeff Bruemmer's avatar
      docs - community drivers (#25435) · 6c87a82f
      Jeff Bruemmer authored
      6c87a82f
    • Howon Lee's avatar
      Coerce all the static viz charts that could be a combo to be a combo (#24696) · abca737f
      Howon Lee authored
      
      * thinking
      
      * killing it
      
      * lab image bundle for lines proper
      
      * linter shutting up
      
      * get rid of viz-settings binding at all
      
      * Remove accidentally re-added categorical-area
      
      * Merged master, and temporarily comment out some tests
      
      * Simplify conditional for detecting chart type
      
      * Remove a few old fns/symbols
      
      * Clean up the detect-chart a bit
      
      * Remove sparkline. It's an old concept that's not used
      
      We can acheive similar results with :line directly. If we care about a trend, we can use a :smartscalar.
      
      * Fix up tests that now also use combo charts
      
      * Missed a key change for area test
      
      * Get rid of deprecated sparkline stuff
      
      * Remove commented out sparkline tests
      
      * Delete this function. I was using it in the REPL, it's not needed
      
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      abca737f
    • Benoit Vinay's avatar
      Convert Variable to TypeScript (#23560) · 3925f1b4
      Benoit Vinay authored
      * Move Variable in its own package
      
      * TemplateTagVariable package created
      
      * memoizeClass return type
      
      * Renaming Query to QueryInner to follow standards
      
      * Constants added to TemplateTagVariable
      
      * Fixed Query typing
      
      * Misc
      3925f1b4
    • Ryan Laurie's avatar
      add simple dev actions page (#25434) · 26d869d1
      Ryan Laurie authored
      26d869d1
    • Braden Shepherdson's avatar
      Serdes v2: Fix a missing case in the deps for a Card (#25392) · 077d8e36
      Braden Shepherdson authored
      Cards can depend on other Cards as their `:source-table`, but the code
      to extract `serdes-dependencies` from the MBQL query did not
      capture that case.
      077d8e36
    • Braden Shepherdson's avatar
      Serdes v2: Handle missing User refs by synthesizing dummy users (#25391) · f2981efc
      Braden Shepherdson authored
      Many entities have `creator_id` and similar fields. `User`s are not
      serialized. Foreign keys to users are serialized as email addresses.
      
      During deserialization in a different instance (eg. a local dev instance
      importing a dump from a prod instance) many such users may not exist.
      This change creates new `User` entities on the fly with empty names,
      generated passwords, and the email set.
      f2981efc
    • Anton Kulyk's avatar
      Respect data app nav items (#25416) · 7667c334
      Anton Kulyk authored
      * Allow overwriting `SidebarLink` name styles
      
      * Add `DataAppPageSidebarLink` component
      
      * Render data app sidebar page tree
      
      * Hide pages marked as hidden
      
      * Add `getParentDataAppPageId` helper
      
      * Highlight parent page when hidden page is selected
      
      * Extract `getSelectedItems` and add tests
      
      * Fix messed up ordering bug
      7667c334
    • Anton Kulyk's avatar
      Implement scaffolding new pages for existing apps (#25402) · 54afeea9
      Anton Kulyk authored
      * Remove `DataAppNewButton`
      
      * Add new item menu
      
      * Fix missing click handler
      
      * Use "pencil" icon for new page
      
      * Fix action buttons look
      
      * Extract `DataAppDataPicker` component
      
      * Rename `scaffold` action
      
      * Add `scaffoldNewPages` action
      
      * Add `ScaffoldDataAppPagesModal` component
      
      * Add `DataAppNavItem` type
      
      * Allow building page URLs out of nav items
      
      * Implement "Add data" flow
      54afeea9
    • Anton Kulyk's avatar
      Implement implicit actions for data apps (#25393) · f4d2f588
      Anton Kulyk authored
      * Add implicit action click behavior types
      
      * Add `isImplicitActionButton` helper
      
      * Extract `ActionButtonView` component
      
      * Separate implicit and default action buttons
      
      * Use `DashboardOrderedCard` instead of `DashCard`
      
      * Use `Value` type for PK argument
      
      * Fix type error
      
      * Extract `ImplicitActionClickBehavior` type
      
      * Add `ImplicitInsertModal`
      
      * Add `DashCardDataMap` type
      
      * Add dashboard selectors for implicit update/delete
      
      * Add `ImplicitUpdateModal`
      
      * Add `ImplicitDeleteModal`
      
      * Validate implicit actions in `clickBehaviorIsValid`
      
      * Reload page on action instead of a single dash card
      
      * Tweak successful insert toast message
      
      * Fix eslint error
      f4d2f588
  3. Sep 14, 2022
  4. Sep 13, 2022
    • Case Nelson's avatar
      [Apps] Add scaffolded pages to existing apps (#25343) · ebe5960b
      Case Nelson authored
      
      * [Apps] Add scaffolded pages to existing apps
      
      Reuse app scaffolding in order to add to existing apps. This will not
      check that the tables you choose have not been previously added to the app.
      
      Also update scaffolding:
      - Add back to list button
      - Update list question to order by newest row on top.
      - Use linkType: "page" instead of linkType: "dashboard"
      
      * Fix H2 test, no need to add app-id to name
      
      * Remove unused require
      
      * Addressing review comments - suggested test uncovered an ordering bug
      
      * Put priority back to ascending
      
      * Implement navigation between data app pages (#25366)
      
      * Add `DataAppPagePicker`
      
      * Rename `QuestionDashboardPicker`
      
      * Add page to `EntityCustomDestinationClickBehavior`
      
      * Fix comment
      
      * Use ellipsis character
      
      * Fix custom destination type
      
      * Add "page" custom destination to pickers
      
      * Pass router props to dashboard click actions
      
      * Remove not used function arguments
      
      * Implement "page" custom destination click behavior
      
      * Fix "page" click behavior isn't treated as valid
      
      * Reorganize `LinkedEntityPicker`
      
      * Fix drills from the homepage
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      ebe5960b
    • Maz Ameli's avatar
      d7126d79
    • Jeff Bruemmer's avatar
      Update README.md (#25396) · d94bb5fc
      Jeff Bruemmer authored
      d94bb5fc
    • Natalie's avatar
      docs - update api/dataset comment (#25342) · f1414a9b
      Natalie authored
      f1414a9b
    • Alexander Polyankin's avatar
      129518fc
    • Bryan Maass's avatar
      H2 disallow `INIT=...` option using connection string (#25369) · 25202443
      Bryan Maass authored
      * trim the init option in h2 connection string
      
      - it can be lower or mixed-case, so `(dissoc-by str/lower-case ...)`
        will lowercase the map's keys and the dissoc-keys, and dissoc them when
        they are equal.
      
      * refactor
      25202443
Loading