This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 17, 2024
-
-
Alexander Polyankin authored
-
Nick Fitzpatrick authored
* search events 1-1-0 * backwards compatible adjustment * making context optional
-
Jesse Devaney authored
* refactor: de-duplicate variable usage * fix incorrect goal-line plotting in pow and log y-axis scales * add Loki variants to validate and enforce desired behavior * update loki snapshots
-
Case Nelson authored
* Change run to make-run in process-query-for-card Fixes #44160 There were two levers where a card could change how it was run. `qp` this is basically `qp/process-query` with some optional userland flags and constraints marked on the passed in query. In the case of pivot tables in the `/pivot/:card-id/query` endpoints it was `qp.pivot/process-query` 'run' this defaults to a streaming response that takes the `qp` param and `export-format` and passes a query to qp. Most often this is overriden to not stream the response. Unfortunately, if `run` is overwritten, then `qp` is thrown away, and the caller who overrides `run` must determine the correct `qp` to use. However, when running `process-query-for-dashcard` it is difficult to properly set `qp` for all of the dashcards without doing card lookups. So [this commit](https://github.com/metabase/metabase/blob/release-x.50.x/src/metabase/query_processor/card.clj#L230-L232) did a check to swap the runner in the presence of a pivot query that calls the **default** runner with a `qp.pivot/run-pivot-query`. The problem is that pulse needs to use a non-default runner, but there's no way for `process-query-for-card` to do both. This commit changes `run` to `make-run` which raises the abstraction to a function that produces a runer given a `qp`. This allows `process-query-for-card` to change the `qp` as needed while keeping the passed in runner. There's really three things going on that could be teased apart further/better. 1. `qp` - this conflates the processor (`qp/process-query` `qp.pivot/run-pivot-query`) and modifying query (`qp/userland-query`, `qp/userland-query-with-default-constraints` `(update query :info merge info)`) 2. `make-run` - How the above are processed: (streaming/realized) * Fix tests
-
Alberto Perdomo authored
Tweak the callout about the SDK still being in development
-
Alex Yarosh authored
-
Raphael Krut-Landau authored
* wip * Remove references to the old enable-query-caching setting * remove fixme * linter * remove some more instances * fix imports
-
Alexander Polyankin authored
-
Ryan Laurie authored
* skip super slow xray test * unmark not very slow tests
-
Nemanja Glumac authored
* Elevate include this period in the relative date picker (#44179) * Mock new row with "include {period}" string * Implement "include this" using a toggle * Elevate "starting from" option in the relative date picker (#44242) * Elevate "Starting from" option in the filter picker * Tweak the date offset close icon * Fix tests
-
Jeff Bruemmer authored
-
Ryan Laurie authored
-
- Jun 14, 2024
-
-
Raphael Krut-Landau authored
-
Jesse Devaney authored
* fix column scaling issues in waterfall chart - refactor dataset scaling to behave like scatter and cartesian chart models * add E2E test
-
Raphael Krut-Landau authored
-
Jeff Bruemmer authored
-
Aleksandr Lesnenko authored
* fix charts crash in safari when dataset timezone is not in iana format * Update Loki Snapshots * better fix: apply offset instead of finding a timezone with such offset * remove unused specs * Update Loki Snapshots * review --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Cal Herries authored
Fix fields from Amazon Athena Tables failing to sync if there is not an underscore in the Table Name (#44032)
-
John Swanson authored
* Fix a potential bug in `hydrate-can-restore` I had a bug here. I wanted to hydrate `:collection` on the items and then return the original items, but instead I was `dissoc`ing `:collection` from the items. If the original items passed in already had `:collection` keys this would break them. AFAIK this didn't cause any issues, but it could have - so fixing it here. * Add a test * Present collection items in the collection When fetching collection items, we need to fetch the true `collection_id` in order to figure out things like `can_restore` and `can_delete`, but set it to the displayed/effective `collection_id` when we actually send it out. This fixes a bug where collections had their `collection_id` match their `id` when returned by this endpoint.
-
Ryan Laurie authored
-
Jeff Bruemmer authored
-
Sloan Sparger authored
-
Alex Yarosh authored
-
Phoomparin Mano authored
* replace color-mod with color-mix * update alpha values to round to 5% * add deprecation notice to lighten, darken and alpha * update loki reference image * add alpha value css variables to storybook preview * update loki reference image
-
Abed Habli authored
-
Ryan Laurie authored
-
John Swanson authored
Previously we were just adding this when the item was archived. Instead, always send a value - if the item is not archived, it can't be restored, so it will be `false` in this case. Making this change will make fixing a frontend bug easier, because the frontend will be able to just trust the `can_restore` value coming in from the backend.
-
github-automation-metabase authored
-
Oisin Coveney authored
fix(sdk): Update README to move `Embedding the collection browser` to `Features currently supposed` (#44208)
-
Ryan Laurie authored
* add additional release slack message * trigger slack messages from build * fixes * remove silly var name
-
Ryan Laurie authored
* update release script to trigger ops issue creation * update secret vars
-
Kamil Mielnik authored
-
Ryan Laurie authored
* combine collections e2e specs * obey the linter
-
Raphael Krut-Landau authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
Nemanja Glumac authored
* Remove "is empty" and "not empty" from time-series chrome * Fix unit test
-
Phoomparin Mano authored
* docs update * add dashboard.backgroundColor
-
Romeo Van Snick authored
* Use MultiAutocomplete in dashboard filters * Handle prefix on MultiAutocomplete * Remove unnecessary tests for empty values * Remove input className * Handle numbers in MultiAutocomplete * Accept number values in MultiAutocomplete * Use MultiAutocomplete in NumberInputWidget * Filter out empty items * Do not expect formatted number in values * Do not allow adding multiple values when multi is false * Handle undefined values * Make value optional * Fix MultiAutocomplete types * Make MultiAutoComplete generic in its value type * Refine MultiAutocomplete type in NumberInputWidget * Refine MultiAutocomplete type in FieldValuesWidget * Fix typo * Fix MultiAutocomplete tests * Add helpers to work with MultiSelect and MultiAutocomplete inputs * Handle MultiAutocomplete input in tests * Fix filter helper * Use multiAutocompleteInput helper * Find the value remove button in test * Fix tests for NumberInputWidget * Fix tests for DefaultPicker * Fix type in NumberInput * Fix dasboard test * Fix embedding test * Add helpers to remove values * Fix chained filter test * Fix nested test * Fix embedding tests * Fix filter tests * Use removeMultiAutocompleteValue * Use removeMultiAutocompleteValue * Remove unused variable * Use multiAutocompleteInput helper * Handle comma's in values * Handle multiselect * Fix filter test * Add filter * Format field value * Fix embedding tests * Allow rendering custom label for item * Use renderValue in FieldValuesWidget * Fix data prop type * Be more explicit about broken types in FieldValuesWidget * Fix default behaviour for label * Fix embedding tests * Force click * Fix sharing test * Use removeMultiAutocompleteValue * Handle multiautocomplete inputs * Force click filter * Close the suggestions menu * Fix email test * Fix sharing filter * Set viewport in test * Fix sharing test * Remove debugging logs * Use removeMultiAutocompleteValue * Close the suggestions menu using blur * Remove commented out code * Remove the unused color prop * Move shared types to types file * Rename ValueType to TValue * Add missing forwardRef * Add tests for filter and renderValue * Use TokenField for single value parameters * Fix single value test * Be more specific about when to select a single input * Fix single value e2e test * Handle undefined parameter * Accept all RowValue types in MultiSelect * Accept all RowValue types in ListField * Accept all RowValue types in SingleSelectListField * Be more precise about the FieldValuesWidget value types * Be more specific about when to render normal input * Remove duplicate import * Remove maxSelectedValues from MultiAutocomplete * Parse values in FieldValuesWidget * Remove parsing complexity from MultiAutocomplete * Be more strict when parsing numbers * Do not use multiselect when arity is 1 * Remove spurious changes * Pass prefix from FieldValuesWidget * Remove number MultiAutocomplete story * Remove renderValue from MultiAutocomplete * Add custom component to MultiAutocomplete * Add missing data prop * Remove spurious changes in MultiAutocomplete * Remove SelectItem reference * Use renderValue in FieldValuesWidget
-
- Jun 13, 2024
-
-
Nick Fitzpatrick authored
-