Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 12, 2024
  2. Feb 11, 2024
  3. Feb 10, 2024
  4. Feb 09, 2024
    • Jerry Huang's avatar
      Add BE for routing billing status (#38153) · cc28ee60
      Jerry Huang authored
      * add BE for billing status
      
      * add BE for billing status
      
      * fix whitespace
      
      * fix english
      
      * address comments
      
      * fix whitespace
      
      * fix comments
      
      * update design
      
      * update design
      
      * add test
      
      * consume json error
      
      * address comments
      
      * update url
      Unverified
      cc28ee60
    • Jeff Bruemmer's avatar
      docs - json unfolding (#37827) · eeda0a87
      Jeff Bruemmer authored
      Unverified
      eeda0a87
    • John Swanson's avatar
      Force reload in `ensure-audit-db-installed!` (#38626) · 25d2e619
      John Swanson authored
      Sometimes analytics bits get removed by other tests (e.g. deleting all
      cards, dashboards, users, etc.). When we run
      `ensure-audit-db-installed!`, though, the checksum hasn't changed (since
      the underlying analytics files didn't change), so we skip reloading the
      data.
      
      This sets `last-analytics-checksum` to `-1` (meaning: skip the checksum
      and just load the analytics data) when running
      `ensure-audit-db-installed!` in the tests that we've seen flake.
      Unverified
      25d2e619
    • Jeff Bruemmer's avatar
      remove in-line toc (#38630) · b8890a84
      Jeff Bruemmer authored
      Unverified
      b8890a84
    • Braden Shepherdson's avatar
      [MLv2] Add drill-thru test coverage for nil-valued bins (#38472) · 9e54403c
      Braden Shepherdson authored
      Zoom-in drills are not available for such bins, and this is now tested.
      
      Also updates a few comments:
      - Pivot drills work for **one** aggregation and 0 breakouts, not for 0.
      - Legend clicks and pivot cell clicks look the same, so some tests
        cover both cases and this is now noted by comments.
      Unverified
      9e54403c
    • bryan's avatar
      Analytics should load only when changed, via checksum (#38622) · a2e5557a
      bryan authored
      
      * load analytics only when changed using a checksum
      
      - over audit deserialization files
      
      * update docstrings
      
      * fix testing wording
      
      * fix nil analytics-resource-dir
      
      * in tests, when you delete the audit db, set the checksum back to 0
      
      * add a comment
      
      * WIP hashing ia content from inside a jar
      
      * Do the unzip sooner, still hashes the file system
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      
      * cleanup java-time -> java-time.api
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Unverified
      a2e5557a
    • Braden Shepherdson's avatar
      [MLv2] Add tests and fix a special case for fk-filter drills (#38297) · 692bb3e9
      Braden Shepherdson authored
      These were not adding an extra stage in order to filter queryies with
      aggregations.
      
      Progress towards #36253.
      Unverified
      692bb3e9
    • Ryan Laurie's avatar
      Allow appends from collection list (#38490) · bc5c4785
      Ryan Laurie authored
      * allow appends from collection list
      
      * little type fixes
      
      * fix existing unit tests
      
      * possible one-character-catastrophe
      
      * don't allow invalid form submission
      
      * add appends test
      
      * :heart: enums
      
      * design feedback
      
      * update tests to match new design
      Unverified
      bc5c4785
    • Noah Moss's avatar
      Connection Impersonation for Redshift (#38475) · 8cd53512
      Noah Moss authored
      * Connection Impersonation for Redshift
      
      * redshift test based on the existing postgres one
      
      * fix test
      
      * fix test
      Unverified
      8cd53512
    • Oisin Coveney's avatar
      Add snowplow events for embedding setup flow (#37617) · d43863a2
      Oisin Coveney authored
      * Add snowplow events for embedding setup flow
      
      * Fix dashboard model tests
      
      * Fix dashboard tests
      
      * Fix card tests
      
      * Fix dashboard API tests
      
      * Fix type error
      
      * Implement analytics 2/7
      
      1. public_link_copied
      2. public_link_removed
      
      * Fix snowplow schema enum
      
      Removing null as we don't seem to put `null` in `enum`
      
      * Complete the embed_flow snowplow schema
      
      * Modify `initial_published_at` to not be overridden
      
      * Implement analytics 4/7
      
      1. public_link_copied
      2. public_link_removed
      3. public_embed_code_copied
      4. static_embed_published
      5. static_embed_unpublished
      
      * Prevent accidental ESLint log in Cypress
      
      * Differentiate `EmbeddingParametersSettings` from `EmbeddingParametersValues`
      
      We were mixing the type before, as the former one are the type of the
      setting values, not the actual values for the parameters.
      
      * Fix dashboard and card types
      
      * Fix `params` count for `static_embed_published` event
      
      * fixup! Prevent accidental ESLint log in Cypress
      
      * Fix ESlint from the result of upgrading ESLint package
      
      * Fix Snowplow schema enum to include null
      
      * Fully implement `static_embed_code_copied`
      
      * Finish embed_flow snowplow :tada:
      
      
      
      * Fix unit tests because markup change
      
      * Fix E2E tests
      
      * Fix E2E CI failure
      
      Apparently using `.realClick()` on copy button could fail locally,
      but pass on CI and vice-versa. I couldn't replicate this all the time.
      
      I'm not sure why it would fail locally.
      
      * Fix copy to clipboard not working on CI
      
      * Improve test readability
      
      * Remove extra test-id
      
      * Fix refactor `*CodeOptionId`
      
      * Restrict Snowplow schema
      
      * Revert unnecessary change
      
      * Apply Cal's suggestions for BE improvements
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      
      * Update src/metabase/util/embed.clj
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      
      * Fix backend linter error, hopefully.
      
      ---------
      
      Co-authored-by: default avatarMahatthana Nomsawadi <mahatthana.n@gmail.com>
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarNicolò Pretto <info@npretto.com>
      Unverified
      d43863a2
    • Noah Moss's avatar
      Default enable-public-sharing to false for existing instances, and true for new ones (#38609) · 48119c60
      Noah Moss authored
      * Default enable-public-sharing to false for existing instances, and true for new ones
      
      * add rollback
      
      * fix typo
      
      * try to fix e2e test
      
      * invert conditionals
      
      * use derivedSettings instead
      Unverified
      48119c60
    • Chris Truter's avatar
    • Jeff Bruemmer's avatar
      update command (#38371) · e578f47b
      Jeff Bruemmer authored
      Unverified
      e578f47b
    • Jeff Bruemmer's avatar
    • Luis Paolini's avatar
    • Jesse Devaney's avatar
      Milestone 3A: Add fixed width behavior to dashboard filters (#38585) · 687b4033
      Jesse Devaney authored
      
      * Migration adding 'width' to Dashboards
      
      3 migrations:
       - 1st adding the width column with default value of 'fixed'
       - 2nd updating all existing dashboards to have width 'full', which corresponds to what the current behaviour is (will
       be the 'old' behaviour after the fixed-width project lands).
         - The rolloback here is necessary but we don't care what happens as the column will be dropped immediately in the
         next rollback anyway
       - 3rd sets the notNullableConstraint. DefaultNull is 'full' here, just in case there's an existing dashboard whose
       width value is not yet set from the 1st migration. Don't know how that could happen, but its here in case
      
      * Dashboard PUT api endpoint accepts width changes and updates appdb
      
      update-dashboard function now is aware of the :width key so those changes can end up in the transaction.
      
      Also added a width test that asserts that the value's default is "fixed", it can be changed, eg. to "full", but cannot
      be changed to other values.
      
      * Add width to revision tests
      
      * Fix dashboard revision tests.
      
      :width key is now needed in some revision tests. As well we need a string communicating that the :width setting has
      changed from 'full' to 'fixed' or vice-versa.
      
      * Fix comments/remarks in migration to be accurate
      
      * Attempt to fix default not working mysql/mariadb
      
      * Set default in dashboard model
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      
      * Revert default :width 'fixed' value.
      
      * Explicitly add default value 'fixed' for MySQL/MariaDB
      
      * dashboard fixed width FE implementation
      
      * adjust popover shadow styling as the popover was blending in with the header
      
      * adjust extra button popover offset
      
      * add E2E to validate behavior
      
      * add fixed width container to public dashboards
      
      * fix public embedding not respecting dashboard width setting
      
      * add test for public dashboards
      
      * Fix embed test failures
      
      * add fixed width to x-ray dashboards
      
      * reduce code duplication
      
      * move FixedWidthContainer into DashboardGridConnected
      
      - We get the fixed-width w/o code duplication across AutomaticDashboardApp, PublicDashboard, and Dashboard
      
      * update E2E tests to reflect actual intended behavior
      
      * fix type errors
      
      * tweak default width of cards to accomodate fixed width
      
      * adjust tooltip button after merging changes from master
      
      * fix bar chart test failure
      
      * fix dashboard filters date test failure
      
      - new ellipsis button in dashboard edit mode broke the test
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * bump funnel default width
      
      * adjust test for new fixed width dashboards
      
      * Fix double overlay for LineAreaBarChart dash-cards
      
      - No longer has an overlay that persists from editing mode to  viewing mode
      - Adjust click-behavior tests to account for new grid-width. Old test relied on a dashcard being taller than they will now default to being. i.e. Move the chosen point/row to down an index.
      
      * Merge FixedWidthContainer with dashboard grid div
      
      * supress brush events while editing timeseries line charts on dashboard
      
      * fix failing test
      
      - test failed because I did not update this assertion based on previous changes
      
      * fix broken link input in editing mode
      
      * initial commit
      
      * fix pointer events issue on text cards in edit mode
      
      * update tests for new dash-card default sizes
      
      * update tabs card moving test because of new default card sizes
      
      * Include apply filters button in fixed width behavior
      
      * tweak - do not need centering if full width
      
      * fix apply filters button
      
      * add fixed width behavior to dashboard filters in edit mode
      
      * remove double border in edit mode
      
      * evenly space parameters/filters in edit mode
      
      * update test to account for moving location of edit mode filters
      
      * Milestone 3B: Fix dashboard tabs and filters order on a public dashboard page (#38574)
      
      * Add `className` prop to `DashboardTabs`
      
      * Fix tab panel position in public dashboards
      
      * adjust filters container padding
      
      * Address feedback
      
      ---------
      
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      
      ---------
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      687b4033
    • Noah Moss's avatar
      v2 audit views and migrations (#38531) · 5e8286c9
      Noah Moss authored
      
      * new audit views and migrations
      
      * fix tests
      
      * rename external users group to anonymous, handle api key users, and add query definition to query_execution table
      
      * fix mysql user email field
      
      * update yamls for 49
      
      ---------
      
      Co-authored-by: default avatarLuiz Arakaki <luiz.arakaki@metabase.com>
      Unverified
      5e8286c9
    • John Swanson's avatar
      Fix dispatch error in `with-model-cleanup` (#38584) · 7fad72cf
      John Swanson authored
      `with-model-cleanup` is called like so:
      
      ```
      (with-model-cleanup [:model/User]
       ...)
      ```
      
      This ends up calling:
      
      ```
      (with-model-cleanup-additional-conditions model)
      ```
      
      to get the additional conditions necessary when "cleaning up" the model.
      This multimethod dispatched on `mi/model`.
      
      But `(mi/model :model/User)` is `nil`. Instead, we *already have* the
      model, not an instance of it, so we want to dispatch on that to
      properly clean up after ourselves.
      Unverified
      7fad72cf
    • Cam Saul's avatar
      Redshift: drop session schema when test suite finishes (#38529) · c7f1ac93
      Cam Saul authored
      
      * Redshift: drop session schema when test suite finishes [ci skip]
      
      * Update Hawk version
      
      * PR feedback
      
      * Bump Hawk version
      
      * Skip after-run for drivers that don't have test extensions
      
      ---------
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Unverified
      c7f1ac93
    • Oleg Gromov's avatar
      Embedding + required params (#38395) · 140a5322
      Oleg Gromov authored
      Unverified
      140a5322
Loading