This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 24, 2024
-
-
Ryan Laurie authored
* create dashboard settings sidebar * update e2e tests fix * only show settings to dashboard editors * update copy * update e2e test * fix types * update tests for new copy * fix import
-
Ryan Laurie authored
* size and padding fixes * linkify and align stuff in question details * reorganize and divide question overflow menu * hide history for analytics content * fix verification icon alignment * whoopsie lets commit all the files * fix css file name
-
- Sep 13, 2024
-
-
Ryan Laurie authored
* Dashboard Info Sidebar * e2e test updates * add unit tests * e2e test updates * fix e2e tests * fix more e2e tests * update back behavior
-
- Sep 12, 2024
-
-
Ryan Laurie authored
* remove more metabse settings * fix missing update for latest version check * test updates * fix setting selectors
-
Nicolò Pretto authored
-
- Sep 10, 2024
-
-
John Swanson authored
* Move stale endpoint to /ee/stale/${collection-id} It's an enterprise-only endpoint, so it makes sense to put the whole thing under enterprise. * refactors ui to use ee stale endpoint lint fixes, change endpoint location fix failure e2e test * Fix endpoint location --------- Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
- Sep 09, 2024
-
-
Ryan Laurie authored
* Question Settings Sidesheet (#47699)
-
- Aug 30, 2024
-
-
Ryan Laurie authored
* add useDocsUrl hook and update lint rule * remove all uses of MetabaseSettings.docsUrl * update tests * revert non-docsurl change
-
Raphael Krut-Landau authored
-
Ngoc Khuat authored
* [notification] New method: `channel/can-connect?` (#44955) * [notification] Channel APIs (#45207) * [notification] namespaced channel type (#45527) * [Notification] Render alert for http channel (#45545) * [notification] Add channel description (#45840) * [notification] update API to enable http channels for alert (#45839) * [Notification] Remove channel details for users without write perms (#46034) * [Notification] Serdes channel (#46031) * [Notification] Update http details schema (#45960) * [Notification] Deactivate channels will delete PulseChannel (#46115) * [Notification] audit log for channel create and update (#46113) * [Notification] Disallow undefined key for http channel details (#46712) * [Notification] Handle channel name conflicts (#46818) * Webhooks Admin Section (#46194) * [notification] Fix test pulse endpoint does not work properly for http channels (#46474) (#47050) * [Notification] Fix unable to update multiple channels per type (#47111) * [Notification] Record Task History when pulse sends channel message (#46218) * Enabling Webhook Alerts (#47022) * [Notification] fix cyclic deps (#47379) * [notification] channel serdes spec (#47386) Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
- Aug 29, 2024
-
-
Nick Fitzpatrick authored
* Query Validator FE * collection path, unit tests * wrapping feature with token flag * updating util function, adding row type * updating session_test.clj * type adjustment * fixing other table sorting * Empty state, clean up utils * unit test adjustment * e2e adjustment
-
Dennis Schridde authored
== Goal == Hide attached DWH database details from anyone incl. admins: * Do not show them in the UI * Do not permit to change them * Do not serialize them The aim is that customers cannot gain access to (parts of) credentials, and they cannot break a feature they are paying for by changing connection details. == Implementation == The Metabase backend already contains provisions in the implementation of `metabase.models.interface/to-json` for `:model/Database` to hide the `details` of the database in HTTP responses, if the user lacks write permission on the database. We utilize this by adding an `is_attached_dwh` column to the `database` table and rejecting `metabase.models.interface/can-write?` when this flag is enabled. In the "admin" UI, we show a replacement text instead of the edit form when the flag is set. (It might be correct to show this whenever `details` is absent. See below for possible follow-up work.) However, several sections of the frontend code expected the `details` field to always be present. In order to make `details` optional, as the backend seems to handle it, we fix the respective code to treat this case in the way that appears appropriate in the context. Database details are already generally excluded from H2 dump snapshots (see `metabase.cmd.copy/*copy-h2-database-details*`), thus nothing changes there. == How to test == === New behaviour === Setting the `is_attached_dwh` field hides the database details: 1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases. - In addition to the fields you would normally set, also set `is_attached_dwh: true`. - This also works when adding this flag to a database that previously did not have this flag set. 2. Start your Metabase instance. 3. Verify the database shows up in the "admin" section (`/admin/databases`). 4. Verify that clicking the database to see its details only reveals "This database cannot be modified." 5. Verify that responses from the backend do not include a `details` field for this database. === Original behaviour === Behaviour without setting the `is_attached_dwh` field is unchanged: 1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases. - Only set the fields you would normally set. Do not set `is_attached_dwh` (or set it to `false`). 2. Start your Metabase instance. 3. Verify the database shows up in the "admin" section (`/admin/databases`). 4. Verify that clicking the database to see its details only reveal the regular edit form, showing connection fields like `host`, `user`, etc. with the values you configured. == How this will be rolled out == 1. Upgrade existing Metabase Cloud instances with data warehouse to a Metabase version that supports `is_attached_dwh`. 2. Set `is_attached_dwh` in the database section of the config file for Metabase Cloud instances with a data warehouse. == Possible follow-up work == In https://github.com/metabase/metabase/issues/25715, absent `database.details` was identified as a bug. Since then, `details` was made `NOT NULL` in the application database, so this bug can no longer occur. However, today backend responses can be missing the `details` field, if the current user lacks write permission to the database setting (see above). Fully re-evaluating the fix to #25715 in this context is outside the scope of this PR. Closes: https://github.com/metabase/harbormaster/issues/5051
-
- Aug 27, 2024
-
-
Raphael Krut-Landau authored
fix(questions + admin/performance): Improve Clear cache button text and question refresh button tooltip (#46791)
-
- Aug 23, 2024
-
-
Raphael Krut-Landau authored
feat(admin/performance): In Admin / Performance, add a tab where you can manage the caching policies of dashboards and questions (#42990) Closes #42567
-
Nick Fitzpatrick authored
* move default modal padding to general modal component * small adjustments. Using base modal where apropriate * shame
-
Mahatthana (Kelvin) Nomsawadi authored
* Update interactive embedding CTA UTM tags * Make the UTM tags more readable * Update static embed doc UTM tags * Update static embed appearance customization doc UTM tags * Update font upsell UTM tags * Update tests * Fix wrong upgrade URL * Update tests
-
- Aug 22, 2024
-
-
Nick Fitzpatrick authored
* extending table component features * adding unit tests * PR Feedback * PR Feedback * unit test adjustment
-
- Aug 20, 2024
-
-
Uladzimir Havenchyk authored
* refactor: sort import members inside destructuring * Show an error message when the temporal unit is not applicable to a dashboard card (#46983) * Fix tests * Add tests * Add tests * Fix types * Fix types --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Aug 19, 2024
-
-
bryan authored
* allow `:blocked` to be saved for table level perms * Adds 2 tests for table level blocked permission settings - N.B. these are NOT ENFORCED YET * update test that asserted we cannot set block on tables (we can) * WIP: Pairing on making perms checking less wild * cleanup, update docs, and add a test for view-data perm only - Added a test where we have data permissions, but not create query, and I think it is failing when we have create query and blocked data permissions. - renamed some functions from check-x -> has-x? since they return a value instead of throwing now * Revert "WIP: Pairing on making perms checking less wild" Keep the same behavior, but stick with the saner flow control This reverts commit 63bcb5b4. * update docs * update test to be passing - TODO: make sure it's correct w.r.t. perm settings * Allow schema level blocked setting in permgraph * remove invalid test cases - continue to have a forcing function to test newly added perms * conform function output * ensure a single blocked table blocks native queries to its DB * update error message - we now catch this error in `metabase.models.query.permissions/has-perm-for-query?` * we now check for data permissions to process query for card * add more explanation to what we are testing - to help see why it fails on CI and passes locally * remove excess `def` * Add test for table-level data X collection perms - update test found to be in-error * update param values qp permission check style * set view-data and create-query explicitly * set viewdata and createquery explicitly in qp test * Respond to review comments (which fixes a case) * setting a table to blocked: leave other tables the same * [Permissions] Add "No access" schema/table permission (#46509) * first pass * refactors downgrading native permission logic and updates calculation so that "No access" downgrades native permissions to "No" * stub for permissions help info on table block * modal changes wip, updates downgrading create queries permissions to all happen at a single call site * clean up, sandboxing modal copy changes, removes rekoke/limit access modal changes to make the diff smaller and move code to a seperate PR * updates permissions help section to contain the final copy * sandboxing copy fix and remove modal that was dropped from requirements * adds blocked at the schema level, updates no access copy to blocked, updates permissions help section to contain new blocked and schema level changes * fixes failed unit and e2e tests after sandboxing copy changes * improve the block e2e test to include table blocking * fixes failing blocked test, fixes other schemas create queries permissions getting correct with one schema was droped to blocked view data access, fixes a bug that prevents the save bar from going away when all permissions for group are set to the default values * clean up * remove color changes * prevents parent being set to blocked preventing edits for children entities * add new hasPermissionValueInSubgraph fn, adds modal to warn users we have to upgrade the view data permissions when they upgrade create queries permissions when a child entity is set to blocked * adds test coverage for new modal * removes unused function, adds new updateEntityPermission fn to help consolidate some logic elsewhere * unit test fix and type fix * most pr feedback * updates the confirmation modal copy when changing a parent entity that contains a child with blocked permissions and/or sandboxed children, adds test coverage for that, adds test coverage for permission view data column not appearing in oss * type fix * [Permissions] Add e2e test coverage for blocked permissions enforcements (#46663) * adds test coverage for enforcement of blocked permissions * moves tests around based on pr feedback * copy changes * adds fix to make sure that blocked permissions are not removed from sibling tables that have the create queries permissions upgraded (#46854) * Fix table name lookup for dbs w/ 1 schema per db * add test for blank schema identifiers * Refine sandboxed user perms for query builder access (#46939) * Refine sandboxed user perms for query builder access - Limit create-queries permissions to unblocked tables only - Check user permissions for each table before granting query builder access - Prevent querying of blocked joined tables from query builder for sandboxed users * Adjust permissions for sandboxed users - Grant view-data permissions only for unblocked tables - Revert create-queries permissions to all tables in sandbox - Remove unnecessary intermediate variable * when sandboxing we no longer grant unrestricted view perms for blocked tables * Update enterprise/backend/src/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions.clj remove blank line Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * - make coalesce-test exhaustive (except for sandbox) * Update enterprise/backend/src/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * t2/select ... -> database/table-id->database-id * update comment * [Permissions] Prevent "Granular" option in DB View Data options from changing permissions to unrestricted (#46976) * fix * adds back most of the code and limits it to only happen with impersonations, updates test to handle differing logic between the two flows * removes test that is not longer needed * more sandbox join table perms tests --------- Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Nemanja Glumac authored
* Remove simple references to `trackStructEvent` * Remove `withAnalytics` entities helper * Remove `trackLoginSSO` * Remove auth trackers * Remove permissions trackers * Remove performance trackers * Remove settings trackers * Remove pulse trackers * Remove undo trackers * Remove click actions trackers * Remove `trackStructEvent` * Remove GoogleAnalytics from the server security middleware * Remove GoogleAnalytics from Kondo config * Fix type failures * Revert "Remove GoogleAnalytics from Kondo config" This reverts commit 363557c4.
-
Ryan Laurie authored
* use ee api to find custom reports collection * remove deprecated hook * fix race condition * add unit tests * fix circular dependency * fix unit tests * another plugin strategy
-
- Aug 14, 2024
-
-
Nicolò Pretto authored
-
- Aug 12, 2024
-
-
Uladzimir Havenchyk authored
* dx: raise an error if lodash is used * fix lint errors * use ts-deepmerge * don't throw an error * use correct type * use merge form icepick
-
- Aug 09, 2024
-
-
Oisin Coveney authored
-
- Aug 06, 2024
-
-
Raphael Krut-Landau authored
fix(webapp/browse): Fix bug where verified filter is applied to recents even when no verified models exist (#46462)
-
Raphael Krut-Landau authored
-
- Aug 02, 2024
-
-
Sloan Sparger authored
-
Sloan Sparger authored
* wip * moves code to enterprise folder, adds enterprise guards, updates conditionals as to when to show the feature * impls filter date logic, improves styling, mocks out real endpoint with collection items endpoint, updates table with isLink boolean rath er than using custom item renderer, removes dead code * use the actual url for stale * so many things... updated design, custom table component, polish, misc. refactors, more correct api typing * updates to pagination component and reverts some now unused changes to the base items table * impls pr feedback * fixes * fixes failing unit test * completes pr feedback from raffi * implements second round of feedback from raffi * adds tests and couple of small fixes / feedback * migrate clean up action to enterprise plugin and fix related e2e test, also skip the collection items count query when we do not need the value * finish main base case e2e test * clean up helper code for manual testing and add OSS test to make sure feature is not available in OSS * better handling of min-height on smaller screens * adds internal undo notification for bulk archiving in the clean up modal * reset pagination when items are archived/unarchived to keep users from getting stuck on a page beyond the current view * pr feedback * further cleanup * unit test fix * fixes issue where archiving all items in the modal and then undoing does not result in the stale items list getting refetched --------- Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
Ryan Laurie authored
* properly handle SMTP environment variables * disable clear button when set by env var * allow the SMTP form to validate with any combination of environment variables * add unit tests for SMTP connection form * BONUS: fix console error for jt keys * fix types
-
- Jul 31, 2024
-
-
Noah Moss authored
Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com>
-
- Jul 25, 2024
-
-
Raphael Krut-Landau authored
Closes #45127
-
Raphael Krut-Landau authored
Closes #45916
-
- Jul 23, 2024
-
-
Raphael Krut-Landau authored
-
Ryan Laurie authored
* what does this break? * Revert "what does this break?" This reverts commit 93e09edeb3618db1e992bdda5842ba897cb0bce5. * don't show audit db in permissions
-
Nemanja Glumac authored
* Rewrite reproduction for 24223 * Fix test
-
- Jul 19, 2024
-
-
Raphael Krut-Landau authored
-
- Jul 16, 2024
-
-
Nicolò Pretto authored
* add pdf export button to static embed and public sharing (#43743) * add export button to embed frame, it works on static embed and public sharing * move css around to make dashcard border show up on static/public embed pdf exports the library we use to render an html node to an image doesn't seem to support box shadow the original fix was done in ParametersAndCardsContainer, but that component is not used in the static/public embeds * fix types * fix night theme pdf export - use padding for the title instead of starting to draw the image from 60px, to keep the bg color - change the css to also apply the bg-color to the first child of the EmbedFrame, to make it work when exporting to pdfs, where the EmbedFrame is not part of the exported dom * refactor: exportTabAsPdfButtonText function * give a default to the filename, even though it should always be there * exportTabAsPdfButtonText -> getExportTabAsPdfButtonText * introduce .WithThemeBackground to not have a css rule too much generic * feat: adds endpoint to download results of a dashcard part of a public dashboard (#44156) * Flag to hide download buttons (#44206) * pass down downloadsEnabled to hide downloads buttons in public and embedded questions or dashcards * Update frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenu.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * PLUGIN_DOWNLOADS_ENABLED -> PLUGIN_RESOURCE_DOWNLOADS * adds comment to areDownloadsEnabled function to explain what it does --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * logic to handle downloads url parameter (#44363) * minimal support for downloads url parameter * updates StaticEmbedSetupPane test to epxect downloads=false instead of hide_download_button=true * fix prettier mistakes * tmp fix to the tests until we have the new analytics events * fix eslint issues * update embedding snippets e2e * update embedding questions e2e * try to clean up the mess of downloads/downloadsEnabled * adds `hasPremiumFeature` check to the plugin, adds unit test for the logic * adds TODOS for analytics * unit tests for downloads flag (#45178) * fix download pdf button not showing up when titled=false and there's only one tab * unit tests for downloads flag on dashboards and questions * adds test about the container id, not sure if we should keep it * adds a comment to explain why we enable premium features in the tests * move downloadsEnabled outside of the Boolean cast as it's already a boolean * E2E tests for public/static downloads (#45240) * wip e2e tests * make downloadUtils ts friendly * assertNotEmpty function * adds tests for public questions * e2e tests for static embed downloads * publicUid -> publicUuid * fix assertNotEmpty * fix parameter not renamed * Apply suggestions from code review Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * remove duplicated test * fix another typo i forgot to rename * fix another rename issue * convert e2e-downloads-helpers to ts * refactor: put method calculation in getEndpoint function * adds note to downloadUtils --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Update e2e/test/scenarios/embedding/embedding-snippets.cy.spec.js Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * change requires to import to reflect that we changed to export the source code in downloadUtils * makes downloadsEnabled prop more consistent across components * colocate downloadsEnabled with hideDownloadButton in embed-display-options * defaults displayOptions.downloads to true to simplify logic * remove unused queryString parameter in tests setup function * reword TODO * Revert "defaults displayOptions.downloads to true to simplify logic" This reverts commit aebf4cf3cf3528deefb9c40dfc48d2f39a278b97. * fix png export when on dark theme (public/embed) not having the dark … (#45497) * fix png export when on dark theme (public/embed) not having the dark background * move the border-radius fix for the dashcard export to saveChartImage * remove comments --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
- Jul 15, 2024
-
-
Nick Fitzpatrick authored
* prevent moving snippet collections into descendents, remove recents tab * PR feedback
-
Oisin Coveney authored
-
- Jul 05, 2024
-
-
Uladzimir Havenchyk authored
* lint: add stylelint support for emotion components * drop comment * fix pattern order * Use one version of typescript * use :focus not :outline * Use the logical CSS property "inset-inline-start:" (not "inline-start:" which doesn't exist) as replacement for the physical css property "left:" * Use mb-color-focus for focus color * Drop dead code --------- Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-