Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 10, 2024
  2. May 09, 2024
  3. May 08, 2024
  4. May 07, 2024
  5. May 06, 2024
  6. May 03, 2024
    • Uladzimir Havenchyk's avatar
    • Nicolò Pretto's avatar
      Embed homepage, MS4 (#41990) · 55500108
      Nicolò Pretto authored
      
      * use css modules instead of inline styles for cursor: default (#41644)
      
      * add toast notification after the feedback (#41575)
      
      * fix modal submit sending data while button says skip (#41784)
      
      * fix: it should not send the feedback if button says skip
      
      * add comment explaining why we check that getLastFeedbackCall() is undefined
      
      * embedding homepage analytics (#41725)
      
      * rename defaultTab -> initialTab
      
      * add events schema for embedding-homepage
      
      * fix stories
      
      * add analytics, e2e tests and fix typo in dismiss reason
      
      * copy embed_flow schema for better diff in the next commit
      
      * adds isExampleDashboard to trackStaticEmbedPublished
      
      * utm tags
      
      * fix bug of is_example_dashboard
      
      * better test names
      
      * refactor embed homepage status type
      
      * "() => {}" => "_.noop"
      
      * add "Setup embedding" to the admin setup checklist (#41638)
      
      * add setup embedding to the admin setup checklist
      
      * restore whitespace as it was before
      
      * i miss prettier (whitespace again)
      
      * Clean up check list for embedding
      
      Largely making a new entry for the embedding info just to fight long
      lines. `:embedding-homepage-dismissed-as-done` just made the maps really
      long. If we have a `:done?` under an `:embedding` keyword it reads much
      more naturally.
      
      Also, The previous diff was calling `boolean` on a var rather than
      invoking the var:
      
      ```clojure
      :embedding-app-origin (boolean embed.settings/embedding-app-origin)
      ;;                             ^^^^^^^^^^^^^^ needs to be (invoked)
      ```
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      
      * Change utm tags for embedding homepage links (#42042)
      
      * update utm tags
      
      * utm_media -> utm_content
      
      * add description to the checklist setup step (#42200)
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      55500108
Loading