This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 29, 2024
-
-
dpsutton authored
* Increase log level to INFO from error Closes #47396 logs before: ``` 2024-08-29 08:37:03,836 INFO db.liquibase :: Checking if Database has unrun migrations... 2024-08-29 08:37:04,045 INFO db.liquibase :: Database has unrun migrations. Checking if migration lock is taken... 2024-08-29 08:37:04,047 INFO db.liquibase :: No migration lock found. 2024-08-29 08:37:04,047 INFO db.liquibase :: Migration lock acquired. 2024-08-29 08:37:04,167 INFO db.liquibase :: Running 83 migrations ... ``` logs after: ``` 2024-08-29 08:39:45,019 INFO db.liquibase :: Running 83 migrations ... ... 2024-08-29 08:39:45,166 INFO liquibase.changelog :: ChangeSet migrations/001_update_migrations.yaml::v49.2024-06-27T00:00:00::calherries ran successfully in 0ms 2024-08-29 08:39:45,182 INFO liquibase.changelog :: Columns is_defective_duplicate(boolean) added to metabase_field 2024-08-29 08:39:45,182 INFO liquibase.changelog :: ChangeSet migrations/001_update_migrations.yaml::v49.2024-06-27T00:00:01::calherries ran successfully in 14ms 2024-08-29 08:39:45,199 INFO liquibase.changelog :: Custom SQL executed 2024-08-29 08:39:45,200 INFO liquibase.changelog :: ChangeSet migrations/001_update_migrations.yaml::v49.2024-06-27T00:00:02::calherries ran successfully in 16ms 2024-08-29 08:39:45,202 INFO liquibase.changelog :: Foreign key fk_field_parent_ref_field_id dropped 2024-08-29 08:39:45,202 INFO liquibase.changelog :: ChangeSet migrations/001_update_migrations.yaml::v49.2024-06-27T00:00:03::calherries ran successfully in 1ms 2024-08-29 08:39:45,204 INFO liquibase.changelog :: Foreign key constraint added to metabase_field (parent_id) 2024-08-29 08:39:45,205 INFO liquibase.changelog :: ChangeSet migrations/001_update_migrations.yaml::v49.2024-06-27T00:00:04::calherries ran successfully in 2ms ... ``` * empty commit to bump CI
-
Ngoc Khuat authored
* handle cache config overflowed * fix root too * do not comment out test * make cljfmt happy --------- Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
Noah Moss authored
Exclude inactive tables from the perms cache, and block queries over inactive tables in the QP (#47363)
-
metamben authored
* Make metric metadata keep the metric's name This is a fix for the problem reported in #40355, which is fixed separately for v50 and backported to v49. * Patch broken test * Normalize dataset-query * Normalize legacy queries only
-
Ryan Laurie authored
-
Ryan Laurie authored
-
Nicolò Pretto authored
* keep locale in url query params * e2e tests * ugly fix for the missing baseUrl error * applies suggestion from Kelvin to make code more demure * Update e2e/test/scenarios/sharing/public-question.cy.spec.js Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> * remove it.skip added by mistake * sort imports * handle native question/ SyncedParametersList too * shorter and more accurate comment
* Update e2e/support/helpers/e2e-embedding-helpers.js Co-authored-by:Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Alexander Solovyov authored
-
Alexander Solovyov authored
-
Ngoc Khuat authored
-
Ngoc Khuat authored
-
- Aug 28, 2024
-
-
metamben authored
* Support multiple bucketings of a column in nested queries Fixes #46644 * Fix e2e test
-
Chris Truter authored
-
Nick Fitzpatrick authored
* Adding schema name to recents, search results in CP * adding unit test * fixup tests + clarify recent item schema --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Nick Fitzpatrick authored
* remove prevent default on CP links * unit flakes?
-
Noah Moss authored
-
Phoomparin Mano authored
* ask for tenancy isolation columns * deny all permissions for all users group * create new collections * add jwt group mappings * add the permissions step * add multi-tenancy message in helper text format * add permission graph * wire together permissions * use schema permissions * use fields from table metadata from query_metadata * add tenancy field reference * remove log messages * deny access to unsandboxed tables * make permission graph more explicit * deny access to sample database for customer groups * add unit test for permission graph * split permission groups and sandboxes * jwt settings and hard-coded user attributes * handle errors when updating sso mappings * add express api and user switcher * only fallback to api keys when license is invalid * add util to sample tenancy column values * conditional BASE_SSO_API imports * improve embedding error message * setup jwt configuration after license step * setup permissions at the last step * add missing import * update steps that requires license * fix incorrect imports * add missing useContext * handle permission update error * remove tenancyIsolationEnabled field * add tenancy column sampling * differentiate tenancy column query error * rename tenancyColumnValues to tenantIds * assign sampled tenant ids to user attributes * add tenant ids * define collection permissions * reference sandboxing group by name * update snippet to be same as the README * extract ask for tenancy columns to a separate step * use the customer_id attribute * query the table query metadata at origin * append tables correctly * improve error handling in table scanning * add retry logic to metadata fetching * only query metadata for selected fields * fix race condition with retry * update loading state and retries * update comments on jwt license Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * filter the target table by id * highlight last selected tenant column * use breakout to get list of ids * temporary workaround to reload the whole page * update row value types * update row value types * block non-selected tables * remove the source-field from sandboxing * use the fk_target_field_id as instead of target.id * update unit test * remove source-field as we only reference our own column * make native permission types more strict --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Phoomparin Mano authored
* ask for tenancy isolation columns * deny all permissions for all users group * create new collections * add jwt group mappings * add the permissions step * add multi-tenancy message in helper text format * add permission graph * wire together permissions * use schema permissions * use fields from table metadata from query_metadata * add tenancy field reference * remove log messages * deny access to unsandboxed tables * make permission graph more explicit * deny access to sample database for customer groups * add unit test for permission graph * split permission groups and sandboxes * jwt settings and hard-coded user attributes * handle errors when updating sso mappings * add util to sample tenancy column values * improve embedding error message * setup jwt configuration after license step * setup permissions at the last step * handle permission update error * add tenancy column sampling * differentiate tenancy column query error * rename tenancyColumnValues to tenantIds * define collection permissions * reference sandboxing group by name * extract ask for tenancy columns to a separate step * query the table query metadata at origin * append tables correctly * improve error handling in table scanning * add retry logic to metadata fetching * only query metadata for selected fields * fix race condition with retry * update loading state and retries * filter the target table by id * highlight last selected tenant column * use breakout to get list of ids * update row value types * block non-selected tables * remove the source-field from sandboxing * use the fk_target_field_id as instead of target.id * update unit test * remove source-field as we only reference our own column * make native permission types more strict --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Ryan Laurie authored
-
Anton Kulyk authored
-
Oisin Coveney authored
-
-
Raphael Krut-Landau authored
fix(admin/performance): Ensure that the strategy form is not considered dirty if the user changes an empty field to that field's default value, or vice versa (#46543)
-
lbrdnk authored
-
Braden Shepherdson authored
Previously, truncating a `:type/DateTime` column by `:month` or `:day` would return a `:type/Date`, which subtly broke the query. In particular, if you try to order-by the breakout column `Created At (month)` then it would not get de-duplicated, causing a SQL error about conflicting ORDER BY clauses. Fixes #46992.
-
Uladzimir Havenchyk authored
-
- Aug 27, 2024
-
-
Alexander Polyankin authored
-
Aleksandr Lesnenko authored
-
Jeff Bruemmer authored
* clarify caching doc * edit
-
John Swanson authored
Previously, `visible-collection-ids` was effectively "free" in that we'd cached `collection-id->collection` for *all* collections, within a single request, and then locally filtered it for permissions without needing to hit the database again. To be honest, there is probably a better fix for this - we're repeatedly calling `visible-collection-ids` when we probably could just save a single copy of it and use it when calculating the effective location of every collection. However, this is a very quick and low-risk fix, and I want to prioritize getting this done, and then we can improve it later. Locally, I copied down the database from stats and timed the `/api/search?model_ancestors=true` endpoint. Before my "speedup" PR (https://github.com/metabase/metabase/pull/46942) it took ~7 seconds to return results. After my "speedup" PR, it took ~15s to return results. :grimace: With this change, it takes 818ms to return results.
-
Alexander Polyankin authored
-
appleby authored
* Fix typo in expression-clause-normalization-test s/time-interval/relative-time-interval/ * Add missing table-id to card def to fix failing legacy-ref-test * Ensure that if yarn test-cljs fails it fails the CI checks When configured to autorun, the command shadow-cljs compile test will exit success even if test failures occur in the node test. See https://github.com/thheller/shadow-cljs/issues/425 In order to ensure our CI checks fail when cljs tests fail, we need to invoke node directly. To prevent running the tests twice, remove `:autorun true` from the `:test` target in shadow-cljs.edn.
-
Raphael Krut-Landau authored
fix(questions + admin/performance): Improve Clear cache button text and question refresh button tooltip (#46791)
-
Jeff Bruemmer authored
-
appleby authored
* zoom-in-timeseries-drill: do not include :hour and :minute for DATE columns When the user attempts to drill through a DATE column, we should not return :hour or :minute drill throughs from available-drill-thrus. Previously we did, which resulted in an error being displayed when the user attempted to select them. Modify next-breakout-unit in zoom_in_timeseries.cljc to not return :hour or :minute units for :type/Date columns, which prevents these from being returned by available-drill-thrus, which prevents them appearing in UI context menus. * Use lib.temporal-bucket/available-temporal-buckets Per review feedback, use lib.temporal-bucket/available-temporal-buckets to get the valid-current-units in metabase.lib.drill-thru.zoom-in-timeseries. * Do not construct zipmap just to lookup the next unit Rather than constructing a zipmap from `valid-current-units', which requires iterating over the seq twice, just traverse the seq once and return the next item in the seq (if any). Constructing a zipmap made sense in the old code because it was constructed once from static data and used many times for lookup. In the new version, the vec of `valid-current-units` is dynamic and dependent on the type of the breakout. * PR suggestion: use threading macro rather than nested sexps Co-authored-by:
Braden Shepherdson <braden@metabase.com> * PR suggestion: use threading macro rather than transducer / eduction * PR suggestion: reduce boilerplate in zoom-in-timeseries tests Reduce code dup by looping over aggregation and bucketing options rather than having a separate deftest for each. --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com> Fixes #39366
-
Nicolò Pretto authored
* use loki to test png exports on questions * try to put the img in the body to see if it fixes the scrollbar issues in ci * fix linting issues * let's try again in ci * Attempt to make CI wait before taking a snapshot for downloaded PNGs * Use the snapshots from CI for PNG downloads * pdf export test thanks to kelvin suggestion about just testing the png * refactored the code to extract a util function * remove pdf tests as they broke in ci
* Update frontend/src/metabase/env.ts Co-authored-by:Phoomparin Mano <poom@metabase.com> * Update frontend/src/metabase/lib/loki-utils.ts --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
John Swanson authored
-
Tim Macdonald authored
Analyze queries synchronously on save
-
Chris Truter authored
-
Luis Paolini authored
Lotsa fixes for this
-