This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 29, 2022
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix repro for #20471 after #20953 is merged * Make database list error message prettier
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Nick Fitzpatrick authored
Adding can_write check to save question modal
-
Nick Fitzpatrick authored
invalidate revisions on question revert
-
Anton Kulyk authored
* Add E2E test * Exclude undefined query params from question URLs * Allow passing `objectId` to `getUrlWithParameters` * Accept PK in `navigateToNewCardFromDashboard` * Add `extra` viz click action param * New implementation for dashboard PK drill * Pass objectId from drill to dashboard nav action * Fix intercepted route * Fix test name * Use URLs for PK dash drill without filters
-
Mahatthana (Kelvin) Nomsawadi authored
-
Alexander Kiselev authored
-
Alexander Polyankin authored
-
- Apr 28, 2022
-
-
Noah Moss authored
* migrate scoring to defenterprise * migrate parameters to defenterprise * migrate snippet perms to defenterprise * migrate gtap deletion to defenterprise * migrate params.field-values to defenterprise * remove ee-strategy-impl code
-
Alexander Lesnenko authored
* check ci * add test-case * apply iso format only to numbers
-
Cam Saul authored
* mbql.u/add-temporal-unit should ignore invalid units rather than erroring * Test fixes
-
Noah Moss authored
-
Nemanja Glumac authored
-
Ariya Hidayat authored
-
Alexander Lesnenko authored
* fix y-axis scatter extend calculation * add visual test
-
Nemanja Glumac authored
-
Alexander Lesnenko authored
-
Anton Kulyk authored
* Allow navbar on embedded homepage * Use regexps
-
Anton Kulyk authored
* Fix FK filter * Add query * Use `question` click object for FK drills * Add null check to `loadObjectDetailFKReferences` * Fix `ObjectDetailDrill` unit test * Accept explicit `objectId` in FK redux actions * Fix type * Fix `objectId` type * Fix opening ObjectDetail for FK drill * Fix loading FK references * Fix following FKs * Hide prev/next buttons when drilling FKs * Fix expected URL after FK drill in tests * Use object detail test helpers * Reproduce #21756 * Fix dashboard drill test Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Anton Kulyk authored
* Add shared ResizeObserver * Migrate `Ellipsified` * Use shared resize observer * Uninstall `resize-observer-polyfill` * Adjust ExplicitSize settings * Add UI throttle for main resize observer handler * Throttle TableSimple render when editing a dashboard * Disable resize observer throttling in Cypress * Replace `for` loop with `forEach` * Remove ref from `Ellipsified` * Only update observer subscription when mode change
-
Ngoc Khuat authored
* MVP fix * make parser more robust * adding tests
-
Benoit Vinay authored
* ParameterWidget to have width of 100% on small devices * Sticky filters only when there is less than 6 * stickyParameters tests updated * Misc * Misc * Stickyness updated for small screen devices only * Reverted unit test as we can’t test mobile/desktop screen size * Misc * describe updateParametersWidgetStickiness added * Stickiness cypress tests WIP * Tests clean up WIP * Tests updated for 12 parameters * Sticky filters test WIP * data-testid added for ParametersWidgetContainer * Percy clean up / parameters widget position checks * data-testid added for ParametersWidgetContainer editing * Parameters edit mode tests updated * Improved stickiness performance * Misc
-
- Apr 27, 2022
-
-
Ariya Hidayat authored
-
Noah Moss authored
* scaffolding, docstring & arg parsing * tweaks * registry and basic oss->ee dispatch * stubbed defenterprise-ee * full defenterprise-ee impl * fix build and tweak docstring * remove debug code * basic tests * use defonce * support for :any feature * schema support * fix schema test * switch to using format * support for schema on return val * tweak macro * move schema validation to submacros * do ee fn resolution at runtime * do conditionals at macro-expansion time * adjust semantics & refactor * fix test * add memoization for ee resolution * fix tests * emit register-mapping! call to avoid eval * call starts-with on symbol * remove schema support * use spec for arg parsing, generate fns, and remove :error fallback option * clean ns * change schema alias to schema * add :arglists meta and small refactor * refactor * move EE logic to fn * validate that the correct args are passed in EE/OSS namespaces, and make :feature required * remove logic for handling nil :feature * fix lint errors * fix ee macros * defenterprise-schema macro & tests * clean ns * propogate metadata * don't memoize ee resolution in dev to make debugging easier * dont do ee fn resolution during macroexpansion * migrate LDAP functions to defenterprise * lint * require ee ns separately so that EE settings are available * revert change to function mocked in tests * add back code lost in merge * clean ns * clean ns again * minor refactor and cleanup * major refactor * fix defenterprise-schema syntax * fix import * major refactor * update docstrings * more docstring tweaks * try to fix lint error on ldap PR * add lint-as mappings for defenterprise and defenterprise-schema to clj-kondo config * clj-kondo/ignore use of spec alias * use destructuring in arg lists since it's now supported * add docstring to def emitted by macro, and some formatting tweaks
-
Case Nelson authored
* Validate datasets are found when checking bigquery Fixes #19709 * Address PR feedback Made a general mechanism to pass expected messages to users in api/database via ex-info. This allows us to suppress logging for "unexceptional" exceptions that one can expect to hit while setting up drivers. * Only validate when filters are set Also removed the dataset list from the exception as it's not surfaced to users.
-
Noah Moss authored
* scaffolding, docstring & arg parsing * tweaks * registry and basic oss->ee dispatch * stubbed defenterprise-ee * full defenterprise-ee impl * fix build and tweak docstring * remove debug code * basic tests * use defonce * support for :any feature * schema support * fix schema test * switch to using format * support for schema on return val * tweak macro * move schema validation to submacros * do ee fn resolution at runtime * do conditionals at macro-expansion time * adjust semantics & refactor * fix test * add memoization for ee resolution * fix tests * emit register-mapping! call to avoid eval * call starts-with on symbol * remove schema support * use spec for arg parsing, generate fns, and remove :error fallback option * clean ns * change schema alias to schema * add :arglists meta and small refactor * refactor * move EE logic to fn * validate that the correct args are passed in EE/OSS namespaces, and make :feature required * remove logic for handling nil :feature * fix lint errors * fix ee macros * defenterprise-schema macro & tests * clean ns * propogate metadata * don't memoize ee resolution in dev to make debugging easier * dont do ee fn resolution during macroexpansion * minor refactor and cleanup * major refactor * update docstrings * more docstring tweaks * try to fix lint error on ldap PR * use dan's suggestion
-
Natalie authored
-
Nick Fitzpatrick authored
-
Case Nelson authored
Sometimes you’ll make a change to some code and not want to commit it. You probably add a comment to the code and hope you’ll either see the comment in the diff before committing or just remember not to check in the change. If you’ve ever done this you’ve probably also committed something you didn’t mean to commit. I know I have. Below is a git pre-commit hook that searches for the text `nocommit` and if found rejects the commit. With it you can stick `nocommit` in a comment next to the change you don’t want committed and know that it won’t be committed. You can maintain a list of personal forbidden words by exporting `NOCOMMIT_RE` e.g: `export NOCOMMIT_RE="spy|tap>|curse word"`
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
dpsutton authored
This issue has a simple fix but a convoluted story. The new bigquery driver handles multiple schemas and puts that schema (dataset-id) in the normal spot on a table in our database. The old driver handled only a single schema by having that dataset-id hardcoded in the database details and leaving the schema slot nil on the table row. ```clojure ;; new driver describe database: [{:name "table-1" :schema "a"} {:name "table-2" :schema "b"}] ;; old driver describe database (with dataset-id "a" on the db): [{:name "table-1" :schema nil}] ``` So if you started on the new driver and then downgraded for some reason, the table sync would see you had tables with schemas, but when it enumerated the tables in the database on the next sync, would see tables without schemas. It did not unify these two together, nor did it archive the tables with a schema. You ended up with both copies in the database, all active. ```clojure [{:name "table-1" :schema "a"} {:name "table-2" :schema "b"} {:name "table-1" :schema nil}] ``` If you then tried to migrate back to the newer driver, we migrated them as normal: since the old driver only dealt with one schema but left it nil, put that dataset-id on all of the tables connected to this connection. But since the new driver and then the old driver created copies of the same tables, you would end up with a constraint violation: tables with the same name and, now after the migration, the same schema. Ignore this error and the sync in more recent versions will correctly inactivate the old tables with no schema. ```clojure [{:name "table-1" :schema "a"} <-| {:name "table-2" :schema "b"} | constraint violation {:name "table-1" :schema "a"}] <-| ;; preferrable: [{:name "table-1" :schema "a"} {:name "table-2" :schema "b"} {:name "table-1" :schema nil :active false}] ```
-
Bryan Maass authored
-
Case Nelson authored
-
Diogo Mendes authored
-
Nemanja Glumac authored
* [E2E] Create and run new `organization` CI group * Run `organization` group in CI * Remove `moderation` from the PR check
-
Nemanja Glumac authored
* Extract specs related to `fitlers` in a separate folder * Run new `filters` E2E group in CI
-
Alexander Lesnenko authored
-