This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 06, 2022
-
-
Noah Moss authored
-
Dalton authored
* Move date formatting code to utils file * Add parameter formatting util * Replace component format fn usage * Add exception for parameters mapped to sql variables * Remove now unused format functions
-
Nemanja Glumac authored
-
Alexander Polyankin authored
-
dpsutton authored
CVE info: Package: com.google.oauth-client:google-oauth-client Installed Version: 1.31.5 Vulnerability CVE-2021-22573 Severity: HIGH Fixed Version: 1.33.3 ``` . metabase/bigquery-cloud-sdk /Users/dan/projects/work/metabase/modules/drivers/bigquery-cloud-sdk . com.google.cloud/google-cloud-bigquery 1.135.4 . [truncated] . com.google.oauth-client/google-oauth-client 1.31.5 . metabase/googleanalytics /Users/dan/projects/work/metabase/modules/drivers/googleanalytics . com.google.apis/google-api-services-analytics v3-rev20190807-1.32.1 . com.google.api-client/google-api-client 1.32.1 . com.google.oauth-client/google-oauth-client 1.31.5 ``` I looked into bumping com.google.apis/google-api-services-analytics-v3-rev20190807-1.32.1 but as far as I can tell from https://search.maven.org/artifact/com.google.apis/google-api-services-analytics this is the most recent version so we have to just target the transitive dep. For bigquery, it seems we are pretty far behind. 1.135.4 was released in July 2021, the current version is 2.13.1 released in June. https://mvnrepository.com/artifact/com.google.cloud/google-cloud-bigquery I'm hesitant to bump this for a CVE but we need to prioritize this upgrade. After this PR: ``` clj -Stree -A:drivers . metabase/bigquery-cloud-sdk /Users/dan/projects/work/metabase/modules/drivers/bigquery-cloud-sdk . com.google.cloud/google-cloud-bigquery 1.135.4 . [truncated] X com.google.oauth-client/google-oauth-client 1.31.5 :older-version . com.google.oauth-client/google-oauth-client 1.33.3 . metabase/googleanalytics /Users/dan/projects/work/metabase/modules/drivers/googleanalytics . com.google.apis/google-api-services-analytics v3-rev20190807-1.32.1 . com.google.api-client/google-api-client 1.32.1 X com.google.oauth-client/google-oauth-client 1.31.5 :older-version ``` With the `X` meaning not included and 1.33.3 being top level included so using that version.
-
Gustavo Saiani authored
-
Case Nelson authored
* Handle deletable state when enabling persistence When enabling persistence all models are supposed to be set to creating unless they have been explicitly turned "off". Before, we were only looking for new models without attached PersistedInfos when enabling, but missed deletable PersistedInfos that needed to be re-enabled. It's the correct thing to do during the refresh as you wouldn't want refresh to re-enable but it's incorrect when enabling. * Remove unecessary thread-last
-
Nemanja Glumac authored
-
- Jun 03, 2022
-
-
Ryan Laurie authored
* add generic range slider input
-
Ryan Laurie authored
* add boolean filtering inline
-
Nemanja Glumac authored
Repro #22518: Changing model definition will not show changes until after browser refresh (#23149) [skip ci] * Add repro for #22518 * Reinforce the test * Skip repro
-
Gustavo Saiani authored
-
Nemanja Glumac authored
-
Braden Shepherdson authored
Add a test to check that all exported models have a portable unique name Either an external name (eg. a database path) or an entity_id column. Unexported models are explicitly listed as such here. This makes it impossible to forget to address a unique ID for any new model. Related to epic #22641
-
Maz Ameli authored
-
Alexander Lesnenko authored
-
Nemanja Glumac authored
-
dpsutton authored
* Switch from classpath to basis for license information Previously we were chopping the classpath up and starting from there so we just had a sequence of strings pointing at jars. Now using the basis so we use a _much_ nicer map like ```clojure {org.bouncycastle/bcprov-jdk15on {:mvn/version "1.70", :deps/manifest :mvn, :dependents [buddy/buddy-core org.bouncycastle/bcutil-jdk15on org.bouncycastle/bcpkix-jdk15on], :parents #{[buddy/buddy-sign buddy/buddy-core] [buddy/buddy-sign buddy/buddy-core org.bouncycastle/bcpkix-jdk15on org.bouncycastle/bcutil-jdk15on] [buddy/buddy-sign buddy/buddy-core org.bouncycastle/bcpkix-jdk15on]}, :paths ["/Users/dan/.m2/repository/org/bouncycastle/bcprov-jdk15on/1.70/bcprov-jdk15on-1.70.jar"]} ...} ``` So we now have a true name for the dependency, a path to it, and a version. No need to string munge on the classpath. * Read pom with `maven-model` rather than us trying to parse the xml, use a maven model on it. Note there is another level we can go to that would be aware of parent poms but we don't need the overkill here. That's far heavier than what we need to do in this instance. Note this also reorders the algo: previously - license in jar - backfill - license from pom Now: - license from jar - license from pom - backfill Possible we will want to actually just skip the license from pom bit since it only gives us a name and a url and not the full text. We could match on these and identify them with the resources used from the backfill if we like. Another important change is that this no longer throws if it cannot find a pom for a jar. This came up for the following lib: ``` ;; deps.edn com.google.cloud.sql/postgres-socket-factory {:mvn/version "1.6.0"} ; Secure Google Cloud SQL postgres connections ;; override: "com.github.jnr" {"jffi$native" {:resource "apache2_0.txt"}} ``` Which was from a 3rd party PR. * Way to generate libs that need overrides * Remove unused fns, add tests, cleanup docstring * Don't leave tap> in Two poms blow up with BOM errors - jakarta.activation-1.2.1.pom - jakarta.activation-api-1.2.2.pom > UTF-8 BOM plus xml decl of iso-8859-1 is incompatible > (position: START_DOCUMENT seen <?xml version="1.0" encoding="iso-8859-1"... @1:41) It has a parent pom and not a license so we wouldn't find it anyways.
-
Alexander Lesnenko authored
-
Ngoc Khuat authored
* dashboard api to get params value should return 404 instead of 500 when param not found * on the 2nd thought, let's return 400 * update the tests too * wording
-
Ngoc Khuat authored
* add parameters to report_card and card APIs * make sure migration can work with existing cards and add migration tests * remove debug code * When parameters is empty, return template tag parameters * update schema message * update migraiton test name * minor changes in test * fix failing tests * Always use card.parameters in PublicQuestion * Add defaults and readd isEmpty check * Default to undefined/use template tags in PublicQuestion... * parameters should be in the writableProperties * Native query card: construct parameters from template tags * Separate the generation of parameter id * Add parameter_mappings to report_card (#23003) * add parameter_mappings to report_card * fix from Noah's comments * fix from Noah's comments * Update a parameter from an updated template tag * Correct the parameters construction * Also add `parameter_mappings` to writableProperties * CI test: bust the npm module cache * Revert "CI test: bust the npm module cache" This reverts commit 5a327b616f0220f43a90f7f871e0bd877ffa6f47. Co-authored-by:
Dalton Johnson <daltojohnso@users.noreply.github.com> Co-authored-by:
Ariya Hidayat <ariya@metabase.com>
-
Howon Lee authored
Adds option to turn JSON column unfolding off. This does not constitute an actual fix of boat161 but flamber wanted it
-
- Jun 02, 2022
-
-
adam-james authored
* Adjust JWT and SAML fetch-and-update user to save new attributes Before this change, JWT/SAML logins would attempt to update attributes, but never considered the first-name or last-name attributes. * Attempts to fix tests to prevent pulluting test users with "Unknown" * No deleting users. * Unit tests checking that first/last names are updated for SSO users When an SSO user is first logged in, they might not have first_name and/or last_name keys. This is allowed, but the names will be "Unknown" in the app-db. Subsequently, a User may log in again with SSO but have fisrt/last name attributes, which should update the Metabase user data in the app-db. These unit tests set up such a scenario to check that the :first_name and :last_name keys are indeed updated. * Adjust Enterprise LDAP to also use SSO-UTILS Trying to unify the LDAP implementation with JWT/SAML a bit here. * Lint error * Reverting LDAP ns changes to get the PR unstuck This is to keep the ball rolling on SSO fixes. I'll add LDAP as an item in the Epic to address this separately.
-
Nemanja Glumac authored
-
Alexander Lesnenko authored
-
Nemanja Glumac authored
-
Nick Fitzpatrick authored
Adding action button to Question Page
-
Diogo Mendes authored
-
Nemanja Glumac authored
Repro #22517: Adding/removing columns on an existing model will drop all configured metadata (#23071)
-
Nemanja Glumac authored
-
Anton Kulyk authored
-
Anton Kulyk authored
* Add new cache info types * Add model cache info mock factory * Add `checkCanRefreshModelCache` utility * Handle new states on model page caching section * Handle new states on Tools page * Fix svg import type error * Use "queued" for `creating` state * Fix tests
-
Anton Kulyk authored
* Update `SegmentedControl` variant style getters * Add `fill-all` variant to `SegmentedControl` * Fix `SegmentedControl` borders * Make `TimeInput's` clear button optional * Extract `useTimeInput` hook * Add `CompactTimeInput` * Add anchor time setting * Only show anchor time if refresh interval >= 6 hours * Show refresh time hints under the anchor input
-
Anton Kulyk authored
-
Gustavo Saiani authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Lesnenko authored
* fix column settings ignored * better fix
-
- Jun 01, 2022
-
-
Natalie authored
-