Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 08, 2024
  2. Sep 30, 2024
  3. Sep 23, 2024
    • Sloan Sparger's avatar
      [E2E] Remove the `default-ee` spec (#47162) · af906dec
      Sloan Sparger authored
      * removes the default-ee snapshot in favor for a blockUserGroupPermissions util
      
      * commit default-ee removal i forgot, replace default strings with undefined
      
      * fix oopsie
      
      * fixes failures for not removing enough permissions for tests in sandboxes.cy.spec.js
      
      * rename var
      Unverified
      af906dec
  4. Aug 20, 2024
  5. Jun 11, 2024
    • bryan's avatar
      Make recents understand context (#43478) · 7b849da3
      bryan authored
      
      * adds the endpoint and a test
      
      * add recents endpoint, todo: tests
      
      * add post recents endpoint
      
      * return recent views for both lists, but make the endpoint work
      
      * Make recent-views context aware
      
      - pruning is context aware, only checks for the recently-inserted
        context
      - Adds endpoints:
          - POST to create selection recents,
          - GET activity/recents
            - requres context query param to be one of:
            - all, views, selections
      
      - Adds context arg to update-users-recent-views!
      - Cleans up arg schema for update-users-recent-views
      
      * impl GET api/activity/recents
      
      - return recent-selections and recent-views from
      - send context == collection from pinned card reads
      
      * update callsites of recent-views/update-users-recent-views!
      
      - to use :view param where necessary
      
      * fixes models/recent-view tests
      
      * adds more activity/recent-view tests
      
      * wip
      
      - fix whitespace linter
      
      * Fix command palette e2e test
      
      - reuse util snake-keys
      
      * updates fe to use new recents endpoints
      
      * fixes fe type issue
      
      * snake-keys -> deep-snake-keys
      
      - I've been betrayed by lsp rename
      
      * snake-keys -> deep-snake-keys
      
      - I've been betrayed by lsp rename
      
      * log selection events for created collections
      
      * mysql doesn't allow default values for TEXT types
      
      * log a recent view on data-picker selection
      
      * decouple view-log context from card-event view context
      
      * fix a doc typo
      
      * stop double logging recent-views on POST
      
      * maybe fixes some tests
      
      * some e2e fixes
      
      * fix mysterious divide by zero during score search
      
      * fix divide by zero possibilities everywhere in score-items
      
      metabase.api.activity/score-items used to throw when there weren't any
      items being scored (even though there's a `(when (seq items) ...)` check)
      
      * more test fixes
      
      * fix more e2e tests, + rename endpoint in tests
      
      * fix oopsie
      
      * fixes a few more tests
      
      * address review comments/questions
      
      * allow for a comma delimited list in qps like ?context=views,selections
      
      returns all recent view items with those contexts, most recent first
      under the `:recents` key.
      
      * refactors FE around new endpoint
      
      * fixes for unit tests
      
      * use ms/QueryVectorOf for context
      
      * fix models/recent_views tests
      
      * use multiple query params instead of comma delimited value on FE
      
      * ignore timestamp when deduping recents
      
      * review comments + test fixing
      
      * update docstring
      
      * fix api/activity_test s
      
      * actually dedupe
      
      * add test for deduping by context
      
      * e2e fix: shows up-to-date list of recently viewed items after another page is visited
      
      * e2e fix: should undo the question replace action
      
      * e2e fix: should replace a dashboard card question (metabase#36984)
      
      * e2e fix: should preselect the most recently visited dashboard
      
      * fix 6 more e2e tests
      
      * fixes fe type check and unit failure
      
      * renames unit test mocking function
      
      * fix a flaky e2e test
      
      * widen Item to accept str or kw where sensible
      
      - allow strings or keywords for moderated_status, and authority_level
      
      * simplify impl + add test
      
      * add view-log to events schema
      
      * add collection context to view log
      
      * fix the final 2 failing e2e tests
      
      * click dashboard tab when the user has can-read? on recent entities
      
      ---------
      
      Co-authored-by: default avatarSloan Sparger <sloansparger@gmail.com>
      Unverified
      7b849da3
  6. Apr 19, 2024
  7. Apr 17, 2024
  8. Apr 05, 2024
    • Nicolò Pretto's avatar
      embed-homepage - ms1 PR (#40382) · 9402bd68
      Nicolò Pretto authored
      
      * create ui for the full embedding homepage, without any logic (#40251)
      
      * wip ui for the full embedding homepage
      
      * adds missing link + fix keys
      
      * remove done TODO
      
      * Update frontend/src/metabase/home/components/EmbedHomepage/InteractiveTabContent.tsx
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * destructure props in the function arguments
      
      * rename customerFacingAnalyticsDocsUrl to analyticsDocsUrl
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * add new settings for embedding homepage (#40455)
      
      * remove old minimal version
      
      * adds new embedding homepage settings and sets them at the end of the setup
      
      * comment e2e test
      
      * add tests for embedding homepage flags
      
      * more tests
      
      * remove unit tests related to old minimal version
      
      * fixes flags descriptions
      
      * :keyword for embedding-homepage
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * replace reloadSettings and refreshSettingsList with initializeSettings
      
      * `value => value === true` -> `Boolean`
      
      * toMatchObject -> toEqual for more strict tests
      
      * remove useless undefined check for settings, the component is conditionally rendered based on a setting so it means they're loaded anyway
      
      * fix: use :hidden as we changed the type to :keyword
      
      * specifically check for the `embedding` feature in the tokenFeatures object instead of checking if any feature is active
      
      * remove double \n
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * connect settings to the embed homepage and show it (#40528)
      
      * fix nested a warnings in browser console
      
      * connect settings to the embed homepage and show it
      
      * fix stories
      
      * remove localStorage.clear() as we're not using it in the logic anymore
      
      * dismiss without feedback for the embedding homepage (#40587)
      
      * feat: add dismiss functionality to the embed homepage
      
      * update setup e2e to check for the dismissal of embedding homepage
      
      * use List from metabase/ui (#40638)
      
      * set embedding-secret-key when embedding is enabled (#40813)
      
      * set embedding-secret-key when embedding is enabled
      
      * use "named" setters and getters as suggested by Noah
      
      * Fix tests for ms1 after updating on master (#41069)
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Unverified
      9402bd68
  9. Feb 26, 2024
  10. Feb 20, 2024
    • Kamil Mielnik's avatar
      Align paths in Prettier & ESLint scripts (#38951) · 750638e4
      Kamil Mielnik authored
      * Align ESLint & prettier paths in "lint-stage" & "scripts" in package.json
      
      * Handle ts files in e2e tests
      
      * Manually fix ESLint-reported issues
      
      * Format "lint-prettier-pure" script the same way as "prettier"
      
      * Run "yarn eslint-fix"
      
      * Manually fix remaining issues
      
      * Ignore database files in ESLint as they reference a file that is git-ignored but does exist locally
      
      * Remove duplicated eslint call
      Unverified
      750638e4
  11. Feb 05, 2024
  12. Jan 11, 2024
    • shaun's avatar
      API Keys UI (#37097) · 7d369288
      shaun authored
      
      * API Keys: add auth card and manage page
      
      * update deletion copy
      
      * add groups data to snapshot
      
      * update e2e tests to work with backend
      
      * update strings and formatting
      
      * update e2e tests
      
      * remove e2e tests from other pr
      
      * update unit tests
      
      * e2e test update
      
      * mock api key endpoints in settingsEditor unit tests
      
      * remove console log
      
      * use dumb quotes
      
      * handle monospace better
      
      * better form validation
      
      * no need to wait
      
      * update test to work with validation
      
      * contrain table width
      
      * remove monospace variant
      
      * API Keys: Handle Groups UI (#37099)
      
      * API Keys: Show in Group members table
      
      * API Keys: Show count in Group listing
      
      * tweak and test group settings views for api keys
      
      * fix sad lint rebase sitch
      
      * update group manager tests
      
      * better loading behavior
      
      * handle all users api keys
      
      * update types and tests
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      Unverified
      7d369288
  13. Oct 31, 2023
  14. Oct 17, 2023
  15. Oct 10, 2023
    • Nemanja Glumac's avatar
      E2E isolate mongo (#34423) · 899ad8ab
      Nemanja Glumac authored
      * Tag Mongo-dependent E2E tests
      
      * Run mongo tests only if `CYPRESS_QA_DB_MONGO` is `true`
      
      * Adjust E2E workflow to run mongo tests separately
      
      * Guard against missing mongo env var
      
      * Fix workflow
      
      * Fix qa snapshots
      
      * Tag additional Mongo E2E tests
      
      * Omit tests tagged with `@mongo` in regular runs
      Unverified
      899ad8ab
  16. Oct 03, 2023
  17. Sep 20, 2023
  18. Sep 07, 2023
  19. Jun 17, 2023
  20. Jun 14, 2023
    • Nemanja Glumac's avatar
      [E2E] Do not hardcode admin id (#31576) · 0438823a
      Nemanja Glumac authored
      We're trying to minimize the amount of hard coded IDs (or any other data) in E2E tests. This change doesn't assume admin's ID is always going to be 1. It fetches the id from the current user instead.
      
      This should make test more resilient to change.
      Unverified
      0438823a
  21. Jun 09, 2023
    • Ngoc Khuat's avatar
      Dashboard grid from 18 to 24 (#31019) · 660f8f0c
      Ngoc Khuat authored
      
      * forward migration for size_x and col
      
      * done?
      
      * test fixes
      
      * adds some document
      
      * migration should not contains comment
      
      * mysql and postgres use different syntax in casting
      
      * makes it work on mariadb
      
      * update grid columns
      
      * update specs
      
      * update specs
      
      * use float for postgres
      
      * postgresql not postgres
      
      * add migration for revision with model=Dashboard
      
      * row is reserved in h2 too
      
      * handle edge case with rollback migration where we have a 1x1 card that located at the shrinkage line
      
      * kondo
      
      * Cal's feedback
      
      * add the code we used to generate random array
      
      * clean up
      
      * use the algorithm to dynamicall generate test data
      
      * no more height migrations
      
      * grid ratio
      
      * unmigrate height in cypress specs
      
      * update specs
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      660f8f0c
  22. May 12, 2023
    • Ngoc Khuat's avatar
      [Feature] Dashboard Tab basic functionality (#30177) · d617aecf
      Ngoc Khuat authored
      
      * Dashboard Tab entity (#29802)
      
      * add dashboard tab entity
      
      * Dashboard tabs CRUD (#29861)
      
      * Dashboard tabs frontend (#30189)
      
      * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx`
      
      commit-id:7cdfd86a
      
      * add tabs to dash
      
      commit-id:d3c2fa74
      
      * improve code structure and other fixes
      
      * rename `dashboardtab_id` to `dashboard_tab_id`
      
      * remove explicit `position` logic
      
      * improve code quality
      
      * add renaming functionality
      
      * add two new tabs when creating first tab
      
      * hide tabs if there is only one
      
      * add unit test for `DashboardTabs` component
      
      * refactor
      
      * fix type errors
      
      * add `tabId` to text cards
      
      * add `tabId` to link cards
      
      * add `tabId` to action button
      
      * use disabled state when only one tab remains
      
      * refetch cards with filter value when changing tabs
      
      * add e2e test
      
      * fix broken e2e tests
      
      * add horizontal scrolling
      
      * fix unit test
      
      * fix create tab button being on right
      
      * fix performance issue when switching tabs
      
      * add `ttag` to `tabs.ts`
      
      * use `aria-label` in e2e test helper
      
      * fix type error after rebasing
      
      * making ordered_tabs optional for tests purposes
      
      * fix failing unit tests
      
      * fix failing e2e tests
      
      * fix flaky revision history e2e test
      
      * fix type error after merging feature branch with master and rebasing
      
      * fix revisions unit test
      
      * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      ---------
      
      Co-authored-by: default avatarEmmad Usmani <emmadusmani@berkeley.edu>
      Unverified
      d617aecf
  23. Mar 01, 2023
    • Nemanja Glumac's avatar
      [E2E] Regroup and move all related files to the root (#28749) · f71f20e1
      Nemanja Glumac authored
      * Register new E2E path alias
      
      * Move E2E support files
      
      * Move E2E runner files
      
      * Move E2E snapshot related files
      
      * Move E2E visual regression tests
      
      * Move E2E `downloads` scenarios
      
      * Move E2E `admin` scenarios
      
      * Move E2E `auditing` scenarios
      
      * Move E2E `bining` scenarios
      
      * Move E2E `ccollections` scenarios
      
      * Move E2E `cross-version` scenarios
      
      * Move E2E `custom-column` scenarios
      
      * Move E2E `dashboard` scenarios
      
      * Move E2E `dashboard-filters` scenarios
      
      * Move E2E `dashboard` reproductions
      
      * Move E2E `embedding` scenarios
      
      * Move E2E `filters` scenarios
      
      * Move E2E `joins` scenarios
      
      * Move E2E `models` scenarios
      
      * Move E2E `native-filters` scenarios
      
      * Move E2E `native` scenarios
      
      * Move E2E `onboarding` scenarios
      
      * Move E2E `organization` scenarios
      
      * Move E2E `permissions` scenarios
      
      * Move E2E `question` scenarios
      
      * Move E2E `visualizations` scenarios
      
      * Move E2E `sharing` scenarios
      
      * Move E2E `docker-compose`
      
      * Fix commands imports
      
      * Fix helpers imports
      
      * Fix downloads reproductions imports
      
      * Fix integration imports
      
      * Move visual regression tests
      
      * Various fixes
      
      * Move `validate-e2e-files` script
      
      * Add eslint rules for E2E folder
      
      * Improve file paths
      
      * Move `cross-version` tests into scenarios
      
      * Path fixes
      
      * Register E2E alias in tsconfig
      
      * Fix failing tests after rebase
      Unverified
      f71f20e1
Loading