Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 18, 2024
    • lbrdnk's avatar
      Add temporal unit to display name (#48946) · 5203a15c
      lbrdnk authored
      * Add temporal unit to display name
      
      * Remove temporal unit adjustments from FE
      
      * formatColumn to displayNameForColumn
      
      * Factor out getFriendlyName
      
      * Adjust BE tests
      
      * Add require
      
      * Adjust FE unit tests
      
      * Adjust temporal-unit-parameters.cy.spec.js
      
      * Adjust dashboard-reproductions.cy.spec
      
      * Convert formatColumn occurrence
      
      * Adjust legacy display name logic generation
      
      After `getFriendlyName` was removed from FE, capitalization
      of display name should happen here. Logic is similar, should
      be adjusted prior merging the PR.
      
      * Adjust embedding-linked-filters.cy.spec.js
      
      * Adjust joins-reproductions.cy.spec.js
      
      * Adjust metrics-editing.cy.spec.js
      
      * Adjust timelines-question.cy.spec.js
      
      * Adjust offset.cy.spec.ts
      
      * TMP Avoid duplication of temporal unit in display name in MLv2 code
      
      * Probably FE fix: add default temporal bucket only if not present
      
      * WIP Add ends-with-temporal-unit? function
      
      Current strategy is to add temporal units to display names if same is not already present
      
      * Adjust display-name-method :metadata/column
      
      Append TU to display name only if different to what's already present
      
      * Adjust FE: show temporal unit that's present on field instead of default on hover on QueryColumnPicker element
      
      * Return also temporal-unit from visible-columns
      
      * Enable tempora-unit to be returned from previous-stage-or-source-visible-columns
      
      * WIP Adjust multi breakout multi stage e2e multiple-column-breakouts.cy.spec
      
      * Adjust multiple-column-breakouts.cy.spec.ts
      
      * It was not a bug.
      
      * Revert changes in _BaseBucketPickerPopover
      
      * Restore temporal-unit for next stages removal in stage.cljc
      
      * Add inherent-temporal-unit
      
      * Adjust display name temporal bucket logic
      
      * Rename to inherited-temporal-unit
      
      * Shutdown too broad display name capitalization
      
      * Eastwood
      
      * Adjust pivot-rows-order-test
      
      * Adjust pivot-non-numeric-values-in-aggregations
      
      * Adjust inherent to inherited
      
      * Rename to inherited
      
      * Add inherent-temporal-unit only to returned-columns
      
      * Update e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js
      
      * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts
      
      * Update consistent-date-formatting-test
      
      * Update dashboard/x-rays.cy.spec.js
      
      * Update waterfall.cy.spec.js
      
      * Return month default for default inherited-temporal-unit
      
      * Update reproductions-3.cy.spec.js
      
      * Update downloads/downloads.cy.spec.js
      
      * Update legend.cy.spec.js
      
      * Update pie_chart.cy.spec.js
      
      * Update click-behavior.cy.spec.js
      
      * Update embedding-linked-filters.cy.spec.js
      
      * Return QueryColumnPicker's condition to original state
      
      * Remove reundant export
      
      * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts
      
      * Comment
      
      * Update nested.cy.spec.js
      
      * Update e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js
      
      * Adjust to TS types
      
      * Adjust for cljfmt
      
      * Capitalize
      
      * Add propagation tests
      
      * Add inherited-temporal-unit propagation for expressions
      
      * Add default inherited-temporal-unit test cases
      
      * Add qp temporal-bucket-test ns
      
      * Simplify default unit logic
      
      * Comment
      
      * Use NULL_DISPLAY_VALUE
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Remove redundant code (for now)
      
      * Update comments
      
      * Comment
      
      * Restore way too daring simplification
      
      * cljfmt
      
      * Adjust capitalize
      
      * Update comment
      
      * Update test
      
      * Address remarks in tests
      
      * Update test
      
      * Address remarks
      
      * typo
      Unverified
      5203a15c
    • Uladzimir Havenchyk's avatar
      fix: respect click behavior on public dashboards (#50067) · 552cf921
      Uladzimir Havenchyk authored
      * fix: pass noop as navigateToNewCardFromDashboard from public or embedded dashboard
      
      * add e2e test
      
      * rework a fix
      Unverified
      552cf921
    • Romeo Van Snick's avatar
      Fix button group breaking (#50064) · c8aa0a54
      Romeo Van Snick authored
      
      * Use Flex instead of Group for items in button
      
      * Allow column picker to stretch to match the height of the element
      
      * Fix height of data picker buttons
      
      * Make sure the whole button is clickable
      
      * Add e2e test for metabase/metabase#50038
      
      * Use correct id for issue in e2e test
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      c8aa0a54
    • Kamil Mielnik's avatar
      Fix flaky test (#50077) · 17887dcd
      Kamil Mielnik authored
      Unverified
      17887dcd
    • Nicolò Pretto's avatar
      fix(49537): remove position relative from echarts tooltip container (#49964) · 7951b711
      Nicolò Pretto authored
      
      * attempt to fix 49537 by removing position relative from the tooltip
      container
      
      * Make echart tooltip container cover all iframe area
      
      * Update the E2E test
      
      * Update loki snapshots from CI
      
      * Re-enable echarts tooltip assertion.
      
      I couldn't find a better way to fail these assertions on the previous
      version of the code, but these assertions are better than nothing.
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Unverified
      7951b711
  2. Nov 15, 2024
  3. Nov 14, 2024
  4. Nov 13, 2024
  5. Nov 12, 2024
  6. Nov 11, 2024
  7. Nov 09, 2024
    • Nemanja Glumac's avatar
      Make "Add database" more prominent (#49678) · f9efc212
      Nemanja Glumac authored
      * Remove dead code from browse models page
      
      * Use the grid to control the gap
      
      * Implement "Add database" button
      
      * Add basic unit tests
      
      * Make sure the feature works when there are no databases
      
      * Add analytics to the db list
      
      * Add "Add database" button to the sidebar
      
      * Add E2E Snowplow tests
      
      * Add unit tests
      
      * Deal with authentication in each beforeEeach separately
      
      * Add Snowplow E2E test for a database card
      
      * Slightly tweak the title line height
      Unverified
      f9efc212
  8. Nov 08, 2024
  9. Nov 07, 2024
  10. Nov 06, 2024
  11. Nov 05, 2024
  12. Nov 04, 2024
Loading