This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 06, 2021
-
-
Gustavo Saiani authored
-
Gustavo Saiani authored
-
Dalton authored
-
Luis Paolini authored
Show how to increase Jetty verbosity * Update docs/operations-guide/log-configuration.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com>
-
Greg Wilson authored
- Make all specific problems H2-level headings. - Create a `doc-toc` div at the top for the table of contents. - Don't use `learn-doc` because we may want to style/show this one independently. - Link to all problem headings. Note: can't use metadata in a page header because our CI tools splat their own headers into these pages, so anything we add becomes part of the page body.
-
Nemanja Glumac authored
* Add sane defaults to the card size in `createQuestionAndDashboard` custom command * Add repro for #17212
-
Nemanja Glumac authored
-
- Aug 05, 2021
-
-
Jeff Evans authored
Adding new cache to `metabase.driver.sql-jdbc.connection` that tracks the DB details hash values per DB id Checking if the non-empty hash value of DB details changed in `db->pooled-connection-spec` in order to invalidate an existing pool Adding test that redefines the log fn to assert that the pool is invalidated on hash change
-
Ariya Hidayat authored
It's redundant since the job explicitly installs the proper version in the previous step, and also running that prematurely pulls a bunch of JARs from Maven Central. This should shave 20 seconds from the CI runs.
-
Nemanja Glumac authored
* Add parial repro for #15656 * Update frontend/test/metabase/scenarios/onboarding/about.cy.spec.js Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
dpsutton authored
-
Cam Saul authored
* Bump some more backend dependencies * Add license info for com.sun.activation/jakarta.activation * Fix reflection warnings * Revert bump of MariaDB for now
-
Ariya Hidayat authored
-
- Aug 04, 2021
-
-
Jeff Evans authored
Remove the `driver/can-connect?` implementation and move the `select-keys` logic instead to the existing place in `sql-jdbc.conn/connection-details->spec` Update test to also include the `:let-user-control-scheduling` details entry
-
Cam Saul authored
* Bump some backend deps. * Update i18n/locale to work with new version of LocaleUtils
-
Cam Saul authored
* Fix JUnit output not correctly stripping ANSI color codes * Remove find-tests profiling log message * 1-arg arity of metabase.test-runner/run * Fix bug with metabase.test-runner/find-tests with a single test name
-
Noah Moss authored
-
Dalton authored
-
Jeff Bruemmer authored
-
Alex Ghiculescu authored
* Fix location of share icon * Update 12-public-links.md Differentiate between dashboard and question sharing Co-authored-by:
Luis Paolini <paoliniluis@gmail.com>
-
Cam Saul authored
-
dpsutton authored
* Remove last of leiningen, comment in shadow and lsp cp [ci skip] * empty commit to flush [ci skip]
-
Ariya Hidayat authored
-
- Aug 03, 2021
-
-
dpsutton authored
* remove moderation reviews hydration * Restore hydration of moderation_reviews and handle correctly nested hydration is (i think) positional. So if you get something handed to you you must return something in that position. Prevoiusly was removing nils and then returning a smaller collection of hydrated items (cards here). But this meant input might look like this [card1 nil card2] and return [card1 card2] and in the nested hierarchy things didn't get matched up correctly. In the real world application it might look like this: ```clojure {:ordered-cards [{:card-id 1} {:card-id nil :viz-settings {info-for text-card}} {:card-id 2}]} ``` And the nil card comes into this function and we return them in a strange manner things get wonky
-
Maz Ameli authored
-
Nemanja Glumac authored
* Remove `project.clj` from Percy workflows * Replace `project.clj` with `deps.edn` in `build-for-test` script * Update reference to the `project.clj` in the comment
-
Howon Lee authored
We're playing this whackamole because we added the middleware to universally sorta stomp on any `limit` or `offset` params, and they got stomped on. Which, in turn, led to my PR to make the default not limited. Which, in turn, led to the other issue this PR solves which makes the search things we relied upon to not have a limit, have a limit.
-
Nemanja Glumac authored
* Register `@testing-library/jest-dom/extend-expect` globally * Remove unnecessary imports from unit tests
-
Luis Paolini authored
-
Cam Saul authored
-
Cam Saul authored
* Add some dox * Rename test-runner & cloverage -> metabase.test-runner & metabase.cloverage-runner * Move JUnit-related test runner code to separate namespace * Bespoke JUnit-output code * Delete unused .lein-classpath file * Do JUnit writes in a cached thread pool * Add failing test to make sure JUnit output works as expected... * Move bad-test to metabase.bad-test so the FAILING tests actually run * FASTER TEST LOADING
* Test CircleCI :system-out * Final cleanup (hopefully) * Sort some namespaces; allow initializing :plugins when namespaces get loaded for now. * Need those [[tags]] in docstrings * Fix bad docstring -
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Alexander Lesnenko authored
-
Dalton authored
* rmv old bucm icons and remove verified fill color * add moderation action section to sidebar * add moderation review icon to the saved question header button * hide moderation section when is not a moderator * add UI for ModerationReviewBanner * Backend for moderation-review - create table moderation_review. Same as before but also has a "most_recent" boolean flag for the most recent moderation for easy lookup - POST /moderation-review/ . Status can be "verified" or nil - must be an admin to post - No PUT or edit route yet. Not sure if this is even necessary. _MAYBE_ to edit the text, but certainly not for the status, ids, etc. If there's to be history, let's build some history - Ensure we never have more than 10 reviews. Adding a new review will delete the older ones, mark all old ones as not `most_recent`, and add the newest one as `most_recent true` - Ensure the card actually exists before creating the mod review - Since admin only at this time, don't need to check moderate permission or view permission - When hydrating ensure reviews are ordered by id desc. Should mimic the created_at desc * fix moderation review banner tooltip offset * disable verification button when already verified * rmv iconOnly prop because it seems to do nothing * update getLatestModerationReview to rely on most_recent boolean * Return 400 on invalid status to post /moderation-review the schema was using keywords on the left hand side rather than the symbols. Required a change to the docstring generator, when it made a docstring for enums, it would call (sort (:vs enum)) and need to string em. * Add ModerationReview model to models.clj and copy infra * hydrate moderation reviews on cards * clean up + wire up to BE + ensure mod buttons don't show for normal users * rmv unused moderation redux logic from QuestionDetailsSidebarPanel * finish writing unit tests for FE * ensure getIconForReview returns an object * enable/disable verify button tooltip when unverified/verified * add e2e tests * fix tests * styling tweaks * more styling on moderationReviewBanner * add function for abbreviated timestamp * increase fontsize of timestamp back to 12 * fix tooltip offset * ensure custom locale is separate from 'en' and not used for other languages * Deletion moderation reviews when deleting cards i had actually thought this was a much larger problem. But it turns out we almost never delete cards (thanks comment!). And so we won't really generate a lot of garbage. I was worried that since we aren't using actual foreign keys but just `moderated_item_type "card"` and `moderated_item_id 2` we would have deleted cards with these moderation reviews but that is not the case as the cards aren't deleted. * hide verify disabled button when a question is verified * update test to use queryByTestId * Hydrate moderation reviews on cards on ordered cards * Handle mysql's lack of offset functionality mysql cannot handle just a `offset` clause, it also needs a limit clause grammar from https://dev.mysql.com/doc/refman/8.0/en/select.html: [LIMIT {[offset,] row_count | row_count OFFSET offset}] select id, name from metabase_field offset 5; -- errors select id, name from metabase_field limit 2 offset 5; -- works Since our numbers are so small here there is no worry and just do the offset in memory rather than jump through hoops for different dbs. * Batch hydrate moderation reviews * Don't let /api/user/:userId failure conceal moderation banner * fix moderation cy tests * work around possible bug in toucan hydration dashboards hydrate ordered cards (hydrate [:ordered_cards [:card :moderation_reviews] :series]) Ordered_cards are dashboard_cards which have an optional card_id. But toucan hydration doesn't filter out the nils as they go down. It seems toucan returns a nil card, and then when hydrating the moderation_review, passes the collection of all "cards" including the nil ones into the hydration function for moderation_reviews This feels like a bug to me * Cleanup moderation warnings * Docstring in moderation review * include hoisted moderated_status on cards in collections api * Expect unverified in test
Co-authored-by:dan sutton <dan@dpsutton.com> Co-authored-by:
Maz Ameli <maz@metabase.com> Co-authored-by:
alxnddr <alxnddr@gmail.com>
-
Dalton authored
* Handle mutation of vizSetting column when syncing columns of a native question When calling Question's _syncNativeQuerySettings method we need to treat existing, mutated columns as invalid so that they are filtered out and a new column takes the existing column's place. The function we use to find valid columns, findColumnIndexForColumnSetting, will return true if it finds a matching field_ref OR a matching name, so we also need to check the addedColumns array we just created in order to remove any columns from vizSettings that also exist there, since we combine the two at the end of this method. * add unit tests for _syncNativeQuerySettings
-
Nemanja Glumac authored
* Remove `yarn start` script * Remove `lein docstring-checker` and `lein-bikeshed` scripts * Update `lein` references in `ci-backend` script
-
Luis Paolini authored
* Intermediate commit * Add the step to include .platform dir into the bundle
-
- Aug 02, 2021
-
-
Alexander Lesnenko authored
-
Gustavo Saiani authored
-