This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 18, 2024
-
-
Jeff Bruemmer authored
-
Chris Truter authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Nemanja Glumac authored
-
Ryan Laurie authored
-
Tim Macdonald authored
Include cards from the root collection in the Query Validator Tool [Fixes #45756]
-
Case Nelson authored
* tests for drivers with spaces in their identifiers * Add driver feature * Fix tests * Remove ambiguous alias for sqlite * Try to fix bigquery and sqlite tests not seeing left-join support * Add explicit support for left-join because of foreign-keys during test hacks * Handle left-join support weirdness * Fix test
-
Nemanja Glumac authored
-
Uladzimir Havenchyk authored
* Remove flakiness from e2e repro * add to flaky group anyway * add to flaky group anyway * fixup! add to flaky group anyway
-
Kamil Mielnik authored
-
Chris Truter authored
-
Anton Kulyk authored
* Fix falsy tabSelected/tabRenamed checks * Update URL management (WIP) * Fix tests failing because of whitespace changes * Fix tests failing because of parameter order * Use one hook for parameters and tab URL management * Fix tests failing because of parameter order * Fix test failing because of whitespace changes * Revert * Fix DashboardTabs tests * Fix tests failing because of parameter order * Fix test * Fix test failing because of whitespace changes * Remove unit tests that should be e2e tests now * Fix tab navigation * Fix string encoding/decoding * Revert test changes * Consistent question search params * Update DashboardTabs tests * Fix `SyncedParametersList` * Fix e2e tests * Fix nav usage * Fix types * Remove `useSyncedQueryString` * Fix test * Move slug utils to dashboard utils * Fix nav * Revert nav change * Fix e2e tests * Fix public/embedded dashboards, handle site url * Add repro test * Bring back and fix `PublicOrEmbeddedDashboardPage` tests * Move `SyncedParametersList` to qb
-
Nemanja Glumac authored
* Do not render if there is no time to format * Add a unit test * Render time if 0 * Simplify the logic with explicit check for `undefined`
-
github-automation-metabase authored
-
Kamil Mielnik authored
* Refactor EditoTabs - get rid of options prop - use named export * Remove unused data-testid * Remove redundant id and aria-labelledby * Remove redundant props spread * Bring back data-testid in use - Thanks VSCode for randomly showing me search results or not... * Fix navigation issue * Add a repro for first issue * Adjust EntityPickerModal root element so that it works with "be.visible" assertion in Cypress * Add a repro for second issue * Refactor tests - Fix not enough history entries issue * Change order of tests to start with simpler one * Fix invalid request issue * Add more assertions * Format code
-
Phoomparin Mano authored
* customize popover z-index * make popover z-index customizable * make the popover z-index customizable * add tests for popover z-index * also specify z-index for mantine popover
-
Cam Saul authored
* Reuse connection for test data loading & JDBC data loading overhaul * Revert silly change * Remove unneeded logic for recording which datasets are loaded or not-yet-loaded * Ok so I guess we do need the code to detect duplicate dataset loading after all * B I G improvements * Appease Kondo * Test fixes
* More test fixes * Fix dataset-already-loaded?-test * Fix test * Fix Presto JDBC and greatly improve test data load speed for it * Postgres test fix * Fix compilation errors * MySQL fixes * Fix syntax error * MySQL fixes * Implement `dataset-already-loaded?` for Athena and cache the set of existing databases * Fix Redshift * Fix Presto JDBC * Vertica test fix * Fix Oracle dataset-already-loaded? * Test fixes and parallelize some API tests. * Test fixes * Oracle test fix? * Another test fix * Stop putting random spaces in code bodies this is not JavaScript code * with-temp-vals-in-db should merge in original value of Database settings * The most test fixes * 3 or 4 test fixes * Add schemas around stuff to catch errors * Appease Kondo * Implement dataset-already-loaded? for vertica * Implement dataset-already-loaded? for SQLite and Snowflake
-
- Jul 17, 2024
-
-
Case Nelson authored
* [WIP] Testing driver filters * Only test returned values in CI * Add :uuid-type for dbs that support that type (test oracle's support) * Try again for oracle test, redshift does not support uuid-type * Add tests, support where available * Add empty/null tests * Adjust test query for athena * Reset logging * Fix comments * Add Athena uuid conversion * Address PR review * Add comments * Address PR comments * Use varchar for portability. Add inline uuid casting for athena --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Emmad Usmani authored
* fix tab actions not working in firefox * add e2e test * update e2e tests that need awaitRequest: false
-
Alexander Polyankin authored
-
Oreon Lothamer authored
* ephemeral pr envs on label
-
adam-james authored
* Field Filter Value Normalization in Embedding Endpoints Fixes 27643 Since we use query-params to pass paramter values, we have to normalize the parameter map values. This PR is a WIP, as I'm trying to find a way to do this hollistically/properly. First commit here is mostly as a marker for where to start working on this properly, as I think the json parsing won't catch all cases, nor should the normalization happen without some attempt to use a schema to properly validate, maybe even coerce things. * read strings if boolean or numbers, replace blank str with nil Also update the common dashboard param values fn to use embedding params from the URL blob if the app db doesn't have embedding params. This happens upon first preview where nothing will have been written to the Appdb yet. * Add query-param normalization test, add related embedding test * schema didn't work in this case after all. Worth a shot, but don't want this to block the PR, so reverting to the previous schema * Add comment pointing out the downsides/reasons for this solution It's nto a perfect solution, but it's probably the best we can get at the moment, without adding a new filter type (boolean) and/or improving the design of hte embedding endpoints and how filters/parameters work
-
John Swanson authored
When we run queries, we preprocess them, during which the sandboxing middleware adds information that we use when checking permissions later on in query processing. When we checked data permissions before saving a card, we were checking permissions on the raw query, without preprocessing. Without the data provided by the sandboxing middleware, the permission check sometimes failed (depending on the permissions for other tables in the DB). Note the big hack here: preprocessing can fail, for lots of reasons. This broke a *lot* of tests that were passing in invalid queries. If an exception occurs during preprocessing, we catch and just use the original query like we were before.
-
lbrdnk authored
* Fix deserialization of mongo native query string * Add test
-
Tim Macdonald authored
* Don't return duplicate cards in the Query Validator Tool [Fixes #45673]
-
Cam Saul authored
* Sync Snowflake `VARIANT` type as :type/SnowflakeVariant` * Test fix
-
Uladzimir Havenchyk authored
-
Alexander Polyankin authored
-
Nicolò Pretto authored
-
Ryan Laurie authored
* install before running script * freeze dat lockfile
-
Oleksandr Yakushev authored
-
Nicolò Pretto authored
-
Tim Macdonald authored
-
Ryan Laurie authored
-
Sloan Sparger authored
-
Nemanja Glumac authored
-
Mahatthana (Kelvin) Nomsawadi authored
* refactor: Simplify code (#44275) * Remove dead code * Remove values same as default options * Simplify hook API: Removing unused argument * review: Remove redundant code * Update look and feel copy (#44277) * Update static embed tab name * Update copies + rearrange settings * Use Mantine Select * Fix E2E tests by applying new copies * Fix unit tests * Fix more E2E tests * review: Add a comment on Mantine `value` quirk * Adjust spacing and relevant tests * Move `transparent` theme to its own toggle option (#44362) * Reorder the function to match the visual order * Make function name consistent * Introduce the new background option (do nothing yet) * Remove redundant exports * Tighten up values to reduce confusion * Make the parameters order consistent * Only show background option on dashboads (spec) * Allow dashboard embed background to be transparent * Make filter background and header/footer transparent * Fix type error * Fix unit tests * Fix E2E tests * Fix checkerboard pattern not showing when no background * Add unit tests * Add missing copy update * Remove remnants from outdated solutions within the PR * Improve code comment references * Fix E2E tests since the last copy change * Fix type errors from merging master * Update light theme style (#44488) * Add background to dashboard filter on light theme * Make position sticky works with transparent background * Fix sticky filters not working on theme=transparent * Fix unit tests * Simplify IntersectionObserver components + fix E2E tests * Add storybook for embedded dashboard * Clarify the use of ExplicitSize context * Remove unused code * Formatting * Review: Better mock `isWithinIframe` * Update dark theme to match the new design (#45134) * Update light theme checkerboard colors * Update checkerboard colors * Consolidate dashboard light/dark border style * Use `--mb-color-text-primary` for light theme dashboard * Update embed dashboard dark theme primary color * Migrate dashboard text-secondary color * Migrate text-tertiary color * Migrate gold, axis, and split line to CSS custom properties * Fix failed e2e tests * Fix static viz not working * Update loki snapshots * Remove unnecessary CSS custom property * Make diff more consistent * Address review: reusing type * Support backward compatibility when passing `theme=transparent` (#45214) * Match preview query with the actual code query * Handle backward compatibility when `theme=transparent` on dashboard * Add unit tests * Address review: Make tests less repetitive * Update Metabase banner upsell UI (#45424) * Prepare folder for nested components * Update upsell UI - add `fullWidth` variant - align title to the left * Fix Upsell banner having horizontal scroll on full width * Add new Metabase banner upsell component * Fix unit tests * Address review: Fix typo Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> * Address review: Move upsel UI to `admin/upsells` Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> * Remove unnecessary ESLint disable comment We can remove it since the file is in admin folder, and is already excluded from the rule. * Address review: remove default value property Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Address review: Extract magic number --------- Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * More UI updates (#45450) * Update dark theme text colors to match the new design * Update powered by metabase logo * Update loki snapshots * Fix unit tests * Fix formatting * Fix wrong dark theme metabase logo badge color * Address review: Compress SVG with svgo Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Fix E2E tests * Update loki snapshots * Clarify Metabase base colors with comments --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Add more tests (#45628) * Add static embed question stories * Add loki snapshots * Add transparent theme for static dashboard tests * Add transparent theme tests for static questions * Assert `background` option in analytics tests * Remove tests for logic that has been moved * Update loki snapshots * Fix failed E2E tests from merging master --------- Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Kamil Mielnik authored
* Refactor EditoTabs - get rid of options prop - use named export * Remove unused data-testid * Remove redundant id and aria-labelledby * Remove redundant props spread * Bring back data-testid in use - Thanks VSCode for randomly showing me search results or not...
-
Raphael Krut-Landau authored
This also makes collections tabbable No longer skip e2e test: "scenarios > collections > trash > should open only one context menu at a time"
-