Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 27, 2024
  2. Aug 26, 2024
  3. Aug 23, 2024
  4. Aug 22, 2024
  5. Aug 21, 2024
  6. Aug 20, 2024
  7. Aug 19, 2024
    • bryan's avatar
      Add no-access table-level and schema-level permission (#46542) · 2bbcf745
      bryan authored
      
      * allow `:blocked` to be saved for table level perms
      
      * Adds 2 tests for table level blocked permission settings
      
      - N.B. these are NOT ENFORCED YET
      
      * update test that asserted we cannot set block on tables (we can)
      
      * WIP: Pairing on making perms checking less wild
      
      * cleanup, update docs, and add a test for view-data perm only
      
      - Added a test where we have data permissions, but not create query, and
        I think it is failing when we have create query and blocked data
        permissions.
      - renamed some functions from check-x -> has-x? since they return a
        value instead of throwing now
      
      * Revert "WIP: Pairing on making perms checking less wild"
      
      Keep the same behavior, but stick with the saner flow control
      
      This reverts commit 63bcb5b4.
      
      * update docs
      
      * update test to be passing
      
      - TODO: make sure it's correct w.r.t. perm settings
      
      * Allow schema level blocked setting in permgraph
      
      * remove invalid test cases
      
      - continue to have a forcing function to test newly added perms
      
      * conform function output
      
      * ensure a single blocked table blocks native queries to its DB
      
      * update error message
      
      - we now catch this error in `metabase.models.query.permissions/has-perm-for-query?`
      
      * we now check for data permissions to process query for card
      
      * add more explanation to what we are testing
      
      - to help see why it fails on CI and passes locally
      
      * remove excess `def`
      
      * Add test for table-level data X collection perms
      
      - update test found to be in-error
      
      * update param values qp permission check style
      
      * set view-data and create-query explicitly
      
      * set viewdata and createquery explicitly in qp test
      
      * Respond to review comments (which fixes a case)
      
      * setting a table to blocked: leave other tables the same
      
      * [Permissions] Add "No access" schema/table permission (#46509)
      
      * first pass
      
      * refactors downgrading native permission logic and updates calculation so that "No access" downgrades native permissions to "No"
      
      * stub for permissions help info on table block
      
      * modal changes wip, updates downgrading create queries permissions to all happen at a single call site
      
      * clean up, sandboxing modal copy changes, removes rekoke/limit access modal changes to make the diff smaller and move code to a seperate PR
      
      * updates permissions help section to contain the final copy
      
      * sandboxing copy fix and remove modal that was dropped from requirements
      
      * adds blocked at the schema level, updates no access copy to blocked, updates permissions help section to contain new blocked and schema level changes
      
      * fixes failed unit and e2e tests after sandboxing copy changes
      
      * improve the block e2e test to include table blocking
      
      * fixes failing blocked test, fixes other schemas create queries permissions getting correct with one schema was droped to blocked view data access, fixes a bug that prevents the save bar from going away when all permissions for group are set to the default values
      
      * clean up
      
      * remove color changes
      
      * prevents parent being set to blocked preventing edits for children entities
      
      * add new hasPermissionValueInSubgraph fn, adds modal to warn users we have to upgrade the view data permissions when they upgrade create queries permissions when a child entity is set to blocked
      
      * adds test coverage for new modal
      
      * removes unused function, adds new updateEntityPermission fn to help consolidate some logic elsewhere
      
      * unit test fix and type fix
      
      * most pr feedback
      
      * updates the confirmation modal copy when changing a parent entity that contains a child with blocked permissions and/or sandboxed children, adds test coverage for that, adds test coverage for permission view data column not appearing in oss
      
      * type fix
      
      * [Permissions] Add e2e test coverage for blocked permissions enforcements (#46663)
      
      * adds test coverage for enforcement of blocked permissions
      
      * moves tests around based on pr feedback
      
      * copy changes
      
      * adds fix to make sure that blocked permissions are not removed from sibling tables that have the create queries permissions upgraded (#46854)
      
      * Fix table name lookup for dbs w/ 1 schema per db
      
      * add test for blank schema identifiers
      
      * Refine sandboxed user perms for query builder access (#46939)
      
      * Refine sandboxed user perms for query builder access
      
      - Limit create-queries permissions to unblocked tables only
      - Check user permissions for each table before granting query builder access
      - Prevent querying of blocked joined tables from query builder for sandboxed users
      
      * Adjust permissions for sandboxed users
      
      - Grant view-data permissions only for unblocked tables
      - Revert create-queries permissions to all tables in sandbox
      - Remove unnecessary intermediate variable
      
      * when sandboxing we no longer grant unrestricted view perms for blocked tables
      
      * Update enterprise/backend/src/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions.clj
      
      remove blank line
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * - make coalesce-test exhaustive (except for sandbox)
      
      * Update enterprise/backend/src/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions.clj
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * t2/select ... -> database/table-id->database-id
      
      * update comment
      
      * [Permissions] Prevent "Granular" option in DB View Data options from changing permissions to unrestricted (#46976)
      
      * fix
      
      * adds back most of the code and limits it to only happen with impersonations, updates test to handle differing logic between the two flows
      
      * removes test that is not longer needed
      
      * more sandbox join table perms tests
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@users.noreply.github.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@gmail.com>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Unverified
      2bbcf745
    • Nemanja Glumac's avatar
      tech: Remove the last GoogleAnalytics tracking bits and references (#46980) · 2899046d
      Nemanja Glumac authored
      * Remove simple references to `trackStructEvent`
      
      * Remove `withAnalytics` entities helper
      
      * Remove `trackLoginSSO`
      
      * Remove auth trackers
      
      * Remove permissions trackers
      
      * Remove performance trackers
      
      * Remove settings trackers
      
      * Remove pulse trackers
      
      * Remove undo trackers
      
      * Remove click actions trackers
      
      * Remove `trackStructEvent`
      
      * Remove GoogleAnalytics from the server security middleware
      
      * Remove GoogleAnalytics from Kondo config
      
      * Fix type failures
      
      * Revert "Remove GoogleAnalytics from Kondo config"
      
      This reverts commit 363557c4.
      Unverified
      2899046d
    • Ryan Laurie's avatar
      Remove unnecessary calls to `/api/collection` (#46752) · c78b46d6
      Ryan Laurie authored
      * use ee api to find custom reports collection
      
      * remove deprecated hook
      
      * fix race condition
      
      * add unit tests
      
      * fix circular dependency
      
      * fix unit tests
      
      * another plugin strategy
      Unverified
      c78b46d6
  8. Aug 16, 2024
  9. Aug 15, 2024
  10. Aug 14, 2024
    • Nicolò Pretto's avatar
    • Phoomparin Mano's avatar
      fix(sdk): optimistic update query builder and update questions in notebook (#46652) · 3df927c9
      Phoomparin Mano authored
      
      * update question state
      
      * update question state
      
      * reload metadata for runQuestionOnNavigate
      
      * fix runnable queries
      
      * fix cannot run question
      
      * extract question predicate functions to question.ts
      
      * update types
      
      * create utils subfolder for query builder
      
      * fix query builder predicate imports
      
      * naming tweaks to be more self-explanatory
      
      * document the non-intuitive loadQuestion useEffect
      
      * change imports to support metric
      
      * remove unused import
      
      * revert originalQuestion check to try to fix e2e failures
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      Unverified
      3df927c9
    • Romeo Van Snick's avatar
      Automatically select offset breakout or move it to the front (#46573) · 9fa749d6
      Romeo Van Snick authored
      * Add defaultTemporalBucket helper
      
      * Add helper to pick default breakout
      
      * Move breakout to the front or add one if it does not exist
      
      * Add updateQuery to AggregationPicker props
      
      * Add tests for creation and reordering of temporal breakouts
      
      * Reuse defaultTemporalBucket in withDefaultTemporalBucket
      
      * Reorder query operations to make sure the correct names get generated
      
      * Remove dependency on referential equality of breakout
      
      * Rename updateQuery to onQueryChange
      
      * Remove onAddAggregations and onUpdateAggregation for onQueryChange
      
      * Extract query update in to separate function
      
      * Remove on{Add,Update,Remove}Aggregation in favor of onQueryChange
      
      * Remove aggregations from summarize details
      
      * Fix e2e tests
      
      * Remove conflicting test
      
      * Fix recent clause in unit tests
      
      * Fix superflouous check for columnAndBucket
      
      * Future proof breakout check
      
      * Remove reliance on details in the useSummarize hook
      
      * Remove details in unit tests
      
      * Removal of default summarization should not trigger a query change
      Unverified
      9fa749d6
Loading