This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 23, 2021
-
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Aug 21, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Aug 20, 2021
-
-
Jeff Evans authored
* Fix serialization dump error when there are no collections Update `select-collections` to correctly handle the case where there are no collections Adding new test that removes all collections, then ensures that dump works with no errors * Fix serialization load error into empty/blank target DB Rethrowing exception in cmd when overall load fails Add test to ensure that a dump containing a user can be loaded into a blank target app DB successfully Adding a few missing bindings to the `with-temp-empty-app-db` code to set the connection vars under metabase.db.connection In upsert, add hooks for a :pre-insert-fn and :post-insert-fn to be invoked for new entity instances created by the upsert process, since whether an entity will be an insert or update isn't necessarily known by the load process (only by upsert once identity-condition is checked for each) In load, setting the pre and post insert functions for a User instance to initialize :password with a random value, and to generate and send a password reset email to the newly inserted user's email, respectively NOTE: this post insert fn (to send a password reset email for newly inserted users) is NOT hooked up for User as of x.41 release, since it is considered a bugfix, but this can be enabled in a future release) Adding new defs for the magic permission group names to make those easier to override from tests that might need to (such as the one added for this commit) * Fix serialization objects being incorrectly updated on skip Remove `maybe-fixup-card-template-ids!`, which was forcing mode :update, since the existing retry logic should cover what it was trying to do Update Card and Metric models to delete any Dependency instances for which they are the `:model_id` (to make serialization tests after other tests created temporary Card/Dependency pairs) Adding missing assertions for Dependency serialization * Serialization: Fix reload entity logic Now that the `:mode` is always respected instead of being ignored sometimes, we need to update our "second pass" reload functions to always make the mode `:update` on the second pass, or else that entity would just be skipped, which is bad Also updated the test to use `:mode` `:skip` from the beginning to be more stringent
-
Dalton authored
* refactor/move parameter object transformations to one place * use hasParameterValue in place of nil check * remove enableDefaultParameters arg since it is unused
-
Gustavo Saiani authored
-
Jeff Evans authored
New BigQuery Driver Create new :bigquery-cloud-sdk driver using the google-cloud-bigquery library instead, and whose source is adapted from the :bigquery driver https://cloud.google.com/bigquery/docs/reference/libraries Marking existing :bigquery driver as deprecated, and superseded-by the new one (bigquery-cloud-sdk) Update new driver and query processor code to use newer Google SDK Switch test data loading over to use new API Add project-id connection property to override the value from the service account JSON, and use it as part of qualified names in the query processor if set Updating google driver so its libraries are compatible with the newer ones used in BigQuery Update date bucketing tests to skip :bigquery-cloud-sdk (new driver) where :bigquery is skipped Update `with-bigquery-fks` to take in the driver, since there are now multiple ones Adding test to confirm that overriding project-id for a public BQ project works (sync and query) Fixing a bunch of whitespace alignment errors in tests
-
Ariya Hidayat authored
Type inference can already correctly infer those return types, no need to explicit anymore.
-
Ariya Hidayat authored
-
Nemanja Glumac authored
* Update `dashboard` custom Cypress command * Update composite custom commands to accommodate new syntax * Update tests that use `cy.createDashboard()` custom command * Update default snapshot generator
-
- Aug 19, 2021
-
-
Anton Kulyk authored
-
Dalton authored
* don't prefetch data for the data selector * rmv prefetch cy test * fix mongo test
-
Alexander Lesnenko authored
* replace backport label with a more flexible backport command * fix backport bot command
-
Ariya Hidayat authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Remove not displayed NotebookCell's 'icon` prop * Refactor NotebookCell to accent `right` prop * Fix cypress getter * Fix icons opacity * Fix margins and paddings * Pass initialState to getStore test helper * Add basic tests for JoinStep * Test automatic join fields assignment * Add selectTable test helper * Fix private property access * Add join fields tests * Test join is correctly applied to query * Add more tests for join dimension pickers * Test selecting joined table columns * Disable failing JoinStep test (jest timeout) * Extend timeout for JoinStep tests
-
Alexander Lesnenko authored
-
- Aug 18, 2021
-
-
dpsutton authored
-
Nemanja Glumac authored
-
Jeff Bruemmer authored
-
Ariya Hidayat authored
Regression in PR #17460
-
Anton Kulyk authored
* Add tooltips to authority level configs * Use tooltips for CollectionAuthorityLevelIcon * Pass tooltips to getCollectionIcon result * Display tooltip in CollectionHeader * Display tooltip in collections sidebar * Display tooltip on the homepage * Display tooltip in ItemPicker * Accept icon props as a TreeNode's icon prop value * Display tooltip in saved question picker * Accept icon props as a SelectListItem's icon prop value * Display tooltip in dashboard's question picker * Add "Belongs to an Official collection" tooltip * Fix prop-types errors * Add tests for CollectionAuthorityLevelIcon * Add tests for isRegularCollection * Fix search results collection icons * Show "Official Collection" label in search results * Don't show tooltips for official collections in search * Fix ItemPicker's prop type * Add basic test for ItemPicker * Test read-only collections are not displayed * Add test IDs to ItemPicker * Refresh Redux store in each ItemPicker's test * Test opening a nested collection * Test default breadcrumbs state * Fix ItemPicker's header test ID * Test ItemPicker read-only items visibility * Add test for onChange prop * Test navigating back from an open collection * Test personal collections are grouped in ItemPicker * Assert number of ItemPicker items * Test getCollectionIcon in EE * Add a workaround for tooltip offsets * Add describe block for CollectionsList tests * Make CollectionsList test shorter * Test collection types on CollectionList * Fix SearchResult's info * Add SearchResult tests * Use isRegularCollection for AuthorityLevelIcon
-
Ariya Hidayat authored
codecov patch calculation is incorrect. Thus, let's rely only on the whole-project calculation and threshold (which is working fine).
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Refactor and dry up `question` custom Cypress commands * Example of `loadMetadata` custom option in action * Example of `visitQuestion` custom option in action * Annotate functions using JSDoc
-
- Aug 17, 2021
-
-
Cam Saul authored
* Help avoid the .lein-env gotchas * Learn to spell @camsaul * Revert the .gitignore change -- too D A N G E R O U S * Fix version numbers (thanks @jeff303)
-
Cam Saul authored
Ensure Setting :default values match the Setting :type; fix user-facing-value for calculated Settings. Cleanup & extra tests for email settings (#17442) * Change of plans. get-string (etc) only return default if it matches the type * Better docstrings * More tests & rework the validate-default-value logic a bit. * Fix lint error * Add an additional test for GET /api/setting * Consolidate exception-chain util functions * Email error message humanization improvements * More tests for util ex-chain * Clean up email error handling and add lots of extra tests * Fix docstring indentation * Even more email tests * Test fixes
* Update Cypress test again * Code cleanup -
dpsutton authored
* Backend SVG rendering proof of concept [ci skip] * Update cssbox to 5.0.0 * Render bar, line, and pie charts in js to svg sparkline is now done in js, bar is now recognized and done in js, new :categorical/donut as well * Remove api route for render * pass along render-type, not hardcoded to :inline * Move bar chart above sparkline and remove line check In order to introduce the bar chart type need it above the sparkline check since it is otherwise the same except for display property of the card. But lots of tests assume that this will get hit with a nil display type set in testing so remove checking for `:line` allows all the testing cases to hit the right type * Fix tests now that bar graphs aren't html but images * Include attachments for bar charts * Move over to in-tree bundle * Force everything [ci noskip] trying to ensure that the built jar includes the newer "resources/frontend_client/app/dist/lib-static-viz.bundle.js" * Run `yarn build-static-viz` in backend-deps in CI this js file is now a hard dependency of the backend so it fits in this tsk. All such things that depend on the backend sources will need it. Makes me think perhaps we want a checked in version but i'm not sure yet. * Look on classpath not filesystem for js bundle [ci noskip] * Move yarn build-static-viz into the checkout step * License information for antlr4-runtime * create attachment for categorical donuts * add ordinal legend to donuts (#17177) * set widths of html image and svg image to 1200 * Revert "add ordinal legend to donuts (#17177)" This reverts commit 1eb81d2e. * Helper functions to render html easily * readme in dev * readme ensure that static viz bundle exists * Cleanup ns after removing proxy * Donut chart colors and legend (#17251) * use external color map for fill per dimension * Add support new color legend for donut * Ensure text doesn't appear as link entire thing is actually the body of a link tag for emails but we want a decent text color rather than a default link color * use chart colors from https://stats.metabase.com/_internal/colors * Make checkers happy - remove unused imports - add a docstring - don't shadow fn with a local * cleanup ns import * Remove reflective call * Cleanup ns on correct branch Co-authored-by:
dan sutton <dan@dpsutton.com> * X-axis: just use (approx) 5 ticks to avoid overlapping labels (#17287) * increase gap between arcs (#17271) * Set rendering hints on html->image * ignore width for now and make them larger * Ns deprecation and some cleanup * make namespace checker happy * Simple tests for detecting chart type * Rename from poc * Tests for scalar/smartscalar * cleanup js svg namespace a bit * Tests of svg engine * ns sorting after renaming * Unify our two different js engine usages settled on the js context. Has typed returns `(.asString ^Value ...)` instead of perhaps capturing std out? https://www.graalvm.org/sdk/javadoc/org/graalvm/polyglot/Value.html Context is a bit more friendly for getting source into it. One downside is that the invocable bit isn't quite as nice. The old way would return a java.util.functionFunction but the difference is (.apply function (object-array args)) vs (.execute fn-ref (object-array args)) * Don't io/resource the io/resource * js engine tests * Ns cleanup in js-svg type hints in the js-engine ns mean we don't need as many classes from polyglot here * Include percentages in rendered donut charts * Testing for percentages Co-authored-by:
Cam Saul <github@camsaul.com> Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com> Co-authored-by:
Ariya Hidayat <ariya@metabase.com>
-
Kyle Doherty authored
* Backend SVG rendering proof of concept [ci skip] * Update cssbox to 5.0.0 * Render bar, line, and pie charts in js to svg sparkline is now done in js, bar is now recognized and done in js, new :categorical/donut as well * Remove api route for render * pass along render-type, not hardcoded to :inline * Move bar chart above sparkline and remove line check In order to introduce the bar chart type need it above the sparkline check since it is otherwise the same except for display property of the card. But lots of tests assume that this will get hit with a nil display type set in testing so remove checking for `:line` allows all the testing cases to hit the right type * Fix tests now that bar graphs aren't html but images * Include attachments for bar charts * Move over to in-tree bundle * Force everything [ci noskip] trying to ensure that the built jar includes the newer "resources/frontend_client/app/dist/lib-static-viz.bundle.js" * Run `yarn build-static-viz` in backend-deps in CI this js file is now a hard dependency of the backend so it fits in this tsk. All such things that depend on the backend sources will need it. Makes me think perhaps we want a checked in version but i'm not sure yet. * Look on classpath not filesystem for js bundle [ci noskip] * Move yarn build-static-viz into the checkout step * License information for antlr4-runtime * create attachment for categorical donuts * add ordinal legend to donuts (#17177) * set widths of html image and svg image to 1200 * Revert "add ordinal legend to donuts (#17177)" This reverts commit 1eb81d2e. * Helper functions to render html easily * readme in dev * readme ensure that static viz bundle exists * Cleanup ns after removing proxy * Donut chart colors and legend (#17251) * use external color map for fill per dimension * Add support new color legend for donut * Ensure text doesn't appear as link entire thing is actually the body of a link tag for emails but we want a decent text color rather than a default link color * use chart colors from https://stats.metabase.com/_internal/colors * Make checkers happy - remove unused imports - add a docstring - don't shadow fn with a local * cleanup ns import * Remove reflective call * Cleanup ns on correct branch Co-authored-by:
dan sutton <dan@dpsutton.com> * X-axis: just use (approx) 5 ticks to avoid overlapping labels (#17287) * increase gap between arcs (#17271) * Set rendering hints on html->image * ignore width for now and make them larger * Ns deprecation and some cleanup * make namespace checker happy * Simple tests for detecting chart type * Rename from poc * Tests for scalar/smartscalar * cleanup js svg namespace a bit * Tests of svg engine * ns sorting after renaming * Unify our two different js engine usages settled on the js context. Has typed returns `(.asString ^Value ...)` instead of perhaps capturing std out? https://www.graalvm.org/sdk/javadoc/org/graalvm/polyglot/Value.html Context is a bit more friendly for getting source into it. One downside is that the invocable bit isn't quite as nice. The old way would return a java.util.functionFunction but the difference is (.apply function (object-array args)) vs (.execute fn-ref (object-array args)) * Don't io/resource the io/resource * js engine tests * Ns cleanup in js-svg type hints in the js-engine ns mean we don't need as many classes from polyglot here * add custom labels * clean up margin * Include labels in backend * alignment Co-authored-by:
Cam Saul <github@camsaul.com> Co-authored-by:
dan sutton <dan@dpsutton.com> Co-authored-by:
Ariya Hidayat <ariya@metabase.com>
-
Jeff Bruemmer authored
-
Cam Saul authored
* Backend SVG rendering proof of concept [ci skip] * Update cssbox to 5.0.0 * Render bar, line, and pie charts in js to svg sparkline is now done in js, bar is now recognized and done in js, new :categorical/donut as well * Remove api route for render * pass along render-type, not hardcoded to :inline * Move bar chart above sparkline and remove line check In order to introduce the bar chart type need it above the sparkline check since it is otherwise the same except for display property of the card. But lots of tests assume that this will get hit with a nil display type set in testing so remove checking for `:line` allows all the testing cases to hit the right type * Fix tests now that bar graphs aren't html but images * Include attachments for bar charts * Move over to in-tree bundle * Force everything [ci noskip] trying to ensure that the built jar includes the newer "resources/frontend_client/app/dist/lib-static-viz.bundle.js" * Run `yarn build-static-viz` in backend-deps in CI this js file is now a hard dependency of the backend so it fits in this tsk. All such things that depend on the backend sources will need it. Makes me think perhaps we want a checked in version but i'm not sure yet. * Look on classpath not filesystem for js bundle [ci noskip] * Move yarn build-static-viz into the checkout step * License information for antlr4-runtime * create attachment for categorical donuts * add ordinal legend to donuts (#17177) * set widths of html image and svg image to 1200 * Revert "add ordinal legend to donuts (#17177)" This reverts commit 1eb81d2e. * Helper functions to render html easily * readme in dev * readme ensure that static viz bundle exists * Cleanup ns after removing proxy * Donut chart colors and legend (#17251) * use external color map for fill per dimension * Add support new color legend for donut * Ensure text doesn't appear as link entire thing is actually the body of a link tag for emails but we want a decent text color rather than a default link color * use chart colors from https://stats.metabase.com/_internal/colors * Make checkers happy - remove unused imports - add a docstring - don't shadow fn with a local * cleanup ns import * Remove reflective call * Cleanup ns on correct branch Co-authored-by:
dan sutton <dan@dpsutton.com> * X-axis: just use (approx) 5 ticks to avoid overlapping labels (#17287) * increase gap between arcs (#17271) * Set rendering hints on html->image * ignore width for now and make them larger * Ns deprecation and some cleanup * make namespace checker happy * Simple tests for detecting chart type * Rename from poc * Tests for scalar/smartscalar * cleanup js svg namespace a bit * Tests of svg engine * ns sorting after renaming * Unify our two different js engine usages settled on the js context. Has typed returns `(.asString ^Value ...)` instead of perhaps capturing std out? https://www.graalvm.org/sdk/javadoc/org/graalvm/polyglot/Value.html Context is a bit more friendly for getting source into it. One downside is that the invocable bit isn't quite as nice. The old way would return a java.util.functionFunction but the difference is (.apply function (object-array args)) vs (.execute fn-ref (object-array args)) * Don't io/resource the io/resource * js engine tests * Ns cleanup in js-svg type hints in the js-engine ns mean we don't need as many classes from polyglot here * Cleanup of text, ns docstrings, alignment * Fix fill->fill-opacity with parsed doc, not regex * Make a single helper that loads a static viz bundle context * Docstrings and make private in js-svg * Sort imported classes in js-svg * Make width passed down through rendering aparatus - svgs are always rendered at 1200 for quality - slack images of html are rendered at 1200 so that they can be zoomed in in the ui but slack automatically scales down - email sends html and the full svg but includes img width tags so that is handled appropriately * docstring Co-authored-by:
dan sutton <dan@dpsutton.com> Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com> Co-authored-by:
Ariya Hidayat <ariya@metabase.com>
-
Anton Kulyk authored
* Fix imports order * Extract JoinClausesContainer * Refactor JoinClause container element * Extract JoinTypePicker component * Refactor JoinStepPicker * Extract JoinTablePicker * Extract JoinedTableControlRoot * Extract label components * Extract RemoveJoinIcon * Add prop types * Turn JoinClause into func component, fix ref usage * Update notebook's step prop-types shape * Extract callbacks
-
Nemanja Glumac authored
#17450 Repro: New databases with "This is a large database ..." still uses the default sync+scan settings (#17476) * Add helper function to choose/select a database * Apply helper function to BigQuery and GA * Add repro for #17450
-
pawit-metabase authored
* upgrade to @percy/cypress 3.x @percy/cypress 2.x uses deprecated @percy/agent which includes an old version of puppeteer. The old version of puppeteer causes `yarn` command to fail on M1 macOS environment. Upgrade to @percy/cypress 3.x removes the dependency and thus solves the issue. The upgrade was done by running `npx @percy/migrate`. * remove percy healthcheck task This no longer exists in 3.x, see https://github.com/percy/percy-cypress/blob/master/README.md#upgrading * remove deprecated percy/exec-action and moved `percy exec` to the correct command * run 'yarn install' before running percy
-
- Aug 16, 2021
-
-
Cam Saul authored
* Enable clj-kondo warnings * (when (seq ...) ...) instead of (when-not (empty? ...) ...)
-
Ariya Hidayat authored
-
Nemanja Glumac authored
* Add "moderation" folder to e2e CI groups * fix question-moderation tests Co-authored-by:
Dalton Johnson <daltojohnso@users.noreply.github.com>
-
Jeff Evans authored
From 3.12.13 -> 3.13.6
-