This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 15, 2024
-
-
Alexander Solovyov authored
this lowers memory usage 100x for 50kb strings (our limit before this change) and speeds up parsing by an order of magnitude. For example, results for parsing 42kb string (already in memory): Before: Time per call: 6.32 ms Alloc per call: 8,732,850b After: Time per call: 55.16 us Alloc per call: 83,254b
-
Ngoc Khuat authored
An one time job to init send-pulse trigger and migration down to clean up send-pulse triggers (#42316) * Add a job to init send pulse trigger only once * Send pulse triggers should respect report timezone (#42502)
-
- May 14, 2024
-
-
Braden Shepherdson authored
Follow up to #42424. This enforces that all drills do not appear on native stages. Also fixes one more drill on top of the two in #42424 that were wrongly showing up for native queries.
-
Braden Shepherdson authored
- `:metadata/key-constraints` for those databases which formally track PK and FK key constraints. Some databases (eg. Presto/Athena/Starburst family) don't support constraints like that, but do support querying based on foreign keys (which is the `:foreign-keys` feature). - `:connection/multiple-databases` for databases where a single connection can connect to many databases. This is the case for Athena, since it connects to an S3 bucket and exposes all files in the bucket as databases through that single connection. - Also removed a troublesome "all DBs except a huge list" case in the SSH tunnel tests with a shorter list of supported drivers.
-
bryan authored
* handle recent view for non-existant entity * test that recent views works with missing entities - just doesn't return them. * dont count on there being entities in the app-db
-
Ngoc Khuat authored
-
Ngoc Khuat authored
-
- May 13, 2024
-
-
bryan authored
* wip * adds more collection-touch events * remove sneaky dep that slipped in * cleaning up, and adding tests * respond to review comments + mini bug reports * make it official * double official * cleanup + return recent-views/Item for `GET activity/popular_items` * get popular_items returning the proper shape * compare doesn't what I thought * add display_name to tables * table.database.name should be the db name, not the table name * add table.database.initial_sync_status * improve call to toucan2 * light renaming + many text fixes * include moderated_status in cards and datasets * look up Dashboard permissions for Dashboards * stop double-querying for `can-write?` checks - also include some debug logging * fix card <-> model dispatching also gets tests passing locally * let the test runner run the tests * fix gc test * adds description * description can be null * better tests no more nils passed through the app * debugging test * fix tests and skip archived * mysql finesse * ellide inactive tables * wip * adds more collection-touch events * remove sneaky dep that slipped in * cleaning up, and adding tests * respond to review comments + mini bug reports * make it official * double official * cleanup + return recent-views/Item for `GET activity/popular_items` * get popular_items returning the proper shape * compare doesn't what I thought * add display_name to tables * table.database.name should be the db name, not the table name * add table.database.initial_sync_status * improve call to toucan2 * light renaming + many text fixes * include moderated_status in cards and datasets * look up Dashboard permissions for Dashboards * stop double-querying for `can-write?` checks - also include some debug logging * fix card <-> model dispatching also gets tests passing locally * let the test runner run the tests * fix gc test * adds description * description can be null * better tests no more nils passed through the app * debugging test * fix tests and skip archived * mysql finesse * New Recents + Popular API Format - Frontend (#42305) * fix tests * new API payload format for recents and populars * update url generation * update recents components * update tests * only show 5 recents in command palette * remove unused types * update tests * obey the linter * type updates * fix unit test * change where we filter recents --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com> * fix modelToUrl types * respond to review comments * post merge test fix --------- Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
adam-james authored
* Don't use the slugify util for filenames * Fix tests that looked for incorrect filenames * add a test * fix filename in pulse test util
-
Noah Moss authored
-
Ngoc Khuat authored
-
Ngoc Khuat authored
-
- May 10, 2024
-
-
adam-james authored
* Format Rows toggle also applies to Column Names Fixes: #42500 When format-rows is false, we want to also pass that true/false value to the title column formatting. That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour in prior versions. * write a better test explanation
-
Braden Shepherdson authored
These params were failing to match. This matches them up and puts the options in the correct place. (`[:contains x y opts]` but `[:contains opts x y z]`).
-
Ngoc Khuat authored
-
Cam Saul authored
* Remove unused `metabase.api.transform` * Copy the deps graph improvements from my other PR * New combined X-Rays API namespace * Fix kondo error
-
Cal Herries authored
-
- May 09, 2024
-
-
Ngoc Khuat authored
-
Braden Shepherdson authored
-
Ngoc Khuat authored
-
- May 08, 2024
-
-
Cam Saul authored
* Cam's module linter 5000 * Get Kondo passing * Revert changes to usage of mdb.setup/setup-db! * Check ns shapes * Add ns :require shape linter; PR feedback * Linter fixes
-
Noah Moss authored
-
adam-james authored
* Dashboard Param Values Common Impl for Embedding/Preview Embedding Refactor the embedding api namespace to allow a bit of reuse between the embedding api and the embedding preview api. In some cases, the implementations are not identical (in terms of the shape of data expected/endpoints available), so this is a first step to making them the same. Related: https://www.notion.so/metabase/Make-embedding-preview-behave-consistently-with-actual-static-embeds-855353d8e5e8411d8164c7ac563c7d2f * Add a test to verify that preview-embed param-values endpoint works * Use preview embed endpoint and fix relevant tests * Add tests * Change name to reflect what actually happens in the function --------- Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
Cal Herries authored
-
Alexander Solovyov authored
-
- May 07, 2024
-
-
Cam Saul authored
* Don't optimize [:between <expr w/ :default bucketing> <relative-datetime> ...] filters * Update tests
-
Cam Saul authored
* Only nest expressions referenced in breakouts or aggregations * Support Offset() as expression with no breakouts * Test fixes
* Oracle test update * Improved Oracle test * Test update * Fix busted test * Fix running and saving Offset over the REST API * Remove stray :wow * More test fixes -
Cam Saul authored
* Only nest expressions referenced in breakouts or aggregations * Test fixes
* Oracle test update * Improved Oracle test -
Ngoc Khuat authored
-
- May 06, 2024
-
-
John Swanson authored
-
Cal Herries authored
-
- May 05, 2024
-
-
lbrdnk authored
-
- May 03, 2024
-
-
John Swanson authored
For dashboards and cards/models only.
-
Nicolò Pretto authored
* use css modules instead of inline styles for cursor: default (#41644) * add toast notification after the feedback (#41575) * fix modal submit sending data while button says skip (#41784) * fix: it should not send the feedback if button says skip * add comment explaining why we check that getLastFeedbackCall() is undefined * embedding homepage analytics (#41725) * rename defaultTab -> initialTab * add events schema for embedding-homepage * fix stories * add analytics, e2e tests and fix typo in dismiss reason * copy embed_flow schema for better diff in the next commit * adds isExampleDashboard to trackStaticEmbedPublished * utm tags * fix bug of is_example_dashboard * better test names * refactor embed homepage status type * "() => {}" => "_.noop" * add "Setup embedding" to the admin setup checklist (#41638) * add setup embedding to the admin setup checklist * restore whitespace as it was before * i miss prettier (whitespace again) * Clean up check list for embedding Largely making a new entry for the embedding info just to fight long lines. `:embedding-homepage-dismissed-as-done` just made the maps really long. If we have a `:done?` under an `:embedding` keyword it reads much more naturally. Also, The previous diff was calling `boolean` on a var rather than invoking the var: ```clojure :embedding-app-origin (boolean embed.settings/embedding-app-origin) ;; ^^^^^^^^^^^^^^ needs to be (invoked) ``` --------- Co-authored-by:
dan sutton <dan@dpsutton.com> * Change utm tags for embedding homepage links (#42042) * update utm tags * utm_media -> utm_content * add description to the checklist setup step (#42200) --------- Co-authored-by:
dan sutton <dan@dpsutton.com>
-
Braden Shepherdson authored
The API/model schemas for dashboard parameters are general enough that they just work for this new type, which doesn't look very different from a value parameter right now. Part of #42118.
-
Cam Saul authored
MLv2: Simplify MetadataProvider protocols (16 methods/3 protocols => 7 methods/2 protocols) (#42070) * Simplified MetadataProvider protocol * Test fix * Ok make CachedMetadataProvider a separate schema again after all. * Consolidate the Metadata schemas * Clean Kondo warnings * Malli-ify the stuff in metabase.lib.metadata.protocols * Fix Kondo warnings * Test fix
* PR feedback
-
- May 02, 2024
-
-
Cam Saul authored
* Fix LgeacyMetric/Segment macroexpansion with definitions using ancient MBQL 2 * Remove stray println * PR feedback
-
Cam Saul authored
* Window functions should use all breakouts except first for partitioning * Update the offset() test * Update tests * Rework how we use driver escape-alias in MLv2; fix Oracle * PR feedback * Test fixes
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
This is a new parameter `:type` (and `:widget-type`) to choose a time granularity (a `:temporal-unit`, eg. `month`, `day`, `day-of-week`) which should replace the unit on the target field for the parameter. The target field should be a breakout with a temporal type (date, datetime) that's compatible with the input unit. The value of the parameter should be a string or keyword naming one of the units: `"month"`, `:month`. Part of #42118.
-