This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Dec 10, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
github-automation-metabase authored
* wip next sdk compat * better code generation, dts works * Last line of file should end in a newline character * feat(sdk): make MetabaseProvider not break ssr * aUpdate enterprise/frontend/src/embedding-sdk/package.template.json * address pr comments * refactor(sdk): use relative paths when fixing d.ts files * make types work on moduleResolution: node * add loading text * fix(sdk): #50736 make sure we don't break the host app if a sdk component is rendered outside of the provider for a render * fix: this should make types work for real? * self review fixes * update test for PublicComponentWrapper * Update enterprise/frontend/src/embedding-sdk/components/private/PublicComponentWrapper/PublicComponentWrapper.tsx * remove unused component * eslint-disable-next-line for MetabaseProvider * list tsx as dependency * /next -> /nextjs --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
- Dec 04, 2024
-
-
github-automation-metabase authored
* add style and className to static dashboards * unify props for static and interactive Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
- Dec 03, 2024
-
-
github-automation-metabase authored
* rename onClose to onCancel * rename questionHeight to drillThroughQuestionHeight * rename showVisualizationSelector to withVisualizationSelector * rename parameter value props * doc updates for parameter values * rename the chart type selector prop * document the withChartTypeSelector prop Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
github-automation-metabase authored
* add tests for css rules not scoped to the sdk * fix(sdk): adds mb-wrapper class and scope css to it * fix typo * add .mb-wrapper to the body on storybook diff --git a/.storybook/preview.tsx b/.storybook/preview.tsx index 52a0d45125d..a4b3a86f4a5 100644 --- a/.storybook/preview.tsx +++ b/.storybook/preview.tsx @@ -42,15 +42,20 @@ const globalStyles = css` export const decorators = isEmbeddingSDK ? [] // No decorators for Embedding SDK stories, as we want to simulate real use cases : [ - renderStory => ( - <EmotionCacheProvider> - <ThemeProvider> - <Global styles={globalStyles} /> - <CssVariables /> - {renderStory()} - </ThemeProvider> - </EmotionCacheProvider> - ), + renderStory => { + if (!document.body.classList.contains("mb-wrapper")) { + document.body.classList.add("mb-wrapper"); + } + return ( + <EmotionCacheProvider> + <ThemeProvider> + <Global styles={globalStyles} /> + <CssVariables /> + {renderStory()} + </ThemeProvider> + </EmotionCacheProvider> + ); + }, ]; function CssVariables() { Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
github-automation-metabase authored
* add withVisualizationSelector prop * add tests * add to docs * use default layout in tests * only use custom layout when needed * make withChartTypeSelector false by default Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
- Nov 29, 2024
-
-
github-automation-metabase authored
feat(sdk): use string types for specifying entity ids instead of internal nanoid type (#50663) (#50704) Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
- Nov 27, 2024
-
-
github-automation-metabase authored
* add background-inverse color mapping * add tooltip themes * tooltip theming * apply to echarts tooltip * update tooltip default color * update tooltip defaults * add sdk color mapping * add additional theme colors * add echarts tooltip story * add loki tests * remove background-inverse theme color option * add to docs * use ChartTooltipRoot for story and update loki snapshot * update secondaryTextColor docstring * fix unit tests Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
github-automation-metabase authored
--------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 25, 2024
-
-
Phoomparin Mano authored
* show sdk loading state when visualizing for the first time * rename to isQueryResultLoading * check for loading indicator * add notes on slow 3G
-
- Nov 23, 2024
-
-
Denis Berezin authored
* feat(sdk): migrate existing sdk tests to cypress component testing * Self review
-
- Nov 22, 2024
-
-
Kamil Mielnik authored
* FE - Allow to use in dashboard filters both pre- and post- last aggregation columns (#46670) * Extract getFilterStageIndexes * Update comment * Include 2 last stages in filterable columns in getParameterColumns * Move getJoinQueryHelpers to test-helpers * Add basic query creation * Add breakout columns * Make tableName optional * Implement 1-stage test, refactor assertions * Rename * Move filter utils up * Use getGroupItems and appendStageIfAggregated in getFilterableColums * Introduce Lib.filterGroups * Revert "Introduce Lib.filterGroups" This reverts commit 5f8b2d09. * Don't reuse getGroupItems or appendStageIfAggregated * Move getFilterStageIndexes out of Lib * Format code * Revert types move * Revert functions move * Improve diff * Group dashcard mapping options * Adjust existing getParameterColumns usages (except unit tests) * Remove redundant call * Fix filtering * Update unit tests * Format code, remove TODO * Add stage index assertions * Add model test for 1-stage query * Add partial boilerplate for 2-stage query * Add a 2-stage case * Add a 2-stage case for model * Update unit test * Fix click behavior mapping * Remove duplicated functions * Remove complex return type * Move appendStageIfAggregated and getFilterStageIndexes to metabase-lib/filter.ts * Re-group columns based on stage index instead of using ML-returned references for comparison * Add new options to dimension types * Use the new stage-number option * Rename appendStageIfSummarized to ensureFilterStage and add explanatory comment * Remove duplicated ensureFilterStage after merge * FE - e2e - Cover dashboard filters with tests (#46958) * Extract getFilterStageIndexes * Update comment * Include 2 last stages in filterable columns in getParameterColumns * Move getJoinQueryHelpers to test-helpers * Add basic query creation * Add breakout columns * Make tableName optional * Implement 1-stage test, refactor assertions * Rename * Move filter utils up * Use getGroupItems and appendStageIfAggregated in getFilterableColums * Introduce Lib.filterGroups * Revert "Introduce Lib.filterGroups" This reverts commit 5f8b2d09. * Don't reuse getGroupItems or appendStageIfAggregated * Move getFilterStageIndexes out of Lib * Format code * Revert types move * Revert functions move * Improve diff * Group dashcard mapping options * Adjust existing getParameterColumns usages (except unit tests) * Remove redundant call * Fix filtering * Update unit tests * Format code, remove TODO * Add stage index assertions * Add model test for 1-stage query * Add partial boilerplate for 2-stage query * Add a 2-stage case * Add a 2-stage case for model * Update unit test * Fix click behavior mapping * Remove duplicated functions * Remove complex return type * Remove unused @ts-expect-error directive - use createQuestionAndDashboard helper instead of command - sort imports * Add boilerplate for query stages test suite * Add createDashboard * Try out the new function * Organize code * Add descriptions * Move visitDashboard call out of createDashboard * Move appendStageIfAggregated and getFilterStageIndexes to metabase-lib/filter.ts * Re-group columns based on stage index instead of using ML-returned references for comparison * Add boilerplate for base questions * Add assertions for mapping options * Simplify verifyDashcardMappingOptions interface * Add assertions for all types of parameters * Update test name * Format code * Add new options to dimension types * Use the new stage-number option * Add Q2 creation * Introduce helper constants * Rename appendStageIfSummarized to ensureFilterStage and add explanatory comment * Add cases for models * Extract subroutines * Add Q3 * Extract createQ2Query and createQ3Query * Extract createQ1uery, remove createM1 * Optimize verifyPopoverMappingOptions * Add more assertions * Add model assertions * Add tooltip assertion * Break large functions down * Restructure tests to prevent memory-related crashes * Refactor * Update comment * Update comment * Remove createQ1 * Remove createQ2, createQ3 * Refactor * Refactor * Comment out failing assertions * Add Q3 assertions * Add Q3 assertions * Add comment * Introduce createAndVisitDashboardWithQueryMatrix * Add Q4 * Fix assertions * Add repro tags * Add comment * De-hardcode indexes * Add Q5-Q8 * Rename * Add Q5 * Add Q6 * Add Q7 & Q8 * Add Q9 * Fix structure * Reuse Lib.ensureFilterStage * Fix unit of time parameters * Support explicit and implicit stage numbers for temporal-unit params * Extend test with temporal unit parameter with stage number * Update unit tests * Let stage-path handle nil (default) stage-number --------- Co-authored-by:
Tamás Benkő <tamas@metabase.com> * Allow filtering on columns from all stages in dashboards (#48254) * Allow filtering on columns from all stages in dashboards * Update tests * Clean up * Update unit tests * Distinguish multiple "Summaries" column groups in dashboard filter mapping (#48261) * Allow filtering on columns from all stages in dashboards * Update tests * Clean up * Update unit tests * Distinguish multiple "Summaries" column groups * Fix imports * Remove redundant attribute * Update import * Allow filter params targeting native stages (#48379) * Move filters on nested native stages to parent stage in expand-mbql-params Similar to the existing handling in move-join-condition-to-source-query. This fixes filter params that directly target a native stage with a non-negative :stage-number, e.g. when applying dashboard filters to a card where the card query is native. Fixes #48258 * Add test for filter params explicitly targeting nested native queries * FE - e2e - Cover dashboard drills with tests (#48289) * Allow filtering on columns from all stages in dashboards * Update tests * Clean up * Update unit tests * Distinguish multiple "Summaries" column groups * Fix imports * Remove redundant attribute * Fix type * Add a test * Add a test * Reduce flakiness * Fix race conditions with last_used_param_values - see https://metaboat.slack.com/archives/C010L1Z4F9S/p1727947712609579 * Add a temporary workaround * Fix name * Fix applying parameters in Question * Revert "Fix type" This reverts commit 67f6778d. * Rename and reorder tests * Add more tests * Update tests to avoid hitting https://github.com/metabase/metabase/issues/46774 * Add Q8 tests and fix tests for Q9 * Update assertions * Update assertions because of https://github.com/metabase/metabase/issues/48339 * Improve test names * Add test * Skip failing test * Add more tests * Add test * Remove redundant code * Remove invalid cases * Add test * Add tests * Add more assertions * Add more assertions * Add assertions * Add assertions * Use helper functions * Use helper functions * Nest helpers consistently throughout the file * Decrease flakiness * Revert "Add a temporary workaround" This reverts commit 48ed8770. * Add a temporary workaround * Add tests * Add assertions * Add tests * Update unit tests * Make temporary workaround safer * Add TODOs to github links * Extract a function to improve readability * Simplify getParametersMappedToDashcard * Fix failing tests by calling Lib.ensureFilterStage in the correct place and properly identifying the originalQuestion so that Question.prototype.isDirtyComparedTo returns expected result * Remove redundant code * Quick dirty fix to run in CI * Format code * Format code * Update unit tests * Fix test setup * Revert "Remove redundant code" This reverts commit 35b47a10. * Use Lib.areLegacyQueriesEqual * Create a new e2e test group: dashboard-filters-2 (#48610) * Allow filtering on columns from all stages in dashboards * Update tests * Clean up * Update unit tests * Distinguish multiple "Summaries" column groups * Fix imports * Remove redundant attribute * Fix type * Add a test * Add a test * Reduce flakiness * Fix race conditions with last_used_param_values - see https://metaboat.slack.com/archives/C010L1Z4F9S/p1727947712609579 * Add a temporary workaround * Fix name * Fix applying parameters in Question * Revert "Fix type" This reverts commit 67f6778d. * Rename and reorder tests * Add more tests * Update tests to avoid hitting https://github.com/metabase/metabase/issues/46774 * Add Q8 tests and fix tests for Q9 * Update assertions * Update assertions because of https://github.com/metabase/metabase/issues/48339 * Improve test names * Add test * Skip failing test * Add more tests * Add test * Remove redundant code * Remove invalid cases * Add test * Add tests * Add more assertions * Add more assertions * Add assertions * Add assertions * Use helper functions * Use helper functions * Nest helpers consistently throughout the file * Decrease flakiness * Revert "Add a temporary workaround" This reverts commit 48ed8770. * Add a temporary workaround * Add tests * Add assertions * Add tests * Update unit tests * Make temporary workaround safer * Add TODOs to github links * Extract a function to improve readability * Simplify getParametersMappedToDashcard * Fix failing tests by calling Lib.ensureFilterStage in the correct place and properly identifying the originalQuestion so that Question.prototype.isDirtyComparedTo returns expected result * Remove redundant code * Quick dirty fix to run in CI * Format code * Format code * Update unit tests * Fix test setup * Create a new e2e test group because the old one was timing out in CI * Add the group to GH action * Revert "Remove redundant code" This reverts commit 35b47a10. * Use Lib.areLegacyQueriesEqual * FE - e2e - Cover combination of unit of time parameter + non-last-stage filters with tests (#48726) * Add JSDoc for entityPickerModalItem * Add addToDashboard parameter to saveQuestion * Add JSDoc for saveQuestion * Fix import * Add a test reproducing the bug * Try to fix unit of time parameters * Fix wrong stage-index for temporal unit parameters on composed ad hoc questions * Fix ad-hoc question naming when there is an empty extra filter stage * Fix unit tests * FE - Do not add extra filtering stage for pivot tables (#48975) * Avoid using Lib.ensureFilterStage for pivoted questions * Fix unit test setup * Add tests for pivot tables * Optimize tests * Test filter modal * Revert redundant changes * [WIP] Dashboard filter columns be fixes (#48906) * Revert "Add a temporary workaround" This reverts commit 4ea37487. * Fix some of the issues and unskip some of the E2E tests * Acknowledge that metrics are transparent * Fix breakouts by the same column with different temporal-units * Use non-negative stageIndex for temporal unit parameters * Add stage if there is an explicit reference to stage after the last Instead of duplicating the ensure-filter-stage logic, just check if there is a parameter referencing the filter stage (which is always one after the last in the query). If there is such a reference, add that stage. --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Require only breakouts when adding new stage in ensure-filter-stage (#49067) * Only require breakouts when adding new stage in ensure-filter-stage Previously, this function required both breakouts and aggregations. Closes #48339 * Update e2e tests after changes to Lib.ensureFilterStage This resolves all-but-one of the TODOs related to #49339 Related to #49022 * Implementing parameter_mappings migration (#49256) * FE - e2e - Update tests after `Lib.ensureFilterStage` changes (#49222) * Unskip #19744 repro * Remove sanity checks * Update comment * Fix typo * Remove invalid test * Ignore pivoted "table" viz and and inline Question.prototype.isPivoted * Remove test for pivoted table * FE - e2e - Click behavior (#49239) * Unskip #19744 repro * Remove sanity checks * Update comment * Fix typo * Remove invalid test * Ignore pivoted "table" viz and and inline Question.prototype.isPivoted * Remove test for pivoted table * Add a test * Disable columns from non-last stage in click behavior * Finish the test * Refactor * FE - e2e - Cover public & embedded dashboards with tests (#49280) * Add test for public dashboard * Add test for embedded dashboard * Add comment * Add test for 2nd stage column * Add test for 2nd stage aggregation column * Add test for 2nd stage breakout column * Add assertions for models * Handle no auto-pivoting of ad-hoc questions from drill thrus --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com> * Add missing test setup * Address some review comments (#49429) * FE - Show columns from all stages in click behavior (target question) (#48828) * Add JSDoc for entityPickerModalItem * Add addToDashboard parameter to saveQuestion * Add JSDoc for saveQuestion * Fix import * Add a test reproducing the bug * Try to fix unit of time parameters * Fix wrong stage-index for temporal unit parameters on composed ad hoc questions * Fix ad-hoc question naming when there is an empty extra filter stage * Fix unit tests * Fix non-unique keys * Add stage-number to click behavior dimension target * Call Lib.ensureFilteringStage in click behavior * Use describeEE because click behavior tests use setTokenFeatures("all") * Stop testing implementation details * Stop testing implementation details * Stop testing implementation details * Modernize test and make it less flaky * Address flake source * Fix SAMPLE_DB_ID * Unskip repro for #19744 * Add a test * Update test name * Introduce verifyNotebookQuery * Use verifyNotebookQuery * Use verifyNotebookQuery * Move verifyNotebookQuery to helpers * Assert items count in verifyNotebookQuery * Extract helper functions * Rename helpers * Refactor * Consistent comments * Extract verifyVizTypeIsLine * Add scrollIntoView calls for extra safety * Add TODO * Use verifyNotebookQuery * Make stages optional * Add createMultiStageQuery * Remove redundant scrollIntoView calls - We don't need them because the assertions are not using "be.visible" * Improve test setup * Add more assertions * Add more assertions * Add basic join support to verifyNotebookJoins * Unnest code * Implement join assertions * Implement expressions and sort assertions * Simplify code * Add commented-out assertions * Yes, it is correct - it's stageIndex which sourceColumn comes from in sourceQuery * Conditionally apply filter stage * Allow mapping to all stages in click behavior * Remove redundant argument * Simplify diff * Simplify diff * Update test setup * Remove TODO related to metabase#49282 - Closes #49282 * Support fetching param values on filter stage (#50120) * Support fetching param values on filter stage Fixes #48613 * Fix temporal-unit-parameters * Enrich dimension targets in click_behavior with stage-numbers (#49911) * Enrich dimension targets in click_behavior with stage-numbers Fixes #49110 * Add missing stage-number * Remove changeSynchronousBatchUpdateSetting references * Update assertions to include time bucket * Use mbql.u/legacy-last-stage-number in metabase.query-processor.card --------- Co-authored-by:
Tamás Benkő <tamas@metabase.com> Co-authored-by:
appleby <86076+appleby@users.noreply.github.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Phoomparin Mano authored
* use -1 for stage index for breakout and aggregation list * add e2e tests * remove sum of total in e2e * use test id matcher * add issue to e2e name Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * move stageIndex to a separate variable --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Nov 21, 2024
-
-
Phoomparin Mano authored
* add stories for dark theme * add dark theme editor stories * add entity picker colors * add editor-only picker * remove redundant story wrapper for dark theme stories * add theme keys to docs * add warning message
-
- Nov 20, 2024
-
-
Phoomparin Mano authored
* revamp the create question component * docs updates * add stories and update styles * prevent switching to visualization when it is not ready * ensure CreateQuestion works in flex parents * add basic e2e tests for CreateQuestion * ensure that switching between editor and visualization works * use the save button for the disabled state * update the question title when the question is saved * implement updating questions in place * rename replaceQuestion * make CreateQuestion props all optional * add background color to modal header * hide the save button if question is dirty * hide save button instead of disabling per design feedback * update e2e tests * revert e2e helpers * add title update assertions * whitespace changes
-
- Nov 19, 2024
-
-
Phoomparin Mano authored
* allow passing custom views to underlying ad-hoc questions * update readme docs * accept component instead * tweak layout story * update docs * add e2e tests * cleanup tests * remove incorrect tests * simplify tests * rename prop to renderDrillThroughQuestion and update docs * swap docs order * add missing marker * clarify drill-through naming * replace dead links
-
Phoomparin Mano authored
* trigger save handlers on question create * add skeleton example stories for save forms * update storybook stories * add tests for saving questions * docs update * add createCard assertions * rollback docs
-
Oisin Coveney authored
-
- Nov 14, 2024
-
-
Oisin Coveney authored
-
Oisin Coveney authored
-
- Nov 13, 2024
-
-
Nicolò Pretto authored
* wip: Alert component for SDKError * use the alert component for the default sdk error component * fix tests * update e2e
-
- Nov 12, 2024
-
-
Phoomparin Mano authored
* add filter picker skeleton * add filter picker skeleton * add picker in popover use case * reuse FilterColumnPicker * add question filter logic * remove fixed width from popover * add onClose handler * add e2e test skeleton * contain FilterBar in Box in story * add a test for adding filters * update e2e tests * add filter picker to the docs * inline props and functions * update the props
-
Oisin Coveney authored
-
- Nov 08, 2024
-
-
Phoomparin Mano authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Correct embedding hash options type semantically * Pass `X-Metabase-Locale` to embed downloads * wip locale header middleware * Allow smart scalar text to be translated * Stop using global variable * Add more details to embedding types * Extend the E2E util type and correct some properties types * Add e2e test * Fix dashboard name * Add a test for static embed question * Make a type name follows a convention Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Fix failed E2E tests due to missing default values * Fix public embed not working with `?locale` anymore * Revert "wip locale header middleware" This reverts commit 83d8d135. * Preserve locale when in the `as-admin` macro is used Motivating issue: ```shell ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Count" ] ``` I'm running a query that has aggregated columns and it is returning the untranslated. Note that these are computed and dynamically given a display name. ```clojure (case tag :count (i18n/tru "Count") :cum-count (i18n/tru "Cumulative count")) ``` The problem is that we run embedding things as admin. And that gets the current user, which in embed and public spaces is nil, and so binds a nil to user-locale, which defaults to english when translating. After: ``` ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Nombre de lignes" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:zh -pb | jq '.data|.cols|map(.display_name)' [ "State", "行数" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124 ' x-metabase-locale:es -pb | jq '.data|.cols|map(.display_name)' [ "State", "Contar" ] ``` This is fetching a dashboard's card which is a query of orders grouped by created at month, sum of total. --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- Nov 07, 2024
-
-
Oisin Coveney authored
-
Oisin Coveney authored
-
- Nov 06, 2024
-
-
Nicolò Pretto authored
* refactor + more specific auth errors * fix linting issues * make tests pass, again * make test pass for real? * continues the refactor and hopefully makes tests pass * try to simplify the logic a little bit more * also logs to the console for the edge case of invalid session * remove setLoginStatus * fix typo * fix debug line that should have been commented * remove dead code * remove test for code that doesnt exist * address feedback from PR * update test copy * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * update copy for site settings error * ex -> exception * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * update tests to use the updated copy + small typos * refactor: use jest spy on to check for console.error Co-authored-by:
"Mahatthana (Kelvin) Nomsawadi" <me@bboykelvin.dev> * use full error message in test * renamed response to session * mock implementation of console.log * fix(49482): don't create a new store on each MetabaseProvider render (#49492) * fix(49482): don't create a new store on each MetabaseProvider render * remove store prop as it seems to not be used --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 05, 2024
-
-
Denis Berezin authored
* Add possibility to hide columns in CollectionBrowser * Add tests * Review fixes * Fix e2e
-
Denis Berezin authored
* Add isOpen prop to control CreateDashboardModal * Add props to storybook
-
- Nov 04, 2024
-
-
Phoomparin Mano authored
feat(sdk): ability to enforce the destination collection to save to and hide the collection picker (#49251) * add ability to hide the collection picker * add save options * make sure collectionId is fresh * update sdk question form component * make collectionId accept null * apply saveOptions to sdk components * revert to use initialCollectionId as context name * target the correct collection id * add e2e tests * update e2e tests * move into within * update test * remove collectionId from default args * revert e2e of hide columns * make e2e helper more generic * use saveToCollectionId prop to save to a specific collection * update e2e tests * update comment formatting Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * clean up leftover changes from an earlier version * readme update * indicate that saveToCollectionId is only applicable to static questions * revert QuestionEditor.isSaveEnabled defaults * update comment format * remove unused initialCollectionId prop * experiment: try to fix failing custom-columns e2e --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 01, 2024
-
-
Denis Berezin authored
* Fix scroll for EditableDashboard in fullscreen mode * Fix scroll for InteractiveDashboard in fullscreen mode * Display fullscreen control to dashboards by default * Fix issue with public shared questions empty footer
-
- Oct 30, 2024
-
-
Denis Berezin authored
* fix(sdk): Editable dashboard should not overlap content below it * Add sizing note
-
- Oct 29, 2024
-
-
Oisin Coveney authored
-
- Oct 28, 2024
-
-
Phoomparin Mano authored
-
- Oct 25, 2024
-
-
Phoomparin Mano authored
* investigate hide columns * add update viz settings in the sdk * cleanup implementation * add storybook for interactive question * use the question callback to update viz settings * remove onUpdateVisualizationSettings * revert change to onUpdateVisualizationSettings * add click action behaviour * fix misspelling * add onUpdateQuestion mock function * add unit test for click action behaviour * add e2e test for hiding question column header
-
Phoomparin Mano authored
* cancel request on unmount in static question * use deferred promise * remove logs * alias cancelled to deferred.promise * extract useLoadStaticQuestion hook * add tests for request cancellation * change updateQuestion method * add sanity check with fetchMock
-
- Oct 24, 2024
-
-
Phoomparin Mano authored
* implement saving questions in interactive question * close modal on create question * add e2e test for saving questions
-
Denis Berezin authored
-
- Oct 18, 2024
-
-
Nicolò Pretto authored
* defineEmbeddingSdkConfig to make typing easier when the config is created outside of the jsx * also add defineEmbeddingSdkTheme, move them to index.ts as i don't have a good name for what file to put them into :shrugs: * updated the readme to use the defineXXX functions
-