Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 12, 2024
  2. Nov 11, 2024
  3. Nov 08, 2024
  4. Nov 07, 2024
  5. Nov 06, 2024
  6. Nov 05, 2024
  7. Nov 04, 2024
    • Phoomparin Mano's avatar
      feat(sdk): ability to enforce the destination collection to save to and hide... · de559f49
      Phoomparin Mano authored
      feat(sdk): ability to enforce the destination collection to save to and hide the collection picker (#49251)
      
      * add ability to hide the collection picker
      
      * add save options
      
      * make sure collectionId is fresh
      
      * update sdk question form component
      
      * make collectionId accept null
      
      * apply saveOptions to sdk components
      
      * revert to use initialCollectionId as context name
      
      * target the correct collection id
      
      * add e2e tests
      
      * update e2e tests
      
      * move into within
      
      * update test
      
      * remove collectionId from default args
      
      * revert e2e of hide columns
      
      * make e2e helper more generic
      
      * use saveToCollectionId prop to save to a specific collection
      
      * update e2e tests
      
      * update comment formatting
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * clean up leftover changes from an earlier version
      
      * readme update
      
      * indicate that saveToCollectionId is only applicable to static questions
      
      * revert QuestionEditor.isSaveEnabled defaults
      
      * update comment format
      
      * remove unused initialCollectionId prop
      
      * experiment: try to fix failing custom-columns e2e
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      de559f49
  8. Nov 03, 2024
  9. Nov 01, 2024
    • Nick Fitzpatrick's avatar
      Dashboard verifications (#48956) · 4a6c1d26
      Nick Fitzpatrick authored
      
      * Adding moderation status to Dashboards
      
      * react sins
      
      * verification coll: subselect on card + dashboard
      
      * fix the 3 failing BE tests
      
      * add an api test for dashboard verification
      
      * verified dashboards are never stale
      
      * e2e tests
      
      * code cleanup
      
      * unit test and e2e test cleanup
      
      * PR Feedback
      
      * backend test fixes
      
      * Nick shouldn't touch clojure
      
      * type fix
      
      * indent
      
      * fix last 2 BE tests
      
      ---------
      
      Co-authored-by: default avatarBryan Maass <bryan.maass@gmail.com>
      4a6c1d26
    • Denis Berezin's avatar
      fix(sdk): Fix interactive dashboard scroll in fullscreen mode (#49366) · 5879f90b
      Denis Berezin authored
      * Fix scroll for EditableDashboard in fullscreen mode
      
      * Fix scroll for InteractiveDashboard in fullscreen mode
      
      * Display fullscreen control to dashboards by default
      
      * Fix issue with public shared questions empty footer
      5879f90b
  10. Oct 31, 2024
  11. Oct 30, 2024
  12. Oct 29, 2024
  13. Oct 28, 2024
  14. Oct 25, 2024
    • Phoomparin Mano's avatar
      fix(sdk): support hiding columns in InteractiveQuestion (#49013) · 6a927dee
      Phoomparin Mano authored
      * investigate hide columns
      
      * add update viz settings in the sdk
      
      * cleanup implementation
      
      * add storybook for interactive question
      
      * use the question callback to update viz settings
      
      * remove onUpdateVisualizationSettings
      
      * revert change to onUpdateVisualizationSettings
      
      * add click action behaviour
      
      * fix misspelling
      
      * add onUpdateQuestion mock function
      
      * add unit test for click action behaviour
      
      * add e2e test for hiding question column header
      6a927dee
    • Nicolò Pretto's avatar
      test(sdk): add tests for auth flow (#49108) · d7e56b26
      Nicolò Pretto authored
      * test(sdk): add tests for auth flow
      
      * make the fetch token fn return something that will pass the validations
      we'll add in the next project
      
      * waitForRequest helper + add expects for card endpoints on api key test
      d7e56b26
    • Phoomparin Mano's avatar
      fix(sdk): static question should cancel requests on component unmount (#48808) · 2fd311c5
      Phoomparin Mano authored
      * cancel request on unmount in static question
      
      * use deferred promise
      
      * remove logs
      
      * alias cancelled to deferred.promise
      
      * extract useLoadStaticQuestion hook
      
      * add tests for request cancellation
      
      * change updateQuestion method
      
      * add sanity check with fetchMock
      2fd311c5
Loading