This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 01, 2022
-
-
metamben authored
* Return app collections as apps, page dashboards as pages * Fix bug: descriptions of datasets should also be searchable
-
adam-james authored
* Send show_values key to static-viz js The static viz components expect certain keys on the settings map passed into the js. At this time, the contract between the backend (Clojure) and the static-viz (js) feels a little under-specified. However, for the change to XY Charts here, we follow the existing method in code of checking the backend viz-settings map for some key, and passing it into js in a 'simplified' form. For instance, in this change, `:graph.show-values` is taken and placed into the settings map as `:show_values` for the static-viz js to use. * De-dupe key * Keep this PR super simple, don't eliminate sparkline stuff yet * Add :line earlier in cond, try to fix tests that fail * Get the :line conditional in the right place, allowing :scalar
-
Nemanja Glumac authored
* Fix native query * Replace deprecated `cy.server` and `cy.route` * Add database through API rather than using UI * Remove superfluous `visit` `openNativeEditor` already contains `cy.visit("/")` * Use Postgres instead of H2 for a second database * Speed typing up a bit * Do not use hard coded IDs * Update test title * Move spec to `native` reproductions
-
Nemanja Glumac authored
* Temporarily skip repro for #17450 for H2 database * Reproduce #17450 using Postgres
-
adam-james authored
* Format Pie Chart Legend Labels as Month, YYYY On the backend, the pie chart legend is not rendered in the javascript, it is instead re-created server side as a set of html elements. This means "YYYY-MM-DD" formatted dates do not get passed through the frontend code responsible for formatting date times (I believe this is done with a library called 'moment.js'). And, since the SVG cannot contain html foreignObjects (the backend SVG renederer 'batik' ignores foreign objects), the legend is left as a responsiblility for Clojure land. This PR adds a `format-month` function to handle this case. Current caveats with this approach: - doesn't consider localization (yet) - adjusted the html to use a table instead of a div full of spans and the formatting could use some tweaks - assumes any string that is parse-able into a Jave DateTime object will be displayed in this Month, Year format, - which might not be true in all cases * Improve label formatting by using viz-settings transform fns * Rework Static Pie Chart legend Try to make it look a bit nicer: - splits legends into 2 tables if there are more than 8 entries - larger colored circle - use tables to help lay things out more evenly (CSS flexbox doesn't seem to work) - handle some legend label formatting cases beyond just timestamps (eg weeks of year, yearly quarters) Also fixed the failing test * Adding a month formatter. Sometimes, the label values are not passed in as timestamps, but just numbers (as strings). In these cases, the Datetime formatters won't be useful, so there are some cases built to handle these. * Remove print statement * Change temporal format fns to more closely follow viz-settings Various changes are made to improve static-viz's use of viz-settings from the frontend. - abbreviation is considered (eg. so "January" is rendered as "Jan" when setting is true) - abbreviation also works for Days of week - x-of-y cases are handled a bit better - separator settings are properly reflected (eg. 2022/05 becomes 2022-05 if separator changed to "-") * Remove unused key from the let * Fix some failing tests * Adding more tests * Prevent non-temporal legend labels from being rendered via datetime If a legend's label is some string, we want to pass it unmodified. If it's a number or a timestamp, we can pass it through to the date time render function to format the string to match the viz-settings/column units * Add missed docstring * Don't lowercase 'D' format, pass correct lowercase 'd' before 'D' format = day of year, which in most human-readable formats is not what we want, but it IS what we want in a :day-of-year case. Instead of always lowercasing, just make sure the lowercase 'd' is in the defaults/overrides * Better way to handle day of week and month of year Also got rid of bad use of read-string by using parse-long * Use a java lib. to format ordinal numbers, respecting site locale
-
Aleksandr Lesnenko authored
-
Aleksandr Lesnenko authored
* pie labels * hide labels when no space for them * unused class * review * fix resizing issue, add visual test * mute invalid typings
-
Gustavo Saiani authored
-
metamben authored
Fixes #25143 and #25157. For recent_views and popular_items hydrate the is_app_page flag for dashboards.
-
Alexander Polyankin authored
-
Ariya Hidayat authored
-
Alexander Polyankin authored
-
Jeff Bruemmer authored
* update link * note on public exports * images * readme link * link to install start
-
Alexander Polyankin authored
-
- Aug 31, 2022
-
-
Nemanja Glumac authored
* Skip test that manually adds H2 database * Use custom action instead
-
Braden Shepherdson authored
This is a simple expedient: convert our entities to a `(sorted-map)` before passing them to the YAML writer! This gives a consistent, platform-agnostic order between dumps. (It might have already been fine, since it's based on Clojure's `hash`?)
-
Braden Shepherdson authored
* Add `serdes-descendants` for "containment" to serialize a subtree This allows naming eg. a Collection and will recursively serialize: all dashboards, cards and dashcards it contains directly, plus all child collections and everything they contain. Currently this words on Collection, Dashboard, DashboardCard, and Card. * lint * Switch to plural `extract-subtrees` with a list of `targets`
-
metamben authored
Hydrate app_id on collections in the search endpoint
-
metamben authored
-
metamben authored
See #25097 for context.
-
Nemanja Glumac authored
* Skip adding another H2 database to avoid failures in CI This is just a temporary measure! Remove this mechanism as soon as #24900 gets fixed! * Use Boolean `true`
-
Anton Kulyk authored
-
Anton Kulyk authored
* Move `CategoryWidgetProps` out of writeback types * Clean up writeback types * Move writeback types to `metabase-types/api` * Rename file
-
adam-james authored
* Remove sort-by first from combo chart rendering The card query (seems to) return the rows in a vector in the same order presented on the frontend UI. Having the row selection function sort the selected rows by first will always just sort things alphabetically. This may be fine in some generic case, but can break in situations where a user has created a query with a sort on some quantity. * Fix test
-
Harry V. Kiselev authored
-
Aleksandr Lesnenko authored
-
Aleksandr Lesnenko authored
* add find-replace search box to the native query editor * mock
-
Aleksandr Lesnenko authored
-
Anton Kulyk authored
* Extend dashboard types * Add click behavior types * Convert `ClickBehaviorSidebar` to TypeScript * Convert `SidebarItem` to TypeScript * Convert `TypeSelector` to TypeScript * Convert `TableClickBehaviorView` to TypeScript * Convert `ActionOptions` to TypeScript * Convert main sidebar view to TypeScript * Convert `LinkOptions` to TypeScript * Fix types * Convert utils to TypeScript * Remove redundant `div` * Extract `ClickBehaviorSidebarHeaderContent` * Extract `ClickBehaviorSidebarContent` * Swap conditionals
-
Anton Kulyk authored
* Untangle `ClickBehaviorSidebarHeader` * Untangle `ClickBehaviorSidebarMainView` * Untangle `Column` * Move `LinkOptions` to its own directory * Untangle `LinkOptions` * Move `TableClickBehaviorView` to its own directory * Untangle `TableClickBehaviorView` * Untangle `QuestionDashboardPicker` * Extract `SidebarItem` component * Remove `SidebarItemClasses` and `SidebarItemStyle` * Fix `QuestionDashboardPicker` sidebar item component * Move components into their own folders * Extract more code into `SidebarItem` * Extract styled components * Untangle main content rendering * Remove redundant div * Fix padding * Clean up `ClickBehaviorSidebar` props * Fix missing prop * Fix incorrect `disabled` condition * Convert sidebar into functional component * Fix `hasSelectedColumn` used before define
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Remove `redux-logger` usage * Remove related lib file * Uninstall `redux-logger`
-
Anton Kulyk authored
* Extract straightforward styled components * Extract `SidebarItem` bits * Remove not used props * Sort imports * Extract `ValuesYouCanReference` component * Extract `CustomLinkText` component * Extract `LinkOption` component * Extract `Column` component * Extract utils * Extract `TypeSelector` component * Extract `ActionOptions` component * Extract `QuestionDashboardPicker` component * Extract `CrossfilterOptions` component * Extract `LinkOptions` component * Extract `TableClickBehaviorView` component * Extract `ClickBehaviorSidebarHeader` component * Extract `ClickBehaviorSidebarMainView` component * Fix `this` references in functional components
-
Anton Kulyk authored
-
Ryan Laurie authored
-
Ngoc Khuat authored
* use login-attributes when hash advanced field-values if sandbox use native query * add a e2e test * Add repro for #24966 Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Handle negative bar data point value * Migrate static line chart values to Values component * Migrate static bar chart values to using Values component * Migrate static area chart values to using Values component * Fix stroke rendering * Fix multiseries value collision * Fix bar + y axis collision * Fix x-axis collision * Fix collision bug * Render chart last so it's above the Y axises * Fix value stroke collide with X-axis * Tidy up <Values /> and make it more readable * Fix auto compact formatting for stacked chart * Handle overlapping value with left Y-axis * `serie` -> `series`, and `series` -> `multipleSeries` So, it's grammatically correct. * Move some types to where they should belong * Add OutlinedText for static viz This is for <Text /> that has a stroke and has `pain-order: stroke`.
-
- Aug 30, 2022
-
-
Nemanja Glumac authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Case Nelson authored
* [Apps] Hydrate action on dashcards It is useful for the frontend if we hydrate :action in the same way that we hydrate :card on :ordered_cards. * Add docstring
-
Dalton authored
-