This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 02, 2024
-
-
Nemanja Glumac authored
Resolves #38301
-
Nemanja Glumac authored
-
Jeff Bruemmer authored
-
Luis Paolini authored
-
Alexander Polyankin authored
* Migrate syncStructuredQueryColumnsAndSettings to MLv2 * Migrate syncStructuredQueryColumnsAndSettings to MLv2 * Fix types * Support converting aggregation references to legacy references Fixes #37698. * Update TS wrapper * Pass query and stageIndex to legacyQuery * Pass query and stageIndex to legacyQuery * Remove no longer used columnDimensionWithName * Update assertion in failing test * Replace non-existing Question.prototype.isNative & Question.prototype.isStructured calls --------- Co-authored-by:
Tamás Benkő <tamas@metabase.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Chris Truter authored
-
- Feb 01, 2024
-
-
Jesse Devaney authored
* auto-adjust native query dates to be at the start of the date range * re-work trend charts compute function to handle updated native query date formatting * add test to validate the native query date formatting * fix unit tests * reorganize test
-
Braden Shepherdson authored
This also adds a couple of hand-written test cases in addition to testing the canned set of queries against most of the drills. Progress towards #36253.
-
Braden Shepherdson authored
This previous got rebuilt from scratch over and over, since different queries being handed the same JS `Metadata` instance were returning completely separate `MetadataProvider`s. The FE replaces the `Metadata` instance as new metadata arrives from the BE, so the `metabase.lib.cache/side-channel-cache` which is attached to the input object is implicitly invalidated when the old `Metadata` is thrown away.
-
adam-james authored
* Migration adding 'width' to Dashboards 3 migrations: - 1st adding the width column with default value of 'fixed' - 2nd updating all existing dashboards to have width 'full', which corresponds to what the current behaviour is (will be the 'old' behaviour after the fixed-width project lands). - The rolloback here is necessary but we don't care what happens as the column will be dropped immediately in the next rollback anyway - 3rd sets the notNullableConstraint. DefaultNull is 'full' here, just in case there's an existing dashboard whose width value is not yet set from the 1st migration. Don't know how that could happen, but its here in case * Dashboard PUT api endpoint accepts width changes and updates appdb update-dashboard function now is aware of the :width key so those changes can end up in the transaction. Also added a width test that asserts that the value's default is "fixed", it can be changed, eg. to "full", but cannot be changed to other values. * Add width to revision tests * Fix dashboard revision tests. :width key is now needed in some revision tests. As well we need a string communicating that the :width setting has changed from 'full' to 'fixed' or vice-versa. * Fix comments/remarks in migration to be accurate * Attempt to fix default not working mysql/mariadb * Set default in dashboard model Signed-off-by:
Adam James <adam.vermeer2@gmail.com> * Revert default :width 'fixed' value. * Explicitly add default value 'fixed' for MySQL/MariaDB --------- Signed-off-by:
Adam James <adam.vermeer2@gmail.com>
-
Jeff Bruemmer authored
-
Cal Herries authored
Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
Romeo Van Snick authored
Makes sure we pass the parameter values to the question when running it after a user reverts to an older version. Resolves metabase#38176. * Pass correct shape of parameters to question * Add reproduction for #38176, where a reverted question does not use the parameters * Reduce paramterValues to the correct format instead of using internal field * Add issue specifier to test Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Create test question with relevant name Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Avoid setting delay on input * Fix text in cell * Simplify selectors for button * Add comment on parameterValues building --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Nicolò Pretto authored
-
Tony-metabase authored
On version 4.8 metabase version 9.4 is not supported Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Ngoc Khuat authored
-
Uladzimir Havenchyk authored
* Add repro for handling not saved dashcards with mapped filters and tabs * Fix repro test * Update e2e/test/scenarios/dashboard-filters/reproductions/38245-negative-dashcard-id-switching-tabs.cy.spec.js Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Tidy-up `isStructured` v1 utils This is a follow-up after #37977. Related to #37953 * Rename MLv1 helper from `isStructured` to `isNative`
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Upgrade `actions/download-artifact` action to v4 * Upgrade `actions/upload-artifact` action to v4
-
- Jan 31, 2024
-
-
Vamsi Peri authored
Updated the Global Bundle with the content of https://truststore.pki.rds.amazonaws.com/global/global-bundle.pem -O rds-combined-ca-bundle.pem This is the new URL to be used, as described on https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL.html The new bundle: - removes expired root certificates - keeps certificates for `rds-ca-2019` - adds certificates for all regions for - `rds-ca-rsa2048-g1`: certificate authority with RSA 2048 private key algorithm and SHA256 signing algorithm - `rds-ca-rsa4096-g1`: certificate authority with RSA 4096 private key algorithm and SHA384 signing algorithm - `rds-ca-ecc384-g1`: certificate authority with ECC 384 private key algorithm and SHA384 signing algorithm It fixes #32017 and #27790 Co-authored-by:
Théophile Helleboid <theophile.helleboid.ext@qonto.com>
-
Emmad Usmani authored
Part of https://github.com/metabase/metabase/issues/38208 ### Description Adds e2e tests for dashboard card and tab duplication ### Checklist - [x] Tests have been added/updated to cover changes in this PR
-
Emmad Usmani authored
Closes https://github.com/metabase/metabase/issues/38208 ### Description Adds a item to the dashboard tab menu to duplicate the tab. ### How to verify 1. Open a dashboard you can edit 2. Go to edit more, click the tab menu for a tab 3. Click duplicate, tab should be duplicated ### Demo https://www.loom.com/share/d73aad469074440992618ee179518d39 ### Checklist ~~- [ ] Tests have been added/updated to cover changes in this PR~~ e2e tests are added in the next PR in the stack
-
Emmad Usmani authored
Part of https://github.com/metabase/metabase/issues/38208 ### Description Adds another button to the dash card action panel that duplicates that dashcard. ### How to verify Describe the steps to verify that the changes are working as expected. 1. Open a dashboard that you can edit 2. Mouseover a dashcard 3. Click the duplicate icon ### Demo https://www.loom.com/share/d73aad469074440992618ee179518d39 ### Checklist ~~- [ ] Tests have been added/updated to cover changes in this PR~~ e2e tests are added further down the stack
-
Raphael Krut-Landau authored
-
John Swanson authored
I misunderstood the desired behavior when I implemented this before. We only want the limit to apply when the `add-default-userland-constraints` middleware is applied to the query, not when we're downloading the data directly. This is a bit of a rat's nest. If there's a better way to approach the problem, I'd be happy to hear it. I added documentation for the odd approach as much as possible. The main difficulty is that the userland middleware does not have access to db-local settings. So if we want db-local settings to apply only to userland, we have to hack our way around it. The solution here is to divide the userland middleware into two parts: - the actually-userland bit, which just marks the query as needing default limits, and - a middleware inserted deeper in the middleware stack (just before we actually apply limits) that actually calculates those limits and attaches them to the query.
-
Raphael Krut-Landau authored
* Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader
-
Aleksandr Lesnenko authored
* format native queries * optional clauses, mlv2, specs * remove unnecessary webpack chunk name directive * disable formatting for mssql and sqlite, address review comments
-
Nicolò Pretto authored
-
Nemanja Glumac authored
-
Cal Herries authored
-
Cal Herries authored
CSV appends: Do not allow numbers with fractional component to be uploaded to an integer column (#38274)
-
- Jan 30, 2024
-
-
John Swanson authored
Sometimes a test passes when run by itself, but fails due to ordering issues. This is typically caused by another test failing to properly clean up after itself, leaving the database in a dirty state. For example, we might change permissions and forget to change them back, so that another test hits an unexpected permissions failure. Finding the cause of these has been a source of pain for me, so I wrote a small snippet to do it for me. If you have a test that passes when run by itself, but fails when run along with all the other tests, you can run `(dev/find-root-test-failure! #'my-ns/my-intermittent-failure-test')`. It will run *all* tests. After each one, it'll run the test you passed in. Once that test starts failing, it'll alert you about which test caused it to fail.
-
Ryan Laurie authored
* use mantine popover in entityMenu * control popover state * more control * fix unit tests to work with snazzy new popover * boringer animation
-
Filip Hric authored
-
metamben authored
* Cast to timestamp before truncating The shift according to the timezone after the truncation can produce values not at the beginning of the truncation period. * Separate handling of time and date inputs * Add test reproducing issue #37065
-
Oleg Gromov authored
Native query editor: Add an explanatory tooltip for the save button when required template tags miss defaults (#38232) * Add an explanatory tooltip for the save button when required template tags miss defaults * Update e2e tests
-