This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 03, 2024
-
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
* Map row id on object detail id * Add a fallback * Add e2e test * Add a limit * Provide a fix for #34070 * Simplify test
-
Nemanja Glumac authored
* Use MLv2 to determine whether a query can be previewed * Add E2E repro for #40608 * Expand E2E repro * Fix test * Make sure the step is active and visible before offering to preview its query * Expand E2E test * Address review comment - use `getNotebookStep` helper
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
* Do not put js code into page title * Typecheck * Add e2e test * Update e2e/test/scenarios/question/document-title.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove old config + fix typo * Add new analytics for 4 new illustration settings
-
Cal Herries authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .DashEditing * Migrate .CardTitle * Migrate .PinMap * Migrate .PinMapUpdateButtonDisabled * Migrate .BrandColorResizeHandle * Migrate .VisualizationSlowSpinner * Migrate .AddSeriesModal * Migrate 2 more classes
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix default export * Remove unused classes * Remove unused components
-
Mahatthana (Kelvin) Nomsawadi authored
* Add login page illustration (#39299) * Move Metabot setting to a new place * Add setting for login page illustration * fix UI styling * Fix not able to upload the same file twice * Update the admin > appearance > conceal metabase copy * Prepare the component for tests * Add some unit tests * Prevent settings not saved sometimes After setting the value to/from `custom` one of the setting could be failed to save, I suspect this happens because the race condition from trying to save the setting values relatively at the same time. * Make unit tests easier to read * Add all unit test test cases * Add basic E2E test * Show fallback icon for broken images * Make use of the proper component * Update the comment to affect the reality * Add an error message when file size is over 2MB * Show an error message when the file size > 2MB * Add the error message tests * Preserve the preview image aspect-ratio * Detect corrupted images * Fix failing unit tests * Address feedback: Type * Feedback: Create meaningful variables * Feedback: Make selector API more sensible * Prevent race condition Makes sure we save the settings completely before making other actions that also change settings otherwise, there could be race conditions. * Feedback: tighten up a type * Feedback: Fix inconsistency callback calls * 2. Add the rest 3 illustration settings (#40487) * Add the rest 3 illustration settings * Don't make the X icon feel lonely * Fix illustration widget saving * Fix type error * 3. Update the select UX to match new design (#40491) * Update the select UX to match new design * Move info dot next to file upload button * Simplify IllustrationWidget API * Update setting title copy * Clean up test comments * Feedback: Clarify `any` type * Feedback: Use shorthand object creation Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Feedback: Use global CSS glass instead of inlining values Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Feedback: Remove unnecessary curly brackets in JSX Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * 4. Connect illustrations to new setting values (#40139) * Wire landing page illustration to the setting value * Wire the unsubscribe page to the setting value * Prepare no rows error to be wired to the setting value * Wire no question results illustration to the setting value * Wire no search results illustration to setting value * Fix error from fixing conflict * Fix required unnecsseary prop on Image * Use Image component * Link dashboard card no results image to the setting value * Move the no data results to more a generic directory * Link collection picker no results image to the setting value * Make illustrations more accessible * Fix failed tests * Test unscribe page illustration + test no illustration * Add landing page tests * Simplify Cypress selectors * Refactor: Rename settings to match the new requirements No question data -> No Data No search results -> No object These changes are made so, these 2 settings are generic enough to include other illustrations later on. * Add no data illustration test * Add no object illustration tests * Fix unsubscribe page background style * Fix not able to build static viz * 5. Follow-up on milestone 1 (#40710) * Update custom background illustration scale behavior * Remove the need to put an SVG file in static folder * Fix test from rebasing off master with @testing-library/user-event upgrade --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
- Apr 02, 2024
-
-
dpsutton authored
* Send creator emails every week mod the email by 52 instead of by 12 and use the current week as an anchor ```clojure user=> (require '[java-time.api :as t]) nil user=> (let [every-day (take 1000 (t/iterate t/plus (t/local-date 2024 1 1) (t/days 1))) f (fn [d] (let [wf (java.time.temporal.WeekFields/of (java.util.Locale/getDefault))] (.get d (.weekOfWeekBasedYear wf))))] (sort (keys (frequencies (map f every-day))))) (1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52) ``` ```clojure user=> (metabase.util.cron/cron-string->schedule-map "0 0 2 ? * 7") {:schedule_minute 0, :schedule_day "sat", :schedule_frame nil, :schedule_hour 2, :schedule_type "weekly"} ``` * fix typo in creator sentiment email, clean up a bit typo: had `:verison` instead of `version`. And while I'm in there, make the payload all in one file and have the email namespace json->bytes->b64-encode so the data is all in one place and the setting that allows it to be present or not is co-located.
-
Nick Fitzpatrick authored
* command palette trigger in app bar search * remove tabbing to the trigger button
-
Nemanja Glumac authored
* Move all notebook containers styles to one place * Make NotebookStep wide again * Tweak sidebar width and breakpoints * Remove top margin from NotebookSteps * Stop line wrapping in an ace editor * Uniform width between step header and step body * Remove stray styles * Scroll content independently * Use named export * Use Mantine button for "Visualize" * Convert notebook step width to rem * Adjust the position of the step close button * Adjust notebook step max-width to 1200px * Remove the `cx` where not needed * Use HTML 5 `aside` element for the sidebar * Use Mantine responsive styles * Fix E2E test
-
Denis Berezin authored
-
Maz Ameli authored
-
Chris Truter authored
-
Ryan Laurie authored
* use RTK Query instead of entity framework for DatabaseCandidates * use skipToken to tighten up API request types
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
Add repro test for a model that uses another model and both have custom column with the same name (#40851) * Add repro test for a model that uses another model and both have custom column with the same name * Skip test * Update e2e/test/scenarios/models/reproductions/39150-model-with-same-custom-column-name.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Update e2e/test/scenarios/models/reproductions/39150-model-with-same-custom-column-name.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Convert to ts and add question --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Alexander Polyankin authored
-
Chris Truter authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrated .PopoverContainer, .PopoverBody * Make global CSS more prominent * Migrate 2 classes * Remove unused class * Migrate .PopoverBodyWithArrow * Remove unused class * Migrate .PopoverBodyMarginBottom * Remove unused class * Migrate .PopoverFooter * Remove unused class * Preserve classes order for easier review * Fix unit tests
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
Add repro for "Dashboard filters do not work with custom columns on saved questions used in models" (#40784)
-
Uladzimir Havenchyk authored
* Add a repro for 'GUI model joining native ones break with column not found error' * Rename test * Add await * Skip test
-
Alexander Polyankin authored
-
Leo Paillier authored
-
Jeff Bruemmer authored
-
Oisin Coveney authored
-
- Apr 01, 2024
-
-
Ryan Laurie authored
* put new strings in the pot * update some more strings * add new translated strings
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Romeo Van Snick authored
-
Roman Abdulmanov authored
-
Anton Kulyk authored
-
Anton Kulyk authored
* Fix parameter values comparison in x-rays * Skip rerun when `parameterValues` are not initialized * Remove not used code
-
Uladzimir Havenchyk authored
-
Uladzimir Havenchyk authored
-