This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 22, 2023
-
-
Emmad Usmani authored
-
metamben authored
* Resolve nested questions in native queries Fixes #25988.
-
Bryan Maass authored
* Decouple checking ddl from classifying h2 stmts - should enable followup for easily blocking more kinds of queries - check all statements to make sure they aren't "ddl". * fix classify-query * linter fixes + get-field refactor * return the CommandInterface values as ints Reach into the CommandList when needed * docstring wording * catch invalid queries -- they can't be classified * respond to review comments - fix see: comment - remove CommandList typehint - rename command-list -> command - skip checking disallowed ddl commands when query is `nil` then also: - fix a linter error - add a test for `nil` query ddl command checking * rename command-list-type -> first-command-type * fix schema + handle h2-parser build failure
-
Cal Herries authored
* Fix action loading and extraction of action type * Remove comment * Fix handling required parameters for public basic actions (#28415) * Fix presenting required parameters * Add tests * Add explanation text to the action editor (#28406) * Add explanation text to the action editor * Replace link * Add missing `nock.cleanAll` calls (#28441) * [CI] Improve `codenotify` workflow (#28432) * Add path filtering to codenotify workflow * Upgrade action to its latest version (v0.6.4) * [E2E] Prevent app permission flakes (#28445) * Ensure dashcards are deleted after actions are deleted (#28446) (c.f. discussion at https://metaboat.slack.com/archives/C04FG88HL95/p1676649795131089 ) * Show not found view when opening archived model (#28443) * Add `isArchived` method to `Question` class * Show nice not found view when opening archived model * [CI] Unify E2E tests workflows (#28431) * [Ci] Fix wildcard glob pattern in path filters (#28447) [ci skip] * Remove dupe tests * Add database_id to implicit actions * Tidy * Update select-actions docstring * Add test for database_id in action dashcards * Remove database_id before insert and update * whitespace * Refactor select-actions * Add database_id to action-create-test * Add test for create+update+select for implicit actions * Fix test * Remove conditional * style --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Tim Macdonald <tim@metabase.com>
-
Aleksandr Lesnenko authored
-
Anton Kulyk authored
* Add `aria-label` to the run button * Assert run action button is shown when expected * Hide run button when actions are disabled
-
Tim Macdonald authored
* If a model is converted to a card, archive the associated actions * If an action is unarchived and its model _is_ a card, throw an error
-
Cal Herries authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix missing type property on a card breaks frontend UI * Add E2E test
-
Alexander Polyankin authored
-
- Feb 21, 2023
-
-
Cam Saul authored
* MISC improvements * Update test/metabase/models/secret_test.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update .clj-kondo/hooks/clojure/test.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update .clj-kondo/hooks/clojure/test.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
john-metabase authored
* Improves consistency of substring in MBQL Standard SQL SUBSTRING() uses a 1-based start index, with various drivers handling a 0 start index in different ways. To make the behavior of substring consistent across drivers, we will always convert a 0 start index in MBQL to a 1 in SQL. The ->honeysql implementation of substring has been generalized and drivers can now override just the name of the substring function, or the entire expression if necessary. SQL Server now calls the parent implementation. Resolves #12445 * Fixes substring from 0 in Mongo * Adds arg to substring parent call * Fix docs and helper text for substring() * Adds schema to require positive integer index for substring * WIP, adds frontend validation for substring index arg * Adds frontend test for substring arg validation * Updates substring test to expect exception on index 0 * Update src/metabase/driver/sql/query_processor.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Use s/if instead of s/conditional * Fix substring call in mysql substring spec * Reverts driver and sql.qp changes for substring index * Reverts changes to dispatch-by-clause-name-or-class * Fixes typeinferencer test substring index * Adds test for canonicalizing substring * Fixes substring canonicalization with extra args * Updates string extracts test to account for substring canonicalization * Rewrites resolver validation application * Adds test case for frontend expression validation errors * Fixes frontend compiler spec for new substring validation --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
dpsutton authored
* Custom migrations Current syntax: specify the migration with ``` - changeSet: id: v46.00-080 author: dpsutton comment: Uppercases all Card names changes: - customChange: class: "metabase.db.custom_migrations.ReversibleUppercaseCards" ``` and in the new namespace metabase.db.custom-migrations: ```clojure (defmigration UppercaseCards (db/execute! {:update :report_card :set {:name :%upper.name}})) (def-reversible-migration ReversibleUppercaseCards (db/execute! {:update :report_card :set {:name :%upper.name}}) (db/execute! {:update :report_card :set {:name :%lower.name}})) ``` * Use db provided by liquibase * edit docstring * set *warn-on-reflection* to fix lint error & rebase --------- Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Nick Fitzpatrick authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
-
Anton Kulyk authored
-
Cam Saul authored
* Fix #15324 * Update tests
-
Cam Saul authored
* Misc QP test improvements * Add test
-
Nemanja Glumac authored
* Expand the glob to include TS(X) files * Use console error * Re-order imports * Print the missing files in red * Fix glob pattern * Add script to pre-commit hooks * Remove the check from CI
-
Aleksandr Lesnenko authored
-
Nemanja Glumac authored
Resolves #27885
-
Nemanja Glumac authored
-
Tim Macdonald authored
This'll be revisited as part of v47 [Fixes #28425]
-
Nemanja Glumac authored
-
Anton Kulyk authored
-
Anton Kulyk authored
* Handle no data perms for model detail page * Fix loading metadata * Fix props name
-
Anton Kulyk authored
* Make `modelId` optional in `ActionCreator` * Add `onSubmit` prop to `ActionCreator` * Allow creating actions with "+ New" button * Add `nock.cleanAll()` * Address comments * Use `CollectionItem` type * Use `import type` * Enable loading and error wrapper for loader
-
- Feb 20, 2023
-
-
Case Nelson authored
* Fix linter * Make sure we're inlining num in substitution and sum aggregations * Set hsql version * Fixing tests * Fixing tests after the h2 conversion * Use h2x/extract in h2, fix test differences * Fixing tests for honeysql2 * Only numbers get inlined * More test fixes * Fixing tests * Undo bad commit * Inline Ratio must produce doubles or h2 will do integer division where 1/2 = 0 * Fix bad case statement * We can't run native queries with AS for oracle --------- Co-authored-by:
Cam Saul <github@camsaul.com> Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Cam Saul authored
-
Ryan Laurie authored
* use entity loader for db data in actions * update entity network mock
-
Ryan Laurie authored
* add parameter mapping explainer text * update link * use styled component link * update actiondashcardSettings tests
-
Nemanja Glumac authored
-
metamben authored
* Make joins work * Run fuzzy-field-info-test only against H2 * Set driver/*driver* when performing actions * Restrict expressions+joins-test to DBs supporting date arithmetics * Fix ordering of (top level) fields in mongo tables * Explicitly exclude mongo from tests requiring foreign key support * Optimize away $sort stage for implicit order-by.
-
Alexander Polyankin authored
-
Ryan Laurie authored
* add add question button to empty dashboard * more options * allow sidebar toggling * close navbar on nav to new question * more emotion * update tests
-
Anton Kulyk authored
-
Anton Kulyk authored
-
Ryan Laurie authored
* add helpers for actions testing * add basic action execution test * update add action test * add tags and documentation for tags * add tags to model actions spec * update test for new actions adding flow * fix merge conflicts * fix merge conflict again * address review comments * make test more reliable * prettier * prettier
-
Tim Macdonald authored
Especially helpful for work @camsaul is doing: https://github.com/clj-kondo/clj-kondo/issues/1996
-