This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 20, 2024
-
-
Uladzimir Havenchyk authored
* refactor: sort import members inside destructuring * Show an error message when the temporal unit is not applicable to a dashboard card (#46983) * Fix tests * Add tests * Add tests * Fix types * Fix types --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Jun 14, 2024
-
-
Oisin Coveney authored
-
- Jun 10, 2024
-
-
Denis Berezin authored
feat(sdk): SDK theming part 6 - text-brand, text-dark, text-light, text-medium, admin-navbar, `accentX` (#43687) * Migrate text-brand * Migrate text-dark * Migrate text-light * Migrate text-medium * Migrate admin-navbar * make compact formatting consistent across all series (#43472) * make compact formatting consistent across all series * fix rebase * [Browse] Show Browse models link in nav only when there are models (#43286) * Upgrade to TypeScript v5.4 (#43736) * use correct github api for CI (#43750) * update list of releases (#43754) * Multi Series Dashcards Render with Filters Applied To All Series (#43428) * Multi Series Dashcards Render with Filters Applied To All Series Fixes: #39083 Multi-series dashcards now properly render when a subscription is set up with filters that impact the values of each card in the multi-series card. * Small refactor for executing dashcards in a pulse context. - move execute-dashboard-subscription to pulse.util - this fn now will also execute all card series cards and put those results into a list on the key :series-results in the dashcard which is then used in the render multimethod to send the correct data to the javascript context A small todo was taken care of as well, we can now use :dashboard-subscription in the :context key * Fix up render fn The shape of hte data going into the javascript was a bit unclear before. This keeps things a little more understandable. Next step is probably to create some Malli schemas inside the js_svg namespace to document and enforce the needed data shapes * pull :data up a level from :result in the series cards * Update src/metabase/pulse/render/body.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Remove unneeded let * set/rename-keys won't work here because we raise the :data key I've realised a suggested change to just use set/rename-keys won't do what we need. We need instead to raise :data from within the result key up to the same level (and dissoc result). I've renamed the helper function to make its purpose a bit clearer --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Hydrate can_run_adhoc_query and address review comments (#43747) This is a followup on #43625. * Consolidate dashboard-card specs (#43716) * Consolidate joins specs (#43717) * Update translations for v50 and add Danish Language Support (#43314) * update translations for v50 * add Danish * update translations for v50 release * alphabetical order is nice * Move database role to url parameters from connection properties on Snowflake (#43602) * Move role to url parameters from connection properties * Fix test * Fix width of save button in cache sidebar (#43755) * Remove dead code (#43603) * Combine search e2e specs (#43718) * Highlight the table cell data in dashboards when the cell is an ID column (#43728) * highlight id cell column * add simpletable stories * add simple table test data * add loki reference image * Update frontend/src/metabase/visualizations/components/TableSimple/TableCell.styled.tsx Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Remove old repro for 39150 (#43749) * Fix remaining `tinyint` booleans in MySQL (#43296) * Correct type for `report_card.dataset` This was missed in the original migration of boolean types to ${boolean.type} in MySQL/MariaDB, and then missed again by me when I migrated `collection_preview` over a week ago. * Change all boolean types to `bit(1)` in MySQL Liquibase changed their boolean type in MySQL from `bit(1)` to `tinyint(4)` in version 4.25.1. Our JDBC driver does not recognize these as booleans, so we needed to migrate them to `bit(1)`s. As discussed [here](#36964), we changed all existing `boolean` types that were in the `001_update_migrations.yml` but not the SQL initialization file. For new installations, this works: things in the SQL initialization file get created with the `bit(1)` type. However, for existing installations, there's a potential issue. Say I'm on v42 and am upgrading to v49. In v43, a new `boolean` was added. In this case, I'll get the `boolean` from the liquibase migration rather than from the SQL initialization file, and it need to be changed to a `bit(1)`. I installed Metabase v41 with MySQL, migrated the database, and then installed Metabase v49 and migrated again. I made a list of all the columns that had the type `tinyint`: ``` mysql> SELECT TABLE_SCHEMA, TABLE_NAME, COLUMN_NAME, COLUMN_TYPE, COLUMN_DEFAULT, IS_NULLABLE FROM INFORMATION_SCHEMA.COLUMNS WHERE COLUMN_TYPE = 'tinyint' AND TABLE_SCHEMA='metabase_test'; +---------------+------------------------------+-------------------+-------------+----------------+-------------+ | TABLE_SCHEMA | TABLE_NAME | COLUMN_NAME | COLUMN_TYPE | COLUMN_DEFAULT | IS_NULLABLE | +---------------+------------------------------+-------------------+-------------+----------------+-------------+ | metabase_test | core_user | is_datasetnewb | tinyint | 1 | NO | | metabase_test | metabase_field | database_required | tinyint | 0 | NO | | metabase_test | metabase_fieldvalues | has_more_values | tinyint | 0 | YES | | metabase_test | permissions_group_membership | is_group_manager | tinyint | 0 | NO | | metabase_test | persisted_info | active | tinyint | 0 | NO | | metabase_test | report_card | dataset | tinyint | 0 | NO | | metabase_test | timeline | archived | tinyint | 0 | NO | | metabase_test | timeline | default | tinyint | 0 | NO | | metabase_test | timeline_event | archived | tinyint | 0 | NO | | metabase_test | timeline_event | time_matters | tinyint | NULL | NO | +---------------+------------------------------+-------------------+-------------+----------------+-------------+ 10 rows in set (0.01 sec) ``` Then wrote migrations. For each column, we: - turn it into a `bit(1)`, - re-set the previously existing default value, and - re-add the NOT NULL constraint, if applicable. * Change author and add missing `dbms` --------- Co-authored-by:
John Swanson <john.swanson@metabase.com> * Add ts-pattern library (#43752) * Add events to measure search performance (#43135) * new_search_query event * Filters in object, search click event * updating event schema * type and event schema adjustments * delete comments BE code * adjusting tests * PR feedback * typos and spacing * Fixup missing colors --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Alex Yarosh <alexandra@metabase.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com> Co-authored-by:
Phoomparin Mano <poom@metabase.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
SakuragiYoshimasa <ysrhsp@outlook.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
- Jun 04, 2024
-
-
Nicolò Pretto authored
* temporarily removes the SameSite=None suggestion box * fix copy
-
- Feb 27, 2024
-
-
Ryan Laurie authored
* add useSetting hook * example usage * better types * more implementations
-
- Feb 20, 2024
-
-
Kamil Mielnik authored
* Upgrade eslint-plugin-import * Configure import/order rule for consistent, predictable imports * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line" * Ensure imports are in a single block * Move or remove informative comments between import statements * Remove imports-grouping comments * Configure groups - the difference between the default setting is the presence of "internal" group * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies * Move comment to the same line as import * Run "yarn eslint-fix" 5 times - Remaining: 16 problems (16 errors, 0 warnings) * Manually fix imports order in remaining files * Run "yarn prettier" * Fix import * Fix circular dependency * Fix circular dependency * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency) * Re-add accidentally removed code * Fix typing * ESLint
-
- Feb 13, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix case where Metabase links are render inside template strings * Add `no-literal-metabase-strings` ESLint rule * Fix all Metabase string errors * Address review: Fix the rule The rule was checking if we have imported the selector `getApplicationName` then ignore all Metabase strings. This is different than `no-unconditional-metabase-links-render` because in that rule, when fixed the Documentation URLs are still in the file, but in this rule, when fixed, there should be no Metabase strings left in the file. * Fix errors from the new lint rule
-
- Jan 26, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* [WIP] ESLint for detecting the use of Metabase links * Add a rule to detect the use of Metabase links * Add tests to the new eslint lint rule that detect Metabase links * Fix all places where errors are caused by the new ESLint rule * Review: Disable rule for admin folder * Review: Remove rule disable reason from files under admin folder
-
- Jan 11, 2024
-
-
Alexander Polyankin authored
-
- Dec 25, 2023
-
-
Nicolò Pretto authored
* feat: single view for embedding settings regardless of setting status (#36802) * feat: single view for embedding settings regardless of setting status * refactor: rename component as now it doesn't container legalese * rename component and refactor * remove unused prop type * test: update e2e * fix not handling null value * fix: keep same behaviour for event * Update frontend/src/metabase/admin/settings/components/widgets/EmbeddingSwitchWidget/EmbeddingSwitchWidget.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * use target instead of currentTarget --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * remove deprecated event on embedding settings (#36857) * feat: Update the UI and copy of the embedding options cards (#36819) * feat: adds icon and some other small ui change * update buttons and ui * update links/buttons for interactive embed option * update unit tests * make e2e pass with the new changes * make unit test pass * integration/unit tests for embedding settings * fix herf -> href
* fix e2e suite * refactor: splti components in two * update url as by updaterd product doc * fix imports * update width as by design * fix linting error * fix copy * update layout, paddings, fontsize etc * add upgrade text * other ui fixes * last minute copy change * inline variable in tests to avoid beforeEach * fix typo * fix e2e by moving assertion on the correct page * fix typo in unit * update link as per product doc * inlie urls * only return used parts in setup function * e2e: update e2e upgrage url * remove oss version of the interactive embedding settings page (#36938) * remove oss version of the interactive embedding settings page * fix redirect logic + add tests * add key to make react not complain * merge lists of embedded questions and dashboards to have new heading structure (#36944) * feat: adds icon and some other small ui change * update buttons and ui * update links/buttons for interactive embed option * update unit tests * make e2e pass with the new changes * make unit test pass * integration/unit tests for embedding settings * fix herf -> href * fix e2e suite * refactor: splti components in two * update url as by updaterd product doc * fix imports * update width as by design * fix linting error * remove oss version of the interactive embedding settings page * merge lists of embedded questions and dashboards to have new heading structure * fix redirect logic + add tests * add key to make react not complain * use plain strings instead of regex when possible * remove regex for testids * fix copy * update layout, paddings, fontsize etc * add upgrade text * other ui fixes * last minute copy change * inline variable in tests to avoid beforeEach * fix typo * fix e2e by moving assertion on the correct page * fix typo in unit * update link as per product doc * inlie urls * only return used parts in setup function * e2e: update e2e upgrage url * update interactive embedding settings page ui (#36949) * feat: adds icon and some other small ui change * update buttons and ui * update links/buttons for interactive embed option * update unit tests * make e2e pass with the new changes * make unit test pass * integration/unit tests for embedding settings * fix herf -> href * fix e2e suite * refactor: splti components in two * update url as by updaterd product doc * fix imports * update width as by design * fix linting error * remove oss version of the interactive embedding settings page * merge lists of embedded questions and dashboards to have new heading structure * update interactive embedding settings page ui * fix redirect logic + add tests * add key to make react not complain * use plain strings instead of regex when possible * remove regex for testids * fix copy * update layout, paddings, fontsize etc * add upgrade text * other ui fixes * last minute copy change * inline variable in tests to avoid beforeEach * fix typo * fix e2e by moving assertion on the correct page * fix typo in unit * update link as per product doc * inlie urls * only return used parts in setup function * e2e: update e2e upgrage url * rename test files with correct naming (#37044) * rename test files with correct naming * test: fix setup functions and add enterprise suite * Fix interactive embedding link target * Update embedding toggle copy * Use default setting labels * Fix failed E2E test --------- Co-authored-by:Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
- Nov 08, 2023
-
-
Jesse Devaney authored
* initial frontend commit * add authorized origins check with note * update interactive embedding unit test * add samesite cookie to embedding E2E * add unit tests for conditional note display * fix types * fix translations * use alert instead of custom component
-
- Jul 10, 2023
-
-
Alexander Polyankin authored
-
- May 31, 2023
-
-
Alexander Polyankin authored
-
- Jan 06, 2023
-
-
Anton Kulyk authored
* Extract `setup` helper * Use more readable test string * Use `not.toBeInTheDocument` vs `toBeNull` * Fix missing assertions * Fix error about `widget` not being an element * Fix missing `key` prop * Improve new dashboard modal tests * Remove not used import * Fix typo * Add missing `key` props * Use `waitFor` instead of `act`
-
- Nov 18, 2022
-
-
Alexander Polyankin authored
-
- Jul 08, 2022
-
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Jun 30, 2022
-
-
Mahatthana (Kelvin) Nomsawadi authored
* WIP embedding changes * Simplify logic to not render nested setting page in the sidebar * Add sub setting for embedding for admin * Update embedding copies for OSS users * Fix E2E tests
-
- Dec 14, 2021
-
-
Alexander Lesnenko authored
* tune admin nav and remove premium embedding offer * update SecretKeyWidget style
-
- Oct 23, 2020
-
-
Cam Saul authored
-