Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 01, 2024
  2. Jan 31, 2024
  3. Jan 30, 2024
  4. Jan 29, 2024
  5. Jan 26, 2024
    • Cam Saul's avatar
      Chain filter search should check block perms (#38213) · 45080ad6
      Cam Saul authored
      * Chain filter search should check block perms
      
      * Simplify test
      45080ad6
    • Case Nelson's avatar
      Field values cache needs to check permissions (#38104) · 6101546f
      Case Nelson authored
      * Field values cache needs to check permissions
      
      If a user does not have permissions to the field, we should not return
      the cached field values.
      
      * Update default-get-or-create-field-values-for-current-user to check can-read too
      
      * Revert params.field-values change
      
      * Use query processor permissions checks before returning cached values
      
      * Return true from check
      
      * Fix test
      
      * Check for ee config
      6101546f
    • Nemanja Glumac's avatar
      Display chart caption even where there is no card title (#36801) · b0a54aa1
      Nemanja Glumac authored
      * Display chart caption even where there is no card title
      
      * Add E2E reproduction for #36788
      b0a54aa1
    • Nemanja Glumac's avatar
      Migrate `isStructured` method references to MLv2 (#37977) · 1dda54f4
      Nemanja Glumac authored
      * Migrate `isStructured` method references to MLv2
      
      * Fix broken audit pages
      
      Just as with #38123, this is another place where MLv2 invocation broke
      because it didn't guard against the internal queries.
      
      * Remove `isStructured()` method from the `Question` prototype
      1dda54f4
    • Romeo Van Snick's avatar
      Run selected text loses parameters (#38095) · bb6a4d0b
      Romeo Van Snick authored
      * Reproduction: Run selected text does not use parameter values correctly
      
      * Use question instead of card when overriding
      
      * Switch to overrideWithQuestion in RELOAD_CARD
      
      * Rename run to dataset in e2e test
      
      * Use cypress builtins instead of custom selectors
      
      * Remove async from e2e test
      
      * Avoid assigning editor to variable
      
      * Type closing }} on editor
      
      * Set type delay to 0
      
      * Add explainer about why the reproduction differs from the issue
      
      * Add limit to test case
      
      * Test actual vizualisation results instead of implementation detauls of dataset
      
      * Clarify that the space is not needed
      
      * Simplify cypress check
      bb6a4d0b
Loading