This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 08, 2024
-
-
Kamil Mielnik authored
* Try to fix flake * See if timeout is necessary * Revert "See if timeout is necessary" This reverts commit 181f3c5e. * Revert change for coordinates filter
-
Kamil Mielnik authored
* Remove @flaky tag * Make workaround test pass * Disable workaround test * Uncomment and unquarantine the workaround test * Disable normal test for now * Revert "Disable normal test for now" This reverts commit 68fa2175. * Bring back quarantine * Update comment
-
Mahatthana (Kelvin) Nomsawadi authored
* Correct embedding hash options type semantically * Pass `X-Metabase-Locale` to embed downloads * wip locale header middleware * Allow smart scalar text to be translated * Stop using global variable * Add more details to embedding types * Extend the E2E util type and correct some properties types * Add e2e test * Fix dashboard name * Add a test for static embed question * Make a type name follows a convention Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Fix failed E2E tests due to missing default values * Fix public embed not working with `?locale` anymore * Revert "wip locale header middleware" This reverts commit 83d8d135. * Preserve locale when in the `as-admin` macro is used Motivating issue: ```shell ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Count" ] ``` I'm running a query that has aggregated columns and it is returning the untranslated. Note that these are computed and dynamically given a display name. ```clojure (case tag :count (i18n/tru "Count") :cum-count (i18n/tru "Cumulative count")) ``` The problem is that we run embedding things as admin. And that gets the current user, which in embed and public spaces is nil, and so binds a nil to user-locale, which defaults to english when translating. After: ``` ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Nombre de lignes" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:zh -pb | jq '.data|.cols|map(.display_name)' [ "State", "行数" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124 ' x-metabase-locale:es -pb | jq '.data|.cols|map(.display_name)' [ "State", "Contar" ] ``` This is fetching a dashboard's card which is a query of orders grouped by created at month, sum of total. --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- Nov 07, 2024
-
-
Raphael Krut-Landau authored
-
Nemanja Glumac authored
* Move the upload CSV button to the main nav bar * Remove the old `SidebarOnboardingSection` * Remove obsolete unit tests * Rework E2E tests * Add some spacing around the button * Fix E2E test * Break `MainNavbar` unit test down * Expand unit tests * Update E2E tests * Fix E2E test failure * Move JSDoc where it belongs * Provide context for translators * Simplify the condition
-
Kamil Mielnik authored
Fix - Values from the returned rows not present in the visualization are interpolable in the URL but don't have values (#49530) * Fix #46318 * Add repro for #46318 * Move setup to beforeEach
-
- Nov 06, 2024
-
-
Alexander Polyankin authored
* Fix :pivot-measures with column names * Fix the test * Update src/metabase/query_processor/pivot.clj Co-authored-by:
Braden Shepherdson <braden@metabase.com> * Add a test * Add a test --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
Kamil Mielnik authored
* Remove @flaky tag * Fix flake * Refactor * Use getDashboardCard * Shorten text * Fix flake * Revert previous changes * Revert "Revert previous changes" This reverts commit 16b56f26. * Fix flake
-
Kamil Mielnik authored
* Remove @flaky tag * Fix flake * Try typing delay instead * Improve comment * Bring back original solution
-
Uladzimir Havenchyk authored
-
Nicolò Pretto authored
* refactor + more specific auth errors * fix linting issues * make tests pass, again * make test pass for real? * continues the refactor and hopefully makes tests pass * try to simplify the logic a little bit more * also logs to the console for the edge case of invalid session * remove setLoginStatus * fix typo * fix debug line that should have been commented * remove dead code * remove test for code that doesnt exist * address feedback from PR * update test copy * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * update copy for site settings error * ex -> exception * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * update tests to use the updated copy + small typos * refactor: use jest spy on to check for console.error Co-authored-by:
"Mahatthana (Kelvin) Nomsawadi" <me@bboykelvin.dev> * use full error message in test * renamed response to session * mock implementation of console.log * fix(49482): don't create a new store on each MetabaseProvider render (#49492) * fix(49482): don't create a new store on each MetabaseProvider render * remove store prop as it seems to not be used --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 05, 2024
-
-
Alexander Polyankin authored
-
Kamil Mielnik authored
* Update saveDashboard helper to wait for the GET /api/dashboard/:id request - update aliases to be unique so that they don't interfere with aliases used in tests * Remove no longer needed intercept + wait
-
Romeo Van Snick authored
* Fix dirty yarn.lock * Use fix width popover for filter pickers * Add e2e test to reproduce #49321 * Do not rely on implementation width for test
-
Romeo Van Snick authored
* Fix missing question type for metrics * Add e2e test to reproduce #49454
-
- Nov 04, 2024
-
-
Kamil Mielnik authored
* Fix flaky #16559 repro * Wait for getCollections * Clean up helper * Wait for cardQuery before saving the dashboard
-
Kamil Mielnik authored
* Fix flaky custom column test * Fix flaky custom column test
-
Phoomparin Mano authored
feat(sdk): ability to enforce the destination collection to save to and hide the collection picker (#49251) * add ability to hide the collection picker * add save options * make sure collectionId is fresh * update sdk question form component * make collectionId accept null * apply saveOptions to sdk components * revert to use initialCollectionId as context name * target the correct collection id * add e2e tests * update e2e tests * move into within * update test * remove collectionId from default args * revert e2e of hide columns * make e2e helper more generic * use saveToCollectionId prop to save to a specific collection * update e2e tests * update comment formatting Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * clean up leftover changes from an earlier version * readme update * indicate that saveToCollectionId is only applicable to static questions * revert QuestionEditor.isSaveEnabled defaults * update comment format * remove unused initialCollectionId prop * experiment: try to fix failing custom-columns e2e --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Romeo Van Snick authored
* Consider a modified question dirty as well * Add e2e tests for 48829
-
- Nov 03, 2024
-
-
Nick Fitzpatrick authored
* Adding moderated status to entity picker * adjusting verified icon size * size adjustments * e2e test adjustments * removing verified model icon * fixing e2e test * unit test * unit test adjustment
-
- Nov 01, 2024
-
-
Nick Fitzpatrick authored
* Adding moderation status to Dashboards * react sins * verification coll: subselect on card + dashboard * fix the 3 failing BE tests * add an api test for dashboard verification * verified dashboards are never stale * e2e tests * code cleanup * unit test and e2e test cleanup * PR Feedback * backend test fixes * Nick shouldn't touch clojure * type fix * indent * fix last 2 BE tests --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Romeo Van Snick authored
* WIP: use list picker when searching a single value * Add test case for multi vs non-multi search fields * Update loki snapshots * Add special case to test for multiautocomplete filter * Use single select value in test * Add test for using list picker * Explicitly make sure elements are visible * Do not use list selector when search is disabled * Add margin to multi autocomplete dropdown * Update loki snapshots * Update loki snapshots
-
Denis Berezin authored
* Fix scroll for EditableDashboard in fullscreen mode * Fix scroll for InteractiveDashboard in fullscreen mode * Display fullscreen control to dashboards by default * Fix issue with public shared questions empty footer
-
Romeo Van Snick authored
This reverts commit fedd1466.
-
- Oct 31, 2024
-
-
Kamil Mielnik authored
* Fix flaky #34574 repro * Format code * Add a wait * Decrease flakiness * Fix flake * Update comment
-
Kamil Mielnik authored
* Fix flaky test * Fix flaky test
-
Nick Fitzpatrick authored
-
Raphael Krut-Landau authored
-
Kamil Mielnik authored
* Fix flaky 25374-3 test * Fix flaky 25374-4 test * Fix race conditions * Decrease flakiness * Fix wrong param * Bullet-proofing
-
Alexander Polyankin authored
-
Kamil Mielnik authored
* Fix #49036 * Add explanatory comments * Improve comment * Improve comment * Update comment * Add repro for #49036 * Exclude custom Shift + Tab handling
-
Romeo Van Snick authored
* Manually remove bad matches when preparing results for ACE * Do two-phase autocompletion * Allow single-character completions * Add test for flickering autocomplete results * Fix autocomplete tests * Simplify autocomplete helpers * Handle empty results in autocomplete * Fix e2e test
-
- Oct 30, 2024
-
-
Nemanja Glumac authored
* Remove unused component * Remove extra space * Remove cross-component dependency on the `Banner` * Use named export * Convert the Banner to TS * Make `ReadOnlyBanner` use `Banner` under the hood * Add test id to the banner * Simplify render method and tests * Add the missing test for ReadOnly banner * Avoid using special ASCII characters for the common apostrophe * Remove E2E spec * Use `Banner` for `DatabaseInfoField` * Use colors defined in the theme * Remove the dependency on the `Banner` component again! * Add a comment * Use pattern matching
-
Mahatthana (Kelvin) Nomsawadi authored
* Update static embed card copy to avoid confusion * Fix E2E tests * Fix unit tests * Update the copy inside static embed modal
-
- Oct 29, 2024
-
-
Romeo Van Snick authored
* Add reproduction for #12586 * Do not show the dirty overlay when an error occurred * Fix tests that rely on dirty overlay * Add issue tag to test case Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Romeo Van Snick authored
* Add max-height to the click actions popover to prevent overflow and infinite scroll * Add reproduction for #48851 * Update reproduction to speed it up * Use existing helper for table header click * Add max height to string filter picker * Revert "Add max-height to the click actions popover to prevent overflow and infinite scroll" This reverts commit 166478d8.
-
- Oct 28, 2024
-
-
Aleksandr Lesnenko authored
* add grey accent color * fix pie chart color assignment * specs * update grey accent * update colors * grey -> gray
-
Nemanja Glumac authored
* Add new route * Add the navigation link * Guard the route * Add first pass of the page structure * Add the bottom section * Add placeholder dummy YT videos * Add images * Track checklist being opened * Track checklist item expanded * Track checklist item CTA clicked * PoC: Stop the video on accordion change * Use actual onboarding videos * Fix missing unique `key` prop * Final content tweaks * Override the accordion styles defined in the `theme` * Use predefined t-shirt sizes where possible * Update copy * Conditionally display the example dashboard CTA * Add very basic unit test coverage * Show onboarding link to new instances only * Remember the last position in the onboarding * Fix the mock settings types * Scroll last opened item into view * Properly display docs links * Another accordion style override * Add tests for the Onboarding page contents * Add E2E Snowplow tests * Conditionally display xray item contents based on settings * Split tests * Make sure items scroll into view when expanded * Do not show example question CTA if example dashboard doesn't exist * Allow YT videos to play in fullscreen * Add comments about the example question * Update rules for when we show the onboarding nav link * Test the conditional documentation links display * Reduce E2E test flakiness
-
Aleksandr Lesnenko authored
* pie chart crashes when light or dark accents of instance colors overriden * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Alexander Polyankin authored
E2E test for "Custom click behavior on a pivot table will go always to tab 1 on a destination dashboard with several tabs" (#49187) * Add tests * Add tests * Add tests
-