Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 14, 2022
  2. Jun 13, 2022
  3. Jun 11, 2022
  4. Jun 10, 2022
  5. Jun 09, 2022
    • Alexander Lesnenko's avatar
      truncate long columns (#23151) · d67d6f06
      Alexander Lesnenko authored
      Unverified
      d67d6f06
    • dpsutton's avatar
      Fix mysql humanize error (#23263) · 051534fe
      dpsutton authored
      * Correctly handle fall-through case.
      
      Condp is exhaustive and throws if nothing matches
      
      ```
      mysql=> (condp = 2
                1 :nope
                3 :nope)
      Execution error (IllegalArgumentException) at metabase.driver.mysql/eval169387 (REPL:870).
      No matching clause: 2
      mysql=>
      ```
      
      and can take a single default clause at the end with no predicate
      
      ```clojure
      mysql=> (condp = 2
                1 :nope
                :default-catch-all)
      :default-catch-all
      ```
      
      This was attempted with a regex `#".*"` but this regex does not match
      everything!
      
      ```clojure
      mysql=> (driver/humanize-connection-error-message :mysql
                                                        "hello\nthere")
      Execution error (IllegalArgumentException) at metabase.driver.mysql/eval167431$fn (mysql.clj:124).
      No matching clause: hello
      there
      mysql=> (re-matches #".*" "hi\nthere")
      nil
      ```
      
      So just use use the message as the default to be returned which was the
      original intention.
      
      * Fix other databases as well
      Unverified
      051534fe
    • Ariya Hidayat's avatar
    • Noah Moss's avatar
      Force slack channel cache refresh when new token is saved (#23253) · 68951307
      Noah Moss authored
      * clear Slack cache last-updated value when resetting cache
      
      * use clear-channel-cache! function on invalid tokens as well
      Unverified
      68951307
Loading