This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 23, 2022
-
-
dpsutton authored
* Allow for disabling settings Disabled settings will return their default value (else nil if no default is set). This allows us to have enterprise override settings and use them from regular OSS code without classloaders, extra vars, remembering to check if the feature is enabled, etc. Motivating examples are the appearance settings. We allow `application-font` setting to change the font of the application. This is an enterprise feature, but anyone can post to `api/setting/application-font` and set a new value or startup as `MB_APPLICATION_FONT=comic-sans java -jar metabase.jar` and have the functionality. Same thing for application colors in static viz. The calling code just calls `(settings/application-colors)` and uses them but doesn't check if the enterprise settings are enabled. To do this correctly, you have to remember to implement the following onerous procedure: A whole namespace for a setting ```clojure (ns metabase-enterprise.embedding.utils (:require [metabase.models.setting :as setting :refer [defsetting]] [metabase.public-settings :as public-settings] [metabase.public-settings.premium-features :as premium-features] [metabase.util.i18n :refer [deferred-tru]])) (defsetting notification-link-base-url (deferred-tru "By default \"Site Url\" is used in notification links, but can be overridden.") :visibility :internal :getter (fn [] (when (premium-features/hide-embed-branding?) (or (setting/get-value-of-type :string :notification-link-base-url) (public-settings/site-url))))) ``` And then in the calling code you have to do the procedure to conditionally require it and put it behind a var that can handle it being nil: ```clojure ;; we want to load this at the top level so the Setting the namespace defines gets loaded (def ^:private site-url* (or (u/ignore-exceptions (classloader/require 'metabase-enterprise.embedding.utils) (resolve 'metabase-enterprise.embedding.utils/notification-link-base-url)) (constantly nil))) ;; and then the usage (defn- site-url "Return the Notification Link Base URL if set by enterprise env var, or Site URL." [] (or (site-url*) (public-settings/site-url))) ``` Far nicer to just place the following into the regular public-settings namespace: ```clojure (defsetting notification-link-base-url (deferred-tru "By default \"Site Url\" is used in notification links, but can be overridden.") :visibility :internal :enabled? premium-features/hide-embed-branding?) ``` Then no need for a custom namespace to hold this setting, no need to have an extra var to point to the setting else a fallback value. Note that this feature is not required on every enterprise feature we have. We a namespace `metabase-enterprise.sso.integrations.sso-settings` that has 24 settings in it, all of which are enterprise features. But these features are used in our enterprise sso offerings and are directly referenced from the enterprise features. No need for the extra var to point to them and the flag checks happen in other parts. * Mark the UI/UX customization settings as requiring whitelabeling Mark the following settings as requiring premium-settings/enable-whitelabeling? (aka token check) - application-name - loading-message (override of "doing science") - show-metabot (override of showing our friendly metabot) - application-colors - application-font - application-logo-url - application-favicon-url Updates the helper functions for colors to use the setting rather than feeling entitled to use a lower level `setting/get-value-of-type`. We need the higher level api so it takes into account if its enabled or not. * Move notification-link-base-url into regular settings with enabled? * Cleanup ns
-
Ariya Hidayat authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Hide password + user form fields when logged in via JWT and SAML * ngoc - update the maybe-add-sso_soruce * Address review: removing deprecated Cypress functions Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Ngoc Khuat authored
* make schema for parameters and parameter_mappings more strict * no duplicate id for parameterlist in mbql schema * reverse a change in mbql schema * allow blank name and slug for parameter * add sectionId * trying to use mbql.s/Parameter instead * reverse change to use mbql.s/Parameter, there are too many failing tests
-
Cal Herries authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Configure show download button in embedding * Address review + fix tests
-
- Jun 22, 2022
-
-
metamben authored
-
Nick Fitzpatrick authored
-
Nick Fitzpatrick authored
-
Ryan Laurie authored
*Inline key + text pickers
-
Jeff Bruemmer authored
-
Ryan Laurie authored
* add inline category filters
-
Ngoc Khuat authored
* Grant Snippets root collection for all users * update perms path * update cypress test * Update repro for #17268 * remove trailing spaces * don't run migration on existing EE instances * fix migration failed in mysql and mariadb * run migration for new instances only Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Alexander Kiselev authored
* TS upgrade * upgrade tslint too
-
- Jun 21, 2022
-
-
metamben authored
* Add collection_preview field to report_card table * Convert bits from MySQL/MariaDB union queries into booleans
-
Cal Herries authored
-
Cal Herries authored
* Add reply-to setting for emails * Add reply-to to SMTPSettings * Change setting UI to match spec * Remove WIP comment * Add email-from-name setting * Support comma delimited list of emails for reply-to setting * Remove extra require * Remove console.logging * Improve the setting descriptions * update email settings * For now, limit reply-to field to one email * Change back SMTPSettings to closed map * Change test to only one reply-to email * Fix SMTPSettings reply-to type * Fix email-api-test * Fix e2e email setup * Add more checks in e2e tests * Fix smoketest Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Noah Moss authored
* first pass at updating parameter validation to include notebook cards and match template tags by either ID or name * fix existing tests * fix more tests * new test * more refactor and another test * Update src/metabase/query_processor/card.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * update names to ngoc's suggestions * Update test/metabase/query_processor/card_test.clj Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> * Update src/metabase/query_processor/card.clj Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> * specific error msg for missing id on request param Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Nick Fitzpatrick authored
-
Alexander Polyankin authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Remove redundant check * Delete data model tests from the admin setup spec * Refactor hide tables spec * Remove admin_setup spec * Add a dummy test so that CircleCI job doesn't fail
-
Nemanja Glumac authored
* Remove various admin checks from smoke tests * Move repro 22754 over to `onboarding > setup` * Remove `admin` spec from smoke tests
-
Alexander Polyankin authored
-
Braden Shepherdson authored
They're useful in v2 serialization as well.
-
Ryan Laurie authored
-
Aleksandr Lesnenko authored
* add metabot animation * review
-
Nemanja Glumac authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Nick Fitzpatrick authored
-
Aleksandr Lesnenko authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Prevent SSO users from changing their user info * Show user name and email under the avatar in profile settings * Add E2E tests * Improve redability * Fix test failure from merging other PR * Clean up user form usage * Extract getFullName to common util
-
- Jun 20, 2022
-
-
Dalton authored
* Add title to NumberInputWidget * make it a label
-
Aleksandr Lesnenko authored
-
Nemanja Glumac authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
metamben authored
Fix compilation of temporal arithmetic for BigQuery and Mongo 5+ * Mongo 4 doesn't support $dateAdd so the generated filters result in an exception. * Support adding field to interval too (time intervals were not allowed in the first place of an addition) * Support temporal arithmetic with more than two operands for Mongo
-
adam-james authored
* Audit Queries fall back to email when first/last names are nil The audit page displays user information, and one column is "Name". Since we now allow nil first/last names, this value can return as a single space character. Instead, I've changed `common/user-full-name` to fall back to returning the user's email address if they have no first/last name values. Additionally: - since names can be nil, I've added sort by email to some of the queries for the audit page - display names have been changed from "Name" to "Member" in several queries to better fit the fallback to email * Add a test to check that audit pages have proper name fallback * Try to get test passing in CI * Make query work in MySQL by coalescing 'null' to empty string
-