* Add max-height to the click actions popover to prevent overflow and infinite scroll

* Add reproduction for #48851

* Update reproduction to speed it up

* Use existing helper for table header click

* Add max height to string filter picker

* Revert "Add max-height to the click actions popover to prevent overflow and infinite scroll"

This reverts commit 166478d8.

Co-authored-by: Romeo Van Snick <romeo@romeovansnick.be>

Co-authored-by: Oisin Coveney <oisin@metabase.com>

- AG instances cannot connect to open ai

Co-authored-by: bryan <bryan.maass@gmail.com>

The audit collection is a bit weird. Users have permissions on the
collection but even superusers don't actually have write permissions on
the elements within it.

For now, I'm just excluding anything in the audit collection from the
"stale" endpoint, so we won't suggest cleaning these up, but I wonder if
maybe there's a cleaner way here. It feels weird to fake permissions
like this.

Fixes https://github.com/metabase/metabase/issues/49164



Co-authored-by: John Swanson <john.swanson@metabase.com>

* document loader and error states

* document loader and error states in the docs

* revert changes to README.md



---------

Co-authored-by: Phoomparin Mano <poom@metabase.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Fix sunburst color assignment that causes pie chart crashing (#49183)

* pie chart crashes when light or dark accents of instance colors overriden

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>

* Update Loki Snapshots

---------

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>

E2E test for "Custom click behavior on a pivot table will go always to tab 1 on a destination dashboard with several tabs" (#49187) (#49235)

* Add tests

* Add tests

* Add tests

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

* Fix adding a time in legacy date picker

* Fix the test

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

* Add verifyNotebookQuery helper

* Use describeEE

* Fix DB id

* Refactor test

* Refactor tests

* Introduce customizeLinkText helper

* Use verifyNotebookQuery

* Fix test setup

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

Co-authored-by: Phoomparin Mano <poom@metabase.com>

 backported "Ensure we clean up model persistence table when model or DB is permanently deleted" (#49200)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Co-authored-by: bryan <bryan.maass@gmail.com>

Co-authored-by: Oisin Coveney <oisin@metabase.com>

* Fix actions without parameters

* Update frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.unit.spec.tsx



---------

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

* fix invalid pie other slice percentage label

* fix invalid percentages of grouped into other rows

* spec

* spec

* Update Loki Snapshots

* Update Loki Snapshots

* Update Loki Snapshots

---------

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>

* minor 51 notes

* Update docs/questions/sharing/visualizations/line-bar-and-area-charts.md

* link

* Apply suggestions from code review



* review

---------

Co-authored-by: Alex Yarosh <alexandra@metabase.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

* Fix csp directives for embed previews

We set content security directives to allow for iframes on
dashboards. This list did not include 'self' so we can't actually host
an iframe pointing at our, well, self.

Embed previews work by just embedding an iframe with the dashboard and
this breaks if we don't allow iframes from our self.

* e2e test

---------

Co-authored-by: dpsutton <dan@dpsutton.com>
Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>

* Fix static embed card download when param has accentuation

* Fix E2E util type

* Add a dashboard E2E test

* test question download with params

* Fix some names regarding tests

* Fix failed E2E tests

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* investigate hide columns

* add update viz settings in the sdk

* cleanup implementation

* add storybook for interactive question

* use the question callback to update viz settings

* remove onUpdateVisualizationSettings

* revert change to onUpdateVisualizationSettings

* add click action behaviour

* fix misspelling

* add onUpdateQuestion mock function

* add unit test for click action behaviour

* add e2e test for hiding question column header

Co-authored-by: Phoomparin Mano <poom@metabase.com>

Co-authored-by: Nicolò Pretto <info@npretto.com>

* test(sdk): add tests for auth flow

* make the fetch token fn return something that will pass the validations
we'll add in the next project

* waitForRequest helper + add expects for card endpoints on api key test

Co-authored-by: Nicolò Pretto <info@npretto.com>

* Format databricks as spark in prettify-native-form

* Add test to be generalized in follow up

Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com>

Co-authored-by: Oisin Coveney <oisin@metabase.com>

* cancel request on unmount in static question

* use deferred promise

* remove logs

* alias cancelled to deferred.promise

* extract useLoadStaticQuestion hook

* add tests for request cancellation

* change updateQuestion method

* add sanity check with fetchMock

Co-authored-by: Phoomparin Mano <poom@metabase.com>

* implement saving questions in interactive question

* close modal on create question

* add e2e test for saving questions

Co-authored-by: Phoomparin Mano <poom@metabase.com>

* Update X-ray to use rtk query

* PR feedback

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Fix date formatting of parameter values with time

* Update frontend/src/metabase/parameters/utils/date-formatting.ts



* Adjust E2E test

* Fix tests

---------

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

Co-authored-by: Denis Berezin <denis.berezin@metabase.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

Co-authored-by: Oisin Coveney <oisin@metabase.com>

* Update Readme version references and published npm version to 1.51.2

* Remove duplicate changelog entries from republishing

---------

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>