Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 15, 2023
  2. May 14, 2023
  3. May 13, 2023
  4. May 12, 2023
    • Ryan Laurie's avatar
    • dpsutton's avatar
      Hides malli's instrumentation messages (#30737) · 97108afc
      dpsutton authored
      Before:
      ```
      ❯ clj -M:"$ALIASES"
      WARNING: abs already refers to: #'clojure.core/abs in namespace: clojure.algo.generic.math-functions, being replaced by: #'clojure.algo.generic.math-functions/abs
      operator.clj:172 recur arg for primitive local: sum is not matching primitive, had: Object, needed: long
      Auto-boxing loop arg: sum
      Clojure 1.12.0-alpha2
      user=> (do (dev) (start!))
      Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/17.0.1-zulu/zulu-17.jdk/Contents/Home
      2023-05-12 14:26:37,091 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB
      2023-05-12 14:26:47,248 INFO util.encryption :: Saved credentials encryption is DISABLED for this Metabase instance. :unlock:
       For more information, see https://metabase.com/docs/latest/operations-guide/encrypting-database-details-at-rest.html
      ..instrumented #'metabase.util.malli/with-api-error-message
      ..instrumented #'metabase.util.honey-sql-2/identifier
      ..instrumented #'metabase.util.honey-sql-2/normalize-type-info
      ..instrumented #'metabase.util.honey-sql-2/with-database-type-info
      ..instrumented #'metabase.util.honey-sql-2/cast
      ..instrumented #'metabase.util.honey-sql-2/quoted-cast
      ```
      
      After:
      
      ```
      ❯ clj -M:"$ALIASES"
      WARNING: abs already refers to: #'clojure.core/abs in namespace: clojure.algo.generic.math-functions, being replaced by: #'clojure.algo.generic.math-functions/abs
      operator.clj:172 recur arg for primitive local: sum is not matching primitive, had: Object, needed: long
      Auto-boxing loop arg: sum
      Clojure 1.12.0-alpha2
      user=> (do (dev) (start!))
      Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/17.0.1-zulu/zulu-17.jdk/Contents/Home
      2023-05-12 15:11:21,678 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB
      2023-05-12 15:11:30,806 INFO util.encryption :: Saved credentials encryption is DISABLED for this Metabase instance. :unlock:
       For more information, see https://metabase.com/docs/latest/operations-guide/encrypting-database-details-at-rest.html
      util.cljc:346 recur arg for primitive local: cumulative_byte_count is not matching primitive, had: Object, needed: long
      Auto-boxing loop arg: cumulative-byte-count
      WARNING: infinite? already refers to: #'kixi.stats.math/infinite? in namespace: kixi.stats.core, being replaced by: #'clojure.core/infinite?
      2023-05-12 15:11:55,615 INFO driver.impl :: Registered abstract driver :sql  :truck:
      ```
      Unverified
      97108afc
    • Jeff Bruemmer's avatar
      docs - pro links (#30742) · 1c525938
      Jeff Bruemmer authored
      * add links to paid features section
      
      * add readme link
      
      * update links
      Unverified
      1c525938
    • bryan's avatar
      Add app db as audit db on app startup (#30305) · 11c1bbaf
      bryan authored
      * add column for marking the audit database
      
      * create audit db on app startup
      
      On app startup, in enterprise mode, always check that there is an
      up-to-date audit database with is_audit set to true. up-to-date means
      that it matches the app-db. If the audit db doesnt exist, or doesn't match up with
      the app-db, it will be created. otherwise no-op
      
      - refactor GET /api/database/ into defendpoint
      
      * add a few tests
      
      * add more tests + return kw for no-op
      
      * Merge branch 'master' into bcm-add-app-db-as-audit-db
      
      * fix migrations file
      
      * lint fix + remove def
      
      * keep the old audit db around
      
      - nil -> ::no-op
      
      * small macro fix
      
      * Merge branch 'master' into bcm-add-app-db-as-audit-db
      
      * Merge branch 'master' into bcm-add-app-db-as-audit-db
      
      * move ensure-db-exists! into its own namespace
      
      - avoids circlar dependency on app startup
      
      * fix tests
      
      * lint fix
      
      * inspect test values
      
      * use mdb.env/env to initialize audit db
      
      * try returning the app-db connection pool
      
      - instead of making a doppelganger in metabase database
      
      * get the is_audit column when looking up dbs in qp
      
      - this key is needed to return the appdb for the "Audit DB"'s connection
      
      * clean up audit-db install/update/noop logic
      
      * remove audit db from GET api/database/
      
      * Merge branch 'master' of github.com:metabase/metabase into bcm-add-app-db-as-audit-db
      
      * fix linter + inline extra function
      
      * fix a test
      
      * Merge branch 'master' into bcm-add-app-db-as-audit-db
      
      * don't test actions on audit db :cry:
      
      * Revert "don't test actions on audit db :cry:"
      
      This reverts commit 581ed1ab9495de7b46bccb8b1ab19f66a8fd106d.
      
      * for tests to work low IDs are basically reserved
      
      - use a higher id when installing audit db
      
      * use defenterprise for ensure-audit-db-installed!
      
      * Merge branch 'master' into bcm-add-app-db-as-audit-db
      Unverified
      11c1bbaf
    • Natalie's avatar
      docs - update sandboxes some more (#30738) · fd8158f2
      Natalie authored
      Unverified
      fd8158f2
    • Natalie's avatar
      docs - update data sandbox examples (#30733) · 3958b4f6
      Natalie authored
      Unverified
      3958b4f6
    • Ngoc Khuat's avatar
      [Feature] Dashboard Tab basic functionality (#30177) · d617aecf
      Ngoc Khuat authored
      
      * Dashboard Tab entity (#29802)
      
      * add dashboard tab entity
      
      * Dashboard tabs CRUD (#29861)
      
      * Dashboard tabs frontend (#30189)
      
      * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx`
      
      commit-id:7cdfd86a
      
      * add tabs to dash
      
      commit-id:d3c2fa74
      
      * improve code structure and other fixes
      
      * rename `dashboardtab_id` to `dashboard_tab_id`
      
      * remove explicit `position` logic
      
      * improve code quality
      
      * add renaming functionality
      
      * add two new tabs when creating first tab
      
      * hide tabs if there is only one
      
      * add unit test for `DashboardTabs` component
      
      * refactor
      
      * fix type errors
      
      * add `tabId` to text cards
      
      * add `tabId` to link cards
      
      * add `tabId` to action button
      
      * use disabled state when only one tab remains
      
      * refetch cards with filter value when changing tabs
      
      * add e2e test
      
      * fix broken e2e tests
      
      * add horizontal scrolling
      
      * fix unit test
      
      * fix create tab button being on right
      
      * fix performance issue when switching tabs
      
      * add `ttag` to `tabs.ts`
      
      * use `aria-label` in e2e test helper
      
      * fix type error after rebasing
      
      * making ordered_tabs optional for tests purposes
      
      * fix failing unit tests
      
      * fix failing e2e tests
      
      * fix flaky revision history e2e test
      
      * fix type error after merging feature branch with master and rebasing
      
      * fix revisions unit test
      
      * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      ---------
      
      Co-authored-by: default avatarEmmad Usmani <emmadusmani@berkeley.edu>
      Unverified
      d617aecf
  5. May 11, 2023
  6. May 10, 2023
    • Natalie's avatar
      docs - rewrite data sandboxes (#30445) · 03e2afba
      Natalie authored
      Unverified
      03e2afba
    • dpsutton's avatar
      Alternative GEOJSON.io fix (#30675) · 37217e7d
      dpsutton authored
      * Alternative GEOJSON.io fix
      
      rather than not testing, just accept that we might get an expected
      location back or we might get nil. This actually represents how the
      application will behave and will seamlessly work as the service improves
      or continues throwing errors:
      
      ```shell
      ❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23"
      <html>
      <head><title>500 Internal Server Error</title></head>
      <body>
      <center><h1>500 Internal Server Error</h1></center>
      <hr><center>openresty</center>
      </body>
      </html>
      
      ❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73"
      [{"area_code":"0","organization_name":"GOOGLE","country_code":"US",
        "country_code3":"USA","continent_code":"NA","ip":"8.8.8.8",
        "region":"California","latitude":"34.0544","longitude":"-118.2441",
        "accuracy":5,"timezone":"America\/Los_Angeles","city":"Los Angeles",
        "organization":"AS15169 GOOGLE","asn":15169,"country":"United States"},
       {"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US",
       "country_code3":"USA","continent_code":"NA","ip":"136.49.173.73",
       "region":"Texas","latitude":"30.2423","longitude":"-97.7672",
       "accuracy":5,"timezone":"America\/Chicago","city":"Austin",
       "organization":"AS16591 GOOGLE-FIBER","asn":16591,"country":"United States"}]
      ```
      
      Changes are basically
      
      ```clojure
      (schema= (s/conditional some? <original-expectation-schema>
                              nil?  (s/eq nil)
               response-from-geojson)
      ```
      
      * Filter to login error messages
      
      ```clojure
      (into [] (map (fn [[log-level error message]] [log-level (type error) message]))
            error-messages-captured-in-test)
      [[:error
        clojure.lang.ExceptionInfo
        "Error geocoding IP addresses {:url https://get.geojs.io/v1/ip/geo.json?ip=127.0.0.1}"]
       [:error clojure.lang.ExceptionInfo "Authentication endpoint error"]]
       ```
      
      * check timestamps with regex
      
      seems like they fixed the service
      
      ```shell
      curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23"
      [{"country":"United States","latitude":"34.0544","longitude":"-118.2441","accuracy":5,"timezone":"America\/Los_Angeles","ip":"8.8.8.8","organization":"AS15169 GOOGLE","country_code3":"USA","asn":15169,"area_code":"0","organization_name":"GOOGLE","country_code":"US","city":"Los Angeles","continent_code":"NA","region":"California"},{"country":"United States","latitude":"30.2423","longitude":"-97.7672","accuracy":5,"timezone":"America\/Chicago","ip":"136.49.173.73","organization":"AS16591 GOOGLE-FIBER","country_code3":"USA","asn":16591,"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US","city":"Austin","continent_code":"NA","region":"Texas"},{"country":"France","latitude":"48.8582","longitude":"2.3387","accuracy":500,"timezone":"Europe\/Paris","ip":"185.233.100.23","organization":"AS198985 AQUILENET","country_code3":"FRA","asn":198985,"area_code":"0","organization_name":"AQUILENET","country_code":"FR","continent_code":"EU"}]
      ```
      
      whereas a few hours ago that returned a 500. And now the timestamps are different
      
      ```
      ;; from schema
      "2021-03-18T19:52:41.808482Z"
      ;; results
      "2021-03-18T20:52:41.808482+01:00"
      ```
      
      kinda sick of dealing with this and don't want to deal with a schema
      that matches "near" to a timestamp.
      
      * Restore these
      
      i copied changes over from tim's fix and it included these fixes. But
      now the service is fixed and these are the original values from cam's
      original fixes
      Unverified
      37217e7d
    • Ryan Laurie's avatar
      add styling to dropzone overlay (#30624) · eba80de4
      Ryan Laurie authored
      Unverified
      eba80de4
    • Jesse Devaney's avatar
Loading