Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 25, 2021
  2. Jun 24, 2021
  3. Jun 23, 2021
    • dpsutton's avatar
      Cache results dont affect average execution time (#16720) · d4121d04
      dpsutton authored
      * Only save successful-query-execution if it wasnt a cached result
      
      the only thing this function does is update the rolling average query
      execution time
      
      * Failing tests for cache execution stats
      
      These tests fail, but they shouldn't.
      
      The save-execution information should not be called twice, and the
      average execution duration should remain the same. What's happening is
      that it is getting called twice just in the cache call, and only one
      of those has the new key `:metrics/ignore-execution-time`. This
      remains a mystery to me
      
      * Don't call completion arity from step arity
      
      the `(rf acc)` call violated the terms of transduction. If it does
      need to be there, perhaps it could be used with reduced
      
      wary of #12207 (which fixes #12165) and seeing if that crops up again.
      
      - i had introduced :metrics/ignore-execution-time but this was because
      i thought that we were running a simple query (limit 1) to get col
      metadata. Now that i know we were just being a bit careless with `(rf
      acc)` this extra information is no longer needed, and we can just
      react to cached data.
      
      * hoist closing paren
      Unverified
      d4121d04
    • dpsutton's avatar
      Licenses file (#16554) · 60617977
      dpsutton authored
      * wip for licenses
      
      * Lots of changes
      
      - bump clojure.data.xml to prevent illegal access
      - had to change navigators because of this
      - switch to full text of license
      - algo is now:
        1. check for a license file in jar
        2. check for an override pointing to a license file locally in
           resources
        3. Check pom file for license information and just use that
      
      can be invoked as:
      ```bash
      % clj -X mb.licenses/process :classpath \"$(cd ../.. && lein classpath)\" :backfill "\"overrides.edn\"" :output-filename "\"backend-licenses.txt\""
      License information written to  backend-licenses.txt
      /Users/dan/.m2/repository/net/jcip/jcip-annotations/1.0/jcip-annotations-1.0.jar  : No license information found.
      org.clojars.brenton:google-diff-match-patch  : No license information found.
      
      % wc backend-licenses.txt
         33638  299118 2092948 backend-licenses.txt
      ```
      
      * xml/parse without the strings
      
      * Add tests
      
      * remove comment form
      
      * namespace comments
      
      * readme
      
      * instructions to create backend license files
      
      * Add version information to the build script
      
      need to either yank it out of the separate project or just use it as a
      local root. not sure which
      
      todos: move to s3 once i get access and figure out the proper bucket
             copy to a place so it ends up in the jar
             generate frontend versions as well
      
      * Build frontend and backend license files
      
      put them in the jar at
      META-INF/leiningen/metabase-core/metabase-core/license-frontend-third-party
      META-INF/leiningen/metabase-core/metabase-core/license-backend-third-party
      
      need to be named ^license.* for lein uberjar to pick them up
      
      * Rename and reformat
      
      * remove old stuff
      
      * combine with a newline
      
      * Tests ensure all jars have an identifiable license
      
      * Extra information if backfill is malformed or missing
      
      * correct name for apache2_0 backfill
      
      * print out classpaths in CI
      
      * print
      
      * see whole classpath. it's empty on ee for some reason
      
      * assert they are there
      
      * Get deps before attempting classpath
      
      for some reason the first one fails. but subsequent re-runs work.
      
      * loop on deps until satisfied
      
      * Include message if cannot satisfy
      
      * include all drivers when getting deps
      
      * rearrange ns docstring
      
      * Hoist functions on pom inside of `with-open` on the input streams
      
      * Update to inversion of pom parsing
      
      * Move to nio from java.io
      Unverified
      60617977
    • Alexander Lesnenko's avatar
      fix map visualization is not suggested with first numeric column (#16706) · 97cc0cf8
      Alexander Lesnenko authored
      * make map visualization sensible for more than 1 column of any type
      
      * actually check if there is at least one metric
      
      * actually check if there is one string in addition to metric
      Unverified
      97cc0cf8
    • Nemanja Glumac's avatar
      Move smoke tests to the CircleCi (#16742) · 16b01629
      Nemanja Glumac authored
      * Move smoke tests to the CircleCi
      
      Closes #16741.
      
      * Remove smoketest script
      Unverified
      16b01629
    • Cam Saul's avatar
      :wave: `get-id` (#16730) · f3847cb8
      Cam Saul authored
      Unverified
      f3847cb8
    • Noah Moss's avatar
    • Ariya Hidayat's avatar
    • Ariya Hidayat's avatar
      Fix a regression in getting subdimensions (#16707) · fe14063b
      Ariya Hidayat authored
      
      * Wait for the SQL query to load `result_metadata`
      
      * Decrease the number of bins to 50
      
      * Update the default bucket for time series
      
      * Remove comment and the issue reference from "column popover" number test
      
      * Unskip "column popover" longitude test
      
      * Enable number binning test via custom question
      
      * Enable longitude tests
      
      Co-authored-by: default avatarNemanja <31325167+nemanjaglumac@users.noreply.github.com>
      Unverified
      fe14063b
    • Nemanja Glumac's avatar
      #16672 Repro: Implicit binning on longitude from SQL question results in error (#16738) · d5a2d691
      Nemanja Glumac authored
      * Add repro for #16672
      
      * Skip the whole `describe` block
      Unverified
      d5a2d691
    • Nemanja Glumac's avatar
    • Nemanja Glumac's avatar
    • Nemanja Glumac's avatar
      [Binning e2e coverage] Asserting on the bins from the regular QB table (#16712) · 75860174
      Nemanja Glumac authored
      * Add initial binning tests for QB regular table (via simple question)
      
      * Add initial binning tests for QB regular table (via custom question)
      
      * Add initial binning tests for QB regular table (via column popover)
      Unverified
      75860174
    • Nemanja Glumac's avatar
      [Binning e2e coverage] Longitude Correctness (#16630) · d1cb2c33
      Nemanja Glumac authored
      * Add initial set of checks for longitude correctness
      
      * Update longitude spec
      
      * Update representative values for "1 degree" bucket size
      
      * Rename function
      
      * Extract x-axis ticks check into a separate function
      
      * Expand and enable all tests
      Unverified
      d1cb2c33
    • Nemanja Glumac's avatar
      [Binning e2e coverage] Time Series Correctness (#16643) · 98ee3ec3
      Nemanja Glumac authored
      * Add initial set of checks for time series binning correctness
      
      * Fix selected value for "Year"
      
      * Rename the function
      
      * Extract x-axis ticks check into a separate function
      
      * Extract time series footer check into a separate function
      
      * Expand tests
      Unverified
      98ee3ec3
    • Gustavo Saiani's avatar
      Unverified
      545f0734
  4. Jun 22, 2021
  5. Jun 21, 2021
Loading