Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 07, 2023
  2. Jul 21, 2023
  3. Jul 04, 2023
  4. Jun 26, 2023
  5. Jun 21, 2023
  6. Jun 20, 2023
  7. Jun 10, 2023
  8. Jun 09, 2023
  9. Jun 07, 2023
  10. Jun 04, 2023
    • Nemanja Glumac's avatar
      Update fallback for `interactive?` check (#31311) · ca8bdae5
      Nemanja Glumac authored
      We migrated from CircleCI a long time ago and are now using GitHub Actions.
      But even without that CircleCI, like many other CI providers, sets the
      `CI` environment variable to `true` or to `1` by default.
      
      This PR updates the `interactive?` check to use that env var as fallback.
      Unverified
      ca8bdae5
  11. Apr 28, 2023
  12. Apr 26, 2023
    • Tim Macdonald's avatar
      Upload CSVs (#30256) · a06e640e
      Tim Macdonald authored
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * Add CSV uploads feature and have postgres and H2 support it (#29636)
      
      * Add csv uploads feature and have postgres support it
      
      * Add h2 support
      
      * CSV: schema detection (#29650)
      
      * CSV / Admin Upload Settings (#29709)
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * Add CSV uploads feature and have postgres and H2 support it (#29636)
      
      * Add csv uploads feature and have postgres support it
      
      * Add h2 support
      
      * Add defsettings
      
      * Add table prefix setting
      
      * add data upload settings
      
      * Add newline
      
      * update settings mock
      
      * Whether or not uploads are enabled
      
      ---------
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * Create table and insert rows from CSV uploads for postgres (#29677)
      
      * WIP create table and insert rows
      
      * Add newline
      
      * Use multimethods
      
      * WIP
      
      * Fix postgres
      
      * Fix postgres impl
      
      * Use detect-schema and add test
      
      * Fix load-from-csv arglists
      
      * Undo whitespace change
      
      * Use empty db instead
      
      * Add table and field tests
      
      * Remove prn
      
      * Uniquify names
      
      * newline
      
      * Add test for float
      
      * Add a test for the table contents
      
      * Tidy load-from-csv
      
      * Drop the table if loading the csv fails
      
      * Drop the table only if loading the csv fails
      
      * whitespace
      
      * Address SQL injection vulnerability
      
      * Use the slugified file-name as the table-name
      
      * Fix kondo
      
      * Using absolute path instead of relative
      
      * Fix kondo
      
      * Detect types for empty CSV files appropriately (#29754)
      
      * Create models from CSV uploads (#29966)
      
      * Wire up CSV uploads, sync the new table
      
      Still need to create a model
      
      * Check database support for CSV uploads better
      
      * Another test
      
      * Create model after sync
      
      * Fix request with formData
      
      * Fix tests
      
      * Fix tests
      
      * Revert "Fix request with formData"
      
      This reverts commit 66f146a41cf42feb34dbb03ed8566fa4220d0642.
      
      * Add whitespace
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Fix postgres support for uploads (#29922)
      
      * Check write perms for collection (#29976)
      
      * Rename metabase.csv -> metabase.upload (#29975)
      
      * Rename metabase.csv -> metabase.upload
      
      * Add docstring
      
      * Rename alias for release.common.upload
      
      ---------
      
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * WIP - 29598 csv status toast (#29757)
      
      * temp
      
      * generalize StatusListing types
      
      * Putting a pin in this for now
      
      * poorly done typing
      
      * generalizing upload function names
      
      * point to real API
      
      * Fixing Storybook
      
      * Permissions for Status Listing
      
      * use formdata and fix types
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      
      * Don't support redshift (#29981)
      
      * Handle uploads to the root collection (#29985)
      
      * Allow the uploads schema to be nil (for MySQL, etc.) (#29987)
      
      * CSV upload: fix stack overflow in detect-schema (#29983)
      
      * Fix stack overflow error on detect schema
      
      * map + vec -> mapv
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      
      * reload collection data after upload (#30009)
      
      * MySQL support for uploads (#29829)
      
      * Add MySQL support for uploads
      
      * Rename arg to upload-type
      
      * Use new ns name
      
      * Allow no table-name prefix to be specified and fix tests
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Fix setting descriptions (#30023)
      
      * Batch CSV insertion for better performance (#30028)
      
      * CSV upload e2e tests (#30005)
      
      * add CSV upload e2e tests
      
      * update tests
      
      * H2 support for uploads (#29828)
      
      * Add uploads support for H2
      
      * Rename arg
      
      * whitespace
      
      * Use new metabase.upload ns name
      
      * Fix tests for H2
      
      * Make table and field matching case insensitive
      
      * Fix kondo error
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Clear CSV upload state after a while (#30014)
      
      * clear upload status after 5s
      
      * make async behavior clearer
      
      * CSV Upload Dates and Datetimes Types (#30076)
      
      * Simple dates
      
      * Simple datetimes
      
      * Fix coalesce for date and datetime
      
      * Add mysql and h2 types
      
      * Fix test
      
      * Misc cleanup
      
      * Fix test
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Fix Kondo (rebase gone wrong)
      
      * MySQL test fix
      
      * Fix order of Metabot setting
      
      * adding unit tests to upload actions and reducers (#30161)
      
      * adding unit tests to upload actions and reducers
      
      * use fetch-mock
      
      * Adding component unit test
      
      * Check CSV Upload permissions on the frontend (#30094)
      
      * CSV / Admin Upload Settings (#29709)
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * Add CSV uploads feature and have postgres and H2 support it (#29636)
      
      * Add csv uploads feature and have postgres support it
      
      * Add h2 support
      
      * Add defsettings
      
      * Add table prefix setting
      
      * add data upload settings
      
      * Add newline
      
      * update settings mock
      
      * Whether or not uploads are enabled
      
      ---------
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * properly check if user can upload to a collection
      
      * do some db checking
      
      * don't check admin status for upload notification
      
      * misc cleanup
      
      * fix rebase
      
      * add loggedin check to statusListing
      
      also combines container + view component into a single file
      
      * update unit tests
      
      * update tests
      
      ---------
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * Csv/misc bugfixes (#30219)
      
      * Support empty header names
      
      * Handle long CSV names more appropriately
      
      Handle duplicate column names in CSVs
      
      * Test fix
      
      * Partition CSV inserts a little more intelligently
      
      * Test fix
      
      * Remove 'duplicate' from duplicated column names
      
      * More intelligent sampling
      
      * Add comment re. Postgres table-name-length-limit
      
      * Quote column names, clean up tests
      
      When unquoted, we couldn't use reserved words (true, false, group, etc.)
      as column names
      
      * Fix test
      
      Now that we quote things, H2 is case-sensitive
      
      * Use dialect-appropriate quoting
      
      Also clean up some card-filtering tests so they work with a dirty DB
      
      * Fix deduplication
      
      * Remove use of setting/get
      
      * Remove unneeded migration
      
      ---------
      
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * Fix test (#30383)
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      Unverified
      a06e640e
  13. Apr 18, 2023
  14. Apr 13, 2023
  15. Mar 30, 2023
  16. Mar 28, 2023
  17. Mar 21, 2023
  18. Mar 20, 2023
  19. Mar 13, 2023
  20. Mar 08, 2023
    • dpsutton's avatar
      Fix flaky json test (#29048) · fd5bd5e0
      dpsutton authored
      Occasionally in CI we get
      
      ```
      “Syntax error compiling at (release/version_info_test.clj:46:26).\nNo such var: json/read-json\n”,
      ```
      
      from `release.version-info-test`.
      This namespace requires `[clojure.data.json :as json]` and uses the
      function `json/read-json` which is deprecated since version 2.x.
      
      The way that deprecated function is defined in version 2.0.2 is
      
      ```clojure
      (ns clojure.data.json)
      ...
      (load "json_compat_0_1")
      ```
      
      and in `clojure/data/json_compat_0_1.clj`:
      
      ```clojure
      (in-ns 'clojure.data.json)
      
      (defn read-json
        "DEPRECATED; replaced by read-str.
        ...)
      ```
      
      And I guess the way that hawk requires some namespaces we can get into
      this half loaded, half not finished state and the var is not (yet)
      defined.
      
      So we can just put aside this nonsense and use a non-deprecated var that
      isn't defined with a `load` statement but in the regular namespace we
      require.
      Unverified
      fd5bd5e0
  21. Mar 07, 2023
    • dpsutton's avatar
      Update tools.build and usage (#28977) · b549b291
      dpsutton authored
      Calling our basis function with just :oss or :ee we don't end up with an
      `:argmap` key.
      
      ```clojure
      uberjar=> (def basis (create-basis :oss))
      ,#'build.uberjar/basis
      uberjar=> (:argmap basis)
      nil          ;; nothing extra in oss
      
      uberjar=> (def basis (create-basis :ee))
      ,#'build.uberjar/basis
      uberjar=> (:argmap basis)
      {:extra-paths ["enterprise/backend/src"]}
      
      ;; and if other aliases are used:
      uberjar=> (def basis' (b/create-basis {:project "deps.edn" :aliases [:dev :test]}))
      ,#'build.uberjar/basis'
      uberjar=> (:argmap basis')
      {:extra-deps {lambdaisland/deep-diff2 {:mvn/version "2.7.169"},
                    methodical/methodical {:mvn/version "0.15.1"},
                    io.github.metabase/hawk {:sha
                    "45ed36008014f9ac1ea66beb56fb1c4c39f8342b"},
                    ....}
       :extra-paths ["dev/src"...]
       :jvm-opts ["-Dmb.run.mode=dev" ...]
       :exec-fn metabase.test-runner/find-and-run-tests-cli}
      ```
      Unverified
      b549b291
  22. Mar 01, 2023
  23. Feb 27, 2023
  24. Feb 23, 2023
  25. Feb 21, 2023
    • dpsutton's avatar
      Custom migrations (#28175) · 30e731e3
      dpsutton authored
      
      * Custom migrations
      
      Current syntax:
      
      specify the migration with
      ```
        - changeSet:
            id: v46.00-080
            author: dpsutton
            comment: Uppercases all Card names
            changes:
              - customChange:
                  class: "metabase.db.custom_migrations.ReversibleUppercaseCards"
      ```
      
      and in the new namespace metabase.db.custom-migrations:
      
      ```clojure
      (defmigration UppercaseCards
        (db/execute! {:update :report_card
                      :set    {:name :%upper.name}}))
      
      (def-reversible-migration ReversibleUppercaseCards
        (db/execute! {:update :report_card
                      :set    {:name :%upper.name}})
        (db/execute! {:update :report_card
                      :set    {:name :%lower.name}}))
      ```
      
      * Use db provided by liquibase
      
      * edit docstring
      
      * set *warn-on-reflection* to fix lint error & rebase
      
      ---------
      
      Co-authored-by: default avatarNoah Moss <noahbmoss@gmail.com>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Unverified
      30e731e3
    • Nemanja Glumac's avatar
      Fix and expand `verify-doc-links` logic (#28482) · 309b8e0a
      Nemanja Glumac authored
      * Expand the glob to include TS(X) files
      
      * Use console error
      
      * Re-order imports
      
      * Print the missing files in red
      
      * Fix glob pattern
      
      * Add script to pre-commit hooks
      
      * Remove the check from CI
      Unverified
      309b8e0a
  26. Feb 20, 2023
  27. Feb 17, 2023
  28. Feb 09, 2023
  29. Feb 08, 2023
  30. Jan 27, 2023
  31. Jan 23, 2023
  32. Dec 29, 2022
  33. Dec 21, 2022
    • john-metabase's avatar
      Start-of-cycle 46 basic dependency version bump (#27332) · 704a1c54
      john-metabase authored
      * Start-of-cycle 46 basic dependency version bump
      
      Some dependencies with available major version bumps are only updated
      to the latest minor version of the current major version. Some
      additional dependencies will be updated in future PRs.
      
      * Removes commons-lang from sparksql deps exceptions
      
      * Fixes MongoDB SRV test for monger 3.6.0
      
      * fixes SQLite datetime tests for new driver version 3.40
      Unverified
      704a1c54
  34. Dec 15, 2022
Loading